Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1557
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1624
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1557
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1557
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1557
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1568
Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1568
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1624
It would be better to make these normal transaction hooks and use the
TSHttpHookAdd() function to add the hook. Then you can use the normal
plugin.config to load the plugin
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1557#discussion_r108756464
--- Diff: doc/admin-guide/plugins/gzip.en.rst ---
@@ -141,6 +141,26 @@ will leave the header intact if the client provided it.
- For when
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1557#discussion_r108756275
--- Diff: doc/admin-guide/plugins/gzip.en.rst ---
@@ -141,6 +141,26 @@ will leave the header intact if the client provided it.
- For when
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1557
We should rip out enforce-brotli configuration option the same can be done
with multiple configs like the example below. We might want to add an allow
feature and use the ! syntax like
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1557
@myraid There was an issue with my build. I got it working. It would
would be great to have debug and error warnings if you haven't built it with
brotli and have it configured that way
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1612
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1611
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1557
I am testing out the plugin with this configuration and I am not getting to
to compress using Brotli:
```
[bcall@C02R70EHG8WP-lm ~]$ tail -1
/usr/local/etc/trafficserver
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1557
Wouldn't it better to have an configuration such as:
```
compressible-path /this/*.js
compressible-path /this/*.css
# with
supported-algothims br
vs
enforce
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1557#discussion_r108296389
--- Diff: doc/admin-guide/plugins/gzip.en.rst ---
@@ -162,6 +182,32 @@ might create a configuration with the following
options::
disallow
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1557#discussion_r108296418
--- Diff: doc/admin-guide/plugins/gzip.en.rst ---
@@ -162,6 +182,32 @@ might create a configuration with the following
options::
disallow
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1557#discussion_r108296435
--- Diff: doc/admin-guide/plugins/gzip.en.rst ---
@@ -162,6 +182,32 @@ might create a configuration with the following
options::
disallow
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/1612
Changed some of the HTTP/2 enums to enum classes and found a bug
found a bug in is_client_state_writeable()
You can merge this pull request into a Git repository by running:
$ git
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/1611
Convert HPACK enums to enum classes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver hpack_enum_class
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1600
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1600
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1573#discussion_r105754317
--- Diff: proxy/logging/LogAccessHttp.cc ---
@@ -71,7 +71,7 @@ LogAccessHttp::LogAccessHttp(HttpSM *sm)
m_proxy_resp_content_type_str
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1532
Information from 7.0.0 release running in production on the same server:
```
[bcall@e24 crash]$ ss -tn | awk '{print $4}' | grep -c ':80$' ; ss -tn |
awk '{print $4}' | grep -c
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1532
The problem I am seeing with 7.1 has to do with http2 client sessions not
closing and releasing the `MIOBuffer`. I am running a test with 7.0.0 and
seeing if the issue was there too
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1573#discussion_r105724614
--- Diff: proxy/logging/LogAccessHttp.cc ---
@@ -71,7 +71,7 @@ LogAccessHttp::LogAccessHttp(HttpSM *sm)
m_proxy_resp_content_type_str
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1571
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1567
Please swash the commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1566
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1557
@myraid
I can see cases where someone might not want to spend the CPU resources on
Brotli compression, but doesn't mind if the origin does Broli encoding. The
plugin would compress
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1566
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1557
It looks like brotli is on by default? It would be nice to have an option
on what types of compression algorithms that you want to enable.
---
If your project is set up for it, you can
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1557#discussion_r105279083
--- Diff: plugins/gzip/gzip.cc ---
@@ -95,18 +104,29 @@ gzip_data_alloc(int compression_type)
}
}
+ if(compression_type
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1532
There is an issue with the number of real TCP connections, the stats that
keeps track of the number of current client connections, and the number of
http2 client sessions. All of them
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1456
We should have a metric that tracks the total number of accepts at the TCP
layer. I recommend that the name be inline with the current metrics
`proxy.process.net.total_accepts
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1557
Added the requirements here:
```
Here are the requirements for supporting brotli encoding.
If the Accept-Encoding has brotli, then the normalize AE should pick up
brotli
Github user bryancall closed the issue at:
https://github.com/apache/trafficserver/issues/1555
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1555
@myraid Issues don't need to be created if there is a PR for it.
The PR for it is: #1557
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1556
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1522
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1544
What version are you running? I am seeing the same errors with 7.1.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1522
@scw00 What are `server_entry->read_vio` and `data` set to when it asserts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1522
Running the current PR under gdb with this macro to see if the optimization
in the patch above would work. I don't think there is a case where error is
set and triggered
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1522
I updated the PR to use oknet's recommendation. I am going to test a
another version of this fix to be:
```
diff --git a/iocore/net/UnixNet.cc b/iocore/net/UnixNet.cc
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1522
@oknet Thank for the suggestion I am running in 7.1.0 in production with
the change you mention above instead of this PR
```
diff --git a/iocore/net/UnixNet.cc b/iocore/net
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1537
Looks like you removed a file and didn't add one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1538
@dragon512 Here is the full output: https://da.gd/zDXXX
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1539#discussion_r104453441
--- Diff: iocore/eventsystem/I_EThread.h ---
@@ -56,7 +56,7 @@ enum ThreadType {
DEDICATED,
};
-extern volatile bool
Github user bryancall closed the issue at:
https://github.com/apache/trafficserver/issues/1443
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1443
Looks like this should be closed since the PR for it was merged. Please
reopen if need be.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user bryancall opened an issue:
https://github.com/apache/trafficserver/issues/1538
Tests are failing on cache-generation-clear
```
[bcall@homer tests]$ time ./autest.sh --ats-bin /usr/local/bin
Running Test basic:. Passed
Running Test basic-cop:. Passed
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1465
@zwoop Did you run the tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user bryancall opened an issue:
https://github.com/apache/trafficserver/issues/1532
ATS 7.1 release running out of memory
Here is a backtrace from a bunch of cores I am getting from 7.1. They are
mostly issues with memory allocation:
[bcall@e24 ~]$ egrep '\#2 |\#3 |\#4
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1465
Here is the full output from running the tests: https://da.gd/XOiCg
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1465
I am seeing 4 failed tests.
```
[bcall@homer tests]$ ./autest.sh --ats-bin /usr/local/bin
Running Test basic:. Passed
Running Test basic-cop:. Passed
Running Test
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1524
I believe this is not really an issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bryancall closed the issue at:
https://github.com/apache/trafficserver/issues/1524
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user bryancall opened an issue:
https://github.com/apache/trafficserver/issues/1524
Seeing a lot of CPU being used on atomics
```
- 22.49%22.20% traffic_server [.] ink_atomic_increment<int,
GitHub user bryancall opened an issue:
https://github.com/apache/trafficserver/issues/1523
ASAN segv when ramping up traffic to a production host
```
ASAN:SIGSEGV
=
==38732==ERROR: AddressSanitizer: SEGV
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1522
Here is a workaround for issue #1401. I ran into issues with the read also
coring.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/1522
Ingore read and write errors if vio has been cleared
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1379
@zwoop Yes, this needs to get backported. I ran into this issue testing
the 7.1.x branch in production.
---
If your project is set up for it, you can reply to this email and have your
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1457#discussion_r103324828
--- Diff: proxy/Main.cc ---
@@ -460,7 +460,7 @@ proxy_signal_handler(int signo, siginfo_t *info, void
*ctx)
shutdown_event_system = true
GitHub user bryancall opened an issue:
https://github.com/apache/trafficserver/issues/1506
Wrong protocol version in the Via header
```
[bcall@homer ats_ssl_config]$ nghttp -v https://127.0.0.1:4443/200.php
[ 0.000] Connected
The negotiated protocol: h2
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1465
@dragon512
I am seeing some errors when running the tests:
```
Total of 15 test
Unknown: 0
Exception: 0
Failed: 10
Warning: 0
kipped: 2
Passed: 3
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1465
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1458
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/1458
Removed spaces at the end of the line on all files
Removed spaces at the end of the line on all files doing:
`find . -type f | grep -v '\.git' | xargs -n1 perl -pi -e 's/\s+\n$/\n
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1454
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1456
Why are there tsconfig changes with this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1454
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1444
This is the same type of hack I described in our Monday meeting. I don't
think it is worth committing it. Tracking down what why this is broken and
having a permanent fix would
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/1454
Updates to the help output for tsxs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver tsxs_help
Alternatively
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1398
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1398#discussion_r99880264
--- Diff: configure.ac ---
@@ -220,6 +220,22 @@ AC_ARG_ENABLE([fast-sdk],
AC_MSG_RESULT([$enable_fast_sdk])
TS_ARG_ENABLE_VAR([use], [fast
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1398#discussion_r99876962
--- Diff: cmd/traffic_top/Makefile.am ---
@@ -17,13 +17,13 @@
# We only build traffic_top if libcurses and libcurl are available
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1401
(gdb) bt full
#0 0x005150b0 in Mutex_trylock (m=0x0, t=0x2b44f3a6d010)
at
/home/bcall/dev/yahoo/build/_build/ats_build/../../trafficserver/iocore/eventsystem/I_Lock.h
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1412
The event is VC_EVENT_INACTIVITY_TIMEOUT (value 105) when it asserts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1403
This is the PR for this issue: #1404
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1401
What does the vc look like?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1391
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1391
Still needs a clang-format. I will merge it and clang-format it once it is
committed.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/1398
Configure option to disable CURL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver no_curl
Alternatively you
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1391
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1248
Please squash commits before merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1391
Please run clang-format on the code. It is not passing CI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1391
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1391
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/210
Please reopen or create another pull request if you want to resolve this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/210
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/761
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/761
Please reopen or create a new pull request if you still want to resolve
this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1275
Please make sure pull requests are reviewed before merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1380
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall closed the issue at:
https://github.com/apache/trafficserver/issues/1283
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bryancall closed the issue at:
https://github.com/apache/trafficserver/issues/1279
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1279
This was closed in PR #1279
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/1380
Fixed issue where somaxconn was being set to 0 on OSX and preventing
ATS to work
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1373
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
1 - 100 of 344 matches
Mail list logo
