Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1088
I have been running this in production without an issue. However, I still
have a comment in the code about the !empt() conditional and the bubble_up
function call.
---
If your project
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1101
ð - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1096#discussion_r83042781
--- Diff: proxy/InkAPI.cc ---
@@ -6663,8 +6661,7 @@ TSHttpTxnServerIntercept(TSCont contp, TSHttpTxn txnp)
sdk_assert(sdk_sanity_check_mutex
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/1095
TS-4956: Memory leaks in hostdb test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4956
Alternatively
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1094
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1093
ð - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/1094
TS-4953: Memory leaks in priority queue test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4953
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1088#discussion_r82836137
--- Diff: lib/ts/PriorityQueue.h ---
@@ -123,11 +129,18 @@ PriorityQueue<T, Comp>::erase(PriorityQueueEntry
*entry)
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1088#discussion_r82832753
--- Diff: lib/ts/PriorityQueue.h ---
@@ -123,11 +129,18 @@ PriorityQueue<T, Comp>::erase(PriorityQueueEntry
*entry)
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1083
Why do we have to guard against the server_session server_vc being NULL
now? What change occurred to require this or was it always possible?
---
If your project is set up for it, you can
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1082
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1082
ð - code looks good and tested!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1072
More comments would be helpful since this is an example plugin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1072
I didn't see any issues, but it would be good to test with a large POST
body and response.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1069
ð - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/1063
TS-4909: Throttling based on resident memory usage
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4909
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1036#discussion_r80176377
--- Diff: iocore/eventsystem/SocketManager.cc ---
@@ -108,3 +111,36 @@ SocketManager::close(int s)
} while (res == -EINTR);
return res
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1036#discussion_r79952516
--- Diff: iocore/net/BIO_fastopen.cc ---
@@ -0,0 +1,168 @@
+/** @file
+ *
+ * OpenSSL socket BIO that does TCP Fast Open
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1036#discussion_r79950862
--- Diff: doc/admin-guide/files/records.config.en.rst ---
@@ -3426,6 +3433,11 @@ Sockets
are co-located and large numbers of sockets
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1036#discussion_r79950331
--- Diff: doc/admin-guide/files/records.config.en.rst ---
@@ -3388,13 +3388,19 @@ Sockets
TCP_NODELAY (1)
SO_KEEPALIVE (2
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1022#discussion_r79073490
--- Diff: mgmt/RecordsConfig.cc ---
@@ -834,6 +860,61 @@ static const RecordElement RecordsConfig
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/978
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1016
ð - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1014
ð - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1012
ð - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1019
ð - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1018
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1018
ð - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/833
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/833
By removing TSUrlHttpQueryGet() I meant, I was always returning true in the
function.
Why are you determining if it should push based on the length of the query
string in the URL
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/857
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/857
I am going to go with this right now and open a bug for disable_read() and
disable_write()
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/978
ð - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/877
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/833
I had problems getting it to work. I had problems with the plugin failing
from TSUrlHttpQueryGet() in the plugin. After removing TSUrlHttpQueryGet()
from the plugin I am seeing many
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/993
ð - Looks good, yay ipv6!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/994
ð - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/995
ð - Looks good, but needs an update
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1004
ð - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/998
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/997
ð - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/998
TS-4837: Add -Wextra to the build
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4837
Alternatively you
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/989
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/989
TS-4828: gcc warning comparison between signed and unsigned integer eâ¦
â¦xpressions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/988
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/987
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/833
@maskit Can you please update this pull request? I would like to get this
in this week.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/988
TS-4827: gcc warning xxx not explicitly initialized in the copy constructor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/987
TS-4824: gcc enumeral and non-enumeral type in conditional expression
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/985
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/982
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/985
TS-4823: gcc ordered comparison of pointer with integer zero warnings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/983
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/983
TS-4812: Unused member variables in NetHandler::NetHandler
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/982
TS-4811: gcc warning missing-field-initializers
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4811
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/943
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/946
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/943
This pull request disables ICP, removes the configuration, APIs, and stats.
I am breaking up removing ICP into pieces. Being that it is late in the
release cycle it might be best to rip
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/966
Looked over the code and I didn't see a problem. I applied the patches and
it passed unit tests and regression.
---
If your project is set up for it, you can reply to this email and have
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/955
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/955#discussion_r77261351
--- Diff: iocore/net/UnixNet.cc ---
@@ -289,7 +289,20 @@ initialize_thread_for_net(EThread *thread)
// NetHandler method definitions
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/954
ð - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/955
TS-4805: CID 1021743: Uninitialized scalar field
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4805
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/943#discussion_r77093447
--- Diff: mgmt/RecordsConfig.cc ---
@@ -1299,6 +1299,9 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/946
@jpeach
I don't think it is necessary to give a warning when running configure
since the user has to give the option to add Linux AIO support with
experimental in the name (--enable
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/944
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/946
TS-4767: Add warning for Linux AIO build option
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4767
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/918
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/944
TS-4676: Remove TS_HTTP_READ_REQUEST_PRE_REMAP_HOOK
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4676
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/943
TS-4771: Remove config, stats, and docs for ICP
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4771
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/924
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/916
ð - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/925
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/924
TS-4786: Rename activity and inactivity timeout arguments
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/917
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/914
Looks good and I tested the build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/914
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/912
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/917
TS-4167: Change default value of proxy.config.http2.active_timeout_in
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/916
Looking at the change I think it would be better to have a generically
named parse result codes since we are using them for everything including URL
parsing too.
---
If your project
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/910
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/915
ð - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/910
@jpeach I updated `MIMEParseResult` to have the same values as
TSParseResult. I will file a bug for getting rid of
`MIMEParseResult::PARSE_OK` and now that the value is only used
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/911
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/912
TS-2470: Remove PCT metrics
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-2470
Alternatively you can
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/911
TS-2220: Rename proxy.config.http.anonymize_insert_client_ip
Rename proxy.config.http.anonymize_insert_client_ip to
proxy.config.http.insert_client_ip
You can merge this pull request
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/910
TS-1509: Remove TS_PARSE_OK constant
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-1509
Alternatively
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/907
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/895
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/886
ð - Looks great!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/897
Instead of headers I would like to seem them in the URL. Possibly as query
parameters.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/907
TS-3826: Traffic Server adds body "No Content" to 204 response
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/tra
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/905
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/905
TS-4335: Remove the option to disable/enable TLS compression
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/898
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/896
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/898
TS-4345: Change defaults for ERROR to not log to syslogs since it canâ¦
⦠potentially flood syslogs
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/896
TS-4374: Remove lighthttpd_mod_generator
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4374
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/894
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/895
TS-4700: Change the default timeout for HTTP/2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4700
201 - 300 of 344 matches
Mail list logo
