Github user ngara commented on the issue:
https://github.com/apache/trafficserver/pull/1152
Maybe this should be an ink_abort instead of ink_release_assert?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ngara commented on the issue:
https://github.com/apache/trafficserver/pull/1152
I took a close look at this and I didn't make the change that caused
clang-format to fail here
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ngara commented on the issue:
https://github.com/apache/trafficserver/pull/1152
OK, figured it out. removing a variable made the equals signs want to line
up differently on a line i didnt modify. Fixed!
---
If your project is set up for it, you can reply to this email
Github user ngara commented on the issue:
https://github.com/apache/trafficserver/pull/1152
I put the plugin hook in and got it working. Thanks for the suggestion.
Nathan
> On Oct 26, 2016, at 9:01 PM, Leif Hedstrom <notificati...@github.com&g
GitHub user ngara opened a pull request:
https://github.com/apache/trafficserver/pull/1155
TS-5012 CID 1267812 Logically Dead Code fixed
removed ink_asserts in favor of ink_abort with an error message
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user ngara opened a pull request:
https://github.com/apache/trafficserver/pull/1152
TS-5009 CID 1022011 Logically dead code removal
Please review - I changed this code to ink_release_assert instead of the
following code, which seems to either return '\0' or *b->st
GitHub user ngara opened a pull request:
https://github.com/apache/trafficserver/pull/1149
TS-5008 CID 1022007 Logically dead code
The first "if (in_ext_map)" and if (ret) return ret; causes the following
code if (in_ext_map) to never execute. Modified to c
GitHub user ngara opened a pull request:
https://github.com/apache/trafficserver/pull/1145
TS-5004 CID 1021675 Structurally dead code removed
Removed some lines of code that won't get executed
You can merge this pull request into a Git repository by running:
$ git pull https
Github user ngara commented on the issue:
https://github.com/apache/trafficserver/pull/963
Alright, I cleaned up my mess. Here's just the single commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ngara commented on the issue:
https://github.com/apache/trafficserver/pull/1021
jpeach: I made the suggested modification. Tests good, also tested with
ret=1 to see how the error would print and that works as expected.
---
If your project is set up for it, you can reply
GitHub user ngara opened a pull request:
https://github.com/apache/trafficserver/pull/1021
TS-4864 CID 1362769 - when pthread_create fails, ink_abort instead ofâ¦
⦠returning 0, and remove dead code
You can merge this pull request into a Git repository by running:
$ git
Github user ngara commented on the issue:
https://github.com/apache/trafficserver/pull/963
This pull request should not be merged in. Handling it with TS-4860
instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user ngara reopened a pull request:
https://github.com/apache/trafficserver/pull/963
TS-4815 - CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: reâ¦
TS-4815 - CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return
TS_ERR_PARAMS;
You can merge this pull
Github user ngara closed the pull request at:
https://github.com/apache/trafficserver/pull/963
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ngara commented on the issue:
https://github.com/apache/trafficserver/pull/963
Thanks for the feedback. Updated to use ink_release_assert which will
always execute, and ready to review again.
---
If your project is set up for it, you can reply to this email and have your
Github user ngara commented on the issue:
https://github.com/apache/trafficserver/pull/893
ok, conflicts resolved again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ngara commented on the issue:
https://github.com/apache/trafficserver/pull/893
Please take a look again, it should be fixed now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user ngara opened a pull request:
https://github.com/apache/trafficserver/pull/893
TS-4581 CID 1356973 dead code in proxy/hdrs/HTTP.cc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ngara/trafficserver TS-4581
18 matches
Mail list logo
