maskit opened a new issue, #10358:
URL: https://github.com/apache/trafficserver/issues/10358

   ```
    48  switch (event) {
    49  case TS_EVENT_NET_ACCEPT:
    50    /* Create a new mutex for the TxnSM, which is going
    51       to handle the incoming request. */
    52    pmutex = TSMutexCreate();
    53    txn_sm = TxnSMCreate(pmutex, (TSVConn)edata, server_port);
    54
    55    /* This is no reason for not grabbing the lock.
    56       So skip the routine which handle LockTry failure case. */
        
   CID 1518573 (#1 of 1): Unchecked return value (CHECKED_RETURN)
   2. check_return: Calling TSMutexLockTry without checking return value (as is 
done elsewhere 6 out of 7 times).
    57    TSMutexLockTry(pmutex); // TODO: why should it not check if we got 
the lock??
    58    TSContCall(txn_sm, TS_EVENT_NONE, nullptr);
    59    TSMutexUnlock(pmutex);
    60    break;
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@trafficserver.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to