[GitHub] trafficserver issue #1112: RFC: Prefer nullptr to NULL.

2016-10-16 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1112 @sudheerv AFAIK there are no plugin compatibility implications here. There are no API and ABI changes. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1112: RFC: Prefer nullptr to NULL.

2016-10-16 Thread sudheerv
Github user sudheerv commented on the issue: https://github.com/apache/trafficserver/pull/1112 +1 The only comment I've is that this change seems like it could cause compatibility issues mainly for plugins, and so should go in a major release (7.0 is probably fine). ---

[GitHub] trafficserver issue #1112: RFC: Prefer nullptr to NULL.

2016-10-15 Thread bryancall
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1112 Is there a Jira ticket for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #1112: RFC: Prefer nullptr to NULL.

2016-10-15 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1112 It's a big change, but we should probably do this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver issue #1112: RFC: Prefer nullptr to NULL.

2016-10-15 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1112 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1028/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1112: RFC: Prefer nullptr to NULL.

2016-10-15 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1112 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/920/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1112: RFC: Prefer nullptr to NULL.

2016-10-14 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1112 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1023/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1112: RFC: Prefer nullptr to NULL.

2016-10-14 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1112 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/915/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1112: RFC: Prefer nullptr to NULL.

2016-10-14 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1112 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1022/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1112: RFC: Prefer nullptr to NULL.

2016-10-14 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1112 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] trafficserver issue #1112: RFC: Prefer nullptr to NULL.

2016-10-14 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1112 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/914/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1112: RFC: Prefer nullptr to NULL.

2016-10-14 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1112 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1021/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1112: RFC: Prefer nullptr to NULL.

2016-10-14 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1112 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/913/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1112: RFC: Prefer nullptr to NULL.

2016-10-14 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1112 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1017/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1112: RFC: Prefer nullptr to NULL.

2016-10-14 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1112 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/909/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1112: RFC: Prefer nullptr to NULL.

2016-10-14 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1112 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1012/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1112: RFC: Prefer nullptr to NULL.

2016-10-14 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1112 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/904/ for details. --- If your project is set up for it, you can reply to this email and have your reply