[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-03-08 Thread bryancall
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1456 We should have a metric that tracks the total number of accepts at the TCP layer. I recommend that the name be inline with the current metrics `proxy.process.net.total_accepts` --- If

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-03-06 Thread shinrich
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/1456 http2 connections are tracked by proxy.process.http2.current_client_sessions and proxy.process.http2.total_client_connections. All successfully negotiated SSL/TCP connections would

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-22 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1456 Yes, if there are subtle differences like this, we should break them out accordingly, and then make an aggregated "sum" metrics in the Lua metrics.config. It almost sounds like a bug

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-21 Thread jacksontj
Github user jacksontj commented on the issue: https://github.com/apache/trafficserver/pull/1456 It seems like we should have some sort of layered approach, where we keep track of tcp (l4) http (L5?) and TLS (L7). We have metrics for some of this it sounds, but IIRC they are a bit

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-21 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1456 The `http` stat measures only HTTP 1.X connections and only those that are successfully created. If, for example, there is a connection that fails the TLS handshake, this stat will

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1456 Hmmm, how is this different from proxy.process.http.total_incoming_connections ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1456 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/138/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1456 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1467/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1456 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1573/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1456 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/6/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-16 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1456 Bad merge, I'll fix the TSConfig stuff. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-16 Thread bryancall
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1456 Why are there tsconfig changes with this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1456 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/128/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1456 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1457/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1456 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1563/ for details. --- If your project is set up for it, you can reply to this email and have