Github user jaaju commented on the issue:
https://github.com/apache/trafficserver/pull/1457
@zizhong you need to call `exit` for normal process termination in case of
SIGTERM so ASAN leak detection report is available. But since you can not call
`exit` from the signal handler, what
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Thanks @jpeach . I do not fully understand what you suggested. Could you
explain a bit more, please?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1457
With some additional effort, we can fix this reliably. The traditional way
to do this is for the signal handler to write a byte to a pipe, which will wake
up an event handler to do an ordered
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
@zwoop , @bryancall, Hey, what is the next step about this? We can't let
ATS crashes this way. We also want our leak detection tools to work fine. Why
is `exit` mandatory in our signal
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
I've reverted this, as per @bryancall recommendation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
@bcall Should we back this out? Fwiw, I don't see a difference in leak
detection with or without this, they both fail badly on master.
---
If your project is set up for it, you can reply to
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Hmm, this line of code is not added by this patch. I would say this is an
already existed issue.
I can work on fixing this. Is there a way to know all these places which
not checking
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
This introduced a new Coverity issues:
```
*** CID 1371483: Error handling issues (CHECKED_RETURN)
/lib/ts/signals.cc: 173 in signal_format_siginfo(int, siginfo_t *, const
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
I've tested this with leak detection, and it seems to still work (it
reports quite a few leaks). So I'm going to land this :).
---
If your project is set up for it, you can reply to this
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
@jpeach @zwoop , already
> tested with --enable-asan and didn't find any issue.
and posted it in this thread. But looks like my message got buried with
this huge amount of
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Also, I'm gonna mark this for v7.1.0, because I've experienced these
crashers myself, and they are super annoying.
---
If your project is set up for it, you can reply to this email and have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Did we address @jpeach concern re: memory leak debugging? Also, probably
would be a good idea if @bryancall chimed in here, since he did a lot of the
work around making ASAN etc. function
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/143/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1578/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1472/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/11/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
@zwoop , thanks! Rebased and pushed again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Ah, that fails because you don't have the fixes I made on master. All you
have to do is rebase your branch with current master, and push again.
---
If your project is set up for it, you can
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/142/ for details.
---
If your project is set up for it, you can reply to this email
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Failed at
```
P_IOBuffer.h(697): error #1011: missing return statement at end of non-void
function "IOBufferReader::operator[]"
}
^
```
I can try to fix it with
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1577/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1471/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Intel CC build *failed*! See
https://ci.trafficserver.apache.org/job/icc-github/10/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Yeh, this failed because the Intel installation was not correct on one of
the VMs. [approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/141/ for details.
---
If your project is set up for it, you can reply to this email
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
@zwoop , in https://ci.trafficserver.apache.org/job/icc-github/9/
```
checking whether the C compiler works... no
configure: error: in `/var/jenkins/workspace/icc-github/src':
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1470/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1576/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Intel CC build *failed*! See
https://ci.trafficserver.apache.org/job/icc-github/9/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
@zizhong No need to apologize, this is exactly why we have a CI / build
system. :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Sorry for the build failed. It's because missed a piece when merging the
code. Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Tested with `--enable-asan` and didn't find any issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1567/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/132/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/linux-github/1461/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
I checked the config.log and found the problem. I didn't have `asan`
installed. However, the error message here was quite misleading.
---
If your project is set up for it, you can reply to
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
@jpeach , I haven't tested it yet.
I would like to try it.
Then I configured it with `--enable-asan`, but got
```
checking whether compiling and linking against OpenSSL
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Is it still possible to use leak checkers that reconcile at exit after this
fix?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
41 matches
Mail list logo
