[GitHub] trafficserver issue #802: TS-4583: Null-pointer dereference after check

2016-12-21 Thread bryancall
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/802 Didn't add "This closes #802 to 72e518181805084fe345cc374274bda5c2e81070, so I am going to manually close. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #802: TS-4583: Null-pointer dereference after check

2016-12-21 Thread bryancall
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/802 I think it is correct to check the value of the server_entry is not NULL before dereferencing the pointer in the same conditional. This is a common pattern. The method

[GitHub] trafficserver issue #802: TS-4583: Null-pointer dereference after check

2016-07-24 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/802 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/376/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #802: TS-4583: Null-pointer dereference after check

2016-07-24 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/802 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/479/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #802: TS-4583: Null-pointer dereference after check

2016-07-24 Thread alhonen
Github user alhonen commented on the issue: https://github.com/apache/trafficserver/pull/802 If they indeed do go NULL together (a bit hard to verify), then we can change the null check instead. I'll modify it thus. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #802: TS-4583: Null-pointer dereference after check

2016-07-23 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/802 @alhonen Thoughts on the concerns from James? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver issue #802: TS-4583: Null-pointer dereference after check

2016-07-17 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/802 I don't think this change is correct. It seems to me that the invariant is that ``server_session`` and ``server_entry`` should be NULL or non-NULL together. So if we call

[GitHub] trafficserver issue #802: TS-4583: Null-pointer dereference after check

2016-07-17 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/802 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/440/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #802: TS-4583: Null-pointer dereference after check

2016-07-17 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/802 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/334/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #802: TS-4583: Null-pointer dereference after check

2016-07-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/802 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or