[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/805 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/350/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/805 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/454/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/805 Great, thanks! [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

Github user yatsukhnenko commented on the issue: https://github.com/apache/trafficserver/pull/805 @zwoop, I chaneged `Synopsis` and `Description` sections --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/805 @yatsukhnenko As James suggested, can you just add a line or two to doc/developer-guide/api/functions/TSInstallDirGet.en.rst instead of creating a new file? This would be my preference as

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

Github user yatsukhnenko commented on the issue: https://github.com/apache/trafficserver/pull/805 [TS-4680](https://issues.apache.org/jira/browse/TS-4680) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/805 Sounds good, can you file a new Jira for these issues? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

Github user yatsukhnenko commented on the issue: https://github.com/apache/trafficserver/pull/805 I'll try to fix it a bit letter if it's not urgent --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/805 Unless @yatsukhnenko also wants to fix the thread safety issue on this, and all APIs? If not, file another Jira IMO. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/805 This follows the pattern of the other APIs, but I notice the initialization is not thread safe. Shall we file a separate JIRA for that? --- If your project is set up for it, you can reply to

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/805 The documentation for this API family is in {{doc/developer-guide/api/functions/TSInstallDirGet.en.rst}}, Just mention the new API there. --- If your project is set up for it, you can reply

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

Github user yatsukhnenko commented on the issue: https://github.com/apache/trafficserver/pull/805 I added tests and created empty doc file(writing documentation is not a good idia considering my English level :shame:) --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/805 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/438/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/805 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/332/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/805 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/805 Also, please add some tests to proxy/InkAPITest.cc, see how the existing tests are done for e.g. TSInstallDirGet. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/805 Cool. Can you add a documentation to this too? Either just add a new file, e.g. doc/developer-guide/api/functions/TSRuntimeDirGet.en.rst Or, my personal preference, merge