Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/829
Superseded by PR #1007
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/829
@amc we should have this discussion on ``@dev``. My main objection to this
API is that is makes promises it doesn't (maybe can't) keep. It just tells you
whether this is HTTP/1 or HTTP/2.
Github user petarpenkov commented on the issue:
https://github.com/apache/trafficserver/pull/829
I updated the PR with TSHttpSsnClientProtocolGet(TSHttpSsn ssnp). @zwoop ,
for refactoring documentation I could open another JIRA issue and take care of
it if it should be done.
---
If
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/829
I have to disagree with James. Once upon a time, this worked (if any one
remember the "proto stack" thing). It was an explicit goal of the TS-3612 work
to get this capability back. It
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/829
I'm quite negative on this API and the underlying "get_protocol_string()".
I think that it doesn't serve the right purpose and is not general enough to be
useful. See dev@ for more discussion.
Github user masaori335 commented on the issue:
https://github.com/apache/trafficserver/pull/829
That's good idea:)
@petarpenkov would you add `TSHttpSsnClientProtocolGet(TSHttpSsn ssnp)`
which is wrapper of `ProxyClientSession::get_protocol_string()` ? ( Session
version of
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/829
good point. Perhaps we can do it in this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user masaori335 commented on the issue:
https://github.com/apache/trafficserver/pull/829
@shukitchan I don't think so. We need one more API,
`TSHttpSsnClientProtocolGet(TSHttpSsn ssnp)`, for TS-2987.
---
If your project is set up for it, you can reply to this email and have
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/829
perhaps we can close TS-2987 as duplicate to TS-4703 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/829
Also, please remember to do the normal API review process (emails etc.),
see https://cwiki.apache.org/confluence/display/TS/API+Review+Process .
---
If your project is set up for it, you can
10 matches
Mail list logo
