[GitHub] trafficserver issue #863: TS-4750: Fix Connection Leak warnings.

2016-08-19 Thread shinrich
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/863 @oknet True there are many variants of the get_remote_* get_remote_ip should be going away since it is IPv4 (looks like only two references remain). For get_remote_endpoint and

[GitHub] trafficserver issue #863: TS-4750: Fix Connection Leak warnings.

2016-08-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/863 @shinrich Lets do it! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] trafficserver issue #863: TS-4750: Fix Connection Leak warnings.

2016-08-15 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/863 @zwoop Looks good to me! @shinrich we are defined too many get_remote_*() method, my suggest is only keep one from get_remote_addr() and get_remote_endpoint() --- If your project is set up

[GitHub] trafficserver issue #863: TS-4750: Fix Connection Leak warnings.

2016-08-14 Thread masaori335
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/863 The change seems reasonable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #863: TS-4750: Fix Connection Leak warnings.

2016-08-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/863 @oknet Can you take a look at this as well please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #863: TS-4750: Fix Connection Leak warnings.

2016-08-12 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/863 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/427/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #863: TS-4750: Fix Connection Leak warnings.

2016-08-12 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/863 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/530/ for details. --- If your project is set up for it, you can reply to this email and have your