[GitHub] trafficserver issue #937: TS-2482: Should use target_addr instead of server_...

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/937 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #937: TS-2482: Should use target_addr instead of server_...

Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/937 @oknet the code is fine, it was just a FYI :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver issue #937: TS-2482: Should use target_addr instead of server_...

Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/937 @jpeach It is conditional assert on lock check. Do u means keep the if statement and ink_abort inside it ? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #937: TS-2482: Should use target_addr instead of server_...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/937 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/530/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #937: TS-2482: Should use target_addr instead of server_...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/937 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/634/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #937: TS-2482: Should use target_addr instead of server_...

Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/937 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] trafficserver issue #937: TS-2482: Should use target_addr instead of server_...

Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/937 @oknet FWIW if you need to assert unconditionally, you can use ``ink_abort``, which just aborts with a message. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #937: TS-2482: Should use target_addr instead of server_...

Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/937 @zwoop ink_release_assert added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature