[GitHub] trafficserver pull request #1337: This avoids some badness around some STL i...

2017-01-20 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1337 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1337: This avoids some badness around some STL i...

2017-01-18 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1337#discussion_r96737701 --- Diff: plugins/experimental/cache_promote/cache_promote.cc --- @@ -327,10 +334,12 @@ class LRUPolicy : public PromotionPolicy private:

[GitHub] trafficserver pull request #1337: This avoids some badness around some STL i...

2017-01-18 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1337 This avoids some badness around some STL implementations Where the complexity of ::size is not O(1) Can someone please carefully review that I did the ++'s and --'s in all the rig