Github user jacksontj closed the pull request at:
https://github.com/apache/trafficserver/pull/947
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user oknet commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/947#discussion_r78128086
--- Diff: iocore/net/UnixNetVConnection.cc ---
@@ -270,6 +270,21 @@ read_from_net(NetHandler *nh, UnixNetVConnection *vc,
EThread *thread)
close
Github user oknet commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/947#discussion_r78127251
--- Diff: iocore/net/UnixNetVConnection.cc ---
@@ -270,6 +270,21 @@ read_from_net(NetHandler *nh, UnixNetVConnection *vc,
EThread *thread)
close
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/947#discussion_r78127223
--- Diff: iocore/net/UnixNetVConnection.cc ---
@@ -270,6 +270,21 @@ read_from_net(NetHandler *nh, UnixNetVConnection *vc,
EThread *thread)
clos
Github user oknet commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/947#discussion_r78127044
--- Diff: iocore/net/UnixNetVConnection.cc ---
@@ -270,6 +270,21 @@ read_from_net(NetHandler *nh, UnixNetVConnection *vc,
EThread *thread)
close
Github user oknet commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/947#discussion_r78126610
--- Diff: iocore/net/UnixNetVConnection.cc ---
@@ -270,6 +270,21 @@ read_from_net(NetHandler *nh, UnixNetVConnection *vc,
EThread *thread)
close
Github user oknet commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/947#discussion_r78126177
--- Diff: iocore/net/UnixNetVConnection.cc ---
@@ -270,6 +270,21 @@ read_from_net(NetHandler *nh, UnixNetVConnection *vc,
EThread *thread)
close
Github user jacksontj commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/947#discussion_r77858252
--- Diff: iocore/net/UnixNet.cc ---
@@ -525,7 +531,17 @@ NetHandler::mainNetEvent(int event, Event *e)
close_UnixNetVConnection(vc, trigger
Github user oknet commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/947#discussion_r77765559
--- Diff: iocore/net/UnixNet.cc ---
@@ -525,7 +531,17 @@ NetHandler::mainNetEvent(int event, Event *e)
close_UnixNetVConnection(vc, trigger_eve
Github user oknet commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/947#discussion_r77764403
--- Diff: iocore/net/UnixNet.cc ---
@@ -525,7 +531,17 @@ NetHandler::mainNetEvent(int event, Event *e)
close_UnixNetVConnection(vc, trigger_eve
Github user jacksontj commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/947#discussion_r77699771
--- Diff: iocore/net/UnixNet.cc ---
@@ -542,7 +555,14 @@ NetHandler::mainNetEvent(int event, Event *e)
close_UnixNetVConnection(vc, trigger
Github user oknet commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/947#discussion_r77499140
--- Diff: iocore/net/UnixNet.cc ---
@@ -542,7 +555,14 @@ NetHandler::mainNetEvent(int event, Event *e)
close_UnixNetVConnection(vc, trigger_eve
GitHub user jacksontj opened a pull request:
https://github.com/apache/trafficserver/pull/947
TS-4796 Change UnixNetHandler to always bubble up epoll errors to the
VConnection
Before if the vcon wasn't read or write enabled errors would be swallowed.
This leads to a variety of issu
13 matches
Mail list logo
