[GitHub] trafficserver pull request #1409: Log crc field and psql field correctly wit...

2017-02-01 Thread maskit
GitHub user maskit opened a pull request: https://github.com/apache/trafficserver/pull/1409 Log crc field and psql field correctly with H2 The two field values were logged incorrectly if a resopnse body is short. Because a write VIO isn't pass to a consumer if whole

[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...

2017-02-01 Thread vmamidi
Github user vmamidi commented on the issue: https://github.com/apache/trafficserver/pull/1404 incorporated the review comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #1397: TS-1768: AC_SEARCH_LIBS vs. AC_CHECK_LIB

2017-02-01 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1397 I'm seeing the same thing on the CI machine [1]. Can you please share the output of `make V=1 cmd/traffic_top/traffic_top` with me? [1]

[GitHub] trafficserver pull request #1407: Fix for YTSATS-983

2017-02-01 Thread SolidWallOfCode
GitHub user SolidWallOfCode opened a pull request: https://github.com/apache/trafficserver/pull/1407 Fix for YTSATS-983 This is a bug where the AdminClient perl interface can get trapped in a spin loop. This has been an internal problem with Yahoo! monitoring applications. You

[GitHub] trafficserver issue #1406: Fix Assertion failure in the regex_revalidate plu...

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1406 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1452/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver pull request #1410: 6.2.x: TS-4729 and TS-4665: H2 not termina...

2017-02-01 Thread maskit
GitHub user maskit opened a pull request: https://github.com/apache/trafficserver/pull/1410 6.2.x: TS-4729 and TS-4665: H2 not terminating stream with short chunked response Backporting #888. Just cherry-picked the two commits, and resolved few conflicts. You can merge this pull

[GitHub] trafficserver issue #1406: Fix Assertion failure in the regex_revalidate plu...

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1406 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1345/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1410: 6.2.x: TS-4729 and TS-4665: H2 not terminating st...

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1410 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1347/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1407: Fix potential spin loop in perl management librar...

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1407 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/Github-Clang/15/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1406: Fix Assertion failure in the regex_revalidate plu...

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1406 clang-analyzer build *failed*! See https://ci.trafficserver.apache.org/job/Github-Clang/17/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1407: Fix for YTSATS-983

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1407 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1343/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1409: Log crc field and psql field correctly with H2

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1409 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1453/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1409: Log crc field and psql field correctly with H2

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1409 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1346/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1408: Prune some unused library dependencies

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1408 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1451/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1408: Prune some unused library dependencies

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1408 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/Github-Clang/16/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1407: Fix for YTSATS-983

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1407 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1450/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver pull request #1408: Prune some unused library dependencies

2017-02-01 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1408 Prune some unused library dependencies and add a script to check for unused dependencies going forward. This PR depends on #1392 because otherwise the script fails -- traffic_server

[GitHub] trafficserver issue #1410: 6.2.x: TS-4729 and TS-4665: H2 not terminating st...

2017-02-01 Thread maskit
Github user maskit commented on the issue: https://github.com/apache/trafficserver/pull/1410 Re-pushed with Conflicts info. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #1406: Fix Assertion failure in the regex_revalidate plu...

2017-02-01 Thread jrushford
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1406 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver issue #1408: Prune some unused library dependencies

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1408 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/1344/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1397: TS-1768: AC_SEARCH_LIBS vs. AC_CHECK_LIB

2017-02-01 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1397 Hmmm, not sure, it is for me: ``` [root@fedora ats]# ldd bin/traffic_top | grep -i hwloc libhwloc.so.5 => /lib64/libhwloc.so.5 (0x7f29395a7000) ``` That's

[GitHub] trafficserver issue #1410: 6.2.x: TS-4729 and TS-4665: H2 not terminating st...

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1410 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1454/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1410: 6.2.x: TS-4729 and TS-4665: H2 not terminating st...

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1410 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1348/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1410: 6.2.x: TS-4729 and TS-4665: H2 not terminating st...

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1410 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1455/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1409: Log crc field and psql field correctly with H2

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1409 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/Github-Clang/18/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1410: 6.2.x: TS-4729 and TS-4665: H2 not terminating st...

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1410 clang-analyzer build *failed*! See https://ci.trafficserver.apache.org/job/Github-Clang/20/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1410: 6.2.x: TS-4729 and TS-4665: H2 not terminating st...

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1410 clang-analyzer build *failed*! See https://ci.trafficserver.apache.org/job/Github-Clang/19/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1392: TS-2095: TS_HAS_LIBZ and TS_HAS_LZMA are always f...

2017-02-01 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1392 @zwoop I revised this: ```Diff print_feature("BUILD_PERSON", BUILD_PERSON, json); print_feature("BUILD_GROUP", BUILD_GROUP, json); print_feature("BUILD_NUMBER",

[GitHub] trafficserver pull request #1404: TS-1403 retry safe methods in case of serv...

2017-02-01 Thread vmamidi
GitHub user vmamidi opened a pull request: https://github.com/apache/trafficserver/pull/1404 TS-1403 retry safe methods in case of server failures irrespective of connection state You can merge this pull request into a Git repository by running: $ git pull

[GitHub] trafficserver issue #1403: idempotent requests should be retryable irrespect...

2017-02-01 Thread vmamidi
GitHub user vmamidi opened an issue: https://github.com/apache/trafficserver/issues/1403 idempotent requests should be retryable irrespective of the state of the connection According to RFC ( https://tools.ietf.org/html/rfc7231#section-4.2.1 ) all the idempotent methods should be

[GitHub] trafficserver issue #1388: Fixes for building with OpenSSL 1.1

2017-02-01 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1388 @zwoop I separated the commits because they each address a different issue -- #1384 and #1385. I think that makes the most sense ... but I'm happy to squash them if you prefer! --- If your

[GitHub] trafficserver issue #1400: traffic_via depends on the PCRE library

2017-02-01 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1400 > I think we should backport this to 7.1.x too I agree. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request #1400: traffic_via depends on the PCRE library

2017-02-01 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1400 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...

2017-02-01 Thread vmamidi
Github user vmamidi commented on the issue: https://github.com/apache/trafficserver/pull/1404 According to RFC ( https://tools.ietf.org/html/rfc7231#section-4.2.1 ) all the idempotent methods should be retryable but we can at least try to retry the safe requests. The methods GET,

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/Github-Clang/12/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver pull request #1404: TS-1403 retry safe methods in case of serv...

2017-02-01 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1404#discussion_r98966326 --- Diff: proxy/http/HttpTransact.cc --- @@ -6487,9 +6487,15 @@ HttpTransact::is_request_valid(State *s, HTTPHdr *incoming_request) bool

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

2017-02-01 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1357 @SolidWallOfCode Is this going to go in for 7.1.x ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1447/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1403: idempotent requests should be retryable irrespect...

2017-02-01 Thread zwoop
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1403 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] trafficserver issue #1405: TS-552: Trivial Autoconf cleanup

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1405 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1341/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1405: TS-552: Trivial Autoconf cleanup

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1405 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1448/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver pull request #1406: Fix Assertion failure in the regex_revalid...

2017-02-01 Thread jrushford
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1406 Fix Assertion failure in the regex_revalidate plugin. When using the regex_revalidate plugin, we see an assertion failure in TSContSchedule() at InkAPI.cc:4232 Since TS-4387,

[GitHub] trafficserver issue #1402: Crash in InactivityCop::check_inactivity with dea...

2017-02-01 Thread jaaju
Github user jaaju commented on the issue: https://github.com/apache/trafficserver/issues/1402 @zwoop , we are seeing this issue only in our production env and our synthetic tests and internal deployments do not have the issue. Also, we are in the process of upgrading from ATS 5 to

[GitHub] trafficserver issue #1403: idempotent requests should be retryable irrespect...

2017-02-01 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1403 Closing, since we have a PR already. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver issue #1403: idempotent requests should be retryable irrespect...

2017-02-01 Thread bryancall
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/issues/1403 This is the PR for this issue: #1404 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/1340/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver pull request #1405: TS-552: Trivial Autoconf cleanup

2017-02-01 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1405 TS-552: Trivial Autoconf cleanup We dropped exc_capture_context() and MLD_demangle_string() along with support for the Alpha architecture. You can merge this pull request into a Git

[GitHub] trafficserver issue #1405: TS-552: Trivial Autoconf cleanup

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1405 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/Github-Clang/13/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1406: Fix Assertion failure in the regex_revalidate plu...

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1406 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1449/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1406: Fix Assertion failure in the regex_revalidate plu...

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1406 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1342/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1406: Fix Assertion failure in the regex_revalidate plu...

2017-02-01 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1406 clang-analyzer build *failed*! See https://ci.trafficserver.apache.org/job/Github-Clang/14/ for details. --- If your project is set up for it, you can reply to this email and have your