Github user oknet commented on the issue:
https://github.com/apache/trafficserver/issues/1412
and HttpSM::history is needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user oknet opened a pull request:
https://github.com/apache/trafficserver/pull/1509
TS-5106: Create ParentRoundRobin object as ParentRecord->selection_strategy
for default parent proxy server
(cherry picked from commit 7ffe037845f45497aa9e95919a3a7bc0ca288163)
To
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1510
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/200/ for details.
---
If your project is set up for it, you can reply to this email
GitHub user oknet opened a pull request:
https://github.com/apache/trafficserver/pull/1511
heap-use-after-free: Access ua_session after HttpTunnel::chain_abort_all
called due to bad post chunked data
You can merge this pull request into a Git repository by running:
$ git
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1511
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1636/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/issues/1412
Can you show me the netvc_context of the UnixNetVConnection ? in order to
identify the side of it (client vc or server vc ?)
---
If your project is set up for it, you can reply to this
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1510
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1531/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/issues/1412
I found a bug related to this issue:
HttpSM::state_request_wait_for_transform_read could receive the
VC_EVENT_EOS, VC_EVENT_ERROR from TransformTerminus::handle_event and transfer
Github user SolidWallOfCode closed the pull request at:
https://github.com/apache/trafficserver/pull/1508
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1511
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1532/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1508
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/202/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1508
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/70/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1508
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1533/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1511
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/69/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1511
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/201/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1508
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1637/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1510
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/68/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1509
Intel CC build *failed*! See
https://ci.trafficserver.apache.org/job/icc-github/67/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1509
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/199/ for details.
---
If your project is set up for it, you can reply to this email
Github user ykopel commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1473#discussion_r103446430
--- Diff: proxy/http/HttpTransact.cc ---
@@ -7845,10 +7845,12 @@ HttpTransact::build_request(State *s, HTTPHdr
*base_request, HTTPHdr *outgoing_r
GitHub user oknet opened a pull request:
https://github.com/apache/trafficserver/pull/1510
Crash at HttpSM::state_request_wait_for_transform_read
In the function, it is try to get int64_t from 'data':
int64_t size = *((int64_t)data);
But
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1509
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1634/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1509
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1530/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/1510
we should always callback EVENT_ERROR or EVENT_EOS with VIO as data value.
a nullptr as data is bad idea here.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1510
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1635/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user realpdm commented on the issue:
https://github.com/apache/trafficserver/issues/1463
It might be useful to note that when ATS crashes it doesn't seem to have
this behavior, bur a proper shut down/restart does
---
If your project is set up for it, you can reply to this
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1512
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/203/ for details.
---
If your project is set up for it, you can reply to this email
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1487
@SolidWallOfCode Why was this closed with no labels, no Milestone, no
nothing :-/. Come one!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user postwait opened a pull request:
https://github.com/apache/trafficserver/pull/1512
Don't push stack variables in lightuserdata
In systems that have wide VA access (Illumos), pushing (the address of)
stack variables into the VM as lightuserdata isn't supported. This
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1512
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/71/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1512
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1638/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1516
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1649/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1514
Not sure if it'll let you push again on this PR, but if not, just make a
new one. The point is, we don't want broken / non-functional commits in the
history, so I reverted this.
---
If your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1517
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/82/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1299
Intel CC build *failed*! See
https://ci.trafficserver.apache.org/job/icc-github/84/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1516
I'm on the fence about including the `Cache-Control: private` changes in
this patch. On one hand, it makes sense for that to be in this refactor. On the
other, it has nothing to do with
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1512
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/77/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1512
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1646/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/1516
I would like to do the review on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1379
@zwoop Yes, this needs to get backported. I ran into this issue testing
the 7.1.x branch in production.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1332
Intel CC build *failed*! See
https://ci.trafficserver.apache.org/job/icc-github/76/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1514
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1517
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1650/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1512
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/210/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1517
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1545/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1299
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/83/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1517
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/214/ for details.
---
If your project is set up for it, you can reply to this email
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1514
The FreeBSD failure is because of the VM being unstable (bloody FreeBSD
needs a reboot once a week or so).
---
If your project is set up for it, you can reply to this email and have your
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1516
Implement Cache-Control: immutable handling
This patch makes `combo_handler` correctly handle the presence of one or
more immutable flags.
In short, the combo response will be
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1512
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/78/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1514
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1648/ for details.
---
If your project is set up for it, you can reply to this email and have
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1518
Ensure 'service trafficserver stopâ is synchronous under load on redhat
Currently the service trafficserver stop command on redhat might return
before ATS has exited.
This is not good
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1332
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/linux-github/1539/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1512
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1645/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1516
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1647/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1512
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/209/ for details.
---
If your project is set up for it, you can reply to this email
Github user postwait closed the pull request at:
https://github.com/apache/trafficserver/pull/1512
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1299
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1651/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1299
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1548/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user timbunce commented on the issue:
https://github.com/apache/trafficserver/pull/1514
Gah! killproc is written to need the -d option to follow the -p option.
Sorry!
```
killproc -p $TS_PIDFILE -d 35 $TS_DAEMON
```
---
If your project is set up for it, you can
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
I've reverted this, as per @bryancall recommendation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1514
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/80/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1514
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1516
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/211/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1516
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/213/ for details.
---
If your project is set up for it, you can reply to this email
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/1511
Looks reasonable to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1514
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1514
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1642/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1332
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1643/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1512
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/linux-github/1540/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1516
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/linux-github/1541/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1516
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1543/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1514
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/212/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1514
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1538/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1514
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/75/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1332
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1644/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1332
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/208/ for details.
---
If your project is set up for it, you can reply to this email
GitHub user jablko opened a pull request:
https://github.com/apache/trafficserver/pull/1517
Remove BisonHeaderToC++.sed
We can do without it, and less is more?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jablko/trafficserver
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1516
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/79/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1516
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/81/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1514
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1544/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user persiaAziz commented on the issue:
https://github.com/apache/trafficserver/pull/1299
@SolidWallOfCode please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1299
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1652/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1514
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/207/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1512
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1542/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1514
Dang it my bad... I'm gonna revert these for now. @timbunce can you please
squash the commits into one commit, and push again?
---
If your project is set up for it, you can reply to this
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1516
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1546/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/issues/1459
Yes, this is still an issue. I need to do some more testing on PR #1446.
Some variant of that will need to be added to 7.1.
---
If your project is set up for it, you can reply to this
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/1516
will try to compile it tonight and see if i have more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/1516
The max-age related code is also a bit different from before. Previously we
can have max-age larger than 31536. Now with this change, I think we can no
longer have max-age larger than
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1516#discussion_r103590528
--- Diff: plugins/esi/combo_handler.cc ---
@@ -187,6 +207,94 @@ InterceptData::~InterceptData()
}
}
+void
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1518
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1549/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1518
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1518
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/217/ for details.
---
If your project is set up for it, you can reply to this email
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1516#discussion_r103586416
--- Diff: plugins/esi/combo_handler.cc ---
@@ -136,6 +138,24 @@ struct InterceptData {
~InterceptData();
};
+/*
+ * This
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1516#discussion_r103587579
--- Diff: plugins/esi/combo_handler.cc ---
@@ -136,6 +138,24 @@ struct InterceptData {
~InterceptData();
};
+/*
+ * This
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1299
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/215/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1518
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1653/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/1516
I am not in favor with the "private" related changes because i think it can
catch some existing users by surprise. And we did not mention anything in the
document as well -
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1518
Note that this is all @timbunce 's work, I just merged his two previous
commits into one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
1 - 100 of 140 matches
Mail list logo
