[jira] [Updated] (TS-956) the ON defined in TS conflict with zlib-1.2.5.1
[ https://issues.apache.org/jira/browse/TS-956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao Yongming updated TS-956: - Attachment: TS-956.patch zlib 1.2.5.1 start to use the micro ON, which is conflict with TS, from what I can tell, this is just a optval for setsockopt(), it is safe to change without any problem, and here is the patch the ON defined in TS conflict with zlib-1.2.5.1 - Key: TS-956 URL: https://issues.apache.org/jira/browse/TS-956 Project: Traffic Server Issue Type: Bug Components: Cleanup, Portability Affects Versions: 3.1.1 Environment: gcc 4.6.1, zlib 1.2.5.1, ts trunk Reporter: Zhao Yongming Assignee: Zhao Yongming Priority: Critical Fix For: 3.1.1 Attachments: TS-956.patch when building trunk with my fresh updated gentoo, TS fail at: {code} x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../../lib/ts -I../../iocore/eventsystem -I../../iocore/net -I../../iocore/aio -I../../iocore/hostdb -I../../iocore/cache -I../../iocore/cluster -I../../iocore/utils -I../../iocore/dns -I../../lib -I../../lib/records -I../../proxy -I../../proxy/hdrs -I../../proxy/http -I../../proxy/http/remap -I../../mgmt -I../../mgmt/preparse -I../../mgmt/utils -D_LARGEFILE64_SOURCE=1 -D_COMPILE64BIT_SOURCE=1 -D_GNU_SOURCE -D_REENTRANT -Dlinux -pipe -g -ggdb3 -fno-strict-aliasing -Wall -Werror -O3 -feliminate-unused-debug-symbols -Wno-invalid-offsetof -MT Inline.o -MD -MP -MF .deps/Inline.Tpo -c -o Inline.o Inline.cc In file included from RamCacheCLFUS.cc:30:0: /usr/include/zlib.h:1283:32: error: invalid conversion from 'char*' to 'int' [-fpermissive] /usr/include/zlib.h:1283:34: error: expected ',' or ';' before '(' token mv -f .deps/CacheHttp.Tpo .deps/CacheHttp.Po x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../../lib/ts -I../../iocore/eventsystem -I../../iocore/net -I../../iocore/aio -I../../iocore/hostdb -I../../iocore/cache -I../../iocore/cluster -I../../iocore/utils -I../../iocore/dns -I../../lib -I../../lib/records -I../../proxy -I../../proxy/hdrs -I../../proxy/http -I../../proxy/http/remap -I../../mgmt -I../../mgmt/preparse -I../../mgmt/utils -D_LARGEFILE64_SOURCE=1 -D_COMPILE64BIT_SOURCE=1 -D_GNU_SOURCE -D_REENTRANT -Dlinux -pipe -g -ggdb3 -fno-strict-aliasing -Wall -Werror -O3 -feliminate-unused-debug-symbols -Wno-invalid-offsetof -MT CacheTest.o -MD -MP -MF .deps/CacheTest.Tpo -c -o CacheTest.o CacheTest.cc make[2]: *** [RamCacheCLFUS.o] Error 1 make[2]: *** Waiting for unfinished jobs {code} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-955) TS-168 breaks regressions for TextLog
[ https://issues.apache.org/jira/browse/TS-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13106067#comment-13106067 ] Leif Hedstrom commented on TS-955: -- Right. That happens because the write on the log doesn't seem to get flushed. And therefore the text log file is never created, so the test to read the log fails (since the filevdoesnt exist). TS-168 breaks regressions for TextLog - Key: TS-955 URL: https://issues.apache.org/jira/browse/TS-955 Project: Traffic Server Issue Type: Bug Components: Logging Affects Versions: 3.1.1 Reporter: Leif Hedstrom Assignee: Zhao Yongming Priority: Critical Fix For: 3.1.1 With the fixes from TS-168, the logging regressions can fail if you run the traffic_server -R 1 more than once. The first run always succeeds, but the 2nd and subsequent run can fail. What seems to happen is that the (small) log is not flushed, and the log is not created until the first flush happens. So, everything looks like it works, up until we (5s after log creation) try to read the log. The log then doesn't exist, and the regression in log_test_handler() fails (since, the file can't be open nor read). I've tracked this down to the commit for TS-168, and also traced through the test in gdb, and as far as I can tell, the flush never happens, which means the log write never happens, and hence, the log file creation never happens either. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-950) Error for regression testing for V3.0.0
[ https://issues.apache.org/jira/browse/TS-950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom updated TS-950: - Fix Version/s: 3.1.1 Assignee: Leif Hedstrom Error for regression testing for V3.0.0 --- Key: TS-950 URL: https://issues.apache.org/jira/browse/TS-950 Project: Traffic Server Issue Type: Bug Components: HTTP Affects Versions: 3.0.0 Environment: Ubuntu 11.04 for ATS V3.0.0. 32-bit. Reporter: Steven Assignee: Leif Hedstrom Priority: Minor Labels: test Fix For: 3.1.1 I am trying to run regression testing in Ubuntu 11.04 for ATS V3.0.0 using /usr/local/trafficserver/bin/traffic_server -R 1 But I have following fatal error: test_http_hdr_print_and_copy FATAL: HdrHeap.cc:610: failed assert `(((uintptr_t) buf) HDR_PTR_ALIGNMENT_MASK) == 0` -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-178) Change INK_ prefix to TS_ and ink_ to ts_ and inkXXX to tsXXX, and change filenames and directory structure
[ https://issues.apache.org/jira/browse/TS-178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom updated TS-178: - Fix Version/s: (was: 3.1.1) sometime Change INK_ prefix to TS_ and ink_ to ts_ and inkXXX to tsXXX, and change filenames and directory structure --- Key: TS-178 URL: https://issues.apache.org/jira/browse/TS-178 Project: Traffic Server Issue Type: Improvement Components: Cleanup Reporter: John Plevyak Fix For: sometime We should change the INK_, ink_ and ink prefixes to be TS_, ts_ and ts. The target for this change is 2.2, that is, right before the 2.2 snap we make this changes. Earlier and it will make merging bug fixes into both 2.0 and 2.1 very hard as patch will likely fail, particularly if we change file names. I would suggest that we combine this with changing the directory structure since we will already be biting the bullet and making it very hard to compare code across these changes. See http://cwiki.apache.org/confluence/display/TS/2_2_Prefix_Changes for the ongoing proposal. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TS-957) ae filtering need to take care of IE6 and the missing of ae header
ae filtering need to take care of IE6 and the missing of ae header -- Key: TS-957 URL: https://issues.apache.org/jira/browse/TS-957 Project: Traffic Server Issue Type: Improvement Components: HTTP Affects Versions: 3.1.1 Reporter: Zhao Yongming Assignee: Zhao Yongming Priority: Minor Fix For: 3.1.1 the ae filter does not take care of IE6 by default. and it does not add the missing ae codes as needed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-214) On Solaris, use port_send to signal async events to a waiting thread (e.g. like eventfd/pipe)
[ https://issues.apache.org/jira/browse/TS-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom updated TS-214: - Fix Version/s: (was: 3.1.1) 3.1.2 Assignee: Theo Schlossnagle (was: George Paul) Theo: Is this something we should look into ? I'm moving this to 3.1.2 for now, but feel to reschedule as necessary. On Solaris, use port_send to signal async events to a waiting thread (e.g. like eventfd/pipe) - Key: TS-214 URL: https://issues.apache.org/jira/browse/TS-214 Project: Traffic Server Issue Type: Improvement Components: Core Affects Versions: 2.1.0 Environment: OpenSolaris Reporter: John Plevyak Assignee: Theo Schlossnagle Fix For: 3.1.2 We should use port_send to signal async events to a waiting thread (e.g. like eventfd/pipe). http://developers.sun.com/solaris/articles/event_completion.html -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-475) HTTP SM should support efficient byte range requests
[ https://issues.apache.org/jira/browse/TS-475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom reassigned TS-475: Assignee: (was: Eric Balsa) Anyone interested to work on this ? HTTP SM should support efficient byte range requests Key: TS-475 URL: https://issues.apache.org/jira/browse/TS-475 Project: Traffic Server Issue Type: Bug Components: HTTP Reporter: Leif Hedstrom Priority: Critical Fix For: 3.1.1 The cache has support for efficiently locate a particular range in the cached object, but the HTTP SM does not support this. In order to make Range: request efficient (particularly on large objects), the SM should support this new cache feature. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-803) Fix SOCKS breakage and allow for setting next-hop SOCKS
[ https://issues.apache.org/jira/browse/TS-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13106631#comment-13106631 ] Leif Hedstrom commented on TS-803: -- Moving out again, until we can get a fresh patch :) Fix SOCKS breakage and allow for setting next-hop SOCKS --- Key: TS-803 URL: https://issues.apache.org/jira/browse/TS-803 Project: Traffic Server Issue Type: New Feature Components: Network Environment: Wherever ATS might run Reporter: M. Nunberg Fix For: 3.1.1 Here is a patch I drew up a few months ago against a snapshot of ATS/2.1.7 unstable/git. There are some quirks here, and I'm not that sure any more what this patch does exactly. However it: 1) Does fix SOCKS connections in general 2) Allows setting next-hop SOCKS proxy via the API Problems: See https://issues.apache.org/jira/browse/TS-802 This has no effect on connections which are drawn from the connection pool, as it seems ATS currently doesn't maintain unique identities for peripheral connection params (source IP, SOCKS etc); i.e. this only affects new TCP connections to an OS. diff -x '*.o' -ru tsorig/iocore/net/I_NetVConnection.h tsgit217/iocore/net/I_NetVConnection.h --- tsorig/iocore/net/I_NetVConnection.h2011-03-09 21:43:58.0 + +++ tsgit217/iocore/net/I_NetVConnection.h2011-03-17 14:37:18.0 + @@ -120,6 +120,13 @@ /// Version of SOCKS to use. unsigned char socks_version; + struct { + unsigned int ip; + int port; + char *username; + char *password; + } socks_override; + int socket_recv_bufsize; int socket_send_bufsize; Only in tsgit217/iocore/net: Makefile Only in tsgit217/iocore/net: Makefile.in diff -x '*.o' -ru tsorig/iocore/net/P_Socks.h tsgit217/iocore/net/P_Socks.h --- tsorig/iocore/net/P_Socks.h2011-03-09 21:43:58.0 + +++ tsgit217/iocore/net/P_Socks.h2011-03-17 13:17:20.0 + @@ -126,7 +126,7 @@ unsigned char version; bool write_done; - + bool manual_parent_selection; SocksAuthHandler auth_handler; unsigned char socks_cmd; @@ -145,7 +145,8 @@ SocksEntry():Continuation(NULL), netVConnection(0), ip(0), port(0), server_ip(0), server_port(0), nattempts(0), -lerrno(0), timeout(0), version(5), write_done(false), auth_handler(NULL), socks_cmd(NORMAL_SOCKS) +lerrno(0), timeout(0), version(5), write_done(false), manual_parent_selection(false), +auth_handler(NULL), socks_cmd(NORMAL_SOCKS) { } }; diff -x '*.o' -ru tsorig/iocore/net/Socks.cc tsgit217/iocore/net/Socks.cc --- tsorig/iocore/net/Socks.cc2011-03-09 21:43:58.0 + +++ tsgit217/iocore/net/Socks.cc2011-03-17 13:46:07.0 + @@ -73,7 +73,8 @@ nattempts = 0; findServer(); - timeout = this_ethread()-schedule_in(this, HRTIME_SECONDS(netProcessor.socks_conf_stuff-server_connect_timeout)); +// timeout = this_ethread()-schedule_in(this, HRTIME_SECONDS(netProcessor.socks_conf_stuff-server_connect_timeout)); + timeout = this_ethread()-schedule_in(this, HRTIME_SECONDS(5)); write_done = false; } @@ -81,6 +82,15 @@ SocksEntry::findServer() { nattempts++; + if(manual_parent_selection) { + if(nattempts 1) { + //Nullify IP and PORT + server_ip = -1; + server_port = 0; + } + Debug(mndebug(Socks), findServer() is a noop with manual socks selection); + return; + } #ifdef SOCKS_WITH_TS if (nattempts == 1) { @@ -187,7 +197,6 @@ } Debug(Socks, Failed to connect to %u.%u.%u.%u:%d, PRINT_IP(server_ip), server_port); - findServer(); if (server_ip == (uint32_t) - 1) { diff -x '*.o' -ru tsorig/iocore/net/UnixNetProcessor.cc tsgit217/iocore/net/UnixNetProcessor.cc --- tsorig/iocore/net/UnixNetProcessor.cc2011-03-09 21:43:58.0 + +++ tsgit217/iocore/net/UnixNetProcessor.cc2011-03-17 15:48:38.0 + @@ -228,6 +228,11 @@ !socks_conf_stuff-ip_range.match(ip)) #endif ); + if(opt-socks_override.ip = 1) { + using_socks = true; + Debug(mndebug, trying to set using_socks to true); + } + SocksEntry *socksEntry = NULL; #endif NET_SUM_GLOBAL_DYN_STAT(net_connections_currently_open_stat, 1); @@ -242,6 +247,16 @@ if (using_socks) { Debug(Socks, Using Socks ip: %u.%u.%u.%u:%d\n, PRINT_IP(ip), port); socksEntry = socksAllocator.alloc(); + +if (opt-socks_override.ip) { +//Needs to be done before socksEntry-init() +socksEntry-server_ip = opt-socks_override.ip; +socksEntry-server_port = opt-socks_override.port; +socksEntry-manual_parent_selection = true; +opt-socks_support
[jira] [Commented] (TS-837) ATS fails to compile with gcc 4.6.1 with --enable-debug
[ https://issues.apache.org/jira/browse/TS-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13106641#comment-13106641 ] Leif Hedstrom commented on TS-837: -- Is this still an issue ?? ATS fails to compile with gcc 4.6.1 with --enable-debug --- Key: TS-837 URL: https://issues.apache.org/jira/browse/TS-837 Project: Traffic Server Issue Type: Bug Affects Versions: 3.1.0, 3.0.0 Environment: Linux, Debian, Amd64 + GCC 4.6.1 Reporter: Igor Galić Fix For: 3.1.1 {noformat} In file included from ../../proxy/ControlMatcher.h:104:0, from ../../proxy/ParentSelection.h:37, from P_Socks.h:30, from P_Net.h:106, from Connection.cc:34: ../../proxy/hdrs/HTTP.h: In member function 'INK_MD5 HTTPInfo::object_key_get()': ../../proxy/hdrs/HTTP.h:1375:24: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] ../../proxy/hdrs/HTTP.h: In member function 'int64_t HTTPInfo::object_size_get()': ../../proxy/hdrs/HTTP.h:1405:24: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] ../../proxy/hdrs/HTTP.h: In member function 'void HTTPInfo::object_size_set(int64_t)': ../../proxy/hdrs/HTTP.h:1422:51: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] cc1plus: all warnings being treated as errors *** [Connection.o] Error 1 make[2]: Leaving directory `/netsrc/trafficserver-3.0.0/iocore/net' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/netsrc/trafficserver-3.0.0/iocore' make: *** [all-recursive] Error 1 {noformat} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-830) traffic_line -r returns Variable Not Found, even if it's a permission issue
[ https://issues.apache.org/jira/browse/TS-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom reassigned TS-830: Assignee: Leif Hedstrom traffic_line -r returns Variable Not Found, even if it's a permission issue - Key: TS-830 URL: https://issues.apache.org/jira/browse/TS-830 Project: Traffic Server Issue Type: Bug Components: Management Affects Versions: 3.1.0, 2.1.9 Reporter: Igor Galić Assignee: Leif Hedstrom Priority: Minor Fix For: 3.1.1 Example: {noformat} i.galic@pheme ~ % /opt/bw/bin/traffic_line -r proxy.config.dns.nameservers /opt/bw/bin/traffic_line: Variable Not Found 1 i.galic@pheme ~ % sudo /opt/bw/bin/traffic_line -r proxy.config.dns.nameservers NULL i.galic@pheme ~ % sudo /opt/bw/bin/traffic_line -r proxy.config.dns.nameservers /opt/bw/bin/traffic_line: Variable Not Found {noformat} I propose we tell the user, when it's actually a permission problem. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-312) add option to always share keep-alive connections to the origin server
[ https://issues.apache.org/jira/browse/TS-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom updated TS-312: - Fix Version/s: (was: 3.1.1) 3.1.2 add option to always share keep-alive connections to the origin server --- Key: TS-312 URL: https://issues.apache.org/jira/browse/TS-312 Project: Traffic Server Issue Type: Improvement Components: Network Reporter: Miles Libbey Assignee: Leif Hedstrom Priority: Minor Fix For: 3.1.2 (was yahoo bug 1411758) Original description by Bryan Call (bcall) 2 years ago at 2007-08-08 13:35 Leif and I were talking about extending the meaning of proxy.config.http.share_server_session for reusing keep-alive connections from the TS server and the origin server, for separate clients attached to TS. You can read more about this in [BUG 1162233]. The configuration options should be: so lets add more options to share_server_session? E.g. 0 - Never share/reuse connections 1 - Share/reuse connections if max_connections is set (default) 2 - Always try to share-reuse connections option 1 will give the behavior we currently have and 2 will always try to share the keep-alive connections to the origin servers. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TS-958) Valgrind complains on overlapping memcpy's
Valgrind complains on overlapping memcpy's -- Key: TS-958 URL: https://issues.apache.org/jira/browse/TS-958 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Leif Hedstrom There are a few complaints from valgrind on overlapping memcpy's. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TS-958) Valgrind complains on overlapping memcpy's
[ https://issues.apache.org/jira/browse/TS-958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom resolved TS-958. -- Resolution: Fixed Valgrind complains on overlapping memcpy's -- Key: TS-958 URL: https://issues.apache.org/jira/browse/TS-958 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Leif Hedstrom There are a few complaints from valgrind on overlapping memcpy's. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-955) TS-168 breaks regressions for TextLog
[ https://issues.apache.org/jira/browse/TS-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13106836#comment-13106836 ] Leif Hedstrom commented on TS-955: -- Removing the old log files (from the previous run) fixes the problem, so perhaps something around log file rotations or something ? TS-168 breaks regressions for TextLog - Key: TS-955 URL: https://issues.apache.org/jira/browse/TS-955 Project: Traffic Server Issue Type: Bug Components: Logging Affects Versions: 3.1.1 Reporter: Leif Hedstrom Assignee: Zhao Yongming Priority: Critical Fix For: 3.1.1 With the fixes from TS-168, the logging regressions can fail if you run the traffic_server -R 1 more than once. The first run always succeeds, but the 2nd and subsequent run can fail. What seems to happen is that the (small) log is not flushed, and the log is not created until the first flush happens. So, everything looks like it works, up until we (5s after log creation) try to read the log. The log then doesn't exist, and the regression in log_test_handler() fails (since, the file can't be open nor read). I've tracked this down to the commit for TS-168, and also traced through the test in gdb, and as far as I can tell, the flush never happens, which means the log write never happens, and hence, the log file creation never happens either. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-837) ATS fails to compile with gcc 4.6.1 with --enable-debug
[ https://issues.apache.org/jira/browse/TS-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13106852#comment-13106852 ] Igor Galić commented on TS-837: --- I don't know if it's still an issue, but it still exists, yes. ATS fails to compile with gcc 4.6.1 with --enable-debug --- Key: TS-837 URL: https://issues.apache.org/jira/browse/TS-837 Project: Traffic Server Issue Type: Bug Affects Versions: 3.1.0, 3.0.0 Environment: Linux, Debian, Amd64 + GCC 4.6.1 Reporter: Igor Galić Fix For: 3.1.1 {noformat} In file included from ../../proxy/ControlMatcher.h:104:0, from ../../proxy/ParentSelection.h:37, from P_Socks.h:30, from P_Net.h:106, from Connection.cc:34: ../../proxy/hdrs/HTTP.h: In member function 'INK_MD5 HTTPInfo::object_key_get()': ../../proxy/hdrs/HTTP.h:1375:24: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] ../../proxy/hdrs/HTTP.h: In member function 'int64_t HTTPInfo::object_size_get()': ../../proxy/hdrs/HTTP.h:1405:24: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] ../../proxy/hdrs/HTTP.h: In member function 'void HTTPInfo::object_size_set(int64_t)': ../../proxy/hdrs/HTTP.h:1422:51: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] cc1plus: all warnings being treated as errors *** [Connection.o] Error 1 make[2]: Leaving directory `/netsrc/trafficserver-3.0.0/iocore/net' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/netsrc/trafficserver-3.0.0/iocore' make: *** [all-recursive] Error 1 {noformat} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira