[jira] [Commented] (TS-4448) Remove superflous \n from TSDebug()

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292503#comment-15292503
 ] 

ASF GitHub Bot commented on TS-4448:


GitHub user zwoop opened a pull request:

https://github.com/apache/trafficserver/pull/652

TS-4448 Remove superfluous \n in Debug() statements

Debug() will check for this anyways, so for consistency, we should remove 
these since it sets a better precedence going forward.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zwoop/trafficserver TS-4448

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/652.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #652


commit d05792b6ac0c29cbfe3e44cb0face5e5885ce942
Author: Leif Hedstrom 
Date:   2016-05-17T22:37:13Z

TS-4448 Remove superfluous \n in Debug() statements




> Remove superflous \n from TSDebug()
> ---
>
> Key: TS-4448
> URL: https://issues.apache.org/jira/browse/TS-4448
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
>  Labels: newbie++
> Fix For: 7.0.0
>
>
> In a number of places (see below), even in docs, we have trailing \n in 
> TSDebug() statements. This is not necessary (albeit, harmless).
> {code}
> doc/developer-guide/debugging/debug-tags.en.rst:   TSDebug ("my-plugin", 
> "Starting my-plugin at %d\n", the_time);
> doc/developer-guide/plugins/example-plugins/blacklist/index.en.rst:   
>  TSDebug ("blacklist_plugin", "This event was unexpected: %d\n", );
> example/blacklist-1/blacklist-1.c:TSDebug("blacklist-1", 
> "blacklisting site: %s\n", sites[i]);
> example/blacklist-1/blacklist-1.c:TSDebug("blacklist_plugin", "This 
> event was unexpected: %d\n", event);
> example/hello/hello.c:  TSDebug("debug-hello", "Hello World!\n");
> example/redirect-1/redirect-1.c:  // TSDebug("redirect_init", "ip_deny is 
> %ld\n", ip_deny);
> example/remap/remap.cc:  TSDebug("debug-remap", "TSPluginInit: Remap plugin 
> started\n");
> example/session-1/session-1.c:TSDebug("tag_session", "In the default 
> case: event = %d\n", event);
> example/version/version.c:  TSDebug("debug-version-plugin", "Running in 
> Apache Traffic Server: v%d.%d.%d\n", major_ts_version, minor_ts_version,
> plugins/experimental/background_fetch/background_fetch.cc:
> TSDebug(PLUGIN_NAME, "Creating log name %s\n", log_name);
> plugins/experimental/background_fetch/background_fetch.cc:
> TSDebug(PLUGIN_NAME, "BgFetchState.acquire(): ret = %d, url = %s\n", ret, 
> url.c_str());
> plugins/experimental/hipes/hipes.cc:  TSDebug(PLUGIN_NAME, "Found 
> _redirect flag in URL: %d\n", redirect_flag);
> plugins/experimental/stale_while_revalidate/stale_while_revalidate.c:
> TSDebug(PLUGIN_NAME, "Plugin registration succeeded.\n");
> plugins/experimental/stale_while_revalidate/stale_while_revalidate.c:  
> TSDebug(PLUGIN_NAME, "Plugin Init Complete.\n");
> plugins/header_rewrite/conditions.cc://   TSDebug(PLUGIN_NAME, "Opened 
> DBM file %s\n", _file.c_str());
> plugins/header_rewrite/header_rewrite.cc:TSDebug(PLUGIN_NAME_DBG, "   
> Adding rule to hook=%s\n", TSHttpHookNameLookup(rule->get_hook()));
> plugins/header_rewrite/header_rewrite_test.cc:fprintf(stdout, "TSDebug: 
> %s: %.*s\n", PLUGIN_NAME, bytes, buf);
> plugins/header_rewrite/ruleset.cc:TSDebug(PLUGIN_NAME, "   Adding 
> condition: %%{%s} with arg: %s\n", p.get_op().c_str(), p.get_arg().c_str());
> plugins/header_rewrite/ruleset.cc:TSDebug(PLUGIN_NAME, "   Adding 
> operator: %s(%s)\n", p.get_op().c_str(), p.get_arg().c_str());
> plugins/libloader/libloader.c:  TSDebug("libloader", " loaded %s\n", lib);
> proxy/InkAPI.cc:// e.g. TSDebug("plugin-cool", "Snoopy is a cool guy even 
> after %d requests.\n", num_reqs);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (TS-4464) authproxy (as remap plugin) turns off cache for internal requests without discretion

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom reassigned TS-4464:
-

Assignee: Leif Hedstrom

> authproxy (as remap plugin) turns off cache for internal requests without 
> discretion
> 
>
> Key: TS-4464
> URL: https://issues.apache.org/jira/browse/TS-4464
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>
> If you use authproxy together with another plugin which also wants to do an 
> internal request, you end up turning off the cache without discretion. This 
> means that using e.g. authproxy together with background_fetch, the request 
> the background_fetch generates (and goes through the same remap rule) can not 
> be cached.
> There's an easy fix that takes care of this case when using authproxy as a 
> remap plugin. I'm not sure how we'd do it if you use the authproxy as a 
> global plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4464) authproxy (as remap plugin) turns off cache for internal requests without discretion

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4464:
--
Fix Version/s: 7.0.0

> authproxy (as remap plugin) turns off cache for internal requests without 
> discretion
> 
>
> Key: TS-4464
> URL: https://issues.apache.org/jira/browse/TS-4464
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Leif Hedstrom
> Fix For: 7.0.0
>
>
> If you use authproxy together with another plugin which also wants to do an 
> internal request, you end up turning off the cache without discretion. This 
> means that using e.g. authproxy together with background_fetch, the request 
> the background_fetch generates (and goes through the same remap rule) can not 
> be cached.
> There's an easy fix that takes care of this case when using authproxy as a 
> remap plugin. I'm not sure how we'd do it if you use the authproxy as a 
> global plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4464) authproxy (as remap plugin) turns off cache for internal requests without discretion

[James Peach (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292425#comment-15292425
 ] 

James Peach commented on TS-4464:
-

IIRC this is what {{AuthRequestIsTagged}} was meant to do.

> authproxy (as remap plugin) turns off cache for internal requests without 
> discretion
> 
>
> Key: TS-4464
> URL: https://issues.apache.org/jira/browse/TS-4464
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Leif Hedstrom
>
> If you use authproxy together with another plugin which also wants to do an 
> internal request, you end up turning off the cache without discretion. This 
> means that using e.g. authproxy together with background_fetch, the request 
> the background_fetch generates (and goes through the same remap rule) can not 
> be cached.
> There's an easy fix that takes care of this case when using authproxy as a 
> remap plugin. I'm not sure how we'd do it if you use the authproxy as a 
> global plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Build failed in Jenkins: clang-analyzer #2305

[jenkins]

See 

Changes:

[Leif Hedstrom] Added the build scripts for the docs portions in jenkins

--
[...truncated 2857 lines...]
reading sources... [ 53%] developer-guide/api/functions/TSMimeHdrFieldGet.en
reading sources... [ 53%] 
developer-guide/api/functions/TSMimeHdrFieldLengthGet.en
reading sources... [ 53%] developer-guide/api/functions/TSMimeHdrFieldNameGet.en
reading sources... [ 53%] developer-guide/api/functions/TSMimeHdrFieldNameSet.en
reading sources... [ 54%] developer-guide/api/functions/TSMimeHdrFieldNext.en
reading sources... [ 54%] developer-guide/api/functions/TSMimeHdrFieldNextDup.en
reading sources... [ 54%] developer-guide/api/functions/TSMimeHdrFieldRemove.en
reading sources... [ 54%] 
developer-guide/api/functions/TSMimeHdrFieldValueAppend.en
reading sources... [ 54%] 
developer-guide/api/functions/TSMimeHdrFieldValueDateInsert.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueDateSet.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueIntSet.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueStringGet.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueStringInsert.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValueStringSet.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValueUintInsert.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValueUintSet.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValuesClear.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValuesCount.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrFieldsClear.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrFieldsCount.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrLengthGet.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrParse.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeHdrPrint.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeParserClear.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeParserCreate.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeParserDestroy.en
reading sources... [ 58%] developer-guide/api/functions/TSMutexCreate.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexDestroy.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexLock.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexLockTry.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexUnlock.en
reading sources... [ 60%] developer-guide/api/functions/TSNetAccept.en
reading sources... [ 60%] 
developer-guide/api/functions/TSNetAcceptNamedProtocol.en
reading sources... [ 60%] developer-guide/api/functions/TSNetConnect.en
reading sources... [ 60%] developer-guide/api/functions/TSPluginInit.en
reading sources... [ 60%] developer-guide/api/functions/TSRemap.en
reading sources... [ 61%] developer-guide/api/functions/TSSslContextFindBy.en
reading sources... [ 61%] 
developer-guide/api/functions/TSSslServerContextCreate.en
reading sources... [ 61%] developer-guide/api/functions/TSTextLogObjectCreate.en
reading sources... [ 61%] developer-guide/api/functions/TSThreadCreate.en
reading sources... [ 62%] developer-guide/api/functions/TSThreadDestroy.en
reading sources... [ 62%] developer-guide/api/functions/TSThreadInit.en
reading sources... [ 62%] developer-guide/api/functions/TSThreadSelf.en
reading sources... [ 62%] 
developer-guide/api/functions/TSTrafficServerVersionGet.en
reading sources... [ 63%] developer-guide/api/functions/TSTransformCreate.en
reading sources... [ 63%] 
developer-guide/api/functions/TSTransformOutputVConnGet.en
reading sources... [ 63%] developer-guide/api/functions/TSTypes.en
reading sources... [ 63%] developer-guide/api/functions/TSUrlCreate.en
reading sources... [ 63%] developer-guide/api/functions/TSUrlDestroy.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlFtpTypeGet.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlFtpTypeSet.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlHostGet.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlHostSet.en
reading sources... [ 65%] developer-guide/api/functions/TSUrlPercentEncode.en
reading sources... [ 65%] developer-guide/api/functions/TSUrlStringGet.en
reading sources... [ 65%] developer-guide/api/functions/TSVConnAbort.en
reading sources... [ 65%] 
developer-guide/api/functions/TSVConnCacheObjectSizeGet.en
reading sources... [ 65%] developer-guide/api/functions/TSVConnClose.en
reading sources... [ 66%] developer-guide/api/functions/TSVConnClosedGet.en
reading sources... [ 66%] developer-guide/api/functions/TSVConnFdCreate.en
reading sources... [ 66%] 

[jira] [Created] (TS-4464) authproxy (as remap plugin) turns off cache for internal requests without discretion

[Leif Hedstrom (JIRA)]

Leif Hedstrom created TS-4464:
-

 Summary: authproxy (as remap plugin) turns off cache for internal 
requests without discretion
 Key: TS-4464
 URL: https://issues.apache.org/jira/browse/TS-4464
 Project: Traffic Server
  Issue Type: Bug
  Components: Plugins
Reporter: Leif Hedstrom


If you use authproxy together with another plugin which also wants to do an 
internal request, you end up turning off the cache without discretion. This 
means that using e.g. authproxy together with background_fetch, the request the 
background_fetch generates (and goes through the same remap rule) can not be 
cached.

There's an easy fix that takes care of this case when using authproxy as a 
remap plugin. I'm not sure how we'd do it if you use the authproxy as a global 
plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Jenkins build is back to normal : centos_7-master » gcc,centos_7,debug #1707

[jenkins]

See 

Jenkins build is back to normal : centos_7-master » gcc,centos_7,release #1707

[jenkins]

See 

Build failed in Jenkins: clang-analyzer #2304

[jenkins]

See 

Changes:

[James Peach] Fix configuration race in ParentProxy API tests.

--
[...truncated 2857 lines...]
reading sources... [ 53%] developer-guide/api/functions/TSMimeHdrFieldGet.en
reading sources... [ 53%] 
developer-guide/api/functions/TSMimeHdrFieldLengthGet.en
reading sources... [ 53%] developer-guide/api/functions/TSMimeHdrFieldNameGet.en
reading sources... [ 53%] developer-guide/api/functions/TSMimeHdrFieldNameSet.en
reading sources... [ 54%] developer-guide/api/functions/TSMimeHdrFieldNext.en
reading sources... [ 54%] developer-guide/api/functions/TSMimeHdrFieldNextDup.en
reading sources... [ 54%] developer-guide/api/functions/TSMimeHdrFieldRemove.en
reading sources... [ 54%] 
developer-guide/api/functions/TSMimeHdrFieldValueAppend.en
reading sources... [ 54%] 
developer-guide/api/functions/TSMimeHdrFieldValueDateInsert.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueDateSet.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueIntSet.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueStringGet.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueStringInsert.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValueStringSet.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValueUintInsert.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValueUintSet.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValuesClear.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValuesCount.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrFieldsClear.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrFieldsCount.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrLengthGet.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrParse.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeHdrPrint.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeParserClear.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeParserCreate.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeParserDestroy.en
reading sources... [ 58%] developer-guide/api/functions/TSMutexCreate.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexDestroy.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexLock.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexLockTry.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexUnlock.en
reading sources... [ 60%] developer-guide/api/functions/TSNetAccept.en
reading sources... [ 60%] 
developer-guide/api/functions/TSNetAcceptNamedProtocol.en
reading sources... [ 60%] developer-guide/api/functions/TSNetConnect.en
reading sources... [ 60%] developer-guide/api/functions/TSPluginInit.en
reading sources... [ 60%] developer-guide/api/functions/TSRemap.en
reading sources... [ 61%] developer-guide/api/functions/TSSslContextFindBy.en
reading sources... [ 61%] 
developer-guide/api/functions/TSSslServerContextCreate.en
reading sources... [ 61%] developer-guide/api/functions/TSTextLogObjectCreate.en
reading sources... [ 61%] developer-guide/api/functions/TSThreadCreate.en
reading sources... [ 62%] developer-guide/api/functions/TSThreadDestroy.en
reading sources... [ 62%] developer-guide/api/functions/TSThreadInit.en
reading sources... [ 62%] developer-guide/api/functions/TSThreadSelf.en
reading sources... [ 62%] 
developer-guide/api/functions/TSTrafficServerVersionGet.en
reading sources... [ 63%] developer-guide/api/functions/TSTransformCreate.en
reading sources... [ 63%] 
developer-guide/api/functions/TSTransformOutputVConnGet.en
reading sources... [ 63%] developer-guide/api/functions/TSTypes.en
reading sources... [ 63%] developer-guide/api/functions/TSUrlCreate.en
reading sources... [ 63%] developer-guide/api/functions/TSUrlDestroy.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlFtpTypeGet.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlFtpTypeSet.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlHostGet.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlHostSet.en
reading sources... [ 65%] developer-guide/api/functions/TSUrlPercentEncode.en
reading sources... [ 65%] developer-guide/api/functions/TSUrlStringGet.en
reading sources... [ 65%] developer-guide/api/functions/TSVConnAbort.en
reading sources... [ 65%] 
developer-guide/api/functions/TSVConnCacheObjectSizeGet.en
reading sources... [ 65%] developer-guide/api/functions/TSVConnClose.en
reading sources... [ 66%] developer-guide/api/functions/TSVConnClosedGet.en
reading sources... [ 66%] developer-guide/api/functions/TSVConnFdCreate.en
reading sources... [ 66%] developer-guide/api/functions/TSVConnIsSsl.en

Build failed in Jenkins: osx-master » clang,osx,release #888

[jenkins]

See 


Changes:

[James Peach] Fix configuration race in ParentProxy API tests.

--
[...truncated 993 lines...]
CClj_asm.o
CClj_trace.o
CClj_gdbjit.o
CClj_ctype.o
CClj_cdata.o
CClj_cconv.o
CClj_ccall.o
CClj_ccallback.o
CClj_carith.o
CClj_clib.o
CClj_cparse.o
CClj_lib.o
CClj_alloc.o
CClib_aux.o
CClib_package.o
CClib_init.o
CCluajit.o
HOSTLINK  host/minilua
DYNASMhost/buildvm_arch.h
HOSTCChost/buildvm.o
HOSTLINK  host/buildvm
BUILDVM   lj_vm.s
BUILDVM   lj_ffdef.h
BUILDVM   lj_bcdef.h
BUILDVM   lj_folddef.h
BUILDVM   lj_recdef.h
BUILDVM   lj_libdef.h
CClj_err.o
BUILDVM   jit/vmdef.lua
CClj_bc.o
CClj_dispatch.o
CClj_record.o
CClj_crecord.o
CClj_ffrecord.o
CClib_base.o
CClib_math.o
CClib_bit.o
CClib_string.o
CClib_table.o
CClib_io.o
CClib_os.o
CClib_debug.o
CClib_jit.o
CClib_ffi.o
ASM   lj_vm.o
CClj_opt_fold.o
ARlibluajit.a
LINK  luajit
OKSuccessfully built LuaJIT
 Successfully built LuaJIT 2.0.4 
Making all in proxy/hdrs
  CXX  HTTP.o
  CXX  HdrHeap.o
  CXX  HdrTSOnly.o
  CXX  HdrToken.o
  CXX  HdrUtils.o
  CXX  HttpCompat.o
  CXX  MIME.o
  CXX  URL.o
  CXX  HdrTest.o
  AR   libhdrs.a
Making all in proxy/shared
  CXX  Error.o
  CXX  DiagsConfig.o
  CXX  UglyLogStubs.o
  CXX  InkXml.o
  AR   liberror.a
  AR   libdiagsconfig.a
  AR   libxml.a
  AR   libUglyLogStubs.a
Making all in mgmt
Making all in cluster
  CXX  ClusterCom.lo
  CXX  VMap.lo
  CXXLDlibcluster.la
Making all in utils
  CXX  MgmtMarshall.lo
  CXX  MgmtSocket.lo
  CXX  MgmtUtils.lo
  CXX  ExpandingArray.lo
  CXX  MgmtLocalCleanup.lo
  CXX  MgmtProcessCleanup.lo
  CXXLDlibutils_lm.la
  CXXLDlibutils_p.la
Making all in api
Making all in include
make[3]: Nothing to be done for `all'.
  CXX  CoreAPIRemote.lo
  CXX  NetworkUtilsRemote.lo
  CXX  CfgContextImpl.lo
  CXX  CfgContextManager.lo
  CXX  CfgContextUtils.lo
  CXX  CoreAPIShared.lo
  CXX  EventCallback.lo
  CXX  GenericParser.lo
  CXX  INKMgmtAPI.lo
  CXX  NetworkMessage.lo
  CXX  CoreAPI.lo
  CXX  EventControlMain.lo
  CXX  NetworkUtilsLocal.lo
  CXX  TSControlMain.lo
  CXX  APITestCliRemote.o
  CXXLDlibmgmtapi.la
  CXXLDlibtsmgmt.la
  CXXLDlibmgmtapilocal.la
  CXXLDtraffic_api_cli_remote
  CXX  RecordsConfig.lo
  CXX  BaseManager.lo
  CXX  RecordsConfigUtils.lo
  CXX  ProcessManager.lo
  CXX  Alarms.lo
  CXX  ProxyConfig.lo
  CXX  FileManager.lo
  CXX  LocalManager.lo
  CXX  MultiFile.lo
  CXX  Rollback.lo
  CXX  WebMgmtUtils.lo
  CXXLDlibmgmt_c.la
  CXXLDlibmgmt_lm.la
  CXXLDlibmgmt_p.la
Making all in proxy
Making all in congest
  CXX  Congestion.o
  CXX  CongestionDB.o
  CXX  CongestionStats.o
  CXX  CongestionTest.o
  AR   libCongestionControl.a
Making all in http
Making all in remap
  CXX  AclFiltering.o
  CXX  RemapConfig.o
  CXX  RemapPluginInfo.o
  CXX  RemapPlugins.o
  CXX  RemapProcessor.o
  CXX  UrlMapping.o
  CXX  UrlMappingPathIndex.o
  CXX  UrlRewrite.o
  AR   libhttp_remap.a
  CXX  HttpSessionAccept.o
  CXX  HttpBodyFactory.o
  CXX  HttpCacheSM.o
  CXX  Http1ClientSession.o
  CXX  Http1ClientTransaction.o
  CXX  HttpConfig.o
  CXX  HttpConnectionCount.o
  CXX  HttpDebugNames.o
  CXX  HttpPages.o
  CXX  HttpProxyServerMain.o
  CXX  HttpSM.o
  CXX  HttpServerSession.o
  CXX  HttpSessionManager.o
  CXX  HttpTransact.o
  CXX  HttpTransactCache.o
  CXX  HttpTransactHeaders.o
  CXX  HttpTunnel.o
  CXX  HttpUpdateSM.o
  CXX  HttpUpdateTester.o
  CXX  RegressionHttpTransact.o
  AR   libhttp.a
Making all in http2
  CXX  HPACK.o
  CXX  HTTP2.o
  CXX  Http2ClientSession.o
  CXX  Http2ConnectionState.o
  CXX  Http2DebugNames.o
  CXX  Http2Stream.o
  CXX  Http2SessionAccept.o
  CXX  HuffmanCodec.o
  CXX  RegressionHPACK.o
  CXX  test_Huffmancode.o
  CXX  test_Http2DependencyTree.o
  CXXLDtest_Huffmancode
  AR   libhttp2.a
  CXXLDtest_Http2DependencyTree
Making all in spdy
  CXX  SpdySessionAccept.o
  AR   libspdy.a
Making all in logging
  CXX  Log.o
  CXX  LogAccess.o
  CXX  LogAccessHttp.o
  CXX  LogAccessICP.o
  CXX  LogBuffer.o
  CXX  LogConfig.o
  CXX  LogField.o
  CXX  LogFieldAliasMap.o
  CXX  LogFile.o
  CXX  LogFilter.o
  CXX  LogFormat.o
  CXX  

Build failed in Jenkins: osx-master » clang,osx,debug #888

[jenkins]

See 


Changes:

[James Peach] Fix configuration race in ParentProxy API tests.

--
[...truncated 994 lines...]
CClj_asm.o
CClj_trace.o
CClj_gdbjit.o
CClj_ctype.o
CClj_cdata.o
CClj_cconv.o
CClj_ccall.o
CClj_ccallback.o
CClj_carith.o
CClj_clib.o
CClj_cparse.o
CClj_lib.o
CClj_alloc.o
CClib_aux.o
CClib_package.o
CClib_init.o
CCluajit.o
HOSTLINK  host/minilua
DYNASMhost/buildvm_arch.h
HOSTCChost/buildvm.o
HOSTLINK  host/buildvm
BUILDVM   lj_ffdef.h
BUILDVM   lj_vm.s
BUILDVM   lj_bcdef.h
BUILDVM   lj_folddef.h
BUILDVM   lj_recdef.h
BUILDVM   lj_libdef.h
BUILDVM   jit/vmdef.lua
CClj_err.o
CClj_dispatch.o
CClj_record.o
CClj_crecord.o
CClj_ffrecord.o
CClib_base.o
CClib_bit.o
CClib_math.o
CClib_string.o
CClib_table.o
CClib_io.o
CClib_os.o
CClib_debug.o
CClib_jit.o
CClib_ffi.o
ASM   lj_vm.o
CClj_bc.o
CClj_opt_fold.o
ARlibluajit.a
LINK  luajit
OKSuccessfully built LuaJIT
 Successfully built LuaJIT 2.0.4 
Making all in proxy/hdrs
  CXX  HTTP.o
  CXX  HdrHeap.o
  CXX  HdrTSOnly.o
  CXX  HdrToken.o
  CXX  HttpCompat.o
  CXX  HdrUtils.o
  CXX  MIME.o
  CXX  URL.o
  CXX  HdrTest.o
  AR   libhdrs.a
Making all in proxy/shared
  CXX  Error.o
  CXX  DiagsConfig.o
  CXX  UglyLogStubs.o
  CXX  InkXml.o
  AR   liberror.a
  AR   libxml.a
  AR   libdiagsconfig.a
  AR   libUglyLogStubs.a
Making all in mgmt
Making all in cluster
  CXX  ClusterCom.lo
  CXX  VMap.lo
  CXXLDlibcluster.la
Making all in utils
  CXX  MgmtMarshall.lo
  CXX  MgmtSocket.lo
  CXX  MgmtUtils.lo
  CXX  MgmtLocalCleanup.lo
  CXX  ExpandingArray.lo
  CXX  MgmtProcessCleanup.lo
  CXXLDlibutils_lm.la
  CXXLDlibutils_p.la
Making all in api
Making all in include
make[3]: Nothing to be done for `all'.
  CXX  CoreAPIRemote.lo
  CXX  NetworkUtilsRemote.lo
  CXX  CfgContextImpl.lo
  CXX  CfgContextManager.lo
  CXX  CfgContextUtils.lo
  CXX  CoreAPIShared.lo
  CXX  EventCallback.lo
  CXX  GenericParser.lo
  CXX  INKMgmtAPI.lo
  CXX  NetworkMessage.lo
  CXX  CoreAPI.lo
  CXX  EventControlMain.lo
  CXX  NetworkUtilsLocal.lo
  CXX  TSControlMain.lo
  CXX  APITestCliRemote.o
  CXXLDlibmgmtapi.la
  CXXLDlibtsmgmt.la
  CXXLDlibmgmtapilocal.la
  CXXLDtraffic_api_cli_remote
  CXX  RecordsConfig.lo
  CXX  BaseManager.lo
  CXX  RecordsConfigUtils.lo
  CXX  ProcessManager.lo
  CXX  ProxyConfig.lo
  CXX  Alarms.lo
  CXX  FileManager.lo
  CXX  LocalManager.lo
  CXX  MultiFile.lo
  CXX  Rollback.lo
  CXX  WebMgmtUtils.lo
  CXXLDlibmgmt_c.la
  CXXLDlibmgmt_lm.la
  CXXLDlibmgmt_p.la
Making all in proxy
Making all in congest
  CXX  Congestion.o
  CXX  CongestionDB.o
  CXX  CongestionStats.o
  CXX  CongestionTest.o
  AR   libCongestionControl.a
Making all in http
Making all in remap
  CXX  AclFiltering.o
  CXX  RemapConfig.o
  CXX  RemapPluginInfo.o
  CXX  RemapPlugins.o
  CXX  RemapProcessor.o
  CXX  UrlMapping.o
  CXX  UrlMappingPathIndex.o
  CXX  UrlRewrite.o
  AR   libhttp_remap.a
  CXX  HttpSessionAccept.o
  CXX  HttpBodyFactory.o
  CXX  HttpCacheSM.o
  CXX  Http1ClientSession.o
  CXX  Http1ClientTransaction.o
  CXX  HttpConfig.o
  CXX  HttpConnectionCount.o
  CXX  HttpDebugNames.o
  CXX  HttpPages.o
  CXX  HttpProxyServerMain.o
  CXX  HttpSM.o
  CXX  HttpServerSession.o
  CXX  HttpSessionManager.o
  CXX  HttpTransact.o
  CXX  HttpTransactCache.o
  CXX  HttpTransactHeaders.o
  CXX  HttpTunnel.o
  CXX  HttpUpdateSM.o
  CXX  HttpUpdateTester.o
  CXX  RegressionHttpTransact.o
  AR   libhttp.a
Making all in http2
  CXX  HPACK.o
  CXX  HTTP2.o
  CXX  Http2ClientSession.o
  CXX  Http2ConnectionState.o
  CXX  Http2DebugNames.o
  CXX  Http2Stream.o
  CXX  Http2SessionAccept.o
  CXX  HuffmanCodec.o
  CXX  RegressionHPACK.o
  CXX  test_Huffmancode.o
  CXX  test_Http2DependencyTree.o
  CXXLDtest_Huffmancode
  AR   libhttp2.a
  CXXLDtest_Http2DependencyTree
Making all in spdy
  CXX  SpdySessionAccept.o
  AR   libspdy.a
Making all in logging
  CXX  Log.o
  CXX  LogAccessHttp.o
  CXX  LogAccess.o
  CXX  LogAccessICP.o
  CXX  LogBuffer.o
  CXX  LogConfig.o
  CXX  LogField.o
  CXX  LogFieldAliasMap.o
  CXX  LogFile.o
  CXX  LogFilter.o
  CXX  LogFormat.o
  CXX  

[jira] [Commented] (TS-3607) ats_pagespeed make error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292204#comment-15292204
 ] 

ASF GitHub Bot commented on TS-3607:


Github user caguado commented on the pull request:

https://github.com/apache/trafficserver/pull/210#issuecomment-220460158
  
Rebased against current 5.3.x and passed clang-format.

@jpeach, please let me know whether this is what you had in mind.


> ats_pagespeed make error
> 
>
> Key: TS-3607
> URL: https://issues.apache.org/jira/browse/TS-3607
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Sebastian Pesman
>Assignee: Otto van der Schaaf
> Fix For: sometime
>
>
> When compiling ats_pagespeed from the current master git 
> /tmp/trafficserver/plugins/experimental/ats_pagespeed the make process 
> results in an error.
> The error:
> ats_pagespeed.cc: In function 'void ats_transform_init(TSCont, 
> TransformCtx*)':
> ats_pagespeed.cc:485:109: error: 'INT64_MAX' was not declared in this scope
>ctx->downstream_vio = TSVConnWrite(downstream_conn, contp, 
> TSIOBufferReaderAlloc(ctx->downstream_buffer), INT64_MAX);
>   
>^
> make: *** [ats_pagespeed.so] Error 1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Build failed in Jenkins: centos_7-master » gcc,centos_7,debug #1706

[jenkins]

See 


--
[...truncated 18386 lines...]
*** TEST 56 *** STARTING ***
*** TEST 56 *** PASSED ***
*** TEST 57 *** STARTING ***
*** TEST 57 *** PASSED ***
*** TEST 58 *** STARTING ***
*** TEST 58 *** PASSED ***
*** TEST 59 *** STARTING ***
*** TEST 59 *** PASSED ***
*** TEST 60 *** STARTING ***
*** TEST 60 *** PASSED ***
*** TEST 61 *** STARTING ***
*** TEST 61 *** PASSED ***
*** TEST 62 *** STARTING ***
*** TEST 62 *** PASSED ***
*** TEST 63 *** STARTING ***
*** TEST 63 *** PASSED ***
*** TEST 64 *** STARTING ***
*** TEST 64 *** PASSED ***
*** TEST 65 *** STARTING ***
*** TEST 65 *** PASSED ***
*** TEST 66 *** STARTING ***
*** TEST 66 *** PASSED ***
*** TEST 67 *** STARTING ***
*** TEST 67 *** PASSED ***
*** TEST 68 *** STARTING ***
*** TEST 68 *** PASSED ***
*** TEST 69 *** STARTING ***
*** TEST 69 *** PASSED ***
*** TEST 70 *** STARTING ***
*** TEST 70 *** PASSED ***
*** TEST 71 *** STARTING ***
*** TEST 71 *** PASSED ***
*** TEST 72 *** STARTING ***
*** TEST 72 *** PASSED ***
*** TEST 73 *** STARTING ***
*** TEST 73 *** PASSED ***
*** TEST 74 *** STARTING ***
*** TEST 74 *** PASSED ***
*** TEST 75 *** STARTING ***
*** TEST 75 *** PASSED ***
*** TEST 76 *** STARTING ***
*** TEST 76 *** PASSED ***
*** TEST 77 *** STARTING ***
*** TEST 77 *** PASSED ***
*** TEST 78 *** STARTING ***
*** TEST 78 *** PASSED ***
*** TEST 79 *** STARTING ***
*** TEST 79 *** PASSED ***
*** TEST 80 *** STARTING ***
*** TEST 80 *** PASSED ***
*** TEST 81 *** STARTING ***
*** TEST 81 *** PASSED ***
*** TEST 82 *** STARTING ***
*** TEST 82 *** PASSED ***
*** TEST 83 *** STARTING ***
*** TEST 83 *** PASSED ***
*** TEST 84 *** STARTING ***
*** TEST 84 *** PASSED ***
*** TEST 85 *** STARTING ***
*** TEST 85 *** PASSED ***
*** TEST 86 *** STARTING ***
*** TEST 86 *** PASSED ***
*** TEST 87 *** STARTING ***
*** TEST 87 *** PASSED ***
*** TEST 88 *** STARTING ***
*** TEST 88 *** PASSED ***
*** TEST 89 *** STARTING ***
*** TEST 89 *** PASSED ***
*** TEST 90 *** STARTING ***
*** TEST 90 *** PASSED ***
*** TEST 91 *** STARTING ***
*** TEST 91 *** PASSED ***
*** TEST 92 *** STARTING ***
*** TEST 92 *** PASSED ***
*** TEST 93 *** STARTING ***
*** TEST 93 *** PASSED ***
*** TEST 94 *** STARTING ***
*** TEST 94 *** PASSED ***
*** TEST 95 *** STARTING ***
*** TEST 95 *** PASSED ***
*** TEST 96 *** STARTING ***
*** TEST 96 *** PASSED ***
*** TEST 97 *** STARTING ***
*** TEST 97 *** PASSED ***
*** TEST 98 *** STARTING ***
*** TEST 98 *** PASSED ***
*** TEST 99 *** STARTING ***
*** TEST 99 *** PASSED ***
*** TEST 100 *** STARTING ***
*** TEST 100 *** PASSED ***
*** TEST 101 *** STARTING ***
*** TEST 101 *** PASSED ***
*** TEST 102 *** STARTING ***
*** TEST 102 *** PASSED ***
*** TEST 103 *** STARTING ***
*** TEST 103 *** PASSED ***
*** TEST 104 *** STARTING ***
*** TEST 104 *** PASSED ***
*** TEST 105 *** STARTING ***
*** TEST 105 *** PASSED ***
*** TEST 106 *** STARTING ***
*** TEST 106 *** PASSED ***
*** TEST 107 *** STARTING ***
*** TEST 107 *** PASSED ***
*** TEST 108 *** STARTING ***
*** TEST 108 *** PASSED ***
*** TEST 109 *** STARTING ***
*** TEST 109 *** PASSED ***
*** TEST 110 *** STARTING ***
*** TEST 110 *** PASSED ***
*** TEST 111 *** STARTING ***
*** TEST 111 *** PASSED ***
*** TEST 112 *** STARTING ***
*** TEST 112 *** PASSED ***
*** TEST 113 *** STARTING ***
*** TEST 113 *** PASSED ***
*** TEST 114 *** STARTING ***
*** TEST 114 *** PASSED ***
*** TEST 115 *** STARTING ***
*** TEST 115 *** PASSED ***
*** TEST 116 *** STARTING ***
*** TEST 116 *** PASSED **REGRESSION_RESULT PARENTSELECTION:
  PASSED
REGRESSION_TEST DONE: FAILED
*
*** TEST 117 *** STARTING ***
*** TEST 117 *** PASSED ***
*** TEST 118 *** STARTING ***
*** TEST 118 *** PASSED ***
*** TEST 119 *** STARTING ***
*** TEST 119 *** PASSED ***
*** TEST 120 *** STARTING ***
*** TEST 120 *** PASSED ***
*** TEST 121 *** STARTING ***
*** TEST 121 *** PASSED ***
*** TEST 122 *** STARTING ***
*** TEST 122 *** PASSED ***
*** TEST 123 *** STARTING ***
*** TEST 123 *** PASSED ***
*** TEST 124 *** STARTING ***
*** TEST 124 *** PASSED ***
*** TEST 125 *** STARTING ***
*** TEST 125 *** PASSED ***
*** TEST 126 *** STARTING ***
*** TEST 126 *** PASSED ***
*** TEST 127 *** STARTING ***
*** TEST 127 *** PASSED ***
*** TEST 128 *** STARTING ***
*** TEST 128 *** PASSED ***
*** TEST 129 *** STARTING ***
*** TEST 129 *** PASSED ***
*** TEST 130 *** STARTING ***
*** TEST 130 *** PASSED ***
*** TEST 131 *** STARTING ***
*** TEST 131 *** PASSED ***
*** TEST 132 *** STARTING ***
*** TEST 132 *** PASSED ***
*** TEST 133 *** STARTING ***
*** TEST 133 *** PASSED ***
*** TEST 134 *** STARTING ***
*** TEST 134 *** PASSED ***
*** TEST 135 *** STARTING ***
*** TEST 135 *** PASSED ***
*** TEST 136 *** STARTING ***
*** TEST 136 *** PASSED ***
*** TEST 137 *** STARTING ***
*** TEST 137 *** PASSED ***
*** TEST 138 *** STARTING ***
*** TEST 138 *** 

Build failed in Jenkins: centos_7-master » gcc,centos_7,release #1706

[jenkins]

See 


--
[...truncated 18383 lines...]
*** TEST 56 *** STARTING ***
*** TEST 56 *** PASSED ***
*** TEST 57 *** STARTING ***
*** TEST 57 *** PASSED ***
*** TEST 58 *** STARTING ***
*** TEST 58 *** PASSED ***
*** TEST 59 *** STARTING ***
*** TEST 59 *** PASSED ***
*** TEST 60 *** STARTING ***
*** TEST 60 *** PASSED ***
*** TEST 61 *** STARTING ***
*** TEST 61 *** PASSED ***
*** TEST 62 *** STARTING ***
*** TEST 62 *** PASSED ***
*** TEST 63 *** STARTING ***
*** TEST 63 *** PASSED ***
*** TEST 64 *** STARTING ***
*** TEST 64 *** PASSED ***
*** TEST 65 *** STARTING ***
*** TEST 65 *** PASSED ***
*** TEST 66 *** STARTING ***
*** TEST 66 *** PASSED ***
*** TEST 67 *** STARTING ***
*** TEST 67 *** PASSED ***
*** TEST 68 *** STARTING ***
*** TEST 68 *** PASSED ***
*** TEST 69 *** STARTING ***
*** TEST 69 *** PASSED ***
*** TEST 70 *** STARTING ***
*** TEST 70 *** PASSED ***
*** TEST 71 *** STARTING ***
*** TEST 71 *** PASSED ***
*** TEST 72 *** STARTING ***
*** TEST 72 *** PASSED ***
*** TEST 73 *** STARTING ***
*** TEST 73 *** PASSED ***
*** TEST 74 *** STARTING ***
*** TEST 74 *** PASSED ***
*** TEST 75 *** STARTING ***
*** TEST 75 *** PASSED ***
*** TEST 76 *** STARTING ***
*** TEST 76 *** PASSED ***
*** TEST 77 *** STARTING ***
*** TEST 77 *** PASSED ***
*** TEST 78 *** STARTING ***
*** TEST 78 *** PASSED ***
*** TEST 79 *** STARTING ***
*** TEST 79 *** PASSED ***
*** TEST 80 *** STARTING ***
*** TEST 80 *** PASSED ***
*** TEST 81 *** STARTING ***
*** TEST 81 *** PASSED ***
*** TEST 82 *** STARTING ***
*** TEST 82 *** PASSED ***
*** TEST 83 *** STARTING ***
*** TEST 83 *** PASSED ***
*** TEST 84 *** STARTING ***
*** TEST 84 *** PASSED ***
*** TEST 85 *** STARTING ***
*** TEST 85 *** PASSED ***
*** TEST 86 *** STARTING ***
*** TEST 86 *** PASSED ***
*** TEST 87 *** STARTING ***
*** TEST 87 *** PASSED ***
*** TEST 88 *** STARTING ***
*** TEST 88 *** PASSED ***
*** TEST 89 *** STARTING ***
*** TEST 89 *** PASSED ***
*** TEST 90 *** STARTING ***
*** TEST 90 *** PASSED ***
*** TEST 91 *** STARTING ***
*** TEST 91 *** PASSED ***
*** TEST 92 *** STARTING ***
*** TEST 92 *** PASSED ***
*** TEST 93 *** STARTING ***
*** TEST 93 *** PASSED ***
*** TEST 94 *** STARTING ***
*** TEST 94 *** PASSED ***
*** TEST 95 *** STARTING ***
*** TEST 95 *** PASSED ***
*** TEST 96 *** STARTING ***
*** TEST 96 *** PASSED ***
*** TEST 97 *** STARTING ***
*** TEST 97 *** PASSED ***
*** TEST 98 *** STARTING ***
*** TEST 98 *** PASSED ***
*** TEST 99 *** STARTING ***
*** TEST 99 *** PASSED ***
*** TEST 100 *** STARTING ***
*** TEST 100 *** PASSED ***
*** TEST 101 *** STARTING ***
*** TEST 101 *** PASSED ***
*** TEST 102 *** STARTING ***
*** TEST 102 *** PASSED ***
*** TEST 103 *** STARTING ***
*** TEST 103 *** PASSED ***
*** TEST 104 *** STARTING ***
*** TEST 104 *** PASSED ***
*** TEST 105 *** STARTING ***
*** TEST 105 *** PASSED ***
*** TEST 106 *** STARTING ***
*** TEST 106 *** PASSED ***
*** TEST 107 *** STARTING ***
*** TEST 107 *** PASSED ***
*** TEST 108 *** STARTING ***
*** TEST 108 *** PASSED ***
*** TEST 109 *** STARTING ***
*** TEST 109 *** PASSED ***
*** TEST 110 *** STARTING ***
*** TEST 110 *** PASSED ***
*** TEST 111 *** STARTING ***
*** TEST 111 *** PASSED ***
*** TEST 112 *** STARTING ***
*** TEST 112 *** PASSED ***
*** TEST 113 *** STARTING ***
*** TEST 113 *** PASSED ***
*** TEST 114 *** STARTING ***
*** TEST 114 *** PASSED ***
*** TEST 115 *** STARTING ***
*** TEST 115 *** PASSED ***
*** TEST 116 *** STARTING ***
*** TEST 116 *** PASSED ***
*** TEST 117 *** STARTING ***
*** TEST 117 *** PASSED ***
*** TEST 118 *** STARTING ***
*** TEST 118 *** PASSREGRESSION_RESULT PARENTSELECTION: 
 PASSED
REGRESSION_TEST DONE: FAILED
ED ***
*** TEST 119 *** STARTING ***
*** TEST 119 *** PASSED ***
*** TEST 120 *** STARTING ***
*** TEST 120 *** PASSED ***
*** TEST 121 *** STARTING ***
*** TEST 121 *** PASSED ***
*** TEST 122 *** STARTING ***
*** TEST 122 *** PASSED ***
*** TEST 123 *** STARTING ***
*** TEST 123 *** PASSED ***
*** TEST 124 *** STARTING ***
*** TEST 124 *** PASSED ***
*** TEST 125 *** STARTING ***
*** TEST 125 *** PASSED ***
*** TEST 126 *** STARTING ***
*** TEST 126 *** PASSED ***
*** TEST 127 *** STARTING ***
*** TEST 127 *** PASSED ***
*** TEST 128 *** STARTING ***
*** TEST 128 *** PASSED ***
*** TEST 129 *** STARTING ***
*** TEST 129 *** PASSED ***
*** TEST 130 *** STARTING ***
*** TEST 130 *** PASSED ***
*** TEST 131 *** STARTING ***
*** TEST 131 *** PASSED ***
*** TEST 132 *** STARTING ***
*** TEST 132 *** PASSED ***
*** TEST 133 *** STARTING ***
*** TEST 133 *** PASSED ***
*** TEST 134 *** STARTING ***
*** TEST 134 *** PASSED ***
*** TEST 135 *** STARTING ***
*** TEST 135 *** PASSED ***
*** TEST 136 *** STARTING ***
*** TEST 136 *** PASSED ***
*** TEST 137 *** STARTING ***
*** TEST 137 *** PASSED ***
*** TEST 138 *** STARTING ***
*** TEST 138 

Build failed in Jenkins: clang-analyzer #2303

[jenkins]

See 

Changes:

[solidwallofcode] TS-4462: Clean up pending_action for TSHttpSchedule. This 
close #649.

--
[...truncated 2857 lines...]
reading sources... [ 53%] developer-guide/api/functions/TSMimeHdrFieldGet.en
reading sources... [ 53%] 
developer-guide/api/functions/TSMimeHdrFieldLengthGet.en
reading sources... [ 53%] developer-guide/api/functions/TSMimeHdrFieldNameGet.en
reading sources... [ 53%] developer-guide/api/functions/TSMimeHdrFieldNameSet.en
reading sources... [ 54%] developer-guide/api/functions/TSMimeHdrFieldNext.en
reading sources... [ 54%] developer-guide/api/functions/TSMimeHdrFieldNextDup.en
reading sources... [ 54%] developer-guide/api/functions/TSMimeHdrFieldRemove.en
reading sources... [ 54%] 
developer-guide/api/functions/TSMimeHdrFieldValueAppend.en
reading sources... [ 54%] 
developer-guide/api/functions/TSMimeHdrFieldValueDateInsert.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueDateSet.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueIntSet.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueStringGet.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueStringInsert.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValueStringSet.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValueUintInsert.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValueUintSet.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValuesClear.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValuesCount.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrFieldsClear.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrFieldsCount.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrLengthGet.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrParse.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeHdrPrint.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeParserClear.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeParserCreate.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeParserDestroy.en
reading sources... [ 58%] developer-guide/api/functions/TSMutexCreate.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexDestroy.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexLock.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexLockTry.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexUnlock.en
reading sources... [ 60%] developer-guide/api/functions/TSNetAccept.en
reading sources... [ 60%] 
developer-guide/api/functions/TSNetAcceptNamedProtocol.en
reading sources... [ 60%] developer-guide/api/functions/TSNetConnect.en
reading sources... [ 60%] developer-guide/api/functions/TSPluginInit.en
reading sources... [ 60%] developer-guide/api/functions/TSRemap.en
reading sources... [ 61%] developer-guide/api/functions/TSSslContextFindBy.en
reading sources... [ 61%] 
developer-guide/api/functions/TSSslServerContextCreate.en
reading sources... [ 61%] developer-guide/api/functions/TSTextLogObjectCreate.en
reading sources... [ 61%] developer-guide/api/functions/TSThreadCreate.en
reading sources... [ 62%] developer-guide/api/functions/TSThreadDestroy.en
reading sources... [ 62%] developer-guide/api/functions/TSThreadInit.en
reading sources... [ 62%] developer-guide/api/functions/TSThreadSelf.en
reading sources... [ 62%] 
developer-guide/api/functions/TSTrafficServerVersionGet.en
reading sources... [ 63%] developer-guide/api/functions/TSTransformCreate.en
reading sources... [ 63%] 
developer-guide/api/functions/TSTransformOutputVConnGet.en
reading sources... [ 63%] developer-guide/api/functions/TSTypes.en
reading sources... [ 63%] developer-guide/api/functions/TSUrlCreate.en
reading sources... [ 63%] developer-guide/api/functions/TSUrlDestroy.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlFtpTypeGet.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlFtpTypeSet.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlHostGet.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlHostSet.en
reading sources... [ 65%] developer-guide/api/functions/TSUrlPercentEncode.en
reading sources... [ 65%] developer-guide/api/functions/TSUrlStringGet.en
reading sources... [ 65%] developer-guide/api/functions/TSVConnAbort.en
reading sources... [ 65%] 
developer-guide/api/functions/TSVConnCacheObjectSizeGet.en
reading sources... [ 65%] developer-guide/api/functions/TSVConnClose.en
reading sources... [ 66%] developer-guide/api/functions/TSVConnClosedGet.en
reading sources... [ 66%] developer-guide/api/functions/TSVConnFdCreate.en
reading sources... [ 66%] 

Jenkins build is back to normal : centos_7-master » clang,centos_7,debug #1706

[jenkins]

See 

[jira] [Resolved] (TS-4462) TSHttpSchedule can cause use after free crash.

[Alan M. Carroll (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan M. Carroll resolved TS-4462.
-
Resolution: Fixed

> TSHttpSchedule can cause use after free crash.
> --
>
> Key: TS-4462
> URL: https://issues.apache.org/jira/browse/TS-4462
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, TS API
>Reporter: Alan M. Carroll
>Assignee: Alan M. Carroll
>Priority: Minor
> Fix For: 7.0.0
>
>
> Yahoo! is seeing production crashes which have been tracked down to calling 
> {{cancel}} on the {{pending_action}} of an {{HttpSM}}. This action comes from 
> use of {{TSHttpSchedule}} which can leave a dangling object in 
> {{pending_action}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4462) TSHttpSchedule can cause use after free crash.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292110#comment-15292110
 ] 

ASF GitHub Bot commented on TS-4462:


Github user asfgit closed the pull request at:

https://github.com/apache/trafficserver/pull/649


> TSHttpSchedule can cause use after free crash.
> --
>
> Key: TS-4462
> URL: https://issues.apache.org/jira/browse/TS-4462
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, TS API
>Reporter: Alan M. Carroll
>Assignee: Alan M. Carroll
>Priority: Minor
> Fix For: 7.0.0
>
>
> Yahoo! is seeing production crashes which have been tracked down to calling 
> {{cancel}} on the {{pending_action}} of an {{HttpSM}}. This action comes from 
> use of {{TSHttpSchedule}} which can leave a dangling object in 
> {{pending_action}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4462) TSHttpSchedule can cause use after free crash.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292109#comment-15292109
 ] 

ASF subversion and git services commented on TS-4462:
-

Commit 05e4577efa0ac7810e25710848f5597be4042c13 in trafficserver's branch 
refs/heads/master from [~amc]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=05e4577 ]

TS-4462: Clean up pending_action for TSHttpSchedule.
This close #649.


> TSHttpSchedule can cause use after free crash.
> --
>
> Key: TS-4462
> URL: https://issues.apache.org/jira/browse/TS-4462
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, TS API
>Reporter: Alan M. Carroll
>Assignee: Alan M. Carroll
>Priority: Minor
> Fix For: 7.0.0
>
>
> Yahoo! is seeing production crashes which have been tracked down to calling 
> {{cancel}} on the {{pending_action}} of an {{HttpSM}}. This action comes from 
> use of {{TSHttpSchedule}} which can leave a dangling object in 
> {{pending_action}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4462) TSHttpSchedule can cause use after free crash.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292089#comment-15292089
 ] 

ASF GitHub Bot commented on TS-4462:


Github user silentdai commented on the pull request:

https://github.com/apache/trafficserver/pull/649#issuecomment-220442827
  
I love this solution. I built with this commit. It avoids the crash when 
resuming the HttpSM from a plugin working in POST_REMAP phase if the cache is 
disabled.


> TSHttpSchedule can cause use after free crash.
> --
>
> Key: TS-4462
> URL: https://issues.apache.org/jira/browse/TS-4462
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, TS API
>Reporter: Alan M. Carroll
>Assignee: Alan M. Carroll
>Priority: Minor
> Fix For: 7.0.0
>
>
> Yahoo! is seeing production crashes which have been tracked down to calling 
> {{cancel}} on the {{pending_action}} of an {{HttpSM}}. This action comes from 
> use of {{TSHttpSchedule}} which can leave a dangling object in 
> {{pending_action}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (TS-4462) TSHttpSchedule can cause use after free crash.

[Alan M. Carroll (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan M. Carroll reassigned TS-4462:
---

Assignee: Alan M. Carroll

> TSHttpSchedule can cause use after free crash.
> --
>
> Key: TS-4462
> URL: https://issues.apache.org/jira/browse/TS-4462
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, TS API
>Reporter: Alan M. Carroll
>Assignee: Alan M. Carroll
>Priority: Minor
> Fix For: 7.0.0
>
>
> Yahoo! is seeing production crashes which have been tracked down to calling 
> {{cancel}} on the {{pending_action}} of an {{HttpSM}}. This action comes from 
> use of {{TSHttpSchedule}} which can leave a dangling object in 
> {{pending_action}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4462) TSHttpSchedule can cause use after free crash.

[Alan M. Carroll (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan M. Carroll updated TS-4462:

Priority: Minor  (was: Major)

> TSHttpSchedule can cause use after free crash.
> --
>
> Key: TS-4462
> URL: https://issues.apache.org/jira/browse/TS-4462
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, TS API
>Reporter: Alan M. Carroll
>Priority: Minor
> Fix For: 7.0.0
>
>
> Yahoo! is seeing production crashes which have been tracked down to calling 
> {{cancel}} on the {{pending_action}} of an {{HttpSM}}. This action comes from 
> use of {{TSHttpSchedule}} which can leave a dangling object in 
> {{pending_action}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Build failed in Jenkins: centos_7-master » clang,centos_7,debug #1705

[jenkins]

See 


--
[...truncated 18403 lines...]
*** TEST 56 *** STARTING ***
*** TEST 56 *** PASSED ***
*** TEST 57 *** STARTING ***
*** TEST 57 *** PASSED ***
*** TEST 58 *** STARTING ***
*** TEST 58 *** PASSED ***
*** TEST 59 *** STARTING ***
*** TEST 59 *** PASSED ***
*** TEST 60 *** STARTING ***
*** TEST 60 *** PASSED ***
*** TEST 61 *** STARTING ***
*** TEST 61 *** PASSED ***
*** TEST 62 *** STARTING ***
*** TEST 62 *** PASSED ***
*** TEST 63 *** STARTING ***
*** TEST 63 *** PASSED ***
*** TEST 64 *** STARTING ***
*** TEST 64 *** PASSED ***
*** TEST 65 *** STARTING ***
*** TEST 65 *** PASSED ***
*** TEST 66 *** STARTING ***
*** TEST 66 *** PASSED ***
*** TEST 67 *** STARTING ***
*** TEST 67 *** PASSED ***
*** TEST 68 *** STARTING ***
*** TEST 68 *** PASSED ***
*** TEST 69 *** STARTING ***
*** TEST 69 *** PASSED ***
*** TEST 70 *** STARTING ***
*** TEST 70 *** PASSED ***
*** TEST 71 *** STARTING ***
*** TEST 71 *** PASSED ***
*** TEST 72 *** STARTING ***
*** TEST 72 *** PASSED ***
*** TEST 73 *** STARTING ***
*** TEST 73 *** PASSED ***
*** TEST 74 *** STARTING ***
*** TEST 74 *** PASSED ***
*** TEST 75 *** STARTING ***
*** TEST 75 *** PASSED ***
*** TEST 76 *** STARTING ***
*** TEST 76 *** PASSED ***
*** TEST 77 *** STARTING ***
*** TEST 77 *** PASSED ***
*** TEST 78 *** STARTING ***
*** TEST 78 *** PASSED ***
*** TEST 79 *** STARTING ***
*** TEST 79 *** PASSED ***
*** TEST 80 *** STARTING ***
*** TEST 80 *** PASSED ***
*** TEST 81 *** STARTING ***
*** TEST 81 *** PASSED ***
*** TEST 82 *** STARTING ***
*** TEST 82 *** PASSED ***
*** TEST 83 *** STARTING ***
*** TEST 83 *** PASSED ***
*** TEST 84 *** STARTING ***
*** TEST 84 *** PASSED ***
*** TEST 85 *** STARTING ***
*** TEST 85 *** PASSED ***
*** TEST 86 *** STARTING ***
*** TEST 86 *** PASSED ***
*** TEST 87 *** STARTING ***
*** TEST 87 *** PASSED ***
*** TEST 88 *** STARTING ***
*** TEST 88 *** PASSED ***
*** TEST 89 *** STARTING ***
*** TEST 89 *** PASSED ***
*** TEST 90 *** STARTING ***
*** TEST 90 *** PASSED ***
*** TEST 91 *** STARTING ***
*** TEST 91 *** PASSED ***
*** TEST 92 *** STARTING ***
*** TEST 92 *** PASSED ***
*** TEST 93 *** STARTING ***
*** TEST 93 *** PASSED ***
*** TEST 94 *** STARTING ***
*** TEST 94 *** PASSED ***
*** TEST 95 *** STARTING ***
*** TEST 95 *** PASSED ***
*** TEST 96 *** STARTING ***
*** TEST 96 *** PASSED ***
*** TEST 97 *** STARTING ***
*** TEST 97 *** PASSED ***
*** TEST 98 *** STARTING ***
*** TEST 98 *** PASSED ***
*** TEST 99 *** STARTING ***
*** TEST 99 *** PASSED ***
*** TEST 100 *** STARTING ***
*** TEST 100 *** PASSED ***
*** TEST 101 *** STARTING ***
*** TEST 101 *** PASSED ***
*** TEST 102 *** STARTING ***
*** TEST 102 *** PASSED ***
*** TEST 103 *** STARTING ***
*** TEST 103 *** PASSED ***
*** TEST 104 *** STARTING ***
*** TEST 104 *** PASSED ***
*** TEST 105 *** STARTING ***
*** TEST 105 *** PASSED ***
*** TEST 106 *** STARTING ***
*** TEST 106 *** PASSED ***
*** TEST 107 *** STARTING ***
*** TEST 107 *** PASSED ***
*** TEST 108 *** STARTING ***
*** TEST 108 *** PASSED ***
*** TEST 109 *** STARTING ***
*** TEST 109 *** PASSED ***
*** TEST 110 *** STARTING ***
*** TEST 110 *** PASSED ***
*** TEST 111 *** STARTING ***
*** TEST 111 *** PASSED ***
*** TEST 112 *** STARTING ***
*** TEST 112 *** PASSED ***
*** TEST 113 *** STARTING ***
*** TEST 113 ***REGRESSION_RESULT PARENTSELECTION:  
PASSED
REGRESSION_TEST DONE: FAILED
 PASSED ***
*** TEST 114 *** STARTING ***
*** TEST 114 *** PASSED ***
*** TEST 115 *** STARTING ***
*** TEST 115 *** PASSED ***
*** TEST 116 *** STARTING ***
*** TEST 116 *** PASSED ***
*** TEST 117 *** STARTING ***
*** TEST 117 *** PASSED ***
*** TEST 118 *** STARTING ***
*** TEST 118 *** PASSED ***
*** TEST 119 *** STARTING ***
*** TEST 119 *** PASSED ***
*** TEST 120 *** STARTING ***
*** TEST 120 *** PASSED ***
*** TEST 121 *** STARTING ***
*** TEST 121 *** PASSED ***
*** TEST 122 *** STARTING ***
*** TEST 122 *** PASSED ***
*** TEST 123 *** STARTING ***
*** TEST 123 *** PASSED ***
*** TEST 124 *** STARTING ***
*** TEST 124 *** PASSED ***
*** TEST 125 *** STARTING ***
*** TEST 125 *** PASSED ***
*** TEST 126 *** STARTING ***
*** TEST 126 *** PASSED ***
*** TEST 127 *** STARTING ***
*** TEST 127 *** PASSED ***
*** TEST 128 *** STARTING ***
*** TEST 128 *** PASSED ***
*** TEST 129 *** STARTING ***
*** TEST 129 *** PASSED ***
*** TEST 130 *** STARTING ***
*** TEST 130 *** PASSED ***
*** TEST 131 *** STARTING ***
*** TEST 131 *** PASSED ***
*** TEST 132 *** STARTING ***
*** TEST 132 *** PASSED ***
*** TEST 133 *** STARTING ***
*** TEST 133 *** PASSED ***
*** TEST 134 *** STARTING ***
*** TEST 134 *** PASSED ***
*** TEST 135 *** STARTING ***
*** TEST 135 *** PASSED ***
*** TEST 136 *** STARTING ***
*** TEST 136 *** PASSED ***
*** TEST 137 *** STARTING ***
*** TEST 137 *** PASSED ***
*** TEST 138 *** STARTING ***
*** TEST 138 

Build failed in Jenkins: centos_7-master » gcc,centos_7,debug #1704

[jenkins]

See 


--
[...truncated 18386 lines...]
*** TEST 56 *** STARTING ***
*** TEST 56 *** PASSED ***
*** TEST 57 *** STARTING ***
*** TEST 57 *** PASSED ***
*** TEST 58 *** STARTING ***
*** TEST 58 *** PASSED ***
*** TEST 59 *** STARTING ***
*** TEST 59 *** PASSED ***
*** TEST 60 *** STARTING ***
*** TEST 60 *** PASSED ***
*** TEST 61 *** STARTING ***
*** TEST 61 *** PASSED ***
*** TEST 62 *** STARTING ***
*** TEST 62 *** PASSED ***
*** TEST 63 *** STARTING ***
*** TEST 63 *** PASSED ***
*** TEST 64 *** STARTING ***
*** TEST 64 *** PASSED ***
*** TEST 65 *** STARTING ***
*** TEST 65 *** PASSED ***
*** TEST 66 *** STARTING ***
*** TEST 66 *** PASSED ***
*** TEST 67 *** STARTING ***
*** TEST 67 *** PASSED ***
*** TEST 68 *** STARTING ***
*** TEST 68 *** PASSED ***
*** TEST 69 *** STARTING ***
*** TEST 69 *** PASSED ***
*** TEST 70 *** STARTING ***
*** TEST 70 *** PASSED ***
*** TEST 71 *** STARTING ***
*** TEST 71 *** PASSED ***
*** TEST 72 *** STARTING ***
*** TEST 72 *** PASSED ***
*** TEST 73 *** STARTING ***
*** TEST 73 *** PASSED ***
*** TEST 74 *** STARTING ***
*** TEST 74 *** PASSED ***
*** TEST 75 *** STARTING ***
*** TEST 75 *** PASSED ***
*** TEST 76 *** STARTING ***
*** TEST 76 *** PASSED ***
*** TEST 77 *** STARTING ***
*** TEST 77 *** PASSED ***
*** TEST 78 *** STARTING ***
*** TEST 78 *** PASSED ***
*** TEST 79 *** STARTING ***
*** TEST 79 *** PASSED ***
*** TEST 80 *** STARTING ***
*** TEST 80 *** PASSED ***
*** TEST 81 *** STARTING ***
*** TEST 81 *** PASSED ***
*** TEST 82 *** STARTING ***
*** TEST 82 *** PASSED ***
*** TEST 83 *** STARTING ***
*** TEST 83 *** PASSED ***
*** TEST 84 *** STARTING ***
*** TEST 84 *** PASSED ***
*** TEST 85 *** STARTING ***
*** TEST 85 *** PASSED ***
*** TEST 86 *** STARTING ***
*** TEST 86 *** PASSED ***
*** TEST 87 *** STARTING ***
*** TEST 87 *** PASSED ***
*** TEST 88 *** STARTING ***
*** TEST 88 *** PASSED ***
*** TEST 89 *** STARTING ***
*** TEST 89 *** PASSED ***
*** TEST 90 *** STARTING ***
*** TEST 90 *** PASSED ***
*** TEST 91 *** STARTING ***
*** TEST 91 *** PASSED ***
*** TEST 92 *** STARTING ***
*** TEST 92 *** PASSED ***
*** TEST 93 *** STARTING ***
*** TEST 93 *** PASSED ***
*** TEST 94 *** STARTING ***
*** TEST 94 *** PASSED ***
*** TEST 95 *** STARTING ***
*** TEST 95 *** PASSED ***
*** TEST 96 *** STARTING ***
*** TEST 96 *** PASSED ***
*** TEST 97 *** STARTING ***
*** TEST 97 *** PASSED ***
*** TEST 98 *** STARTING ***
*** TEST 98 *** PASSED ***
*** TEST 99 *** STARTING ***
*** TEST 99 *** PASSED ***
*** TEST 100 *** STARTING ***
*** TEST 100 *** PASSED ***
*** TEST 101 *** STARTING ***
*** TEST 101 *** PASSED ***
*** TEST 102 *** STARTING ***
*** TEST 102 *** PASSED ***
*** TEST 103 *** STARTING ***
*** TEST 103 *** PASSED ***
*** TEST 104 *** STARTING ***
*** TEST 104 *** PASSED ***
*** TEST 105 *** STARTING ***
*** TEST 105 *** PASSED ***
*** TEST 106 *** STARTING ***
*** TEST 106 *** PASSED ***
*** TEST 107 *** STARTING ***
*** TEST 107 *** PASSED ***
*** TEST 108 *** STARTING ***
*** TEST 108 *** PASSED ***
*** TEST 109 *** STARTING ***
*** TEST 109 *** PASSED ***
*** TEST 110 *** STARTING ***
*** TEST 110 *** PASSED ***
*** TEST 111 *** STARTING ***
*** TEST 111 *** PASSED ***
*** TEST 112 *** STARTING ***
*** TEST 112 *** PASSED ***
*** TEST 113 *** STARTING ***
*** TEST 113 *** PASSED ***
*** TEST 114 *** STARTING ***
*** TEST 114 *** PASSED ***
*** TEST 115 *** STARTING ***
*** TEST 115 *** PASSED ***
*** TEST 116 *** STARTING ***
*** TEST 116 *** PASSED **REGRESSION_RESULT PARENTSELECTION:
  PASSED
REGRESSION_TEST DONE: FAILED
*
*** TEST 117 *** STARTING ***
*** TEST 117 *** PASSED ***
*** TEST 118 *** STARTING ***
*** TEST 118 *** PASSED ***
*** TEST 119 *** STARTING ***
*** TEST 119 *** PASSED ***
*** TEST 120 *** STARTING ***
*** TEST 120 *** PASSED ***
*** TEST 121 *** STARTING ***
*** TEST 121 *** PASSED ***
*** TEST 122 *** STARTING ***
*** TEST 122 *** PASSED ***
*** TEST 123 *** STARTING ***
*** TEST 123 *** PASSED ***
*** TEST 124 *** STARTING ***
*** TEST 124 *** PASSED ***
*** TEST 125 *** STARTING ***
*** TEST 125 *** PASSED ***
*** TEST 126 *** STARTING ***
*** TEST 126 *** PASSED ***
*** TEST 127 *** STARTING ***
*** TEST 127 *** PASSED ***
*** TEST 128 *** STARTING ***
*** TEST 128 *** PASSED ***
*** TEST 129 *** STARTING ***
*** TEST 129 *** PASSED ***
*** TEST 130 *** STARTING ***
*** TEST 130 *** PASSED ***
*** TEST 131 *** STARTING ***
*** TEST 131 *** PASSED ***
*** TEST 132 *** STARTING ***
*** TEST 132 *** PASSED ***
*** TEST 133 *** STARTING ***
*** TEST 133 *** PASSED ***
*** TEST 134 *** STARTING ***
*** TEST 134 *** PASSED ***
*** TEST 135 *** STARTING ***
*** TEST 135 *** PASSED ***
*** TEST 136 *** STARTING ***
*** TEST 136 *** PASSED ***
*** TEST 137 *** STARTING ***
*** TEST 137 *** PASSED ***
*** TEST 138 *** STARTING ***
*** TEST 138 *** 

Build failed in Jenkins: clang-analyzer #2302

[jenkins]

See 

Changes:

[dragon512] TS-4450: Syntax error in CI test

--
[...truncated 2857 lines...]
reading sources... [ 53%] developer-guide/api/functions/TSMimeHdrFieldGet.en
reading sources... [ 53%] 
developer-guide/api/functions/TSMimeHdrFieldLengthGet.en
reading sources... [ 53%] developer-guide/api/functions/TSMimeHdrFieldNameGet.en
reading sources... [ 53%] developer-guide/api/functions/TSMimeHdrFieldNameSet.en
reading sources... [ 54%] developer-guide/api/functions/TSMimeHdrFieldNext.en
reading sources... [ 54%] developer-guide/api/functions/TSMimeHdrFieldNextDup.en
reading sources... [ 54%] developer-guide/api/functions/TSMimeHdrFieldRemove.en
reading sources... [ 54%] 
developer-guide/api/functions/TSMimeHdrFieldValueAppend.en
reading sources... [ 54%] 
developer-guide/api/functions/TSMimeHdrFieldValueDateInsert.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueDateSet.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueIntSet.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueStringGet.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueStringInsert.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValueStringSet.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValueUintInsert.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValueUintSet.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValuesClear.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValuesCount.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrFieldsClear.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrFieldsCount.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrLengthGet.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrParse.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeHdrPrint.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeParserClear.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeParserCreate.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeParserDestroy.en
reading sources... [ 58%] developer-guide/api/functions/TSMutexCreate.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexDestroy.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexLock.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexLockTry.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexUnlock.en
reading sources... [ 60%] developer-guide/api/functions/TSNetAccept.en
reading sources... [ 60%] 
developer-guide/api/functions/TSNetAcceptNamedProtocol.en
reading sources... [ 60%] developer-guide/api/functions/TSNetConnect.en
reading sources... [ 60%] developer-guide/api/functions/TSPluginInit.en
reading sources... [ 60%] developer-guide/api/functions/TSRemap.en
reading sources... [ 61%] developer-guide/api/functions/TSSslContextFindBy.en
reading sources... [ 61%] 
developer-guide/api/functions/TSSslServerContextCreate.en
reading sources... [ 61%] developer-guide/api/functions/TSTextLogObjectCreate.en
reading sources... [ 61%] developer-guide/api/functions/TSThreadCreate.en
reading sources... [ 62%] developer-guide/api/functions/TSThreadDestroy.en
reading sources... [ 62%] developer-guide/api/functions/TSThreadInit.en
reading sources... [ 62%] developer-guide/api/functions/TSThreadSelf.en
reading sources... [ 62%] 
developer-guide/api/functions/TSTrafficServerVersionGet.en
reading sources... [ 63%] developer-guide/api/functions/TSTransformCreate.en
reading sources... [ 63%] 
developer-guide/api/functions/TSTransformOutputVConnGet.en
reading sources... [ 63%] developer-guide/api/functions/TSTypes.en
reading sources... [ 63%] developer-guide/api/functions/TSUrlCreate.en
reading sources... [ 63%] developer-guide/api/functions/TSUrlDestroy.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlFtpTypeGet.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlFtpTypeSet.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlHostGet.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlHostSet.en
reading sources... [ 65%] developer-guide/api/functions/TSUrlPercentEncode.en
reading sources... [ 65%] developer-guide/api/functions/TSUrlStringGet.en
reading sources... [ 65%] developer-guide/api/functions/TSVConnAbort.en
reading sources... [ 65%] 
developer-guide/api/functions/TSVConnCacheObjectSizeGet.en
reading sources... [ 65%] developer-guide/api/functions/TSVConnClose.en
reading sources... [ 66%] developer-guide/api/functions/TSVConnClosedGet.en
reading sources... [ 66%] developer-guide/api/functions/TSVConnFdCreate.en
reading sources... [ 66%] developer-guide/api/functions/TSVConnIsSsl.en
reading sources... 

[jira] [Commented] (TS-4462) TSHttpSchedule can cause use after free crash.

[Leif Hedstrom (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291976#comment-15291976
 ] 

Leif Hedstrom commented on TS-4462:
---

Heh, 6 years to find  :)

> TSHttpSchedule can cause use after free crash.
> --
>
> Key: TS-4462
> URL: https://issues.apache.org/jira/browse/TS-4462
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, TS API
>Reporter: Alan M. Carroll
> Fix For: 7.0.0
>
>
> Yahoo! is seeing production crashes which have been tracked down to calling 
> {{cancel}} on the {{pending_action}} of an {{HttpSM}}. This action comes from 
> use of {{TSHttpSchedule}} which can leave a dangling object in 
> {{pending_action}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4462) TSHttpSchedule can cause use after free crash.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291958#comment-15291958
 ] 

ASF GitHub Bot commented on TS-4462:


Github user shinrich commented on the pull request:

https://github.com/apache/trafficserver/pull/649#issuecomment-220422969
  
Looks good to me.


> TSHttpSchedule can cause use after free crash.
> --
>
> Key: TS-4462
> URL: https://issues.apache.org/jira/browse/TS-4462
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, TS API
>Reporter: Alan M. Carroll
> Fix For: 7.0.0
>
>
> Yahoo! is seeing production crashes which have been tracked down to calling 
> {{cancel}} on the {{pending_action}} of an {{HttpSM}}. This action comes from 
> use of {{TSHttpSchedule}} which can leave a dangling object in 
> {{pending_action}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4458) disabling configuration modification breaks reloading

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291949#comment-15291949
 ] 

ASF GitHub Bot commented on TS-4458:


Github user jpeach commented on the pull request:

https://github.com/apache/trafficserver/pull/651#issuecomment-220421430
  
Ping @bcall


> disabling configuration modification breaks reloading
> -
>
> Key: TS-4458
> URL: https://issues.apache.org/jira/browse/TS-4458
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Configuration
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 7.0.0
>
>
> If you set {{proxy.config.disable_configuration_modification}} to 1, records 
> configuration callbacks are never registered, so if you update 
> {{records.config}} and then reload with {{traffic_ctl config reload}}, the 
> new configuration is not actually applied.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4458) disabling configuration modification breaks reloading

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291948#comment-15291948
 ] 

ASF GitHub Bot commented on TS-4458:


GitHub user jpeach opened a pull request:

https://github.com/apache/trafficserver/pull/651

TS-4458: disabling configuration modification breaks reloading

If you set ``proxy.config.disable_configuration_modification`` to 1, 
records configuration callbacks are never registered, so if you update 
records.config and then reload with ``traffic_ctl config reload``, the new 
configuration is not actually applied.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jpeach/trafficserver fix/4458

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/651.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #651


commit 244fb89e25df8db550d119f52e04a4d4c960e34f
Author: James Peach 
Date:   2016-05-18T22:47:21Z

TS-4458: Return RecErrT from Rec APIs.

commit 733e0be79507dc8631026378d8975b50dac607fd
Author: James Peach 
Date:   2016-05-19T18:07:12Z

TS-4458: Fix disabled modification behaviour.

If you set proxy.config.disable_configuration_modification to 1 to
prevent writing to records.config, various other features broke.
For example, configuration change callbacks were never run, so
reloading configuration did nothing.

This change retains the callbacks and just disables the persistence
of changes to records.config. Note that if you change a record with
the API, you still have to touch records.config to reload the old
values.




> disabling configuration modification breaks reloading
> -
>
> Key: TS-4458
> URL: https://issues.apache.org/jira/browse/TS-4458
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Configuration
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 7.0.0
>
>
> If you set {{proxy.config.disable_configuration_modification}} to 1, records 
> configuration callbacks are never registered, so if you update 
> {{records.config}} and then reload with {{traffic_ctl config reload}}, the 
> new configuration is not actually applied.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4450) Syntax error in CI test script test_https.py.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291937#comment-15291937
 ] 

ASF subversion and git services commented on TS-4450:
-

Commit c3c9616f64f1ad549c0d951629a39d59c390c522 in trafficserver's branch 
refs/heads/master from [~jpe...@apache.org]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=c3c9616 ]

Merge pull request #650 from dragon512/patch-1

TS-4450: Syntax error in CI test

> Syntax error in CI test script test_https.py.
> -
>
> Key: TS-4450
> URL: https://issues.apache.org/jira/browse/TS-4450
> Project: Traffic Server
>  Issue Type: Bug
>  Components: CI
>Reporter: Peter Chou
>Assignee: Jason Kenny
> Fix For: 7.0.0
>
>
> I don't know Python, but the parenthesis seems to be un-needed or at least 
> un-balanced here. Sorry about the formatting, the caret is pointing to the 
> parenthesis.
>   File "/usr/src/git/trafficserver/ci/tsqa/tests/test_https.py", line 318
> signal_cmd = [traffic_ctl, 'config', 'reload')]
>  ^
> SyntaxError: invalid syntax



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4450) Syntax error in CI test script test_https.py.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291936#comment-15291936
 ] 

ASF subversion and git services commented on TS-4450:
-

Commit 724aa920b873192e149f298a1122ffe9a7a74e89 in trafficserver's branch 
refs/heads/master from dragon512
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=724aa92 ]

TS-4450: Syntax error in CI test

Fix extra ) that was in the list

> Syntax error in CI test script test_https.py.
> -
>
> Key: TS-4450
> URL: https://issues.apache.org/jira/browse/TS-4450
> Project: Traffic Server
>  Issue Type: Bug
>  Components: CI
>Reporter: Peter Chou
>Assignee: Jason Kenny
> Fix For: 7.0.0
>
>
> I don't know Python, but the parenthesis seems to be un-needed or at least 
> un-balanced here. Sorry about the formatting, the caret is pointing to the 
> parenthesis.
>   File "/usr/src/git/trafficserver/ci/tsqa/tests/test_https.py", line 318
> signal_cmd = [traffic_ctl, 'config', 'reload')]
>  ^
> SyntaxError: invalid syntax



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4450) Syntax error in CI test script test_https.py.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291935#comment-15291935
 ] 

ASF GitHub Bot commented on TS-4450:


Github user jpeach closed the pull request at:

https://github.com/apache/trafficserver/pull/650


> Syntax error in CI test script test_https.py.
> -
>
> Key: TS-4450
> URL: https://issues.apache.org/jira/browse/TS-4450
> Project: Traffic Server
>  Issue Type: Bug
>  Components: CI
>Reporter: Peter Chou
>Assignee: Jason Kenny
> Fix For: 7.0.0
>
>
> I don't know Python, but the parenthesis seems to be un-needed or at least 
> un-balanced here. Sorry about the formatting, the caret is pointing to the 
> parenthesis.
>   File "/usr/src/git/trafficserver/ci/tsqa/tests/test_https.py", line 318
> signal_cmd = [traffic_ctl, 'config', 'reload')]
>  ^
> SyntaxError: invalid syntax



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Jenkins build is back to normal : centos_7-master » gcc,centos_7,release #1704

[jenkins]

See 

[jira] [Commented] (TS-4450) Syntax error in CI test script test_https.py.

[Jason Kenny (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291934#comment-15291934
 ] 

Jason Kenny commented on TS-4450:
-

Ya looks like a bad ) is here.

looks like jpeach had a bad check in on this test 25 days ago. Do these tests 
get run to verify they work?

https://github.com/apache/trafficserver/pull/650 

> Syntax error in CI test script test_https.py.
> -
>
> Key: TS-4450
> URL: https://issues.apache.org/jira/browse/TS-4450
> Project: Traffic Server
>  Issue Type: Bug
>  Components: CI
>Reporter: Peter Chou
>Assignee: Jason Kenny
> Fix For: 7.0.0
>
>
> I don't know Python, but the parenthesis seems to be un-needed or at least 
> un-balanced here. Sorry about the formatting, the caret is pointing to the 
> parenthesis.
>   File "/usr/src/git/trafficserver/ci/tsqa/tests/test_https.py", line 318
> signal_cmd = [traffic_ctl, 'config', 'reload')]
>  ^
> SyntaxError: invalid syntax



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4450) Syntax error in CI test script test_https.py.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291932#comment-15291932
 ] 

ASF GitHub Bot commented on TS-4450:


GitHub user dragon512 opened a pull request:

https://github.com/apache/trafficserver/pull/650

TS-4450: Syntax error in CI test

Fix extra ) that was in the list

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dragon512/trafficserver patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/650.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #650


commit 724aa920b873192e149f298a1122ffe9a7a74e89
Author: dragon512 
Date:   2016-05-19T18:55:32Z

TS-4450: Syntax error in CI test

Fix extra ) that was in the list




> Syntax error in CI test script test_https.py.
> -
>
> Key: TS-4450
> URL: https://issues.apache.org/jira/browse/TS-4450
> Project: Traffic Server
>  Issue Type: Bug
>  Components: CI
>Reporter: Peter Chou
>Assignee: Jason Kenny
> Fix For: 7.0.0
>
>
> I don't know Python, but the parenthesis seems to be un-needed or at least 
> un-balanced here. Sorry about the formatting, the caret is pointing to the 
> parenthesis.
>   File "/usr/src/git/trafficserver/ci/tsqa/tests/test_https.py", line 318
> signal_cmd = [traffic_ctl, 'config', 'reload')]
>  ^
> SyntaxError: invalid syntax



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4462) TSHttpSchedule can cause use after free crash.

[Leif Hedstrom (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291922#comment-15291922
 ] 

Leif Hedstrom commented on TS-4462:
---

[~amc] Any details on when this was introduced? Is this a 6.2.0 candidate?

> TSHttpSchedule can cause use after free crash.
> --
>
> Key: TS-4462
> URL: https://issues.apache.org/jira/browse/TS-4462
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, TS API
>Reporter: Alan M. Carroll
> Fix For: 7.0.0
>
>
> Yahoo! is seeing production crashes which have been tracked down to calling 
> {{cancel}} on the {{pending_action}} of an {{HttpSM}}. This action comes from 
> use of {{TSHttpSchedule}} which can leave a dangling object in 
> {{pending_action}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4462) TSHttpSchedule can cause use after free crash.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291928#comment-15291928
 ] 

ASF GitHub Bot commented on TS-4462:


GitHub user SolidWallOfCode opened a pull request:

https://github.com/apache/trafficserver/pull/649

TS-4462: Clean up pending_action for TSHttpSchedule.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SolidWallOfCode/trafficserver ts-4462

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/649.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #649


commit 7a4fcf8e61ee26f90e2e77dd7dcf8aa5a9881137
Author: Alan M. Carroll 
Date:   2016-05-19T18:03:15Z

TS-4462: Clean up pending_action for TSHttpSchedule.




> TSHttpSchedule can cause use after free crash.
> --
>
> Key: TS-4462
> URL: https://issues.apache.org/jira/browse/TS-4462
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, TS API
>Reporter: Alan M. Carroll
> Fix For: 7.0.0
>
>
> Yahoo! is seeing production crashes which have been tracked down to calling 
> {{cancel}} on the {{pending_action}} of an {{HttpSM}}. This action comes from 
> use of {{TSHttpSchedule}} which can leave a dangling object in 
> {{pending_action}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4462) TSHttpSchedule can cause use after free crash.

[Alan M. Carroll (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291926#comment-15291926
 ] 

Alan M. Carroll commented on TS-4462:
-

Looks like it was introduced in commit 56341bf9, for TS-187 around Feb 2010.

> TSHttpSchedule can cause use after free crash.
> --
>
> Key: TS-4462
> URL: https://issues.apache.org/jira/browse/TS-4462
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, TS API
>Reporter: Alan M. Carroll
> Fix For: 7.0.0
>
>
> Yahoo! is seeing production crashes which have been tracked down to calling 
> {{cancel}} on the {{pending_action}} of an {{HttpSM}}. This action comes from 
> use of {{TSHttpSchedule}} which can leave a dangling object in 
> {{pending_action}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4463) explicit reconfiguration should not check for file changes

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4463:
--
Fix Version/s: 7.0.0

> explicit reconfiguration should not check for file changes
> --
>
> Key: TS-4463
> URL: https://issues.apache.org/jira/browse/TS-4463
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: James Peach
>  Labels: incompatible
> Fix For: 7.0.0
>
>
> When an operator runs {{traffic_ctl config reload}} that is an explicit 
> signal that they want the configuration reloaded. We should not second guess 
> that by checking whether files are updated like we do today.
> One use case for this is when 
> {{proxy.config.disable_configuration_modification}} is enabled and you change 
> configuration in memory with the API. It is surprising and confusing to have 
> to touch {{records.config}} to restore the old values.
> Consider whether we should add a {{\-\-changed-only}} flag to only reload 
> changed configuration. I'm leaning against that but could be persuaded.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4450) Syntax error in CI test script test_https.py.

[Leif Hedstrom (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291920#comment-15291920
 ] 

Leif Hedstrom commented on TS-4450:
---

[~jkenny] Can you take a look please?

Also, [~pbchou] Mind making a PR for this?

> Syntax error in CI test script test_https.py.
> -
>
> Key: TS-4450
> URL: https://issues.apache.org/jira/browse/TS-4450
> Project: Traffic Server
>  Issue Type: Bug
>  Components: CI
>Reporter: Peter Chou
>Assignee: Jason Kenny
> Fix For: 7.0.0
>
>
> I don't know Python, but the parenthesis seems to be un-needed or at least 
> un-balanced here. Sorry about the formatting, the caret is pointing to the 
> parenthesis.
>   File "/usr/src/git/trafficserver/ci/tsqa/tests/test_https.py", line 318
> signal_cmd = [traffic_ctl, 'config', 'reload')]
>  ^
> SyntaxError: invalid syntax



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4463) explicit reconfiguration should not check for file changes

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4463:
--
Assignee: James Peach

> explicit reconfiguration should not check for file changes
> --
>
> Key: TS-4463
> URL: https://issues.apache.org/jira/browse/TS-4463
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: James Peach
>Assignee: James Peach
>  Labels: incompatible
> Fix For: 7.0.0
>
>
> When an operator runs {{traffic_ctl config reload}} that is an explicit 
> signal that they want the configuration reloaded. We should not second guess 
> that by checking whether files are updated like we do today.
> One use case for this is when 
> {{proxy.config.disable_configuration_modification}} is enabled and you change 
> configuration in memory with the API. It is surprising and confusing to have 
> to touch {{records.config}} to restore the old values.
> Consider whether we should add a {{\-\-changed-only}} flag to only reload 
> changed configuration. I'm leaning against that but could be persuaded.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4458) disabling configuration modification breaks reloading

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4458:
--
Fix Version/s: 7.0.0

> disabling configuration modification breaks reloading
> -
>
> Key: TS-4458
> URL: https://issues.apache.org/jira/browse/TS-4458
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Configuration
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 7.0.0
>
>
> If you set {{proxy.config.disable_configuration_modification}} to 1, records 
> configuration callbacks are never registered, so if you update 
> {{records.config}} and then reload with {{traffic_ctl config reload}}, the 
> new configuration is not actually applied.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4462) TSHttpSchedule can cause use after free crash.

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4462:
--
Fix Version/s: 7.0.0

> TSHttpSchedule can cause use after free crash.
> --
>
> Key: TS-4462
> URL: https://issues.apache.org/jira/browse/TS-4462
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, TS API
>Reporter: Alan M. Carroll
> Fix For: 7.0.0
>
>
> Yahoo! is seeing production crashes which have been tracked down to calling 
> {{cancel}} on the {{pending_action}} of an {{HttpSM}}. This action comes from 
> use of {{TSHttpSchedule}} which can leave a dangling object in 
> {{pending_action}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4455) remove isEosRcvd() and eosRcvd

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4455:
--
Fix Version/s: 7.0.0

> remove isEosRcvd() and eosRcvd
> --
>
> Key: TS-4455
> URL: https://issues.apache.org/jira/browse/TS-4455
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL
>Reporter: Oknet Xu
> Fix For: 7.0.0
>
>
> the isEosRcvd() is used by HttpSM.
> It is check SSLNetVConnection->eosRcvd while received VC_EVENT_READ_READY or 
> VC_EVENT_READ_COMPLETE event, and rewrite the event to VC_EVENT_EOS.
> {code}
> int
> HttpSM::state_read_client_request_header(int event, void *data)
> {
> .
> .
> .
>   // check to see if there was an EOS received on the SSL connection
>   SSLNetVConnection *ssl_vc = dynamic_cast *>(ua_session->get_netvc());
>   if (ssl_vc && ssl_vc->isEosRcvd()) {
> DebugSM("http", "EOS for ssl vc %p at read_first_btye state", 
> ua_session->get_netvc());
> event = VC_EVENT_EOS;
>   }
>   switch (event) {
>   case VC_EVENT_READ_READY:
>   case VC_EVENT_READ_COMPLETE:
> // More data to parse
> break;
>   case VC_EVENT_EOS:
> ua_entry->eos = true;
> if ((client_request_hdr_bytes > 0) && 
> is_transparent_passthrough_allowed() && (ua_raw_buffer_reader != NULL)) {
>   break;
> }
> .
> .
> .
> {code}
> the eosRcvd is set to true only in SSLNetVConnection::net_read_io()
> {code}
> // changed by YTS Team, yamsat
> void
> SSLNetVConnection::net_read_io(NetHandler *nh, EThread *lthread)
> {
> .
> .
> .
>   case SSL_READ_EOS:
> // close the connection if we have SSL_READ_EOS, this is the return value 
> from ssl_read_from_net() if we get an
> // SSL_ERROR_ZERO_RETURN from SSL_get_error()
> // SSL_ERROR_ZERO_RETURN means that the origin server closed the SSL 
> connection
> eosRcvd = true;
> read.triggered = 0;
> readSignalDone(VC_EVENT_EOS, nh);
> if (bytes > 0) {
>   Debug("ssl", "read_from_net, read finished - EOS");
> } else {
>   Debug("ssl", "read_from_net, read finished - 0 useful bytes read, bytes 
> used by SSL layer");
> }
> break;
> .
> .
> .
> {code}
> It is also signal VC_EVENT_EOS to SM after set eosRcvd to true.
> thus, the eosRcvd and isEosRcvd() is no longer necessary.
> suggest remove them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4450) Syntax error in CI test script test_https.py.

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4450:
--
Fix Version/s: 7.0.0

> Syntax error in CI test script test_https.py.
> -
>
> Key: TS-4450
> URL: https://issues.apache.org/jira/browse/TS-4450
> Project: Traffic Server
>  Issue Type: Bug
>  Components: CI
>Reporter: Peter Chou
> Fix For: 7.0.0
>
>
> I don't know Python, but the parenthesis seems to be un-needed or at least 
> un-balanced here. Sorry about the formatting, the caret is pointing to the 
> parenthesis.
>   File "/usr/src/git/trafficserver/ci/tsqa/tests/test_https.py", line 318
> signal_cmd = [traffic_ctl, 'config', 'reload')]
>  ^
> SyntaxError: invalid syntax



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4450) Syntax error in CI test script test_https.py.

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4450:
--
Assignee: Jason Kenny

> Syntax error in CI test script test_https.py.
> -
>
> Key: TS-4450
> URL: https://issues.apache.org/jira/browse/TS-4450
> Project: Traffic Server
>  Issue Type: Bug
>  Components: CI
>Reporter: Peter Chou
>Assignee: Jason Kenny
> Fix For: 7.0.0
>
>
> I don't know Python, but the parenthesis seems to be un-needed or at least 
> un-balanced here. Sorry about the formatting, the caret is pointing to the 
> parenthesis.
>   File "/usr/src/git/trafficserver/ci/tsqa/tests/test_https.py", line 318
> signal_cmd = [traffic_ctl, 'config', 'reload')]
>  ^
> SyntaxError: invalid syntax



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4447) Error running make test

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4447:
--
Fix Version/s: sometime

> Error running make test
> ---
>
> Key: TS-4447
> URL: https://issues.apache.org/jira/browse/TS-4447
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Tests
>Affects Versions: 6.2.0
>Reporter: Bryan Call
> Fix For: sometime
>
>
>  +++ /home/bcall/trafficserver/cmd/traffic_via/tests/[u c s f p eS;tNc  i p s 
> ]   2016-05-16 21:37:26.447657936 +
>  @@ -1,4 +1,3 @@
>  -/home/bcall/trafficserver/cmd/traffic_via/.libs/lt-traffic_via: 
> /usr/local/lib/libcrypto.so.10: no version information available (required by 
> /home/bcall/trafficserver/lib/ts/.libs/libtsutil.so.6)
>   Via header is [u c s f p eS;tNc  i p s ], Length is 26
>   Via Header Details:
>   Request headers received from client   :unknown
>  FAIL: test_traffic_via
>  =
>  1 of 1 test failed
>  Please report to d...@trafficserver.apache.org
>  =



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4451) Remove magic numbers from codebase where possible

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4451:
--
Fix Version/s: sometime

> Remove magic numbers from codebase where possible
> -
>
> Key: TS-4451
> URL: https://issues.apache.org/jira/browse/TS-4451
> Project: Traffic Server
>  Issue Type: Improvement
>Reporter: Thomas Jackson
> Fix For: sometime
>
>
> There are quite a few places in the code that have magic numbers. A common 
> pattern is the string len for a string passed in (TS-4440 for example).
> The goal of this ticket is to:
> - Find an automated mechanism to check for magic numbers
> - Bring the codebase into alignment with automated check
> -- Create some MACROS for the common cases



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4453) READ_COMPLETE signal is not being sent for short POST's

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4453:
--
Fix Version/s: 7.0.0

> READ_COMPLETE signal is not being sent for short POST's
> ---
>
> Key: TS-4453
> URL: https://issues.apache.org/jira/browse/TS-4453
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Susan Hinrichs
>Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
>
> Reported by [~briang].  Since TS-3612 commit, he has noticed that the 
> READ_COMPLETE event is not being delivered to the VIO in the case of short 
> POSTs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4452) Change open_write_fail_action to MgmtByte

[Leif Hedstrom (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291918#comment-15291918
 ] 

Leif Hedstrom commented on TS-4452:
---

[~sudheerv] This can be closed, right ?

> Change open_write_fail_action to MgmtByte
> -
>
> Key: TS-4452
> URL: https://issues.apache.org/jira/browse/TS-4452
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Configuration
>Reporter: Sudheer Vinukonda
> Fix For: 7.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4454) iobuffer readers are being cleared

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4454:
--
Fix Version/s: 7.0.0

> iobuffer readers are being cleared
> --
>
> Key: TS-4454
> URL: https://issues.apache.org/jira/browse/TS-4454
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Susan Hinrichs
>Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
>
> A generalization of TS-.  [~calavera] and [~oknet] both reported crashes 
> from trying to deallocate iobuffer readers that had already been cleared.  
> These crashes were in 6.2.0 and 6.0.x.  [~calavera] provided a fix to null 
> check the immediate problem reported in TS-.  But it was generally agreed 
> that this is probably a symptom of an iobuffer that had been freed and 
> reallocated during the lifetime of the transaction.  Filing this bug to track 
> the broader issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4454) iobuffer readers are being cleared

[Leif Hedstrom (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291913#comment-15291913
 ] 

Leif Hedstrom commented on TS-4454:
---

[~shinrich] Is this a 6.2.0 candidate?

> iobuffer readers are being cleared
> --
>
> Key: TS-4454
> URL: https://issues.apache.org/jira/browse/TS-4454
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Susan Hinrichs
>Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
>
> A generalization of TS-.  [~calavera] and [~oknet] both reported crashes 
> from trying to deallocate iobuffer readers that had already been cleared.  
> These crashes were in 6.2.0 and 6.0.x.  [~calavera] provided a fix to null 
> check the immediate problem reported in TS-.  But it was generally agreed 
> that this is probably a symptom of an iobuffer that had been freed and 
> reallocated during the lifetime of the transaction.  Filing this bug to track 
> the broader issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4452) Change open_write_fail_action to MgmtByte

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4452:
--
Fix Version/s: 7.0.0

> Change open_write_fail_action to MgmtByte
> -
>
> Key: TS-4452
> URL: https://issues.apache.org/jira/browse/TS-4452
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Configuration
>Reporter: Sudheer Vinukonda
> Fix For: 7.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4453) READ_COMPLETE signal is not being sent for short POST's

[Leif Hedstrom (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291916#comment-15291916
 ] 

Leif Hedstrom commented on TS-4453:
---

[~shinrich] Is this a 6.2.0 candidate?

> READ_COMPLETE signal is not being sent for short POST's
> ---
>
> Key: TS-4453
> URL: https://issues.apache.org/jira/browse/TS-4453
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Susan Hinrichs
>Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
>
> Reported by [~briang].  Since TS-3612 commit, he has noticed that the 
> READ_COMPLETE event is not being delivered to the VIO in the case of short 
> POSTs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4463) explicit reconfiguration should not check for file changes

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4463:
--
Issue Type: Improvement  (was: Bug)

> explicit reconfiguration should not check for file changes
> --
>
> Key: TS-4463
> URL: https://issues.apache.org/jira/browse/TS-4463
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Management API
>Reporter: James Peach
>Assignee: James Peach
>  Labels: incompatible
> Fix For: 7.0.0
>
>
> When an operator runs {{traffic_ctl config reload}} that is an explicit 
> signal that they want the configuration reloaded. We should not second guess 
> that by checking whether files are updated like we do today.
> One use case for this is when 
> {{proxy.config.disable_configuration_modification}} is enabled and you change 
> configuration in memory with the API. It is surprising and confusing to have 
> to touch {{records.config}} to restore the old values.
> Consider whether we should add a {{\-\-changed-only}} flag to only reload 
> changed configuration. I'm leaning against that but could be persuaded.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4463) explicit reconfiguration should not check for file changes

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4463:
--
Labels: incompatible  (was: )

> explicit reconfiguration should not check for file changes
> --
>
> Key: TS-4463
> URL: https://issues.apache.org/jira/browse/TS-4463
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Management API
>Reporter: James Peach
>  Labels: incompatible
> Fix For: 7.0.0
>
>
> When an operator runs {{traffic_ctl config reload}} that is an explicit 
> signal that they want the configuration reloaded. We should not second guess 
> that by checking whether files are updated like we do today.
> One use case for this is when 
> {{proxy.config.disable_configuration_modification}} is enabled and you change 
> configuration in memory with the API. It is surprising and confusing to have 
> to touch {{records.config}} to restore the old values.
> Consider whether we should add a {{\-\-changed-only}} flag to only reload 
> changed configuration. I'm leaning against that but could be persuaded.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Build failed in Jenkins: clang-analyzer #2301

[jenkins]

See 

Changes:

[James Peach] TS-4460: Remove record conversion from RecSetRecord.

--
[...truncated 2857 lines...]
reading sources... [ 53%] developer-guide/api/functions/TSMimeHdrFieldGet.en
reading sources... [ 53%] 
developer-guide/api/functions/TSMimeHdrFieldLengthGet.en
reading sources... [ 53%] developer-guide/api/functions/TSMimeHdrFieldNameGet.en
reading sources... [ 53%] developer-guide/api/functions/TSMimeHdrFieldNameSet.en
reading sources... [ 54%] developer-guide/api/functions/TSMimeHdrFieldNext.en
reading sources... [ 54%] developer-guide/api/functions/TSMimeHdrFieldNextDup.en
reading sources... [ 54%] developer-guide/api/functions/TSMimeHdrFieldRemove.en
reading sources... [ 54%] 
developer-guide/api/functions/TSMimeHdrFieldValueAppend.en
reading sources... [ 54%] 
developer-guide/api/functions/TSMimeHdrFieldValueDateInsert.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueDateSet.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueIntSet.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueStringGet.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueStringInsert.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValueStringSet.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValueUintInsert.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValueUintSet.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValuesClear.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValuesCount.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrFieldsClear.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrFieldsCount.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrLengthGet.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrParse.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeHdrPrint.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeParserClear.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeParserCreate.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeParserDestroy.en
reading sources... [ 58%] developer-guide/api/functions/TSMutexCreate.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexDestroy.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexLock.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexLockTry.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexUnlock.en
reading sources... [ 60%] developer-guide/api/functions/TSNetAccept.en
reading sources... [ 60%] 
developer-guide/api/functions/TSNetAcceptNamedProtocol.en
reading sources... [ 60%] developer-guide/api/functions/TSNetConnect.en
reading sources... [ 60%] developer-guide/api/functions/TSPluginInit.en
reading sources... [ 60%] developer-guide/api/functions/TSRemap.en
reading sources... [ 61%] developer-guide/api/functions/TSSslContextFindBy.en
reading sources... [ 61%] 
developer-guide/api/functions/TSSslServerContextCreate.en
reading sources... [ 61%] developer-guide/api/functions/TSTextLogObjectCreate.en
reading sources... [ 61%] developer-guide/api/functions/TSThreadCreate.en
reading sources... [ 62%] developer-guide/api/functions/TSThreadDestroy.en
reading sources... [ 62%] developer-guide/api/functions/TSThreadInit.en
reading sources... [ 62%] developer-guide/api/functions/TSThreadSelf.en
reading sources... [ 62%] 
developer-guide/api/functions/TSTrafficServerVersionGet.en
reading sources... [ 63%] developer-guide/api/functions/TSTransformCreate.en
reading sources... [ 63%] 
developer-guide/api/functions/TSTransformOutputVConnGet.en
reading sources... [ 63%] developer-guide/api/functions/TSTypes.en
reading sources... [ 63%] developer-guide/api/functions/TSUrlCreate.en
reading sources... [ 63%] developer-guide/api/functions/TSUrlDestroy.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlFtpTypeGet.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlFtpTypeSet.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlHostGet.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlHostSet.en
reading sources... [ 65%] developer-guide/api/functions/TSUrlPercentEncode.en
reading sources... [ 65%] developer-guide/api/functions/TSUrlStringGet.en
reading sources... [ 65%] developer-guide/api/functions/TSVConnAbort.en
reading sources... [ 65%] 
developer-guide/api/functions/TSVConnCacheObjectSizeGet.en
reading sources... [ 65%] developer-guide/api/functions/TSVConnClose.en
reading sources... [ 66%] developer-guide/api/functions/TSVConnClosedGet.en
reading sources... [ 66%] developer-guide/api/functions/TSVConnFdCreate.en
reading sources... [ 66%] 

[jira] [Commented] (TS-4460) Remove record conversion from RecSetRecord

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291675#comment-15291675
 ] 

ASF subversion and git services commented on TS-4460:
-

Commit 3e88f1306e030c710470b9538027daa40ee8cfde in trafficserver's branch 
refs/heads/master from [~jpe...@apache.org]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=3e88f13 ]

TS-4460: Remove record conversion from RecSetRecord.

RecSetRecord manually converts a record value from a string. It
could just use RecDataSetFromString. The only place this semantic
is called from is clustering, so it could probably be removed
altogether.


> Remove record conversion from RecSetRecord
> --
>
> Key: TS-4460
> URL: https://issues.apache.org/jira/browse/TS-4460
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 7.0.0
>
>
> {{RecSetRecord}} manually converts a record value from a string. It could 
> just use {{RecDataSetFromString}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (TS-4460) Remove record conversion from RecSetRecord

[James Peach (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Peach resolved TS-4460.
-
   Resolution: Fixed
Fix Version/s: 7.0.0

> Remove record conversion from RecSetRecord
> --
>
> Key: TS-4460
> URL: https://issues.apache.org/jira/browse/TS-4460
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 7.0.0
>
>
> {{RecSetRecord}} manually converts a record value from a string. It could 
> just use {{RecDataSetFromString}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4460) Remove record conversion from RecSetRecord

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291674#comment-15291674
 ] 

ASF GitHub Bot commented on TS-4460:


Github user jpeach closed the pull request at:

https://github.com/apache/trafficserver/pull/648


> Remove record conversion from RecSetRecord
> --
>
> Key: TS-4460
> URL: https://issues.apache.org/jira/browse/TS-4460
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 7.0.0
>
>
> {{RecSetRecord}} manually converts a record value from a string. It could 
> just use {{RecDataSetFromString}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4460) Remove record conversion from RecSetRecord

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291676#comment-15291676
 ] 

ASF subversion and git services commented on TS-4460:
-

Commit 294a932b30e59fc4432067929764c58ad24ce0a0 in trafficserver's branch 
refs/heads/master from [~jpe...@apache.org]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=294a932 ]

Merge pull request #648 from jpeach/fix/4460

TS-4460: Remove record conversion from RecSetRecord.

> Remove record conversion from RecSetRecord
> --
>
> Key: TS-4460
> URL: https://issues.apache.org/jira/browse/TS-4460
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 7.0.0
>
>
> {{RecSetRecord}} manually converts a record value from a string. It could 
> just use {{RecDataSetFromString}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (TS-4462) TSHttpSchedule can cause use after free crash.

[Alan M. Carroll (JIRA)]

Alan M. Carroll created TS-4462:
---

 Summary: TSHttpSchedule can cause use after free crash.
 Key: TS-4462
 URL: https://issues.apache.org/jira/browse/TS-4462
 Project: Traffic Server
  Issue Type: Bug
  Components: Core, TS API
Reporter: Alan M. Carroll


Yahoo! is seeing production crashes which have been tracked down to calling 
{{cancel}} on the {{pending_action}} of an {{HttpSM}}. This action comes from 
use of {{TSHttpSchedule}} which can leave a dangling object in 
{{pending_action}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4461) Not closing client connections

[Bryan Call (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Call updated TS-4461:
---
Priority: Blocker  (was: Critical)

> Not closing client connections
> --
>
> Key: TS-4461
> URL: https://issues.apache.org/jira/browse/TS-4461
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 6.2.0
>Reporter: Bryan Call
>Priority: Blocker
> Fix For: 7.0.0
>
>
> Looks like we are not closing client connections correctly on the 6.2.x 
> branch.  After taking a server our of rotation for awhile.
> {code}
> [bcall@l28 ~]$ ss -s
> Total: 18212 (kernel 18329)
> TCP:   18122 (estab 17141, closed 123, orphaned 4, synrecv 0, timewait 
> 123/0), ports 152
> {code}
> in traffic top:
> {code}
>  CLIENTORIGIN SERVER
> Requests 1.8 Head Bytes 492.0Requests 1.8 Head Bytes 345.7
> Req/Conn 1.0 Body Bytes   0.0Req/Conn 1.0 Body Bytes   0.0
> New Conn 1.8 Avg Size   269.0New Conn 1.8 Avg Size   189.0
> Curr Conn0.0 Net (bits)   3.9K   Curr Conn0.0 Net (bits)   
> 2.8K
> Active Con   6.6MResp (ms)0.8
> Dynamic KA   0.0
> {code}
> Looks like it is happening on the client connections to TLS ports (ip of the 
> server removed):
> {code}
> [bcall@l28 ~]$ ss -tn | grep 'XXX:44[3-4]' | wc -l
> 12434
> {code}
> And not on the non-TLS ports
> {code}
> [bcall@l28 ~]$ ss -tn | grep 'XXX:8' | wc -l
> 0
> {code}
> Count of the fd for the traffic_server process:
> {code}
> [bcall@l28 ~]$ sudo ls -l /proc/$(pidof traffic_server)/fd | wc -l
> 18127
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4461) Not closing client connections

[Leif Hedstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-4461:
--
Fix Version/s: 7.0.0

> Not closing client connections
> --
>
> Key: TS-4461
> URL: https://issues.apache.org/jira/browse/TS-4461
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 6.2.0
>Reporter: Bryan Call
> Fix For: 7.0.0
>
>
> Looks like we are not closing client connections correctly on the 6.2.x 
> branch.  After taking a server our of rotation for awhile.
> {code}
> [bcall@l28 ~]$ ss -s
> Total: 18212 (kernel 18329)
> TCP:   18122 (estab 17141, closed 123, orphaned 4, synrecv 0, timewait 
> 123/0), ports 152
> {code}
> in traffic top:
> {code}
>  CLIENTORIGIN SERVER
> Requests 1.8 Head Bytes 492.0Requests 1.8 Head Bytes 345.7
> Req/Conn 1.0 Body Bytes   0.0Req/Conn 1.0 Body Bytes   0.0
> New Conn 1.8 Avg Size   269.0New Conn 1.8 Avg Size   189.0
> Curr Conn0.0 Net (bits)   3.9K   Curr Conn0.0 Net (bits)   
> 2.8K
> Active Con   6.6MResp (ms)0.8
> Dynamic KA   0.0
> {code}
> Looks like it is happening on the client connections to TLS ports (ip of the 
> server removed):
> {code}
> [bcall@l28 ~]$ ss -tn | grep 'XXX:44[3-4]' | wc -l
> 12434
> {code}
> And not on the non-TLS ports
> {code}
> [bcall@l28 ~]$ ss -tn | grep 'XXX:8' | wc -l
> 0
> {code}
> Count of the fd for the traffic_server process:
> {code}
> [bcall@l28 ~]$ sudo ls -l /proc/$(pidof traffic_server)/fd | wc -l
> 18127
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4459) Force domain names in cert to lower on insert into lookup tree

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291541#comment-15291541
 ] 

ASF GitHub Bot commented on TS-4459:


Github user zwoop commented on the pull request:

https://github.com/apache/trafficserver/pull/647#issuecomment-220391391
  
[approve ci]


> Force domain names in cert to lower on insert into lookup tree
> --
>
> Key: TS-4459
> URL: https://issues.apache.org/jira/browse/TS-4459
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL
>Reporter: Steven Feltner
> Fix For: 7.0.0
>
>
> We have certs from a legacy system that were issued with mixed case domain 
> names.  We are migrating this older product over to ATS and found that domain 
> names need to be lower cased before being inserted in the lookup table.
> I will be submitting  a pull request to resolve this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4461) Not closing client connections

[Bryan Call (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Call updated TS-4461:
---
Description: 
Looks like we are not closing client connections correctly on the 6.2.x branch. 
 After taking a server our of rotation for awhile.

{code}
[bcall@l28 ~]$ ss -s
Total: 18212 (kernel 18329)
TCP:   18122 (estab 17141, closed 123, orphaned 4, synrecv 0, timewait 123/0), 
ports 152
{code}

in traffic top:
{code}
 CLIENTORIGIN SERVER
Requests 1.8 Head Bytes 492.0Requests 1.8 Head Bytes 345.7
Req/Conn 1.0 Body Bytes   0.0Req/Conn 1.0 Body Bytes   0.0
New Conn 1.8 Avg Size   269.0New Conn 1.8 Avg Size   189.0
Curr Conn0.0 Net (bits)   3.9K   Curr Conn0.0 Net (bits)   2.8K
Active Con   6.6MResp (ms)0.8
Dynamic KA   0.0
{code}

Looks like it is happening on the client connections to TLS ports (ip of the 
server removed):
{code}
[bcall@l28 ~]$ ss -tn | grep 'XXX:44[3-4]' | wc -l
12434
{code}

And not on the non-TLS ports
{code}
[bcall@l28 ~]$ ss -tn | grep 'XXX:8' | wc -l
0
{code}

Count of the fd for the traffic_server process:
{code}
[bcall@l28 ~]$ sudo ls -l /proc/$(pidof traffic_server)/fd | wc -l
18127
{code}


  was:
Looks like we are not closing client connections correctly on the 6.2.x branch. 
 After taking a server our of rotation for awhile.

{code}
[bcall@l28 ~]$ ss -s
Total: 18212 (kernel 18329)
TCP:   18122 (estab 17141, closed 123, orphaned 4, synrecv 0, timewait 123/0), 
ports 152
{code}

in traffic top:
{code}
 CLIENTORIGIN SERVER
Requests 1.8 Head Bytes 492.0Requests 1.8 Head Bytes 345.7
Req/Conn 1.0 Body Bytes   0.0Req/Conn 1.0 Body Bytes   0.0
New Conn 1.8 Avg Size   269.0New Conn 1.8 Avg Size   189.0
Curr Conn0.0 Net (bits)   3.9K   Curr Conn0.0 Net (bits)   2.8K
Active Con   6.6MResp (ms)0.8
Dynamic KA   0.0
{code}

Looks like it is happening on the client connections to TLS ports (ip of the 
server removed):
{code}
[bcall@l28 ~]$ ss -tn | grep 'XXX:44[3-4]' | wc -l
12434
{code}

And not on the non-TLS ports
{code}
[bcall@l28 ~]$ ss -tn | grep 'XXX:8' | wc -l
0
{code}


> Not closing client connections
> --
>
> Key: TS-4461
> URL: https://issues.apache.org/jira/browse/TS-4461
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Bryan Call
>
> Looks like we are not closing client connections correctly on the 6.2.x 
> branch.  After taking a server our of rotation for awhile.
> {code}
> [bcall@l28 ~]$ ss -s
> Total: 18212 (kernel 18329)
> TCP:   18122 (estab 17141, closed 123, orphaned 4, synrecv 0, timewait 
> 123/0), ports 152
> {code}
> in traffic top:
> {code}
>  CLIENTORIGIN SERVER
> Requests 1.8 Head Bytes 492.0Requests 1.8 Head Bytes 345.7
> Req/Conn 1.0 Body Bytes   0.0Req/Conn 1.0 Body Bytes   0.0
> New Conn 1.8 Avg Size   269.0New Conn 1.8 Avg Size   189.0
> Curr Conn0.0 Net (bits)   3.9K   Curr Conn0.0 Net (bits)   
> 2.8K
> Active Con   6.6MResp (ms)0.8
> Dynamic KA   0.0
> {code}
> Looks like it is happening on the client connections to TLS ports (ip of the 
> server removed):
> {code}
> [bcall@l28 ~]$ ss -tn | grep 'XXX:44[3-4]' | wc -l
> 12434
> {code}
> And not on the non-TLS ports
> {code}
> [bcall@l28 ~]$ ss -tn | grep 'XXX:8' | wc -l
> 0
> {code}
> Count of the fd for the traffic_server process:
> {code}
> [bcall@l28 ~]$ sudo ls -l /proc/$(pidof traffic_server)/fd | wc -l
> 18127
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4461) Not closing client connections

[Bryan Call (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Call updated TS-4461:
---
Description: 
Looks like we are not closing client connections correctly on the 6.2.x branch. 
 After taking a server our of rotation for awhile.

{code}
[bcall@l28 ~]$ ss -s
Total: 18212 (kernel 18329)
TCP:   18122 (estab 17141, closed 123, orphaned 4, synrecv 0, timewait 123/0), 
ports 152
{code}

in traffic top:
{code}
 CLIENTORIGIN SERVER
Requests 1.8 Head Bytes 492.0Requests 1.8 Head Bytes 345.7
Req/Conn 1.0 Body Bytes   0.0Req/Conn 1.0 Body Bytes   0.0
New Conn 1.8 Avg Size   269.0New Conn 1.8 Avg Size   189.0
Curr Conn0.0 Net (bits)   3.9K   Curr Conn0.0 Net (bits)   2.8K
Active Con   6.6MResp (ms)0.8
Dynamic KA   0.0
{code}

Looks like it is happening on the client connections to TLS ports (ip of the 
server removed):
{code}
[bcall@l28 ~]$ ss -tn | grep 'XXX:44[3-4]' | wc -l
12434
{code}

  was:
Looks like we are not closing client connections correctly on the 6.2.x branch.

{code}
[bcall@l28 ~]$ ss -s
Total: 18212 (kernel 18329)
TCP:   18122 (estab 17141, closed 123, orphaned 4, synrecv 0, timewait 123/0), 
ports 152
{code}

in traffic top:
{code}
 CLIENTORIGIN SERVER
Requests 1.8 Head Bytes 492.0Requests 1.8 Head Bytes 345.7
Req/Conn 1.0 Body Bytes   0.0Req/Conn 1.0 Body Bytes   0.0
New Conn 1.8 Avg Size   269.0New Conn 1.8 Avg Size   189.0
Curr Conn0.0 Net (bits)   3.9K   Curr Conn0.0 Net (bits)   2.8K
Active Con   6.6MResp (ms)0.8
Dynamic KA   0.0
{code}



> Not closing client connections
> --
>
> Key: TS-4461
> URL: https://issues.apache.org/jira/browse/TS-4461
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Bryan Call
>
> Looks like we are not closing client connections correctly on the 6.2.x 
> branch.  After taking a server our of rotation for awhile.
> {code}
> [bcall@l28 ~]$ ss -s
> Total: 18212 (kernel 18329)
> TCP:   18122 (estab 17141, closed 123, orphaned 4, synrecv 0, timewait 
> 123/0), ports 152
> {code}
> in traffic top:
> {code}
>  CLIENTORIGIN SERVER
> Requests 1.8 Head Bytes 492.0Requests 1.8 Head Bytes 345.7
> Req/Conn 1.0 Body Bytes   0.0Req/Conn 1.0 Body Bytes   0.0
> New Conn 1.8 Avg Size   269.0New Conn 1.8 Avg Size   189.0
> Curr Conn0.0 Net (bits)   3.9K   Curr Conn0.0 Net (bits)   
> 2.8K
> Active Con   6.6MResp (ms)0.8
> Dynamic KA   0.0
> {code}
> Looks like it is happening on the client connections to TLS ports (ip of the 
> server removed):
> {code}
> [bcall@l28 ~]$ ss -tn | grep 'XXX:44[3-4]' | wc -l
> 12434
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Jenkins build is back to normal : centos_7-master » clang,centos_7,release #1703

[jenkins]

See 

Build failed in Jenkins: clang-analyzer #2300

[jenkins]

See 

Changes:

[Masaori Koshiba] TS-3535: Experimental Support of HTTP/2 Stream Priority 
feature

--
[...truncated 2853 lines...]
reading sources... [ 53%] developer-guide/api/functions/TSMimeHdrFieldGet.en
reading sources... [ 53%] 
developer-guide/api/functions/TSMimeHdrFieldLengthGet.en
reading sources... [ 53%] developer-guide/api/functions/TSMimeHdrFieldNameGet.en
reading sources... [ 53%] developer-guide/api/functions/TSMimeHdrFieldNameSet.en
reading sources... [ 54%] developer-guide/api/functions/TSMimeHdrFieldNext.en
reading sources... [ 54%] developer-guide/api/functions/TSMimeHdrFieldNextDup.en
reading sources... [ 54%] developer-guide/api/functions/TSMimeHdrFieldRemove.en
reading sources... [ 54%] 
developer-guide/api/functions/TSMimeHdrFieldValueAppend.en
reading sources... [ 54%] 
developer-guide/api/functions/TSMimeHdrFieldValueDateInsert.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueDateSet.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueIntSet.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueStringGet.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueStringInsert.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValueStringSet.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValueUintInsert.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValueUintSet.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValuesClear.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValuesCount.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrFieldsClear.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrFieldsCount.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrLengthGet.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrParse.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeHdrPrint.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeParserClear.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeParserCreate.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeParserDestroy.en
reading sources... [ 58%] developer-guide/api/functions/TSMutexCreate.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexDestroy.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexLock.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexLockTry.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexUnlock.en
reading sources... [ 60%] developer-guide/api/functions/TSNetAccept.en
reading sources... [ 60%] 
developer-guide/api/functions/TSNetAcceptNamedProtocol.en
reading sources... [ 60%] developer-guide/api/functions/TSNetConnect.en
reading sources... [ 60%] developer-guide/api/functions/TSPluginInit.en
reading sources... [ 60%] developer-guide/api/functions/TSRemap.en
reading sources... [ 61%] developer-guide/api/functions/TSSslContextFindBy.en
reading sources... [ 61%] 
developer-guide/api/functions/TSSslServerContextCreate.en
reading sources... [ 61%] developer-guide/api/functions/TSTextLogObjectCreate.en
reading sources... [ 61%] developer-guide/api/functions/TSThreadCreate.en
reading sources... [ 62%] developer-guide/api/functions/TSThreadDestroy.en
reading sources... [ 62%] developer-guide/api/functions/TSThreadInit.en
reading sources... [ 62%] developer-guide/api/functions/TSThreadSelf.en
reading sources... [ 62%] 
developer-guide/api/functions/TSTrafficServerVersionGet.en
reading sources... [ 63%] developer-guide/api/functions/TSTransformCreate.en
reading sources... [ 63%] 
developer-guide/api/functions/TSTransformOutputVConnGet.en
reading sources... [ 63%] developer-guide/api/functions/TSTypes.en
reading sources... [ 63%] developer-guide/api/functions/TSUrlCreate.en
reading sources... [ 63%] developer-guide/api/functions/TSUrlDestroy.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlFtpTypeGet.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlFtpTypeSet.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlHostGet.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlHostSet.en
reading sources... [ 65%] developer-guide/api/functions/TSUrlPercentEncode.en
reading sources... [ 65%] developer-guide/api/functions/TSUrlStringGet.en
reading sources... [ 65%] developer-guide/api/functions/TSVConnAbort.en
reading sources... [ 65%] 
developer-guide/api/functions/TSVConnCacheObjectSizeGet.en
reading sources... [ 65%] developer-guide/api/functions/TSVConnClose.en
reading sources... [ 66%] developer-guide/api/functions/TSVConnClosedGet.en
reading sources... [ 66%] developer-guide/api/functions/TSVConnFdCreate.en
reading sources... [ 66%] 

Jenkins build is back to normal : centos_7-master » gcc,centos_7,debug #1703

[jenkins]

See 

Build failed in Jenkins: centos_7-master » gcc,centos_7,release #1703

[jenkins]

See 


--
[...truncated 18384 lines...]
*** TEST 56 *** STARTING ***
*** TEST 56 *** PASSED ***
*** TEST 57 *** STARTING ***
*** TEST 57 *** PASSED ***
*** TEST 58 *** STARTING ***
*** TEST 58 *** PASSED ***
*** TEST 59 *** STARTING ***
*** TEST 59 *** PASSED ***
*** TEST 60 *** STARTING ***
*** TEST 60 *** PASSED ***
*** TEST 61 *** STARTING ***
*** TEST 61 *** PASSED ***
*** TEST 62 *** STARTING ***
*** TEST 62 *** PASSED ***
*** TEST 63 *** STARTING ***
*** TEST 63 *** PASSED ***
*** TEST 64 *** STARTING ***
*** TEST 64 *** PASSED ***
*** TEST 65 *** STARTING ***
*** TEST 65 *** PASSED ***
*** TEST 66 *** STARTING ***
*** TEST 66 *** PASSED ***
*** TEST 67 *** STARTING ***
*** TEST 67 *** PASSED ***
*** TEST 68 *** STARTING ***
*** TEST 68 *** PASSED ***
*** TEST 69 *** STARTING ***
*** TEST 69 *** PASSED ***
*** TEST 70 *** STARTING ***
*** TEST 70 *** PASSED ***
*** TEST 71 *** STARTING ***
*** TEST 71 *** PASSED ***
*** TEST 72 *** STARTING ***
*** TEST 72 *** PASSED ***
*** TEST 73 *** STARTING ***
*** TEST 73 *** PASSED ***
*** TEST 74 *** STARTING ***
*** TEST 74 *** PASSED ***
*** TEST 75 *** STARTING ***
*** TEST 75 *** PASSED ***
*** TEST 76 *** STARTING ***
*** TEST 76 *** PASSED ***
*** TEST 77 *** STARTING ***
*** TEST 77 *** PASSED ***
*** TEST 78 *** STARTING ***
*** TEST 78 *** PASSED ***
*** TEST 79 *** STARTING ***
*** TEST 79 *** PASSED ***
*** TEST 80 *** STARTING ***
*** TEST 80 *** PASSED ***
*** TEST 81 *** STARTING ***
*** TEST 81 *** PASSED ***
*** TEST 82 *** STARTING ***
*** TEST 82 *** PASSED ***
*** TEST 83 *** STARTING ***
*** TEST 83 *** PASSED ***
*** TEST 84 *** STARTING ***
*** TEST 84 *** PASSED ***
*** TEST 85 *** STARTING ***
*** TEST 85 *** PASSED ***
*** TEST 86 *** STARTING ***
*** TEST 86 *** PASSED ***
*** TEST 87 *** STARTING ***
*** TEST 87 *** PASSED ***
*** TEST 88 *** STARTING ***
*** TEST 88 *** PASSED ***
*** TEST 89 *** STARTING ***
*** TEST 89 *** PASSED ***
*** TEST 90 *** STARTING ***
*** TEST 90 *** PASSED ***
*** TEST 91 *** STARTING ***
*** TEST 91 *** PASSED ***
*** TEST 92 *** STARTING ***
*** TEST 92 *** PASSED ***
*** TEST 93 *** STARTING ***
*** TEST 93 *** PASSED ***
*** TEST 94 *** STARTING ***
*** TEST 94 *** PASSED ***
*** TEST 95 *** STARTING ***
*** TEST 95 *** PASSED ***
*** TEST 96 *** STARTING ***
*** TEST 96 *** PASSED ***
*** TEST 97 *** STARTING ***
*** TEST 97 *** PASSED ***
*** TEST 98 *** STARTING ***
*** TEST 98 *** PASSED ***
*** TEST 99 *** STARTING ***
*** TEST 99 *** PASSED ***
*** TEST 100 *** STARTING ***
*** TEST 100 *** PASSED ***
*** TEST 101 *** STARTING ***
*** TEST 101 *** PASSED ***
*** TEST 102 *** STARTING ***
*** TEST 102 *** PASSED ***
*** TEST 103 *** STARTING ***
*** TEST 103 *** PASSED ***
*** TEST 104 *** STARTING ***
*** TEST 104 *** PASSED ***
*** TEST 105 *** STARTING ***
*** TEST 105 *** PASSED ***
*** TEST 106 *** STARTING ***
*** TEST 106 *** PASSED ***
*** TEST 107 *** STARTING ***
*** TEST 107 *** PASSED ***
*** TEST 108 *** STARTING ***
*** TEST 108 *** PASSED ***
*** TEST 109 *** STARTING ***
*** TEST 109 *** PASSED ***
*** TEST 110 *** STARTING ***
*** TEST 110 *** PASSED ***
*** TEST 111 *** STARTING ***
*** TEST 111 *** PASSED ***
*** TEST 112 *** STARTING ***
*** TEST 112 *** PASSED ***
*** TEST 113 *** STARTING ***
*** TEST 113 *** PASSED ***
*** TEST 114 *** STARTING ***
*** TEST 114 *** PASSED ***
*** TEST 115 *** STARTING ***
*** TEST 115 *** PASSED ***
*** TEST 116 *** STARTING ***
*** TEST 116 *** PASSED ***
*** TEST 117 *** STARTING ***
*** TEST 117 *** PASREGRESSION_RESULT PARENTSELECTION:  
PASSED
REGRESSION_TEST DONE: FAILED
SED ***
*** TEST 118 *** STARTING ***
*** TEST 118 *** PASSED ***
*** TEST 119 *** STARTING ***
*** TEST 119 *** PASSED ***
*** TEST 120 *** STARTING ***
*** TEST 120 *** PASSED ***
*** TEST 121 *** STARTING ***
*** TEST 121 *** PASSED ***
*** TEST 122 *** STARTING ***
*** TEST 122 *** PASSED ***
*** TEST 123 *** STARTING ***
*** TEST 123 *** PASSED ***
*** TEST 124 *** STARTING ***
*** TEST 124 *** PASSED ***
*** TEST 125 *** STARTING ***
*** TEST 125 *** PASSED ***
*** TEST 126 *** STARTING ***
*** TEST 126 *** PASSED ***
*** TEST 127 *** STARTING ***
*** TEST 127 *** PASSED ***
*** TEST 128 *** STARTING ***
*** TEST 128 *** PASSED ***
*** TEST 129 *** STARTING ***
*** TEST 129 *** PASSED ***
*** TEST 130 *** STARTING ***
*** TEST 130 *** PASSED ***
*** TEST 131 *** STARTING ***
*** TEST 131 *** PASSED ***
*** TEST 132 *** STARTING ***
*** TEST 132 *** PASSED ***
*** TEST 133 *** STARTING ***
*** TEST 133 *** PASSED ***
*** TEST 134 *** STARTING ***
*** TEST 134 *** PASSED ***
*** TEST 135 *** STARTING ***
*** TEST 135 *** PASSED ***
*** TEST 136 *** STARTING ***
*** TEST 136 *** PASSED ***
*** TEST 137 *** STARTING ***
*** TEST 137 *** PASSED ***
*** TEST 138 *** STARTING ***
*** TEST 138 

[jira] [Resolved] (TS-3535) Add priority feature to the HTTP/2 implementation

[Masaori Koshiba (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Masaori Koshiba resolved TS-3535.
-
Resolution: Fixed

> Add priority feature to the HTTP/2 implementation
> -
>
> Key: TS-3535
> URL: https://issues.apache.org/jira/browse/TS-3535
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: HTTP/2
>Reporter: Bryan Call
>Assignee: Masaori Koshiba
> Fix For: 7.0.0
>
>
> Prioritizes the responses back to the client based on the priority level 
> specified by the HTTP/2 protocol.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4443) regex_remap: fix $i substitution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291429#comment-15291429
 ] 

ASF GitHub Bot commented on TS-4443:


Github user yatsukhnenko commented on the pull request:

https://github.com/apache/trafficserver/pull/643#issuecomment-220377419
  
You had to say [approve ci] 


> regex_remap: fix $i substitution
> 
>
> Key: TS-4443
> URL: https://issues.apache.org/jira/browse/TS-4443
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Pavlo Yatsukhnenko
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>
> GitHub #635



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3535) Add priority feature to the HTTP/2 implementation

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291420#comment-15291420
 ] 

ASF subversion and git services commented on TS-3535:
-

Commit 16172a4e79865d1201a51e85aeb72df8b0609986 in trafficserver's branch 
refs/heads/master from [~masaori]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=16172a4 ]

TS-3535: Experimental Support of HTTP/2 Stream Priority feature

- Add a option to enable this feature ( disabled in default ).
  `proxy.config.http2.stream_priority_enabled`
- Parse priority parameters of HEADERS and PRIORITY frame correctly.
- Add Http2DependencyTree and tests using `lib/ts/PriorityQueue.h`.
- Create a dependency tree when clients send HEADERS frame with priority 
parameters or PRIORITY frame.
- Separate `Http2ConnectionState::send_data_frame()` into 
`Http2ConnectionState::send_a_data_frame()`
  and `Http2ConnectionState::send_data_frames()`.
- Schedule DATA frames using the WFQ algorithm.

This closes #632


> Add priority feature to the HTTP/2 implementation
> -
>
> Key: TS-3535
> URL: https://issues.apache.org/jira/browse/TS-3535
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: HTTP/2
>Reporter: Bryan Call
>Assignee: Masaori Koshiba
> Fix For: 7.0.0
>
>
> Prioritizes the responses back to the client based on the priority level 
> specified by the HTTP/2 protocol.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3535) Add priority feature to the HTTP/2 implementation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291421#comment-15291421
 ] 

ASF GitHub Bot commented on TS-3535:


Github user asfgit closed the pull request at:

https://github.com/apache/trafficserver/pull/632


> Add priority feature to the HTTP/2 implementation
> -
>
> Key: TS-3535
> URL: https://issues.apache.org/jira/browse/TS-3535
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: HTTP/2
>Reporter: Bryan Call
>Assignee: Masaori Koshiba
> Fix For: 7.0.0
>
>
> Prioritizes the responses back to the client based on the priority level 
> specified by the HTTP/2 protocol.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4103) Introduce unit testing for CPP API.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291413#comment-15291413
 ] 

ASF GitHub Bot commented on TS-4103:


Github user zwoop commented on the pull request:

https://github.com/apache/trafficserver/pull/408#issuecomment-220376332
  


.



> Introduce unit testing for CPP API.
> ---
>
> Key: TS-4103
> URL: https://issues.apache.org/jira/browse/TS-4103
> Project: Traffic Server
>  Issue Type: New Feature
>  Components: CPP API
>Reporter: Sandeep Davu
>Assignee: Brian Geffon
> Fix For: 7.0.0
>
>
> create mock classes for CPP API. 
> These mocks can be used for unit testing plugins written using CPP API.
> Using gtest as testing framework. gmock as mocking framework.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3245) getopt doesn't work correctly when used in plugin chaining

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291411#comment-15291411
 ] 

ASF GitHub Bot commented on TS-3245:


Github user zwoop commented on the pull request:

https://github.com/apache/trafficserver/pull/571#issuecomment-220376319
  


.



> getopt doesn't work correctly when used in plugin chaining
> --
>
> Key: TS-3245
> URL: https://issues.apache.org/jira/browse/TS-3245
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Affects Versions: 5.1.1
>Reporter: Sudheer Vinukonda
>Priority: Minor
>  Labels: newbie
> Fix For: sometime
>
>
> When multiple plugins that use getopt are chained, it doesn't work correctly 
> for the subsequent plugins after the first plugin. [~jpe...@apache.org] and 
> [~zwoop] suggested that the getopt globals need to be reset (example, 
> {{optind = opterr = optopt = 0}}) before using it and would be better to do 
> it in the core during plugin loading to keep it simple/transparent from 
> plugin development. 
> Note that, if a plugin itself uses getopt multiple times on different argv's, 
> it would have to reset the globals between them. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4291) Custom log field {{pqhl}} should not count internal headers.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291410#comment-15291410
 ] 

ASF GitHub Bot commented on TS-4291:


Github user zwoop commented on the pull request:

https://github.com/apache/trafficserver/pull/588#issuecomment-220376312
  


.



> Custom log field {{pqhl}} should not count internal headers.
> 
>
> Key: TS-4291
> URL: https://issues.apache.org/jira/browse/TS-4291
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: Sudheer Vinukonda
> Fix For: sometime
>
>
> [~zwoop] suggested to add a simple API (not necessarily exposed to plugins at 
> the moment), to count the length of @-custom headers and deduct that when 
> reporting {{pqhl}}. Also, apply the same modification to lengths of other leg 
> request/response objects (e.g client_req, client_resp, server_req, 
> server_resp).
> IRC discussion below.
> {code}
> oag
> 7:55 If anyone is around who is familiar with the @-headers trick, I have a 
> question:
> 7:55 I have observed that @custom-header in an outgoing request changes the 
> value of the pqhl log field, even though the header is never actually sent.
> 7:55 This is true in 5.3.1. Does anyone know if this as been changed in 6.x.x 
> ?
> 7:55 Would like it if pqhl was an accurate reflection of data to the origin 
> server.
> 7:55 (pqhl + pqbl that is.)
> zwoop
> 7:55 oag  I'm pretty sure that is intended, if you don't want it there, why 
> not add it to another header ?
> 7:55 the way it works is that it "filters" out the @ header before sending, 
> and returning, headers
> 7:55 (afaik)
> 7:55 entirely possible I'm wrong too, but that was my impression from before.
> ***
> 7:55 Playback Complete.
> 7:57 esproul [~ad...@static-108-48-124-82.washdc.fios.verizon.net] entered 
> the room.
> sudheerv
> 8:07 zwoop: oag: umm..interesting, like zwoop said while it is intentional 
> that @-custom headers are meant never to be leaked outside, the pqhl adding 
> the @-headers seems like not something desirable
> 8:08 i'd be okay if we agree to not add it to pqhl
> 8:08 pqhl
> The proxy request header length; the header length in Traffic Server’s 
> request to the origin server.
> 8:09 given that pqhl is defined as the header length in the outbound request
> 8:09 adding @-headers to it seems inconsistent/inaccurate
> 8:10 as a matter of fact, i use @headers pretty "heavily" in our 
> products..but, don't enable pqhl
> 8:10 (at the moment anyway)
> zwoop
> 8:15 sudheerv  but that sets a poor precedence. You want to exclude @ headers 
> from pqhl, but not the other 3 internal header log tags that we have ?
> zwoop
> 8:16 One very important feature of the @-headers is to be able to log 
> internal (plugin generated) information in our custom logs
> sudheerv
> 8:16 zwoop: but, pqhl is just the length of the outgoing headers?
> zwoop
> 8:16 ah
> sudheerv
> 8:16 i haven't looked at in detail, but, excluding @ headers ( and the other 
> intenral headers)
> zwoop
> 8:16 in bytes ?
> sudheerv
> 8:16 from pqhl
> 8:16 will it mess up the log fields?
> 8:16 yeah
> zwoop
> 8:16 I thought it was the request header object.
> 8:16 Yeah, I don't know
> sudheerv
> 8:17 yeah, worth double checking - when the wise man complains :)
> zwoop
> 8:17 maybe you'd have to keep two lengths then, one with, and one without the 
> @ headers ?
> sudheerv
> 8:17 but, yeah, i'd not want to exclude the headers from log fields
> 8:17 just the length
> 8:17 sure, yeah unless it's already computing them in one place
> zwoop
> 8:17 m_proxy_request->length_get()
> sudheerv
> 8:17 where it'd be easier to exclude them - need ot check that part of the 
> code
> 8:17 ah, ok
> 8:19 so, would you be okay to modify pqhl (lenght in bytes) to exclude the 
> internal headers?
> zwoop
> 8:19 http://pastebin.com/svwPmaa0
> 8:19 looks like it counts the size of the "blocks" used, and not individual 
> header. It'd likely get much, much more expensive if you have to walk through 
> every header value.
> 8:21 actually, maybe it does count it individually, cause it calls 
> mime_field_length_get(MIMEField *field)
> sudheerv
> 8:21 yeah
> zwoop
> 8:22 But regardless, I'd be concerned that this might break other behavior 
> internally, so at a minimum, you'd want this exclusion only for a log tag. 
> And even so, since it's incompatible, etiher for v7.0.0, or as a separate log 
> tag
> sudheerv
> 8:22 and it does it each time lenght_get() is called?
> zwoop
> 8:22 looks like it
> sudheerv
> 8:22 umm..ok - yeah, may be, we just live with it then :)
> 8:22 we can update the docs though
> 8:23 oag: may be, you could help with that :)
> zwoop
> 8:23 this is probably a huge can of worm :)
> sudheerv
> 8:23 agree
> zwoop
> 8:23 i'm not touching it :)
> sudheerv
> 

[jira] [Commented] (TS-4072) Diagnostic log rolling races

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291412#comment-15291412
 ] 

ASF GitHub Bot commented on TS-4072:


Github user zwoop commented on the pull request:

https://github.com/apache/trafficserver/pull/568#issuecomment-220376323
  


.



> Diagnostic log rolling races
> 
>
> Key: TS-4072
> URL: https://issues.apache.org/jira/browse/TS-4072
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: James Peach
>Assignee: Alan M. Carroll
> Fix For: 7.0.0
>
>
> When diagnostic logs are rolled, {{Diags::diags_log}} is deleted and replaced 
> with a new log object. Since the global {{diags}} points to a a single 
> {{Diags}} object there is nothing to prevent a different thread logging 
> through this object at the time it is deleted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-3978) Allow empty document caching to follow normal logic

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291414#comment-15291414
 ] 

ASF GitHub Bot commented on TS-3978:


Github user zwoop commented on the pull request:

https://github.com/apache/trafficserver/pull/310#issuecomment-220376339
  


.



> Allow empty document caching to follow normal logic
> ---
>
> Key: TS-3978
> URL: https://issues.apache.org/jira/browse/TS-3978
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cache
>Reporter: Felicity Tarnell
> Fix For: 7.0.0
>
>
> Currently, allow_empty_doc only works if the origin sends a content-length 
> header.  It should have a setting to enable empty documents to be cached in 
> the normal way without any special handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4408) volume.config is ordering sensitive

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291406#comment-15291406
 ] 

ASF GitHub Bot commented on TS-4408:


Github user zwoop commented on the pull request:

https://github.com/apache/trafficserver/pull/618#issuecomment-220376299
  


.



> volume.config is ordering sensitive
> ---
>
> Key: TS-4408
> URL: https://issues.apache.org/jira/browse/TS-4408
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Configuration
>Reporter: James Peach
> Fix For: sometime
>
>
> {{volume.config}} is sensitive to the ordering of its fields. For example, 
> this doesn't work:
> {code}
> volume=1 size=50% scheme=http
> {code}
> but this does:
> {code}
> volume=1 scheme=http size=50%
> {code}
> All the key=value configuration files are supposed to be ordering-insensitive.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4455) remove isEosRcvd() and eosRcvd

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291404#comment-15291404
 ] 

ASF GitHub Bot commented on TS-4455:


Github user zwoop commented on the pull request:

https://github.com/apache/trafficserver/pull/646#issuecomment-220376259
  


.



> remove isEosRcvd() and eosRcvd
> --
>
> Key: TS-4455
> URL: https://issues.apache.org/jira/browse/TS-4455
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL
>Reporter: Oknet Xu
>
> the isEosRcvd() is used by HttpSM.
> It is check SSLNetVConnection->eosRcvd while received VC_EVENT_READ_READY or 
> VC_EVENT_READ_COMPLETE event, and rewrite the event to VC_EVENT_EOS.
> {code}
> int
> HttpSM::state_read_client_request_header(int event, void *data)
> {
> .
> .
> .
>   // check to see if there was an EOS received on the SSL connection
>   SSLNetVConnection *ssl_vc = dynamic_cast *>(ua_session->get_netvc());
>   if (ssl_vc && ssl_vc->isEosRcvd()) {
> DebugSM("http", "EOS for ssl vc %p at read_first_btye state", 
> ua_session->get_netvc());
> event = VC_EVENT_EOS;
>   }
>   switch (event) {
>   case VC_EVENT_READ_READY:
>   case VC_EVENT_READ_COMPLETE:
> // More data to parse
> break;
>   case VC_EVENT_EOS:
> ua_entry->eos = true;
> if ((client_request_hdr_bytes > 0) && 
> is_transparent_passthrough_allowed() && (ua_raw_buffer_reader != NULL)) {
>   break;
> }
> .
> .
> .
> {code}
> the eosRcvd is set to true only in SSLNetVConnection::net_read_io()
> {code}
> // changed by YTS Team, yamsat
> void
> SSLNetVConnection::net_read_io(NetHandler *nh, EThread *lthread)
> {
> .
> .
> .
>   case SSL_READ_EOS:
> // close the connection if we have SSL_READ_EOS, this is the return value 
> from ssl_read_from_net() if we get an
> // SSL_ERROR_ZERO_RETURN from SSL_get_error()
> // SSL_ERROR_ZERO_RETURN means that the origin server closed the SSL 
> connection
> eosRcvd = true;
> read.triggered = 0;
> readSignalDone(VC_EVENT_EOS, nh);
> if (bytes > 0) {
>   Debug("ssl", "read_from_net, read finished - EOS");
> } else {
>   Debug("ssl", "read_from_net, read finished - 0 useful bytes read, bytes 
> used by SSL layer");
> }
> break;
> .
> .
> .
> {code}
> It is also signal VC_EVENT_EOS to SM after set eosRcvd to true.
> thus, the eosRcvd and isEosRcvd() is no longer necessary.
> suggest remove them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4443) regex_remap: fix $i substitution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291405#comment-15291405
 ] 

ASF GitHub Bot commented on TS-4443:


Github user zwoop commented on the pull request:

https://github.com/apache/trafficserver/pull/643#issuecomment-220376270
  


.



> regex_remap: fix $i substitution
> 
>
> Key: TS-4443
> URL: https://issues.apache.org/jira/browse/TS-4443
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Pavlo Yatsukhnenko
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>
> GitHub #635



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4459) Force domain names in cert to lower on insert into lookup tree

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291403#comment-15291403
 ] 

ASF GitHub Bot commented on TS-4459:


Github user zwoop commented on the pull request:

https://github.com/apache/trafficserver/pull/647#issuecomment-220376258
  


.



> Force domain names in cert to lower on insert into lookup tree
> --
>
> Key: TS-4459
> URL: https://issues.apache.org/jira/browse/TS-4459
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL
>Reporter: Steven Feltner
> Fix For: 7.0.0
>
>
> We have certs from a legacy system that were issued with mixed case domain 
> names.  We are migrating this older product over to ATS and found that domain 
> names need to be lower cased before being inserted in the lookup table.
> I will be submitting  a pull request to resolve this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4156) remove the traffic_sac, stand alone log collation server

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291408#comment-15291408
 ] 

ASF GitHub Bot commented on TS-4156:


Github user zwoop commented on the pull request:

https://github.com/apache/trafficserver/pull/593#issuecomment-220376308
  


.



> remove the traffic_sac, stand alone log collation server
> 
>
> Key: TS-4156
> URL: https://issues.apache.org/jira/browse/TS-4156
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Logging
>Reporter: Zhao Yongming
>Assignee: Zhao Yongming
> Fix For: 7.0.0
>
>
> the stand alone collation server act as a dedicated log server from ATS, this 
> is a dedicated log product back in the Inktomi age, and we don't need it as 
> this functions are build into the traffic_server binary for free distribution.
> it is time to nuke it down.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4379) Log field for connections to origin

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291407#comment-15291407
 ] 

ASF GitHub Bot commented on TS-4379:


Github user zwoop commented on the pull request:

https://github.com/apache/trafficserver/pull/598#issuecomment-220376302
  


.



> Log field for connections to origin 
> 
>
> Key: TS-4379
> URL: https://issues.apache.org/jira/browse/TS-4379
> Project: Traffic Server
>  Issue Type: New Feature
>  Components: Logging
>Reporter: Eric Schwartz
> Fix For: sometime
>
>
> Simple log field for # of connections open to the origin server. Did this a 
> while back for some work we were doing to track the maximum number of 
> connections to a given origin across some traffic spikes. Thought someone 
> else might find it useful.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-3535) Add priority feature to the HTTP/2 implementation

[Masaori Koshiba (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Masaori Koshiba updated TS-3535:

Backport to Version: 6.2.0

> Add priority feature to the HTTP/2 implementation
> -
>
> Key: TS-3535
> URL: https://issues.apache.org/jira/browse/TS-3535
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: HTTP/2
>Reporter: Bryan Call
>Assignee: Masaori Koshiba
> Fix For: 7.0.0
>
>
> Prioritizes the responses back to the client based on the priority level 
> specified by the HTTP/2 protocol.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4455) remove isEosRcvd() and eosRcvd

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291352#comment-15291352
 ] 

ASF GitHub Bot commented on TS-4455:


Github user zwoop commented on the pull request:

https://github.com/apache/trafficserver/pull/646#issuecomment-220368272
  
I think we should squash these three commits to one, right?


> remove isEosRcvd() and eosRcvd
> --
>
> Key: TS-4455
> URL: https://issues.apache.org/jira/browse/TS-4455
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL
>Reporter: Oknet Xu
>
> the isEosRcvd() is used by HttpSM.
> It is check SSLNetVConnection->eosRcvd while received VC_EVENT_READ_READY or 
> VC_EVENT_READ_COMPLETE event, and rewrite the event to VC_EVENT_EOS.
> {code}
> int
> HttpSM::state_read_client_request_header(int event, void *data)
> {
> .
> .
> .
>   // check to see if there was an EOS received on the SSL connection
>   SSLNetVConnection *ssl_vc = dynamic_cast *>(ua_session->get_netvc());
>   if (ssl_vc && ssl_vc->isEosRcvd()) {
> DebugSM("http", "EOS for ssl vc %p at read_first_btye state", 
> ua_session->get_netvc());
> event = VC_EVENT_EOS;
>   }
>   switch (event) {
>   case VC_EVENT_READ_READY:
>   case VC_EVENT_READ_COMPLETE:
> // More data to parse
> break;
>   case VC_EVENT_EOS:
> ua_entry->eos = true;
> if ((client_request_hdr_bytes > 0) && 
> is_transparent_passthrough_allowed() && (ua_raw_buffer_reader != NULL)) {
>   break;
> }
> .
> .
> .
> {code}
> the eosRcvd is set to true only in SSLNetVConnection::net_read_io()
> {code}
> // changed by YTS Team, yamsat
> void
> SSLNetVConnection::net_read_io(NetHandler *nh, EThread *lthread)
> {
> .
> .
> .
>   case SSL_READ_EOS:
> // close the connection if we have SSL_READ_EOS, this is the return value 
> from ssl_read_from_net() if we get an
> // SSL_ERROR_ZERO_RETURN from SSL_get_error()
> // SSL_ERROR_ZERO_RETURN means that the origin server closed the SSL 
> connection
> eosRcvd = true;
> read.triggered = 0;
> readSignalDone(VC_EVENT_EOS, nh);
> if (bytes > 0) {
>   Debug("ssl", "read_from_net, read finished - EOS");
> } else {
>   Debug("ssl", "read_from_net, read finished - 0 useful bytes read, bytes 
> used by SSL layer");
> }
> break;
> .
> .
> .
> {code}
> It is also signal VC_EVENT_EOS to SM after set eosRcvd to true.
> thus, the eosRcvd and isEosRcvd() is no longer necessary.
> suggest remove them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4457) Via header always reports http1

[Susan Hinrichs (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291321#comment-15291321
 ] 

Susan Hinrichs commented on TS-4457:


This is not a regression is it?  Looking through the code in 
HttpTransactHeaders::insert_via_header_in_response it appears to hard code 
either HTTP/1.1 or HTTP/1.0.  I guess to fix it up, we should add logic in the 
Http2Stream to update the via header appropriately.  Or replace the hard coded 
logic with calls to get_protocol_string().

> Via header always reports http1
> ---
>
> Key: TS-4457
> URL: https://issues.apache.org/jira/browse/TS-4457
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Miles Libbey
> Fix For: 7.0.0
>
>
> When using http2, the Via header says http1.1.
> $ curl -D- -o/dev/null -s "https://docs.trafficserver.apache.org/; | grep via
> via:http/1.1 ATS (ApacheTrafficServer/6.2.0 [cRs f ])



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Build failed in Jenkins: clang-analyzer #2299

[jenkins]

See 

--
[...truncated 2846 lines...]
reading sources... [ 53%] developer-guide/api/functions/TSMimeHdrFieldGet.en
reading sources... [ 53%] 
developer-guide/api/functions/TSMimeHdrFieldLengthGet.en
reading sources... [ 53%] developer-guide/api/functions/TSMimeHdrFieldNameGet.en
reading sources... [ 53%] developer-guide/api/functions/TSMimeHdrFieldNameSet.en
reading sources... [ 54%] developer-guide/api/functions/TSMimeHdrFieldNext.en
reading sources... [ 54%] developer-guide/api/functions/TSMimeHdrFieldNextDup.en
reading sources... [ 54%] developer-guide/api/functions/TSMimeHdrFieldRemove.en
reading sources... [ 54%] 
developer-guide/api/functions/TSMimeHdrFieldValueAppend.en
reading sources... [ 54%] 
developer-guide/api/functions/TSMimeHdrFieldValueDateInsert.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueDateSet.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueIntSet.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueStringGet.en
reading sources... [ 55%] 
developer-guide/api/functions/TSMimeHdrFieldValueStringInsert.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValueStringSet.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValueUintInsert.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValueUintSet.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValuesClear.en
reading sources... [ 56%] 
developer-guide/api/functions/TSMimeHdrFieldValuesCount.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrFieldsClear.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrFieldsCount.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrLengthGet.en
reading sources... [ 57%] developer-guide/api/functions/TSMimeHdrParse.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeHdrPrint.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeParserClear.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeParserCreate.en
reading sources... [ 58%] developer-guide/api/functions/TSMimeParserDestroy.en
reading sources... [ 58%] developer-guide/api/functions/TSMutexCreate.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexDestroy.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexLock.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexLockTry.en
reading sources... [ 59%] developer-guide/api/functions/TSMutexUnlock.en
reading sources... [ 60%] developer-guide/api/functions/TSNetAccept.en
reading sources... [ 60%] 
developer-guide/api/functions/TSNetAcceptNamedProtocol.en
reading sources... [ 60%] developer-guide/api/functions/TSNetConnect.en
reading sources... [ 60%] developer-guide/api/functions/TSPluginInit.en
reading sources... [ 60%] developer-guide/api/functions/TSRemap.en
reading sources... [ 61%] developer-guide/api/functions/TSSslContextFindBy.en
reading sources... [ 61%] 
developer-guide/api/functions/TSSslServerContextCreate.en
reading sources... [ 61%] developer-guide/api/functions/TSTextLogObjectCreate.en
reading sources... [ 61%] developer-guide/api/functions/TSThreadCreate.en
reading sources... [ 62%] developer-guide/api/functions/TSThreadDestroy.en
reading sources... [ 62%] developer-guide/api/functions/TSThreadInit.en
reading sources... [ 62%] developer-guide/api/functions/TSThreadSelf.en
reading sources... [ 62%] 
developer-guide/api/functions/TSTrafficServerVersionGet.en
reading sources... [ 63%] developer-guide/api/functions/TSTransformCreate.en
reading sources... [ 63%] 
developer-guide/api/functions/TSTransformOutputVConnGet.en
reading sources... [ 63%] developer-guide/api/functions/TSTypes.en
reading sources... [ 63%] developer-guide/api/functions/TSUrlCreate.en
reading sources... [ 63%] developer-guide/api/functions/TSUrlDestroy.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlFtpTypeGet.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlFtpTypeSet.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlHostGet.en
reading sources... [ 64%] developer-guide/api/functions/TSUrlHostSet.en
reading sources... [ 65%] developer-guide/api/functions/TSUrlPercentEncode.en
reading sources... [ 65%] developer-guide/api/functions/TSUrlStringGet.en
reading sources... [ 65%] developer-guide/api/functions/TSVConnAbort.en
reading sources... [ 65%] 
developer-guide/api/functions/TSVConnCacheObjectSizeGet.en
reading sources... [ 65%] developer-guide/api/functions/TSVConnClose.en
reading sources... [ 66%] developer-guide/api/functions/TSVConnClosedGet.en
reading sources... [ 66%] developer-guide/api/functions/TSVConnFdCreate.en
reading sources... [ 66%] developer-guide/api/functions/TSVConnIsSsl.en
reading sources... [ 66%] developer-guide/api/functions/TSVConnRead.en
reading 

[jira] [Commented] (TS-4072) Diagnostic log rolling races

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290521#comment-15290521
 ] 

ASF GitHub Bot commented on TS-4072:


Github user oknet commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/568#discussion_r63826235
  
--- Diff: lib/ts/Diags.cc ---
@@ -625,11 +625,14 @@ Diags::should_roll_diagslog()
 fflush(diags_log->m_fp);
 if (diags_log->roll()) {
--- End diff --

agree with u,  old file will be closed by ~~LINE 635: delete old_diags;~~.


> Diagnostic log rolling races
> 
>
> Key: TS-4072
> URL: https://issues.apache.org/jira/browse/TS-4072
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Reporter: James Peach
>Assignee: Alan M. Carroll
> Fix For: 7.0.0
>
>
> When diagnostic logs are rolled, {{Diags::diags_log}} is deleted and replaced 
> with a new log object. Since the global {{diags}} points to a a single 
> {{Diags}} object there is nothing to prevent a different thread logging 
> through this object at the time it is deleted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)