[jira] [Updated] (TS-4897) Unbound growth of number of memory maps for traffic_server under SSL termination load when ssl_ticket_enabled=0
[
https://issues.apache.org/jira/browse/TS-4897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leif Hedstrom updated TS-4897:
--
Component/s: TLS
> Unbound growth of number of memory maps for traffic_server under SSL
> termination load when ssl_ticket_enabled=0
> ---
>
> Key: TS-4897
> URL: https://issues.apache.org/jira/browse/TS-4897
> Project: Traffic Server
> Issue Type: Bug
> Components: TLS
>Reporter: Can Selcik
> Fix For: 7.1.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The number of {{\[anon\]}} memory regions mapped to the {{traffic_server}}
> process displays unbound growth until the kernel thresholds are reached and
> the process is terminated.
> This happens when ATS is used to terminate SSL and {{ssl_ticket_enabled=0}}
> in {{ssl_multicert.config}}.
> We've experienced this issue on our staging and production hosts and were
> able to replicate it with the above configuration under high volume HTTPS
> load. We didn't experience this with {{5.2.x}} and it will make sense why at
> the end.
> While generating {{https}} traffic with {{siege}} or {{ab}}, the issue can be
> observed with:
> {{watch "pmap $(pidof traffic_server) | wc -l"}}
> {{git bisect}} pointed us to:
> Turns out a no-op {{ats_madvise}} hides the symptoms of the issue.
> Going in deeper, we realize that {{ssl_ticket_enabled}} option is relevant
> because after enabling the {{ssl.session_cache}} tag, we see that ATS doesn't
> manage its own session cache for SSL, it is done by the library instead. In
> that case, the code path doing the problematic allocation within ATS doesn't
> get executed often since OpenSSL takes care of the session tokens.
> But why does this happen? It happens because {{MADV_DONTDUMP}} is passed to
> {{posix_madvise}} even though {{MADV_DONTDUMP}} is not a valid flag for
> {{posix_madvise}} as it is not a drop-in replacement to {{madvise}}.
> Looking at {{}}:
> {noformat}
> 87 /* Advice to `madvise'. */
> 88 #ifdef __USE_BSD
> 89 # define MADV_NORMAL▸ 0▸/* No further special treatment. */
> 90 # define MADV_RANDOM▸ 1▸/* Expect random page references. */
> 91 # define MADV_SEQUENTIAL 2▸/* Expect sequential page references.
> */
> 92 # define MADV_WILLNEED▸ 3▸/* Will need these pages. */
> 93 # define MADV_DONTNEED▸ 4▸/* Don't need these pages. */
> 94 # define MADV_REMOVE▸ 9▸/* Remove these pages and resources.
> */
> 95 # define MADV_DONTFORK▸ 10▸ /* Do not inherit across fork. */
> 96 # define MADV_DOFORK▸ 11▸ /* Do inherit across fork. */
> 97 # define MADV_MERGEABLE▸ 12▸ /* KSM may merge identical pages. */
> 98 # define MADV_UNMERGEABLE 13▸ /* KSM may not merge identical pages.
> */
> 99 # define MADV_DONTDUMP▸ 16/* Explicity exclude from the core
> dump,
> 100overrides the coredump filter
> bits. */
> 101 # define MADV_DODUMP▸ 17▸ /* Clear the MADV_DONTDUMP flag. */
> 102 # define MADV_HWPOISON▸ 100▸ /* Poison a page for testing. */
> 103 #endif
> {noformat}
> However {{posix_madvise}} takes:
> {noformat}
> 107 # define POSIX_MADV_NORMAL▸ 0 /* No further special treatment. */
> 108 # define POSIX_MADV_RANDOM▸ 1 /* Expect random page references.
> */
> 109 # define POSIX_MADV_SEQUENTIAL▸ 2 /* Expect sequential page
> references. */
> 110 # define POSIX_MADV_WILLNEED▸ 3 /* Will need these pages. */
> 111 # define POSIX_MADV_DONTNEED▸ 4 /* Don't need these pages. */
> {noformat}
> Also {{posix_madvise}} and {{madvise}} can both be present on the same
> system. However they do not have the same capability. That's why {{Explicity
> exclude from the core dump, overrides the coredump filter bits}}
> functionality isn't achievable through {{posix_madvise}}.
> Will post a PR momentarily.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] trafficserver issue #1041: TS-4887 : Clean up Parent Selection URL feature
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1041 @pbchou can you squash these commits together? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (TS-4514) Transaction hangs when no_dns_just_forward is configured but parent proxy is unresolvable
[
https://issues.apache.org/jira/browse/TS-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Sorber resolved TS-4514.
-
Resolution: Fixed
Don't need to re-open for backport.
> Transaction hangs when no_dns_just_forward is configured but parent proxy is
> unresolvable
> -
>
> Key: TS-4514
> URL: https://issues.apache.org/jira/browse/TS-4514
> Project: Traffic Server
> Issue Type: Bug
> Components: DNS, Parent Proxy
>Reporter: Uri Shachar
>Assignee: Uri Shachar
> Fix For: 7.0.0
>
>
> When ATS is configured with:
> {code}
> CONFIG proxy.config.http.no_dns_just_forward_to_parent INT 1
> {code}
> And a transaction comes in that has an unresolvable parent in parents.config
> ATS will keep retrying to resolve the same parent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (TS-4896) TSHttpTxnClientAddrGet and TSHttpTxnIncomingAddrGet may return NULL
[ https://issues.apache.org/jira/browse/TS-4896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Susan Hinrichs updated TS-4896: --- Priority: Minor (was: Major) > TSHttpTxnClientAddrGet and TSHttpTxnIncomingAddrGet may return NULL > --- > > Key: TS-4896 > URL: https://issues.apache.org/jira/browse/TS-4896 > Project: Traffic Server > Issue Type: Bug > Components: Core >Reporter: Susan Hinrichs >Priority: Minor > > With the clean up rearranging to ensure SSN close occurs after TXN close > (TS-4507), the API calls TSHttpTxnClientAddrGet and TSHttpTxnIncomingAddrGet > may return NULL. This can occur in the case where the client connection has > terminated, but the HttpSM has not yet shutdown. We now null out the > reference in HttpSM to the client_vc. These calls fetch the addresses from > the client_vc, so it HttpSM reference to it has been removed, these API's > will return NULL. > Locally, we copy these addresses into the ProxyClientSession before the > client_vc is disconnected. We had push back from deployed plugins for a > short term fix. > Not clear what if anything we want to do in open source. But wanted people > to be aware that this is an issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4891) ATS-7.0.x giving segmentation fault
[ https://issues.apache.org/jira/browse/TS-4891?focusedWorklogId=29783=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29783 ] ASF GitHub Bot logged work on TS-4891: -- Author: ASF GitHub Bot Created on: 26/Sep/16 23:19 Start Date: 26/Sep/16 23:19 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1045 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/770/ for details. Issue Time Tracking --- Worklog Id: (was: 29783) Time Spent: 2h 50m (was: 2h 40m) > ATS-7.0.x giving segmentation fault > --- > > Key: TS-4891 > URL: https://issues.apache.org/jira/browse/TS-4891 > Project: Traffic Server > Issue Type: Bug > Components: Core >Affects Versions: 7.0.0 >Reporter: Syeda Persia Aziz >Assignee: Syeda Persia Aziz > Fix For: 7.1.0 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > The current 7.0.x branch is giving me segmentation fault as I run it. It > happens when trying to elevate_fopen Diags.log. It fails and shoots an > diags-error message which does not have any debug tag. > The trace and info can be found here: > https://gist.github.com/persiaAziz/48a321a1c1913af1580261fa40d14df0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] trafficserver pull request #1045: TS-4891: Initializing prefix_str on declar...
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1045#discussion_r80590510
--- Diff: proxy/Main.cc ---
@@ -1507,9 +1507,8 @@ main(int /* argc ATS_UNUSED */, const char **argv)
// re-start it again, TS will crash.
// This is also needed for log rotation - setting up the file can cause
privilege
// related errors and if diagsConfig isn't get up yet that will crash on
a NULL pointer.
- diagsConfig = new DiagsConfig(DIAGS_LOG_FILENAME, error_tags,
action_tags, false);
- diags = diagsConfig->diags;
- diags->prefix_str = "Server ";
+ diagsConfig = new DiagsConfig("Server ", DIAGS_LOG_FILENAME, error_tags,
action_tags, false);
--- End diff --
Why do we sometimes have a trailing space on the prefix?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Work logged] (TS-4699) Add an example websocket termination plugin using the C++ API
[ https://issues.apache.org/jira/browse/TS-4699?focusedWorklogId=29773=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29773 ] ASF GitHub Bot logged work on TS-4699: -- Author: ASF GitHub Bot Created on: 26/Sep/16 22:29 Start Date: 26/Sep/16 22:29 Worklog Time Spent: 10m Work Description: Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/824 [approve ci] Issue Time Tracking --- Worklog Id: (was: 29773) Time Spent: 2h 50m (was: 2h 40m) > Add an example websocket termination plugin using the C++ API > - > > Key: TS-4699 > URL: https://issues.apache.org/jira/browse/TS-4699 > Project: Traffic Server > Issue Type: Improvement > Components: CPP API >Reporter: Oliver Goodman >Assignee: Brian Geffon > Fix For: 7.1.0 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > It may be of interest to users to have an experimental example plugin showing > how to terminate incoming websocket connections. A minimal example could > implement the protocol and use it to set up a simple websocket echo server. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] trafficserver issue #824: TS-4699: Adds a C++ API WebSocket example
Github user ogoodman commented on the issue: https://github.com/apache/trafficserver/pull/824 Ok, this time I had a look at the source for the relevant header files of each distribution. It seems you can't trust randomly posted, heavily upvoted gists claiming to do useful things. Who would have thought it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Work logged] (TS-4891) ATS-7.0.x giving segmentation fault
[ https://issues.apache.org/jira/browse/TS-4891?focusedWorklogId=29769=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29769 ] ASF GitHub Bot logged work on TS-4891: -- Author: ASF GitHub Bot Created on: 26/Sep/16 21:53 Start Date: 26/Sep/16 21:53 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1045 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/768/ for details. Issue Time Tracking --- Worklog Id: (was: 29769) Time Spent: 2h (was: 1h 50m) > ATS-7.0.x giving segmentation fault > --- > > Key: TS-4891 > URL: https://issues.apache.org/jira/browse/TS-4891 > Project: Traffic Server > Issue Type: Bug > Components: Core >Affects Versions: 7.0.0 >Reporter: Syeda Persia Aziz >Assignee: Syeda Persia Aziz > Fix For: 7.1.0 > > Time Spent: 2h > Remaining Estimate: 0h > > The current 7.0.x branch is giving me segmentation fault as I run it. It > happens when trying to elevate_fopen Diags.log. It fails and shoots an > diags-error message which does not have any debug tag. > The trace and info can be found here: > https://gist.github.com/persiaAziz/48a321a1c1913af1580261fa40d14df0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4891) ATS-7.0.x giving segmentation fault
[ https://issues.apache.org/jira/browse/TS-4891?focusedWorklogId=29763=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29763 ] ASF GitHub Bot logged work on TS-4891: -- Author: ASF GitHub Bot Created on: 26/Sep/16 21:07 Start Date: 26/Sep/16 21:07 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1045 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/767/ for details. Issue Time Tracking --- Worklog Id: (was: 29763) Time Spent: 1h 10m (was: 1h) > ATS-7.0.x giving segmentation fault > --- > > Key: TS-4891 > URL: https://issues.apache.org/jira/browse/TS-4891 > Project: Traffic Server > Issue Type: Bug > Components: Core >Affects Versions: 7.0.0 >Reporter: Syeda Persia Aziz >Assignee: Syeda Persia Aziz > Fix For: 7.1.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > The current 7.0.x branch is giving me segmentation fault as I run it. It > happens when trying to elevate_fopen Diags.log. It fails and shoots an > diags-error message which does not have any debug tag. > The trace and info can be found here: > https://gist.github.com/persiaAziz/48a321a1c1913af1580261fa40d14df0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (TS-4514) Transaction hangs when no_dns_just_forward is configured but parent proxy is unresolvable
[
https://issues.apache.org/jira/browse/TS-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Rushford reopened TS-4514:
---
Backport to Version: 6.2.0
I ran into this issue while testing 6.2.0. Spoke to [~psudaemon] about this
and he will backport.
> Transaction hangs when no_dns_just_forward is configured but parent proxy is
> unresolvable
> -
>
> Key: TS-4514
> URL: https://issues.apache.org/jira/browse/TS-4514
> Project: Traffic Server
> Issue Type: Bug
> Components: DNS, Parent Proxy
>Reporter: Uri Shachar
>Assignee: Uri Shachar
> Fix For: 7.0.0
>
>
> When ATS is configured with:
> {code}
> CONFIG proxy.config.http.no_dns_just_forward_to_parent INT 1
> {code}
> And a transaction comes in that has an unresolvable parent in parents.config
> ATS will keep retrying to resolve the same parent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] trafficserver pull request #1048: TS-4883: Thread start signature
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/1048 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
