[jira] [Work logged] (TS-4997) Move C++ API to plugins.

2016-10-23 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4997?focusedWorklogId=30975=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30975
 ]

ASF GitHub Bot logged work on TS-4997:
--

Author: ASF GitHub Bot
Created on: 24/Oct/16 04:06
Start Date: 24/Oct/16 04:06
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1134
  
Hmmm, are we sure this makes sense? The CPP APIs aren't plugins, and we 
certainly don't put the TS API's into plugins. I could perhaps see this go into 
proxy somewhere.


Issue Time Tracking
---

Worklog Id: (was: 30975)
Time Spent: 40m  (was: 0.5h)

> Move C++ API to plugins.
> 
>
> Key: TS-4997
> URL: https://issues.apache.org/jira/browse/TS-4997
> Project: Traffic Server
>  Issue Type: Task
>  Components: CPP API
>Reporter: James Peach
>Assignee: James Peach
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Move the C++ API to the {{plugins}} directory. Although the C++ API is a 
> dependency of some plugins, it is itself a consumer of the TS plugin API, so 
> the best place from a build ordering POV is {{plugins}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1134: TS-4997: Move C++ API to plugins.

2016-10-23 Thread zwoop 
Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1134
  
Hmmm, are we sure this makes sense? The CPP APIs aren't plugins, and we 
certainly don't put the TS API's into plugins. I could perhaps see this go into 
proxy somewhere.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4995) Consolidate C++ API example plugins.

2016-10-23 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4995?focusedWorklogId=30974=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30974
 ]

ASF GitHub Bot logged work on TS-4995:
--

Author: ASF GitHub Bot
Created on: 24/Oct/16 03:53
Start Date: 24/Oct/16 03:53
Worklog Time Spent: 10m 
  Work Description: Github user bgaff commented on the issue:

https://github.com/apache/trafficserver/pull/1132
  
Sounds good to me


Issue Time Tracking
---

Worklog Id: (was: 30974)
Time Spent: 50m  (was: 40m)

> Consolidate C++ API example plugins.
> 
>
> Key: TS-4995
> URL: https://issues.apache.org/jira/browse/TS-4995
> Project: Traffic Server
>  Issue Type: Bug
>  Components: CPP API, Plugins
>Reporter: James Peach
>Assignee: Brian Geffon
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Move the C++ API examples to colocate them with the rest of the examples.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1132: TS-4995: Consolidate C++ API example plugins.

2016-10-23 Thread bgaff 
Github user bgaff commented on the issue:

https://github.com/apache/trafficserver/pull/1132
  
Sounds good to me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1132: TS-4995: Consolidate C++ API example plugins.

2016-10-23 Thread bryancall 
Github user bryancall commented on the issue:

https://github.com/apache/trafficserver/pull/1132
  
👍  - I think this is a better location


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4995) Consolidate C++ API example plugins.

2016-10-23 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4995?focusedWorklogId=30973=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30973
 ]

ASF GitHub Bot logged work on TS-4995:
--

Author: ASF GitHub Bot
Created on: 23/Oct/16 21:28
Start Date: 23/Oct/16 21:28
Worklog Time Spent: 10m 
  Work Description: Github user bryancall commented on the issue:

https://github.com/apache/trafficserver/pull/1132
  
  - I think this is a better location


Issue Time Tracking
---

Worklog Id: (was: 30973)
Time Spent: 40m  (was: 0.5h)

> Consolidate C++ API example plugins.
> 
>
> Key: TS-4995
> URL: https://issues.apache.org/jira/browse/TS-4995
> Project: Traffic Server
>  Issue Type: Bug
>  Components: CPP API, Plugins
>Reporter: James Peach
>Assignee: Brian Geffon
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Move the C++ API examples to colocate them with the rest of the examples.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4997) Move C++ API to plugins.

2016-10-23 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4997?focusedWorklogId=30972=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30972
 ]

ASF GitHub Bot logged work on TS-4997:
--

Author: ASF GitHub Bot
Created on: 23/Oct/16 20:45
Start Date: 23/Oct/16 20:45
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1134
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1068/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 30972)
Time Spent: 0.5h  (was: 20m)

> Move C++ API to plugins.
> 
>
> Key: TS-4997
> URL: https://issues.apache.org/jira/browse/TS-4997
> Project: Traffic Server
>  Issue Type: Task
>  Components: CPP API
>Reporter: James Peach
>Assignee: James Peach
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Move the C++ API to the {{plugins}} directory. Although the C++ API is a 
> dependency of some plugins, it is itself a consumer of the TS plugin API, so 
> the best place from a build ordering POV is {{plugins}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1134: TS-4997: Move C++ API to plugins.

2016-10-23 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1134
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1068/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4997) Move C++ API to plugins.

2016-10-23 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4997?focusedWorklogId=30971=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30971
 ]

ASF GitHub Bot logged work on TS-4997:
--

Author: ASF GitHub Bot
Created on: 23/Oct/16 20:44
Start Date: 23/Oct/16 20:44
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1134
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/960/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 30971)
Time Spent: 20m  (was: 10m)

> Move C++ API to plugins.
> 
>
> Key: TS-4997
> URL: https://issues.apache.org/jira/browse/TS-4997
> Project: Traffic Server
>  Issue Type: Task
>  Components: CPP API
>Reporter: James Peach
>Assignee: James Peach
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Move the C++ API to the {{plugins}} directory. Although the C++ API is a 
> dependency of some plugins, it is itself a consumer of the TS plugin API, so 
> the best place from a build ordering POV is {{plugins}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1134: TS-4997: Move C++ API to plugins.

2016-10-23 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1134
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/960/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1134: TS-4997: Move C++ API to plugins.

2016-10-23 Thread jpeach 
GitHub user jpeach opened a pull request:

https://github.com/apache/trafficserver/pull/1134

TS-4997: Move C++ API to plugins.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jpeach/trafficserver TS-4997

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1134


commit b66e6994abadf1b305b4a56b3a48bfd2535d0bcf
Author: James Peach 
Date:   2016-10-22T18:28:29Z

TS-4995: Consolidate C++ API example plugins.

Move all the C++ example plugins into the 'example' directory so
that there is only one place to look for plugin examples.

commit a0e9905f9674a5569a27cc6ba646999f4c0163bb
Author: James Peach 
Date:   2016-10-23T20:29:41Z

TS-4997: Move C++ API to the plugins directory.

Although the C++ API is a dependency of some plugins, it is itself
a consumer of the TS plugin API, so the best place from a build
ordering perspective is the plugins directory.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4997) Move C++ API to plugins.

2016-10-23 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4997?focusedWorklogId=30970=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30970
 ]

ASF GitHub Bot logged work on TS-4997:
--

Author: ASF GitHub Bot
Created on: 23/Oct/16 20:31
Start Date: 23/Oct/16 20:31
Worklog Time Spent: 10m 
  Work Description: GitHub user jpeach opened a pull request:

https://github.com/apache/trafficserver/pull/1134

TS-4997: Move C++ API to plugins.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jpeach/trafficserver TS-4997

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1134


commit b66e6994abadf1b305b4a56b3a48bfd2535d0bcf
Author: James Peach 
Date:   2016-10-22T18:28:29Z

TS-4995: Consolidate C++ API example plugins.

Move all the C++ example plugins into the 'example' directory so
that there is only one place to look for plugin examples.

commit a0e9905f9674a5569a27cc6ba646999f4c0163bb
Author: James Peach 
Date:   2016-10-23T20:29:41Z

TS-4997: Move C++ API to the plugins directory.

Although the C++ API is a dependency of some plugins, it is itself
a consumer of the TS plugin API, so the best place from a build
ordering perspective is the plugins directory.




Issue Time Tracking
---

Worklog Id: (was: 30970)
Time Spent: 10m
Remaining Estimate: 0h

> Move C++ API to plugins.
> 
>
> Key: TS-4997
> URL: https://issues.apache.org/jira/browse/TS-4997
> Project: Traffic Server
>  Issue Type: Task
>  Components: CPP API
>Reporter: James Peach
>Assignee: James Peach
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Move the C++ API to the {{plugins}} directory. Although the C++ API is a 
> dependency of some plugins, it is itself a consumer of the TS plugin API, so 
> the best place from a build ordering POV is {{plugins}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (TS-4997) Move C++ API to plugins.

2016-10-23 Thread James Peach (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Peach reassigned TS-4997:
---

Assignee: James Peach  (was: Brian Geffon)

> Move C++ API to plugins.
> 
>
> Key: TS-4997
> URL: https://issues.apache.org/jira/browse/TS-4997
> Project: Traffic Server
>  Issue Type: Task
>  Components: CPP API
>Reporter: James Peach
>Assignee: James Peach
>
> Move the C++ API to the {{plugins}} directory. Although the C++ API is a 
> dependency of some plugins, it is itself a consumer of the TS plugin API, so 
> the best place from a build ordering POV is {{plugins}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (TS-4997) Move C++ API to plugins.

2016-10-23 Thread James Peach (JIRA) 
James Peach created TS-4997:
---

 Summary: Move C++ API to plugins.
 Key: TS-4997
 URL: https://issues.apache.org/jira/browse/TS-4997
 Project: Traffic Server
  Issue Type: Task
  Components: CPP API
Reporter: James Peach
Assignee: Brian Geffon


Move the C++ API to the {{plugins}} directory. Although the C++ API is a 
dependency of some plugins, it is itself a consumer of the TS plugin API, so 
the best place from a build ordering POV is {{plugins}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4993) backslash/escape removed from header_rewrite rule when unquoted

2016-10-23 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4993?focusedWorklogId=30969=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30969
 ]

ASF GitHub Bot logged work on TS-4993:
--

Author: ASF GitHub Bot
Created on: 23/Oct/16 18:56
Start Date: 23/Oct/16 18:56
Worklog Time Spent: 10m 
  Work Description: Github user igalic commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1133#discussion_r84601766
  
--- Diff: plugins/header_rewrite/header_rewrite_test.cc ---
@@ -31,274 +33,395 @@ const char PLUGIN_NAME_DBG[] = 
"TEST_dbg_header_rewrite";
 extern "C" void
 TSError(const char *fmt, ...)
 {
-  char buf[2048];
-  int bytes = 0;
-  va_list args;
-  va_start(args, fmt);
-  if ((bytes = vsnprintf(buf, sizeof(buf), fmt, args)) > 0) {
-fprintf(stderr, "TSError: %s: %.*s\n", PLUGIN_NAME, bytes, buf);
-  }
-  va_end(args);
--- End diff --

how does this function work now?


Issue Time Tracking
---

Worklog Id: (was: 30969)
Time Spent: 40m  (was: 0.5h)

> backslash/escape removed from header_rewrite rule when unquoted
> ---
>
> Key: TS-4993
> URL: https://issues.apache.org/jira/browse/TS-4993
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 7.0.0
>Reporter: Randall Meyer
>Assignee: Leif Hedstrom
> Fix For: 7.1.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Loading up a configuration with a header_rewrite rule of:
> {noformat}
> cond %{READ_RESPONSE_HDR_HOOK} [AND]
> cond %{PATH} /(\.html|\.js|\.png)(?:\?(.*))*$/ [AND]
> cond %{STATUS} >199 [AND]
> cond %{STATUS} <300
>   set-header Cache-Control "max-age=31536000, public
> {noformat}
> results in an call to abort() in matcher.h under ATS 7.0.0. This worked fine 
> under ATS 6.x (and probably 5.3.x)
> {noformat}
> (gdb) where
> #0  0x74f64625 in *__GI_raise (sig=) at 
> ../nptl/sysdeps/unix/sysv/linux/raise.c:64
> #1  0x74f65e05 in *__GI_abort () at abort.c:92
> #2  0x7fffe71dd3ff in Matchers::setRegex 
> (this=this@entry=0x7fffe5ac0f80) at matcher.h:98
> #3  0x7fffe71d7baa in Matchers::set (d=..., 
> this=0x7fffe5ac0f80) at matcher.h:119
> #4  ConditionPath::initialize (this=0x7fffe59a6d00, p=...) at 
> conditions.cc:260
> {noformat}
> The string comes to matcher with the escapes removed:
> {noformat}
> Adding condition: %{PATH} with arg: /(.html|.js|.png)(?:?(.*))*$/
> {noformat}
> If I add quotes around the regex, this regex is passed through correctly 
> escaped.
> Not sure if this is expected behavior or not. 
> This also seems related to TS-4797 and TS-4940. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4993) backslash/escape removed from header_rewrite rule when unquoted

2016-10-23 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4993?focusedWorklogId=30968=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30968
 ]

ASF GitHub Bot logged work on TS-4993:
--

Author: ASF GitHub Bot
Created on: 23/Oct/16 18:55
Start Date: 23/Oct/16 18:55
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1133
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1067/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 30968)
Time Spent: 0.5h  (was: 20m)

> backslash/escape removed from header_rewrite rule when unquoted
> ---
>
> Key: TS-4993
> URL: https://issues.apache.org/jira/browse/TS-4993
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 7.0.0
>Reporter: Randall Meyer
>Assignee: Leif Hedstrom
> Fix For: 7.1.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Loading up a configuration with a header_rewrite rule of:
> {noformat}
> cond %{READ_RESPONSE_HDR_HOOK} [AND]
> cond %{PATH} /(\.html|\.js|\.png)(?:\?(.*))*$/ [AND]
> cond %{STATUS} >199 [AND]
> cond %{STATUS} <300
>   set-header Cache-Control "max-age=31536000, public
> {noformat}
> results in an call to abort() in matcher.h under ATS 7.0.0. This worked fine 
> under ATS 6.x (and probably 5.3.x)
> {noformat}
> (gdb) where
> #0  0x74f64625 in *__GI_raise (sig=) at 
> ../nptl/sysdeps/unix/sysv/linux/raise.c:64
> #1  0x74f65e05 in *__GI_abort () at abort.c:92
> #2  0x7fffe71dd3ff in Matchers::setRegex 
> (this=this@entry=0x7fffe5ac0f80) at matcher.h:98
> #3  0x7fffe71d7baa in Matchers::set (d=..., 
> this=0x7fffe5ac0f80) at matcher.h:119
> #4  ConditionPath::initialize (this=0x7fffe59a6d00, p=...) at 
> conditions.cc:260
> {noformat}
> The string comes to matcher with the escapes removed:
> {noformat}
> Adding condition: %{PATH} with arg: /(.html|.js|.png)(?:?(.*))*$/
> {noformat}
> If I add quotes around the regex, this regex is passed through correctly 
> escaped.
> Not sure if this is expected behavior or not. 
> This also seems related to TS-4797 and TS-4940. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...

2016-10-23 Thread igalic 
Github user igalic commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1133#discussion_r84601766
  
--- Diff: plugins/header_rewrite/header_rewrite_test.cc ---
@@ -31,274 +33,395 @@ const char PLUGIN_NAME_DBG[] = 
"TEST_dbg_header_rewrite";
 extern "C" void
 TSError(const char *fmt, ...)
 {
-  char buf[2048];
-  int bytes = 0;
-  va_list args;
-  va_start(args, fmt);
-  if ((bytes = vsnprintf(buf, sizeof(buf), fmt, args)) > 0) {
-fprintf(stderr, "TSError: %s: %.*s\n", PLUGIN_NAME, bytes, buf);
-  }
-  va_end(args);
--- End diff --

how does this function work now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1133: TS-4993: Disables escaping and quotes inside rege...

2016-10-23 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1133
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1067/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4993) backslash/escape removed from header_rewrite rule when unquoted

2016-10-23 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4993?focusedWorklogId=30967=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30967
 ]

ASF GitHub Bot logged work on TS-4993:
--

Author: ASF GitHub Bot
Created on: 23/Oct/16 18:54
Start Date: 23/Oct/16 18:54
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1133
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/959/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 30967)
Time Spent: 20m  (was: 10m)

> backslash/escape removed from header_rewrite rule when unquoted
> ---
>
> Key: TS-4993
> URL: https://issues.apache.org/jira/browse/TS-4993
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 7.0.0
>Reporter: Randall Meyer
>Assignee: Leif Hedstrom
> Fix For: 7.1.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Loading up a configuration with a header_rewrite rule of:
> {noformat}
> cond %{READ_RESPONSE_HDR_HOOK} [AND]
> cond %{PATH} /(\.html|\.js|\.png)(?:\?(.*))*$/ [AND]
> cond %{STATUS} >199 [AND]
> cond %{STATUS} <300
>   set-header Cache-Control "max-age=31536000, public
> {noformat}
> results in an call to abort() in matcher.h under ATS 7.0.0. This worked fine 
> under ATS 6.x (and probably 5.3.x)
> {noformat}
> (gdb) where
> #0  0x74f64625 in *__GI_raise (sig=) at 
> ../nptl/sysdeps/unix/sysv/linux/raise.c:64
> #1  0x74f65e05 in *__GI_abort () at abort.c:92
> #2  0x7fffe71dd3ff in Matchers::setRegex 
> (this=this@entry=0x7fffe5ac0f80) at matcher.h:98
> #3  0x7fffe71d7baa in Matchers::set (d=..., 
> this=0x7fffe5ac0f80) at matcher.h:119
> #4  ConditionPath::initialize (this=0x7fffe59a6d00, p=...) at 
> conditions.cc:260
> {noformat}
> The string comes to matcher with the escapes removed:
> {noformat}
> Adding condition: %{PATH} with arg: /(.html|.js|.png)(?:?(.*))*$/
> {noformat}
> If I add quotes around the regex, this regex is passed through correctly 
> escaped.
> Not sure if this is expected behavior or not. 
> This also seems related to TS-4797 and TS-4940. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1133: TS-4993: Disables escaping and quotes inside rege...

2016-10-23 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1133
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/959/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4993) backslash/escape removed from header_rewrite rule when unquoted

2016-10-23 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-4993?focusedWorklogId=30966=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30966
 ]

ASF GitHub Bot logged work on TS-4993:
--

Author: ASF GitHub Bot
Created on: 23/Oct/16 18:41
Start Date: 23/Oct/16 18:41
Worklog Time Spent: 10m 
  Work Description: GitHub user zwoop opened a pull request:

https://github.com/apache/trafficserver/pull/1133

TS-4993: Disables escaping and quotes inside regexes

In addition, this cleans up the unit tests a bit, to make it more useful 
from
the command line when testing/debugging. New tests are also added for 
regular
expression parse testing.

Note: This restores 6.1.x functionality in 7.x, however, it's not 
compatible with 5.3.x. I do feel that this is the right approach, because it 
retains PCRE compatibility within the // that indicates a regex.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zwoop/trafficserver TS-4993

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1133.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1133


commit 75757f3eb4a50d1c80997356e6df2d001e32d360
Author: Leif Hedstrom 
Date:   2016-10-22T01:18:43Z

TS-4993: Disables escaping and quotes inside regexes

In addition, this cleans up the unit tests a bit, to make it more useful 
from
the command line when testing/debugging. New tests are also added for 
regular
expression parse testing




Issue Time Tracking
---

Worklog Id: (was: 30966)
Time Spent: 10m
Remaining Estimate: 0h

> backslash/escape removed from header_rewrite rule when unquoted
> ---
>
> Key: TS-4993
> URL: https://issues.apache.org/jira/browse/TS-4993
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Affects Versions: 7.0.0
>Reporter: Randall Meyer
>Assignee: Leif Hedstrom
> Fix For: 7.1.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Loading up a configuration with a header_rewrite rule of:
> {noformat}
> cond %{READ_RESPONSE_HDR_HOOK} [AND]
> cond %{PATH} /(\.html|\.js|\.png)(?:\?(.*))*$/ [AND]
> cond %{STATUS} >199 [AND]
> cond %{STATUS} <300
>   set-header Cache-Control "max-age=31536000, public
> {noformat}
> results in an call to abort() in matcher.h under ATS 7.0.0. This worked fine 
> under ATS 6.x (and probably 5.3.x)
> {noformat}
> (gdb) where
> #0  0x74f64625 in *__GI_raise (sig=) at 
> ../nptl/sysdeps/unix/sysv/linux/raise.c:64
> #1  0x74f65e05 in *__GI_abort () at abort.c:92
> #2  0x7fffe71dd3ff in Matchers::setRegex 
> (this=this@entry=0x7fffe5ac0f80) at matcher.h:98
> #3  0x7fffe71d7baa in Matchers::set (d=..., 
> this=0x7fffe5ac0f80) at matcher.h:119
> #4  ConditionPath::initialize (this=0x7fffe59a6d00, p=...) at 
> conditions.cc:260
> {noformat}
> The string comes to matcher with the escapes removed:
> {noformat}
> Adding condition: %{PATH} with arg: /(.html|.js|.png)(?:?(.*))*$/
> {noformat}
> If I add quotes around the regex, this regex is passed through correctly 
> escaped.
> Not sure if this is expected behavior or not. 
> This also seems related to TS-4797 and TS-4940. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...

2016-10-23 Thread zwoop 
GitHub user zwoop opened a pull request:

https://github.com/apache/trafficserver/pull/1133

TS-4993: Disables escaping and quotes inside regexes

In addition, this cleans up the unit tests a bit, to make it more useful 
from
the command line when testing/debugging. New tests are also added for 
regular
expression parse testing.

Note: This restores 6.1.x functionality in 7.x, however, it's not 
compatible with 5.3.x. I do feel that this is the right approach, because it 
retains PCRE compatibility within the // that indicates a regex.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zwoop/trafficserver TS-4993

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1133.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1133


commit 75757f3eb4a50d1c80997356e6df2d001e32d360
Author: Leif Hedstrom 
Date:   2016-10-22T01:18:43Z

TS-4993: Disables escaping and quotes inside regexes

In addition, this cleans up the unit tests a bit, to make it more useful 
from
the command line when testing/debugging. New tests are also added for 
regular
expression parse testing




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---