Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1520#discussion_r104270172
--- Diff: proxy/http/HttpTransactHeaders.cc ---
@@ -741,26 +741,14 @@
HttpTransactHeaders::insert_via_header_in_request(HttpTransact::State *s,
Github user SolidWallOfCode closed the pull request at:
https://github.com/apache/trafficserver/pull/1495
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/1515
@jpeach: sounds like right thing to do, needed a quick fix, will find some
time to make the API less error-prone.
@zwoop: sir, yes, sir!
---
If your project is set up for it, you can
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/issues/1532
Any indication of object buildup in a particular type of object pool?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user bryancall opened an issue:
https://github.com/apache/trafficserver/issues/1532
ATS 7.1 release running out of memory
Here is a backtrace from a bunch of cores I am getting from 7.1. They are
mostly issues with memory allocation:
[bcall@e24 ~]$ egrep '\#2 |\#3 |\#4
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/issues/1531
Oh, nevermind. I saw vio = NULL in the stack, but that is the local
variable.
That makes sense that the event would be passing up the write via. It is a
write event we are
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1531
Hmmm, I see
```
(gdb) frame 4
#4 0x0064dbac in HttpSM::state_read_server_response_header
(this=0x2aaab2ecc300, event=3, data=0x2aaadfe10fe0) at HttpSM.cc:1811
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/issues/1531
The server_entry->read_vio is NULL. From what I can tell this value only
gets set due to do_io_read() calls in attach_server_session() and
setup_server_read_response_header().
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1531
Assertion in state_read_server_response_header (v7.1.0)
Seeing this on docs (infrequently):
```
(gdb) bt full
#0 0x757b21d7 in __GI_raise (sig=sig@entry=6) at
Github user ushachar commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1473#discussion_r104184151
--- Diff: proxy/http/HttpTransact.cc ---
@@ -7845,10 +7845,12 @@ HttpTransact::build_request(State *s, HTTPHdr
*base_request, HTTPHdr *outgoing_r
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1510
Otherwise it looks reasonable to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1510
I wonder why we haven't seen this before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1495
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/227/ for details.
---
If your project is set up for it, you can reply to this email
GitHub user mingzym opened an issue:
https://github.com/apache/trafficserver/issues/1530
lib/bindings fail to build with system lua.h installed
```
make[4]: Nothing to be done for `all-am'.
Making all in bindings
CXX lua.lo
CXX bindings.lo
CXX
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1495
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/95/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1495
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1559/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1495
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1663/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/issues/1476
Still struggling with this issue. Running into it every 2-4 hours in
production. At this point, I think it is a use-after-free, but as noted avoid
ASAN fails in this case.
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/issues/1498
Actually it looks like the issue is just tracking down the particular issue
in #1476 / #1480.
I enabled ASAN while merging in another issue, and it caught the double
free in
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/issues/1529
Are you sure you're using the right codebase? This builds on the CI FreeBSD
and I can see the declaration of `Transaction::setEvent`
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/issues/1527
So do you think this is making a real performance difference? Or are we
just not timing out connections as quickly now?
I hadn't noticed a difference in number of active
Github user shinrich closed the pull request at:
https://github.com/apache/trafficserver/pull/1526
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/1526
Yes, I suppose since it is a latent issue and not a regression it doesn't
need to be in the 7.1 train. We will separately pull it into our version. Set
version to 7.2
---
If your
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1526
Ship it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user oknet closed the pull request at:
https://github.com/apache/trafficserver/pull/1511
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user mingzym opened an issue:
https://github.com/apache/trafficserver/issues/1529
cppapi broken building on FreeBSD 11
```
gmake[3]: Entering directory '/usr/home/zym/traffic/lib/cppapi'
CXX AsyncHttpFetch.lo
CXX GlobalPlugin.lo
CXX
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/1522
or we can use:
```
if (vc->write.enabled && vc->write.triggered || vc->write.error &&
vc->write.vio._cont != nullptr)
```
keep old condition then add new condition.
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/1522
to review #947 again, my suggestion is
```
diff --git a/iocore/net/UnixNet.cc b/iocore/net/UnixNet.cc
index 85d7527..5ef65cb 100644
--- a/iocore/net/UnixNet.cc
+++
28 matches
Mail list logo
