[GitHub] trafficserver pull request #1623: Delete dead code

Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1623#discussion_r109090078 --- Diff: proxy/logging/LogBuffer.cc --- @@ -112,14 +112,6 @@ LogBufferHeader::log_filename() return addr; }

[GitHub] trafficserver issue #1622: Delete proxy/AbstractBuffer.{cc,h}

Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1622 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] trafficserver issue #1622: Delete proxy/AbstractBuffer.{cc,h}

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1622 Dupe of #1623. Please don't file a PR and Issue at the same time. You only need an issue if you don't have code. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1623: Delete dead code

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1623 clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/382/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1623: Delete dead code

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1623 clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/381/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1623: Delete dead code

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1623 Linux build *successful*! https://ci.trafficserver.apache.org/job/linux-github/1711/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1623: Delete dead code

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1623 FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1820/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1623: Delete dead code

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1623 Intel CC build *successful*! https://ci.trafficserver.apache.org/job/icc-github/250/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1623: Delete dead code

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1623 Linux build *successful*! https://ci.trafficserver.apache.org/job/linux-github/1710/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1623: Delete dead code

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1623 AU check *successful*! https://ci.trafficserver.apache.org/job/autest-github/121/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1623: Delete dead code

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1623 Intel CC build *successful*! https://ci.trafficserver.apache.org/job/icc-github/249/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1623: Delete dead code

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1623 AU check *successful*! https://ci.trafficserver.apache.org/job/autest-github/120/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1623: Delete dead code

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1623 FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1819/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1623: Delete dead code

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1623 clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/124/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1623: Delete dead code

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1623 RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/138/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1623: Delete dead code

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1623 RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/137/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1623: Delete dead code

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1623 clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/123/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver pull request #1623: Delete dead code

GitHub user danobi opened a pull request: https://github.com/apache/trafficserver/pull/1623 Delete dead code None of this code was being called or used elsewhere. Most likely some point before git history someone migrated off the abstract base class and never bothered to

[GitHub] trafficserver issue #1622: Delete proxyAbstractBuffer.{cc,h}

GitHub user danobi opened an issue: https://github.com/apache/trafficserver/issues/1622 Delete proxyAbstractBuffer.{cc,h} These files are never used, despite the fact that other comments seem to indicate otherwise. Just another day in the logging subsystem, I guess.

Build failed in Jenkins: ubuntu_16_04-master » gcc,ubuntu_16_04,release #654

See -- [...truncated 1.67 MB...] make[2]: Nothing to be done for 'check-am'. make[2]: Leaving directory

Build failed in Jenkins: fedora_24-master » gcc,fedora_24,release #422

See -- [...truncated 25.71 KB...] checking sys/disk.h presence... no checking for sys/disk.h... no checking sys/disklabel.h

[GitHub] trafficserver pull request #1621: Clean up globalregisterplugin

Github user SolidWallOfCode closed the pull request at: https://github.com/apache/trafficserver/pull/1621 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver issue #1621: Clean up globalregisterplugin

Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1621 Looks good. Thanks @persiaAziz. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver issue #1568: TS-4195: double free on exit

Github user zizhong commented on the issue: https://github.com/apache/trafficserver/pull/1568 @bryancall , @zwoop , ping you guys since this PR opened for a long while. We landed this fix in Linkedin several weeks ago. It works great. No more annoying crashes when we do

[GitHub] trafficserver issue #1557: brotli support in gzip plugin

Github user myraid commented on the issue: https://github.com/apache/trafficserver/pull/1557 @bryancall I removed the enforce-brotli config option. Squashed all the commits. Can you review and approve. --- If your project is set up for it, you can reply to this email and

[GitHub] trafficserver issue #1621: Clean up globalregisterplugin

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1621 clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/380/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1621: Clean up globalregisterplugin

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1621 Intel CC build *successful*! https://ci.trafficserver.apache.org/job/icc-github/248/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1621: Clean up globalregisterplugin

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1621 Linux build *successful*! https://ci.trafficserver.apache.org/job/linux-github/1709/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1621: Clean up globalregisterplugin

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1621 FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1818/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1621: Clean up globalregisterplugin

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1621 AU check *successful*! https://ci.trafficserver.apache.org/job/autest-github/119/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1621: Clean up globalregisterplugin

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1621 RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/136/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1621: Clean up globalregisterplugin

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1621 clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/122/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver pull request #1621: Clean up globalregisterplugin

GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/1621 Clean up globalregisterplugin You can merge this pull request into a Git repository by running: $ git pull https://github.com/persiaAziz/trafficserver regglobalPlugin