Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/825
Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/826
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/753#discussion_r72400929
--- Diff: iocore/net/I_NetVConnection.h ---
@@ -40,6 +40,13 @@
#define SSL_EVENT_SERVER 0
#define SSL_EVENT_CLIENT 1
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/828
TS-4645: traffic_top doesn't start
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4645
Alternatively you
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/793
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/794
The length of the file is 256 in the dirent structure. All the OSes we
support fall within that size.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/794
Here is a good list on the limits of filename sizes:
https://en.wikipedia.org/wiki/Comparison_of_file_systems#Limits
---
If your project is set up for it, you can reply to this email
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/794
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/826
TS-3620: Enable HTTP/2 by default
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-3620
Alternatively you
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/828
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/761
Having a throttling setting to work would mean that it would need to be
lower then the combination of the incoming and outgoing connection settings. I
think it is confusing to have another
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/847#discussion_r74278773
--- Diff: proxy/http2/Http2Stream.cc ---
@@ -509,7 +509,7 @@ Http2Stream::update_write_request(IOBufferReader
*buf_reader, int64_t write_len
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/857
Yeah, I started down the path of disable_read() and disable_write(), then
ran into having to implemented the methods in multiple locations (pluginvc)
when declaring them pure virtual
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/864#discussion_r74672814
--- Diff: proxy/http/HttpTransact.cc ---
@@ -4785,27 +4785,34 @@
HttpTransact::merge_and_update_headers_for_cache_update(State *s
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/857
TS-4732: Changing the do_io_read API so it can be called with NULL and
0 byte values. Allowing do_io_read and do_io_write to not warn on closed
connection when we are only trying
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/794
TS-4652: ASAN issue in logging with gcc 6.1.1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4652
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/771#discussion_r71292554
--- Diff: iocore/net/UnixNetVConnection.cc ---
@@ -1304,9 +1305,10 @@ UnixNetVConnection::connectUp(EThread *t, int fd)
SET_HANDLER
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/762#discussion_r71290755
--- Diff: proxy/http/HttpConfig.cc ---
@@ -809,6 +809,8 @@ register_stat_callbacks()
(int)https_incoming_requests_stat
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/761
I don't think it is a good idea to add another configuration value for
limiting connections. We already have proxy.config.net.max_connections_in for
limiting the number of connections
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/771#discussion_r71293917
--- Diff: iocore/net/UnixNet.cc ---
@@ -465,6 +433,9 @@ NetHandler::mainNetEvent(int event, Event *e)
epd = (EventIO *)get_ev_data(pd, x
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/798
@shukitchan Overall it looks good. I had one minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/813
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/798#discussion_r71495348
--- Diff: plugins/experimental/esi/lib/Variables.cc ---
@@ -357,9 +357,25 @@ Variables::_parseCookieString(const char *str, int
str_len
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/771#discussion_r71490006
--- Diff: iocore/net/UnixNet.cc ---
@@ -465,6 +433,9 @@ NetHandler::mainNetEvent(int event, Event *e)
epd = (EventIO *)get_ev_data(pd, x
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/771#discussion_r71512654
--- Diff: iocore/net/UnixNet.cc ---
@@ -465,6 +433,9 @@ NetHandler::mainNetEvent(int event, Event *e)
epd = (EventIO *)get_ev_data(pd, x
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/793
TS-4651: ASAN issue with gcc 6.1.1
Changed the way the atomic swap is being done
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/771
@zwoop Yes, this should be merged after the clang-format.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/864
@jpeach I would be OK with deleting the Expires header, but I think we
should keep the Cache-Control, Last-Modified, and Vary.
---
If your project is set up for it, you can reply
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/351
Looking over the pull request I didn't see any limits on how much is going
to be buffered on the server. It might be good to start the transfer to the
origin once a configurable limite
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/868
ð - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/858
Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/864
ð - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1398#discussion_r99876962
--- Diff: cmd/traffic_top/Makefile.am ---
@@ -17,13 +17,13 @@
# We only build traffic_top if libcurses and libcurl are available
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1398#discussion_r99880264
--- Diff: configure.ac ---
@@ -220,6 +220,22 @@ AC_ARG_ENABLE([fast-sdk],
AC_MSG_RESULT([$enable_fast_sdk])
TS_ARG_ENABLE_VAR([use], [fast
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1401
(gdb) bt full
#0 0x005150b0 in Mutex_trylock (m=0x0, t=0x2b44f3a6d010)
at
/home/bcall/dev/yahoo/build/_build/ats_build/../../trafficserver/iocore/eventsystem/I_Lock.h
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1398
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1403
This is the PR for this issue: #1404
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1412
The event is VC_EVENT_INACTIVITY_TIMEOUT (value 105) when it asserts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1401
What does the vc look like?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1349#discussion_r97462157
--- Diff: iocore/net/OCSPStapling.cc ---
@@ -290,7 +294,7 @@ process_responder(OCSP_REQUEST *req, char *host, char
*path, char *port, int req
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1361
ð - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1361
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1272
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/871#discussion_r97472812
--- Diff: proxy/http/HttpTransact.cc ---
@@ -8059,12 +8059,8 @@ HttpTransact::build_response(State *s, HTTPHdr
*base_response, HTTPHdr *outgoing
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/871
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/871
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1180
I had to manually commit it via the command line because it didn't have an
updated clang-format.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1272
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1370
Please don't create issues if you have a PR for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1364
TS-2157 pull request: #182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/588
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/761
I haven't seen an update to this PR for awhile. I will close it in a week
if it hasn't been updated.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/351
I haven't seen an update to this PR for awhile. I will close it in a week
if it hasn't been updated.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/210
I haven't seen an update to this PR for awhile. I will close it in a week
if it hasn't been updated.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1364
ð - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1364
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1245
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1180
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1309
@jablko It looks like there is going to be a merge conflict if you commit
this and then #1313. That is what I am seeing when I am testing it on my
server:
patching file example
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/1373
#1279 - CID 1367531: Uninitialized members (UNINIT_CTOR): proxy/main.cc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1391
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/761
Please reopen or create a new pull request if you still want to resolve
this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/761
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/210
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/210
Please reopen or create another pull request if you want to resolve this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1391
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1391
Please run clang-format on the code. It is not passing CI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1248
Please squash commits before merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1391
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/1398
Configure option to disable CURL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver no_curl
Alternatively you
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1391
Still needs a clang-format. I will merge it and clang-format it once it is
committed.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1391
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1341
This has been resloved
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bryancall closed the issue at:
https://github.com/apache/trafficserver/issues/1341
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1344
@brkishore Only committers can have issues assigned to them. It is a
limitation of GitHub.
Please submit a PR for it once you have a fix. Thank you!
---
If your project
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1373
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1275
Please make sure pull requests are reviewed before merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bryancall closed the issue at:
https://github.com/apache/trafficserver/issues/1283
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/1380
Fixed issue where somaxconn was being set to 0 on OSX and preventing
ATS to work
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1279
This was closed in PR #1279
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bryancall closed the issue at:
https://github.com/apache/trafficserver/issues/1279
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1380
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1349
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1465
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1458
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1465
@dragon512
I am seeing some errors when running the tests:
```
Total of 15 test
Unknown: 0
Exception: 0
Failed: 10
Warning: 0
kipped: 2
Passed: 3
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1456
Why are there tsconfig changes with this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1454
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/1458
Removed spaces at the end of the line on all files
Removed spaces at the end of the line on all files doing:
`find . -type f | grep -v '\.git' | xargs -n1 perl -pi -e 's/\s+\n$/\n
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/1454
Updates to the help output for tsxs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver tsxs_help
Alternatively
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1454
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1444
This is the same type of hack I described in our Monday meeting. I don't
think it is worth committing it. Tracking down what why this is broken and
having a permanent fix would
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1294
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1309#discussion_r96547120
--- Diff: example/cppapi/websocket/WSBuffer.cc ---
@@ -157,7 +157,7 @@ WSBuffer::read_buffered_message(std::string ,
int )
std::string
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1309
Is this pull request needed anymore after #1313 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/881
ð - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/856#discussion_r75507271
--- Diff: proxy/http/HttpSM.cc ---
@@ -4865,12 +4865,13 @@ HttpSM::do_http_server_open(bool raw)
md5_ctx.hash_immediate(hostname_hash
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/877#discussion_r75506303
--- Diff: plugins/experimental/header_freq/header_freq.cc ---
@@ -0,0 +1,260 @@
+/** @file
+
+ This plugin counts the number of times
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/867
ð - Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/351#discussion_r74867804
--- Diff: plugins/request_buffer/request_buffer.cc ---
@@ -0,0 +1,119 @@
+/* request_buffer.cc - Plugin to enable request buffer for the given
1 - 100 of 344 matches
Mail list logo
