[GitHub] trafficserver issue #1557: brotli support in gzip plugin
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1557 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1624: Http transaction debugging feature
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1624 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1557: brotli support in gzip plugin
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1557 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1557: brotli support in gzip plugin
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1557 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1557: brotli support in gzip plugin
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1557 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1568: TS-4195: double free on exit
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1568 Looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1568: TS-4195: double free on exit
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/1568 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1624: Http transaction debugging feature
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1624 It would be better to make these normal transaction hooks and use the TSHttpHookAdd() function to add the hook. Then you can use the normal plugin.config to load the plugin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1557: brotli support in gzip plugin
Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1557#discussion_r108756464 --- Diff: doc/admin-guide/plugins/gzip.en.rst --- @@ -141,6 +141,26 @@ will leave the header intact if the client provided it. - For when the proxy parses responses, and the resulting compression and decompression is wasteful. +supported-algorithms +-- + +Provides the compression algorithms that are supported. This will allow the proxy to selectively +support certain compressions. The default is gzip. Multiple algorthims can be selected using ',' delimiter + +-- To selectively support only certain compression algorithms. + +enforce-brotli --- End diff -- Also, please squash the commits --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1557: brotli support in gzip plugin
Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1557#discussion_r108756275 --- Diff: doc/admin-guide/plugins/gzip.en.rst --- @@ -141,6 +141,26 @@ will leave the header intact if the client provided it. - For when the proxy parses responses, and the resulting compression and decompression is wasteful. +supported-algorithms +-- + +Provides the compression algorithms that are supported. This will allow the proxy to selectively +support certain compressions. The default is gzip. Multiple algorthims can be selected using ',' delimiter + +-- To selectively support only certain compression algorithms. + +enforce-brotli --- End diff -- We should rip out enforce-brotli configuration option the same can be done with multiple configs like the example below. We might want to add an allow feature and use the ! syntax like other options, but we can add that later. ``` [s.yimg.com] remove-accept-encoding true enabled true flush true compressible-content-type text/* disallow *.js disallow *.css supported-algorithms gzip [s.yimg.com] remove-accept-encoding true enabled true flush true compressible-content-type text/* supported-algorithms br ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1557: brotli support in gzip plugin
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1557 We should rip out enforce-brotli configuration option the same can be done with multiple configs like the example below. We might want to add an allow feature and use the ! syntax like other options. but we can add that later. ``` [s.yimg.com] remove-accept-encoding true enabled true flush true compressible-content-type text/* disallow *.js disallow *.css supported-algorithms gzip [s.yimg.com] remove-accept-encoding true enabled true flush true compressible-content-type text/* supported-algorithms br ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1557: brotli support in gzip plugin
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1557 @myraid There was an issue with my build. I got it working. It would would be great to have debug and error warnings if you haven't built it with brotli and have it configured that way. I am sure others will run into this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1612: Changed some of the HTTP/2 enums to enum c...
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/1612 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1611: Convert HPACK enums to enum classes
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/1611 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1557: brotli support in gzip plugin
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1557 I am testing out the plugin with this configuration and I am not getting to to compress using Brotli: ``` [bcall@C02R70EHG8WP-lm ~]$ tail -1 /usr/local/etc/trafficserver/plugin.config gzip.so /usr/local/etc/trafficserver/gzip.config [bcall@C02R70EHG8WP-lm ~]$ tail -1 /usr/local/etc/trafficserver/remap.config map / https://s.yimg.com/ [bcall@C02R70EHG8WP-lm ~]$ cat /usr/local/etc/trafficserver/gzip.config # Enforces brotli compression for javascript and css files [www.yahoo.com] remove-accept-encoding true enabled true flush true supported-algorithms bz compressible-content-type text/* enforce-brotli *.js enforce-brotli *.css [bcall@C02R70EHG8WP-lm ~]$ curl -H 'Host: s.yimg.com' -H 'accept-encoding: br' -s -o /dev/null -D - 'http://127.0.0.1:8080/zz/combo?/os/stencil/3.1.0/styles-ltr.css&/os/yc/css/bundle.c60a6d54.css' HTTP/1.1 200 OK Vary: Accept-Encoding Last-Modified: Wed, 08 Feb 2017 01:24:18 GMT Content-Type: text/css Expires: Fri, 03 Feb 2034 01:51:59 GMT Cache-Control: max-age=536112000, public Date: Wed, 08 Feb 2017 01:24:18 GMT Age: 4138271 Content-Length: 115395 Via: http/1.0 c1.ycs.bf1.yahoo.com (ApacheTrafficServer [cRs f ]), https/1.1 e19.ycpi.cha.yahoo.com (ApacheTrafficServer [cRs f ]) Server: ATS/7.2.0 Connection: keep-alive ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1557: brotli support in gzip plugin
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1557 Wouldn't it better to have an configuration such as: ``` compressible-path /this/*.js compressible-path /this/*.css # with supported-algothims br vs enforce-brotli /this/*.js enforce-brotli /this/*.css I am not a big fan of having algorithm specific configuration options. ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1557: brotli support in gzip plugin
Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1557#discussion_r108296389 --- Diff: doc/admin-guide/plugins/gzip.en.rst --- @@ -162,6 +182,32 @@ might create a configuration with the following options:: disallow /notthis/*.js flush true +# Allows brotli encoded response from origin but is not capable of brotli compression +[brotli.allowed.com] +enabled true +compressible-content-type text/* +compressible-content-type application/json +flush true +supported-algothims gzip,deflate --- End diff -- spelling mistake "supported-algothims" should be "supported-algorithms" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1557: brotli support in gzip plugin
Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1557#discussion_r108296418 --- Diff: doc/admin-guide/plugins/gzip.en.rst --- @@ -162,6 +182,32 @@ might create a configuration with the following options:: disallow /notthis/*.js flush true +# Allows brotli encoded response from origin but is not capable of brotli compression +[brotli.allowed.com] +enabled true +compressible-content-type text/* +compressible-content-type application/json +flush true +supported-algothims gzip,deflate + +# Enforces brotli compression for javascript and css files +[brotli.enforce.com] +enabled true +compressible-content-type text/* +compressible-content-type application/json +flush true +supported-algothims gzip --- End diff -- spelling mistake "supported-algothims" should be "supported-algorithms" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1557: brotli support in gzip plugin
Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1557#discussion_r108296435 --- Diff: doc/admin-guide/plugins/gzip.en.rst --- @@ -162,6 +182,32 @@ might create a configuration with the following options:: disallow /notthis/*.js flush true +# Allows brotli encoded response from origin but is not capable of brotli compression +[brotli.allowed.com] +enabled true +compressible-content-type text/* +compressible-content-type application/json +flush true +supported-algothims gzip,deflate + +# Enforces brotli compression for javascript and css files +[brotli.enforce.com] +enabled true +compressible-content-type text/* +compressible-content-type application/json +flush true +supported-algothims gzip +enforce-brotli /this/*.js +enforce-brotli /this/*.css + +# Supports brotli compression +[brotli.enforce.com] +enabled true +compressible-content-type text/* +compressible-content-type application/json +flush true +supported-algothims br, gzip --- End diff -- spelling mistake "supported-algothims" should be "supported-algorithms" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1612: Changed some of the HTTP/2 enums to enum c...
GitHub user bryancall opened a pull request: https://github.com/apache/trafficserver/pull/1612 Changed some of the HTTP/2 enums to enum classes and found a bug found a bug in is_client_state_writeable() You can merge this pull request into a Git repository by running: $ git pull https://github.com/bryancall/trafficserver http2_enum_class Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1612.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1612 commit 45dcbd5d72d90ad3b77bda97ccc7e4a1451cd3b8 Author: Bryan Call <bc...@apache.org> Date: 2017-03-24T16:41:12Z Changed some of the HTTP/2 enums to enum classes and found a comparison bug in is_client_state_writeable() --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1611: Convert HPACK enums to enum classes
GitHub user bryancall opened a pull request: https://github.com/apache/trafficserver/pull/1611 Convert HPACK enums to enum classes You can merge this pull request into a Git repository by running: $ git pull https://github.com/bryancall/trafficserver hpack_enum_class Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1611.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1611 commit 9b8de2ebfb1c1c6a3aa19fb59e149cc4da91d2be Author: Bryan Call <bc...@apache.org> Date: 2017-03-24T16:02:43Z Convert HPACK enums to enum classes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1600: fix , remove not used array buf in rcv_dat...
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/1600 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1600: fix , remove not used array buf in rcv_data_frame...
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1600 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1573: #1481 Makes % work consistently, and...
Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1573#discussion_r105754317 --- Diff: proxy/logging/LogAccessHttp.cc --- @@ -71,7 +71,7 @@ LogAccessHttp::LogAccessHttp(HttpSM *sm) m_proxy_resp_content_type_str(nullptr), m_proxy_resp_content_type_len(0), m_cache_lookup_url_canon_str(nullptr), -m_cache_lookup_url_canon_len(0) +m_cache_lookup_url_canon_len(-1) --- End diff -- Yeah, it would be better to do it in another PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1532: ATS 7.1 release running out of memory
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1532
Information from 7.0.0 release running in production on the same server:
```
[bcall@e24 crash]$ ss -tn | awk '{print $4}' | grep -c ':80$' ; ss -tn |
awk '{print $4}' | grep -c ':443$'; traffic_ctl metric get
proxy.process.net.connections_currently_open; traffic_ctl metric match
current_client_sessions; traffic_ctl metric match
http.current_client_connections; grep HttpSM.cc:6485
/home/y/logs/trafficserver/traffic.out; ss -s
2658
54005
proxy.process.net.connections_currently_open 78128
proxy.process.http2.current_client_sessions 37296
proxy.process.http.current_client_connections 14835
7748180 |7669410 | 2563600384 | 32545 |
memory/IOBuffer/../../../../trafficserver/proxy/http/HttpSM.cc:6485
27926828 | 27884703 | 1371799552 | 32564 |
memory/IOBuffer/../../../../trafficserver/proxy/http/HttpSM.cc:6485
30031206 | 2975 | 1009647616 | 32328 |
memory/IOBuffer/../../../../trafficserver/proxy/http/HttpSM.cc:6485
33306877 | 33252469 | 1767923712 | 32493 |
memory/IOBuffer/../../../../trafficserver/proxy/http/HttpSM.cc:6485
87611972 | 87588769 |752799744 | 32444 |
memory/IOBuffer/../../../../trafficserver/proxy/http/HttpSM.cc:6485
Total: 63568 (kernel 65390)
TCP: 97209 (estab 63217, closed 31012, orphaned 2935, synrecv 0, timewait
31012/0), ports 17009
Transport Total IPIPv6
* 65390 - -
RAW 0 0 0
UDP 281216
TCP 66197 50229 15968
INET 66225 50241 15984
FRAG 0 0 0
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1532: ATS 7.1 release running out of memory
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/issues/1532 The problem I am seeing with 7.1 has to do with http2 client sessions not closing and releasing the `MIOBuffer`. I am running a test with 7.0.0 and seeing if the issue was there too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1573: #1481 Makes % work consistently, and...
Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1573#discussion_r105724614 --- Diff: proxy/logging/LogAccessHttp.cc --- @@ -71,7 +71,7 @@ LogAccessHttp::LogAccessHttp(HttpSM *sm) m_proxy_resp_content_type_str(nullptr), m_proxy_resp_content_type_len(0), m_cache_lookup_url_canon_str(nullptr), -m_cache_lookup_url_canon_len(0) +m_cache_lookup_url_canon_len(-1) --- End diff -- Should have consistency on the len initialization values. Set them all to -1? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1571: StringView should be made compatible with std::st...
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/issues/1571 ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1567: Diags scrubbing mechanism
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1567 Please swash the commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1566: Fix build by ordering the linked libraries...
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/1566 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1557: brotli support in gzip plugin
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1557 @myraid I can see cases where someone might not want to spend the CPU resources on Brotli compression, but doesn't mind if the origin does Broli encoding. The plugin would compress the response from the origin using certain algorithms. The configuration option would be something like: algorithms deflate,gzip,brotli It would really be nice to enable Brotli on certain content types (e.g. text/javascript) that are static and not on types that would be more dynamic (e.g. text/html). Unfortunately the configuration doesn't easily lend itself to this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1566: Fix build by ordering the linked libraries.
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1566 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1557: brotli support in gzip plugin
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1557 It looks like brotli is on by default? It would be nice to have an option on what types of compression algorithms that you want to enable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1557: brotli support in gzip plugin
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1557#discussion_r105279083
--- Diff: plugins/gzip/gzip.cc ---
@@ -95,18 +104,29 @@ gzip_data_alloc(int compression_type)
}
}
+ if(compression_type == COMPRESSION_TYPE_BROTLI) {
+ debug("gzip-transform: brotli compression. Create Brotli Encoder
Instance.");
--- End diff --
Please clang-format over the change. gmake clang-format.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1532: ATS 7.1 release running out of memory
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1532
There is an issue with the number of real TCP connections, the stats that
keeps track of the number of current client connections, and the number of
http2 client sessions. All of them disagree:
```
[bcall@e24 ~]$ ss -tn | awk '{print $4}' | grep -c :80 ; ss -tn | awk
'{print $4}' | grep -c :443; traffic_ctl metric get
proxy.process.net.accepts_currently_open; traffic_ctl metric match
current_client_sessions
253
1364
proxy.process.net.accepts_currently_open 9
proxy.process.http2.current_client_sessions 41804
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1456 We should have a metric that tracks the total number of accepts at the TCP layer. I recommend that the name be inline with the current metrics `proxy.process.net.total_accepts` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1557: brotli support in gzip plugin
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1557 Added the requirements here: ``` Here are the requirements for supporting brotli encoding. If the Accept-Encoding has brotli, then the normalize AE should pick up brotli. (Should we send both "br" and "gzip" in AE? If the response is already encoded then do nothing. Should we have a configuration to force brotli encode the response? If the response is unencoded and if Accept-Encoding has brotli then encode using brotli. ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1555: Support for brotli in gzip plugin.
Github user bryancall closed the issue at: https://github.com/apache/trafficserver/issues/1555 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1555: Support for brotli in gzip plugin.
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/issues/1555 @myraid Issues don't need to be created if there is a PR for it. The PR for it is: #1557 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1556: Force use of python3 for microserver
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/1556 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1522: Ignore read and write errors if vio has be...
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/1522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1544: AddressSanitizer failed to deallocate
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/issues/1544 What version are you running? I am seeing the same errors with 7.1.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1522 @scw00 What are `server_entry->read_vio` and `data` set to when it asserts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1522 Running the current PR under gdb with this macro to see if the optimization in the patch above would work. I don't think there is a case where error is set and triggered is not gdb macro: ``` handle SIGPIPE nostop handle SIGPIPE noprint break UnixNet.cc:508 if (!vc->read.triggered && vc->read.error) break UnixNet.cc:525 if (!vc->write.triggered && vc->write.error) cont p vc->read.triggered p vc->read.enabled p vc->read.error p vc->write.triggered p vc->write.enabled p vc->write.error ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1522
I updated the PR to use oknet's recommendation. I am going to test a
another version of this fix to be:
```
diff --git a/iocore/net/UnixNet.cc b/iocore/net/UnixNet.cc
index 85d7527..636b9a2 100644
--- a/iocore/net/UnixNet.cc
+++ b/iocore/net/UnixNet.cc
@@ -505,7 +505,7 @@ NetHandler::mainNetEvent(int event, Event *e)
set_cont_flags(vc->control_flags);
if (vc->closed)
close_UnixNetVConnection(vc, trigger_event->ethread);
-else if ((vc->read.enabled || vc->read.error) && vc->read.triggered)
+else if (vc->read.enabled && vc->read.triggered || vc->read.error &&
vc->read.vio._cont != nullptr)
vc->net_read_io(this, trigger_event->ethread);
else if (!vc->read.enabled) {
read_ready_list.remove(vc);
@@ -522,7 +522,7 @@ NetHandler::mainNetEvent(int event, Event *e)
set_cont_flags(vc->control_flags);
if (vc->closed)
close_UnixNetVConnection(vc, trigger_event->ethread);
-else if ((vc->write.enabled || vc->write.error) && vc->write.triggered)
+else if (vc->write.enabled && vc->write.triggered || vc->write.error
&& vc->write.vio._cont != nullptr)
write_to_net(this, vc, trigger_event->ethread);
else if (!vc->write.enabled) {
write_ready_list.remove(vc);
@@ -540,7 +540,7 @@ NetHandler::mainNetEvent(int event, Event *e)
diags->set_override(vc->control.debug_override);
if (vc->closed)
close_UnixNetVConnection(vc, trigger_event->ethread);
-else if ((vc->read.enabled || vc->read.error) && vc->read.triggered)
+else if (vc->read.enabled && vc->read.triggered || vc->read.error &&
vc->read.vio._cont != nullptr)
vc->net_read_io(this, trigger_event->ethread);
else if (!vc->read.enabled)
vc->ep.modify(-EVENTIO_READ);
@@ -549,7 +549,7 @@ NetHandler::mainNetEvent(int event, Event *e)
diags->set_override(vc->control.debug_override);
if (vc->closed)
close_UnixNetVConnection(vc, trigger_event->ethread);
-else if ((vc->write.enabled || vc->write.error) && vc->write.triggered)
+else if (vc->write.enabled && vc->write.triggered || vc->write.error
&& vc->write.vio._cont != nullptr)
write_to_net(this, vc, trigger_event->ethread);
else if (!vc->write.enabled)
vc->ep.modify(-EVENTIO_WRITE);
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1522
@oknet Thank for the suggestion I am running in 7.1.0 in production with
the change you mention above instead of this PR
```
diff --git a/iocore/net/UnixNet.cc b/iocore/net/UnixNet.cc
index 85d7527ec..636b9a255 100644
--- a/iocore/net/UnixNet.cc
+++ b/iocore/net/UnixNet.cc
@@ -505,7 +505,7 @@ NetHandler::mainNetEvent(int event, Event *e)
set_cont_flags(vc->control_flags);
if (vc->closed)
close_UnixNetVConnection(vc, trigger_event->ethread);
-else if ((vc->read.enabled || vc->read.error) && vc->read.triggered)
+else if (vc->read.enabled && vc->read.triggered || vc->read.error &&
vc->read.vio._cont != nullptr)
vc->net_read_io(this, trigger_event->ethread);
else if (!vc->read.enabled) {
read_ready_list.remove(vc);
@@ -522,7 +522,7 @@ NetHandler::mainNetEvent(int event, Event *e)
set_cont_flags(vc->control_flags);
if (vc->closed)
close_UnixNetVConnection(vc, trigger_event->ethread);
-else if ((vc->write.enabled || vc->write.error) && vc->write.triggered)
+else if (vc->write.enabled && vc->write.triggered || vc->write.error
&& vc->write.vio._cont != nullptr)
write_to_net(this, vc, trigger_event->ethread);
else if (!vc->write.enabled) {
write_ready_list.remove(vc);
@@ -540,7 +540,7 @@ NetHandler::mainNetEvent(int event, Event *e)
diags->set_override(vc->control.debug_override);
if (vc->closed)
close_UnixNetVConnection(vc, trigger_event->ethread);
-else if ((vc->read.enabled || vc->read.error) && vc->read.triggered)
+else if (vc->read.enabled && vc->read.triggered || vc->read.error &&
vc->read.vio._cont != nullptr)
vc->net_read_io(this, trigger_event->ethread);
else if (!vc->read.enabled)
vc->ep.modify(-EVENTIO_READ);
@@ -549,7 +549,7 @@ NetHandler::mainNetEvent(int event, Event *e)
diags->set_override(vc->control.debug_override);
if (vc->closed)
close_UnixNetVConnection(vc, trigger_event->ethread);
-else if ((vc->write.enabled || vc->write.error) && vc->write.triggered)
+else if (vc->write.enabled && vc->write.triggered || vc->write.error
&& vc->write.vio._cont != nullptr)
write_to_net(this, vc, trigger_event->ethread);
else if (!vc->write.enabled)
vc->ep.modify(-EVENTIO_WRITE);
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1537: TS-4976: Regularize example plugin basic_auth.
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1537 Looks like you removed a file and didn't add one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1538: Tests are failing on cache-generation-clear
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/issues/1538 @dragon512 Here is the full output: https://da.gd/zDXXX --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1539: Signals fix
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1539#discussion_r104453441
--- Diff: iocore/eventsystem/I_EThread.h ---
@@ -56,7 +56,7 @@ enum ThreadType {
DEDICATED,
};
-extern volatile bool shutdown_event_system;
+extern bool shutdown_event_system;
--- End diff --
`volatile` shouldn't have any effect. It is used incorrectly throughout
ATS as a synchronization mechanism.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1443: Assert on null t_state.transact_return_point
Github user bryancall closed the issue at: https://github.com/apache/trafficserver/issues/1443 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1443: Assert on null t_state.transact_return_point
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/issues/1443 Looks like this should be closed since the PR for it was merged. Please reopen if need be. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1538: Tests are failing on cache-generation-clear
GitHub user bryancall opened an issue: https://github.com/apache/trafficserver/issues/1538 Tests are failing on cache-generation-clear ``` [bcall@homer tests]$ time ./autest.sh --ats-bin /usr/local/bin Running Test basic:. Passed Running Test basic-cop:. Passed Running Test basic-manager:. Passed Running Test cache-generation-clear:FF Failed Running Test cache-generation-disjoint:.. Passed Running Test config:. Passed Running Test copy_config:.. Passed Running Test copy_config2:.. Passed Running Test custom-log:. Passed Running Test custom_response: Skipped Warning: Skipping test custom_response because: This test fails at the moment as is turned off Running Test disjoint-wait-for-cache: Skipped Warning: Skipping test disjoint-wait-for-cache because: This test fails at the moment as is turned off Running Test header_rewrite:. Passed Running Test http2:. Passed Running Test remap_http:.. Passed Running Test remap_https:.. Passed ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1465: Add new testing system to the test subdirectory
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1465 @zwoop Did you run the tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1532: ATS 7.1 release running out of memory
GitHub user bryancall opened an issue: https://github.com/apache/trafficserver/issues/1532 ATS 7.1 release running out of memory Here is a backtrace from a bunch of cores I am getting from 7.1. They are mostly issues with memory allocation: [bcall@e24 ~]$ egrep '\#2 |\#3 |\#4 |\#5 ' ~/gdb.out > #2 0x007857e8 in UnixNetProcessor::allocate_vc (this=0x105cc20, t=0x0) at ../../../../trafficserver/iocore/net/UnixNetProcessor.cc:460 > #3 0x00782bdf in NetAccept::do_blocking_accept (this=0x2b9b280253d0, t=0x2b9b281d6050) at ../../../../trafficserver/iocore/net/UnixNetAccept.cc:259 > #4 0x00783a1b in NetAccept::acceptLoopEvent (this=0x2b9b280253d0, event=1, e=0x2b9b281cf3c0) at ../../../../trafficserver/iocore/net/UnixNetAccept.cc:469 > #5 0x00515468 in Continuation::handleEvent (this=0x2b9b280253d0, event=1, data=0x2b9b281cf3c0) at /home/bcall/dev/yahoo/build/_build/ats_build/../../trafficserver/iocore/eventsystem/I_Continuation.h:153 > #2 0x2af5d64098d0 in ink_abort (message_format=0x2af5d64200f0 "couldn't allocate %zu bytes at alignment %zu - insufficient memory") at ../../../../trafficserver/lib/ts/ink_error.cc:99 > #3 0x2af5d640deff in ats_memalign (alignment=4096, size=4194304) at ../../../../trafficserver/lib/ts/ink_memory.cc:108 > #4 0x00515638 in IOBufferData::alloc (this=0x2af631221260, size_index=-4194304, type=MEMALIGNED) at /home/bcall/dev/yahoo/build/_build/ats_build/../../trafficserver/iocore/eventsystem/P_IOBuffer.h:288 > #5 0x00515579 in new_IOBufferData_internal (loc=0x814bf0 "memory/IOBuffer/../../../../trafficserver/iocore/cache/Cache.cc:2498", size_index=-4194304, type=MEMALIGNED) at /home/bcall/dev/yahoo/build/_build/ats_build/../../trafficserver/iocore/eventsystem/P_IOBuffer.h:264 > #2 0x2b46476178d0 in ink_abort (message_format=0x2b464762e0f0 "couldn't allocate %zu bytes at alignment %zu - insufficient memory") at ../../../../trafficserver/lib/ts/ink_error.cc:99 > #3 0x2b464761beff in ats_memalign (alignment=4096, size=33554432) at ../../../../trafficserver/lib/ts/ink_memory.cc:108 > #4 0x2b464761c938 in freelist_new (f=0x14ec000) at ../../../../trafficserver/lib/ts/ink_queue.cc:212 > #5 0x2b464761c832 in ink_freelist_new (f=0x14ec000) at ../../../../trafficserver/lib/ts/ink_queue.cc:183 > #2 0x2aed89fc08d0 in ink_abort (message_format=0x2aed89fd70f0 "couldn't allocate %zu bytes at alignment %zu - insufficient memory") at ../../../../trafficserver/lib/ts/ink_error.cc:99 > #3 0x2aed89fc4eff in ats_memalign (alignment=4096, size=987136) at ../../../../trafficserver/lib/ts/ink_memory.cc:108 > #4 0x2aed89fc5938 in freelist_new (f=0x25bb5d0) at ../../../../trafficserver/lib/ts/ink_queue.cc:212 > #5 0x2aed89fc5832 in ink_freelist_new (f=0x25bb5d0) at ../../../../trafficserver/lib/ts/ink_queue.cc:183 > #2 0x2b3d66d4a8d0 in ink_abort (message_format=0x2b3d66d610f0 "couldn't allocate %zu bytes at alignment %zu - insufficient memory") at ../../../../trafficserver/lib/ts/ink_error.cc:99 > #3 0x2b3d66d4eeff in ats_memalign (alignment=4096, size=33554432) at ../../../../trafficserver/lib/ts/ink_memory.cc:108 > #4 0x2b3d66d4f938 in freelist_new (f=0x1f5) at ../../../../trafficserver/lib/ts/ink_queue.cc:212 > #5 0x2b3d66d4f832 in ink_freelist_new (f=0x1f5) at ../../../../trafficserver/lib/ts/ink_queue.cc:183 > #2 0x2af391be38d0 in ink_abort (message_format=0x2af391bfa0f0 "couldn't allocate %zu bytes at alignment %zu - insufficient memory") at ../../../../trafficserver/lib/ts/ink_error.cc:99 > #3 0x2af391be7eff in ats_memalign (alignment=4096, size=3407872) at ../../../../trafficserver/lib/ts/ink_memory.cc:108 > #4 0x00515638 in IOBufferData::alloc (this=0x2ab464602e90, size_index=-3407872, type=MEMALIGNED) at /home/bcall/dev/yahoo/build/_build/ats_build/../../trafficserver/iocore/eventsystem/P_IOBuffer.h:288 > #5 0x00515579 in new_IOBufferData_internal (loc=0x814bf0 "memory/IOBuffer/../../../../trafficserver/iocore/cache/Cache.cc:2498", size_index=-3407872, type=MEMALIGNED) at /home/bcall/dev/yahoo/build/_build/ats_build/../../trafficserver/iocore/eventsystem/P_IOBuffer.h:264 > #2 0x00534d3d in TSHttpSsnClientAddrGet (ssnp=0x2ab21f4d1bc0) at ../../../trafficserver/proxy/InkAPI.cc:5445 > #3 0x00534d8b in TSHttpTxnClientAddrGet (txnp=0x2ab48b84cc00) at ../../../trafficserver/proxy/InkAPI.cc:5453 > #4 0x2aaab248f8f6 in http_hook (contp=0x275cf40, event=60006, edata=0x2ab48b84cc00) at INKPluginInit.cc:174 > #5 0x0052a025 in INKContInternal::handle_event (this=0x275cf40, event=60006, edat
[GitHub] trafficserver issue #1465: Add new testing system to the test subdirectory
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1465 Here is the full output from running the tests: https://da.gd/XOiCg --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1465: Add new testing system to the test subdirectory
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1465 I am seeing 4 failed tests. ``` [bcall@homer tests]$ ./autest.sh --ats-bin /usr/local/bin Running Test basic:. Passed Running Test basic-cop:. Passed Running Test basic-manager:. Passed Running Test cache-generation-clear:FF Failed Running Test cache-generation-disjoint:.. Passed Running Test config:. Passed Running Test copy_config:.. Passed Running Test copy_config2:.. Passed Running Test custom: Failed Running Test custom_response: Skipped Warning: Skipping test custom_response because: This test fails at the moment as is turned off Running Test disjoint-wait-for-cache: Skipped Warning: Skipping test disjoint-wait-for-cache because: This test fails at the moment as is turned off Running Test header_rewrite:F Failed Running Test http2:. Passed Running Test remap_http:.FFF.. Failed Running Test remap_https:.. Passed Total of 15 test Unknown: 0 Exception: 0 Failed: 4 Warning: 0 Skipped: 2 Passed: 9 ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1524: Seeing a lot of CPU being used on atomics
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/issues/1524 I believe this is not really an issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1524: Seeing a lot of CPU being used on atomics
Github user bryancall closed the issue at: https://github.com/apache/trafficserver/issues/1524 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1524: Seeing a lot of CPU being used on atomics
GitHub user bryancall opened an issue: https://github.com/apache/trafficserver/issues/1524 Seeing a lot of CPU being used on atomics ``` - 22.49%22.20% traffic_server [.] ink_atomic_increment<int, int> - ink_atomic_increment<int, int> - 65.31% RefCountObj::refcount_inc - 88.88% Ptr::Ptr - MutexTryLock::MutexTryLock + 56.95% CacheVC::openReadStartHead + 41.89% EThread::process_event - 11.12% Ptr::operator= Ptr::operator= EThread::schedule_local + EThread::schedule_in_local ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1523: ASAN segv when ramping up traffic to a production...
GitHub user bryancall opened an issue: https://github.com/apache/trafficserver/issues/1523 ASAN segv when ramping up traffic to a production host ``` ASAN:SIGSEGV = ==38732==ERROR: AddressSanitizer: SEGV on unknown address 0x (pc 0x bp 0x2abf141497c0 sp 0x2abf141496a8 T23) ==38732==Hint: pc points to the zero page. AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: SEGV ??:0 ?? Thread T23 ([ET_NET 21]) created by T0 ([TS_MAIN]) here: #0 0x528ed4 in __interceptor_pthread_create (/home/y/bin64/traffic_server+0x528ed4) #1 0xb3e984 in ink_thread_create /home/bcall/dev/yahoo/build/_build/asan_build/../../trafficserver/lib/ts/ink_thread.h:152 #2 0xb3ef5a in Thread::start(char const*, unsigned long, void* (*)(void*), void*, void*) ../../../../trafficserver/iocore/eventsystem/Thread.cc:102 #3 0xb447d9 in EventProcessor::start(int, unsigned long) ../../../../trafficserver/iocore/eventsystem/UnixEventProcessor.cc:240 #4 0x654afe in main ../../../trafficserver/proxy/Main.cc:1771 #5 0x2abf0cdadd1c in __libc_start_main (/lib64/libc.so.6+0x1ed1c) ==38732==ABORTING ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1522 Here is a workaround for issue #1401. I ran into issues with the read also coring. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1522: Ingore read and write errors if vio has be...
GitHub user bryancall opened a pull request: https://github.com/apache/trafficserver/pull/1522 Ingore read and write errors if vio has been cleared You can merge this pull request into a Git repository by running: $ git pull https://github.com/bryancall/trafficserver ignore_error Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1522.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1522 commit 5aac06f8a155c99443a53dd71c5d39e848d1b929 Author: Bryan Call <bc...@apache.org> Date: 2017-03-01T17:01:25Z Ingore read and write errors if vio has been cleared --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1379: Make sure to schedule connect event on correct th...
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1379 @zwoop Yes, this needs to get backported. I ran into this issue testing the 7.1.x branch in production. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1457: fix TS-4195: crash when stop trafficserver
Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1457#discussion_r103324828 --- Diff: proxy/Main.cc --- @@ -460,7 +460,7 @@ proxy_signal_handler(int signo, siginfo_t *info, void *ctx) shutdown_event_system = true; sleep(1); - ::exit(signo); --- End diff -- This is going to cause an issue with leak detection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1506: Wrong protocol version in the Via header
GitHub user bryancall opened an issue: https://github.com/apache/trafficserver/issues/1506 Wrong protocol version in the Via header ``` [bcall@homer ats_ssl_config]$ nghttp -v https://127.0.0.1:4443/200.php [ 0.000] Connected The negotiated protocol: h2 ... [from ATS going to the origin] Via: https/1.1 homer.bryancall.com[aa274815-0002-4b4a-a1b2-058c8a2e0829] (ApacheTrafficServer/7.2.0) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1465: Add new testing system to the test subdirectory
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1465 @dragon512 I am seeing some errors when running the tests: ``` Total of 15 test Unknown: 0 Exception: 0 Failed: 10 Warning: 0 kipped: 2 Passed: 3 ``` Looking at the output from the errors: ``` - > User-Agent: curl/`` ?^^ + > User-Agent: curl/7.51.0 ?^^ - `` - < HTTP/1.1 404 Not Found on Accelerator + > Accept: */* + > ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1465: Add new testing system to the test subdirectory
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1465 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1458: Removed spaces at the end of the line on a...
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/1458 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1458: Removed spaces at the end of the line on a...
GitHub user bryancall opened a pull request: https://github.com/apache/trafficserver/pull/1458 Removed spaces at the end of the line on all files Removed spaces at the end of the line on all files doing: `find . -type f | grep -v '\.git' | xargs -n1 perl -pi -e 's/\s+\n$/\n/'` and then doing `git co --` on the binary files. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bryancall/trafficserver no_space_eol Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1458.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1458 commit 63a7265478972bcba60b1c9d9fd2100220419184 Author: Bryan Call <bc...@apache.org> Date: 2017-02-16T18:24:12Z Removed spaces at the end of the line on all files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1454: Updates to the help output for tsxs
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/1454 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1456 Why are there tsconfig changes with this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1454: Updates to the help output for tsxs
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1454 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1444: issue #1401: Potential fix to the write_to_io_net...
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1444 This is the same type of hack I described in our Monday meeting. I don't think it is worth committing it. Tracking down what why this is broken and having a permanent fix would be appropriate. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1454: Updates to the help output for tsxs
GitHub user bryancall opened a pull request: https://github.com/apache/trafficserver/pull/1454 Updates to the help output for tsxs You can merge this pull request into a Git repository by running: $ git pull https://github.com/bryancall/trafficserver tsxs_help Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1454.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1454 commit 9ffe07d86b62d7e0dbb379db4b04dedd2c06be68 Author: Bryan Call <bc...@apache.org> Date: 2017-02-15T21:52:44Z Updates to the help output for tsxs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1398: Configure option to disable CURL
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/1398 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1398: Configure option to disable CURL
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1398#discussion_r99880264
--- Diff: configure.ac ---
@@ -220,6 +220,22 @@ AC_ARG_ENABLE([fast-sdk],
AC_MSG_RESULT([$enable_fast_sdk])
TS_ARG_ENABLE_VAR([use], [fast-sdk])
+# Curl support for traffic_top
+AC_MSG_CHECKING([whether to enable CURL])
+AC_ARG_ENABLE([curl],
+ [AS_HELP_STRING([--disable-curl],[turn off CURL support for
traffic_top])],
+ [],
+ [enable_curl=yes]
+)
+AC_MSG_RESULT([$enable_curl])
+
+if test "x${enable_curl}" = "xyes"; then
+AX_LIB_CURL([7.19], [has_curl=1],[has_curl=0])
+AM_CONDITIONAL([HAS_CURL], [test "x$has_curl" = "xyes"])
+else
+AM_CONDITIONAL([HAS_CURL], [false])
+fi
--- End diff --
Yes, that worked. I tried replacing lines 233 to 234 with using the
AC_DEFINE yesterday and I was getting:
configure: error: conditional "HAS_CURL" was never defined.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1398: Configure option to disable CURL
Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1398#discussion_r99876962 --- Diff: cmd/traffic_top/Makefile.am --- @@ -17,13 +17,13 @@ # We only build traffic_top if libcurses and libcurl are available. if BUILD_TRAFFIC_TOP - AM_CPPFLAGS = \ $(iocore_include_dirs) \ -I$(abs_top_srcdir)/lib \ -I$(abs_top_srcdir)/mgmt/api/include \ @CURL_CFLAGS@ \ @CURSES_CFLAGS@ +endif --- End diff -- Yes, when I added it back in I put it in the wrong place. I will move it and make sure it works like it is supposed to. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1401: Segfault in write_to_net_io with 7.1.x
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/issues/1401
(gdb) bt full
#0 0x005150b0 in Mutex_trylock (m=0x0, t=0x2b44f3a6d010)
at
/home/bcall/dev/yahoo/build/_build/ats_build/../../trafficserver/iocore/eventsystem/I_Lock.h:289
No locals.
#1 0x0051526f in MutexTryLock::MutexTryLock (this=0x2b44f9c35be0,
am=..., t=0x2b44f3a6d010)
at
/home/bcall/dev/yahoo/build/_build/ats_build/../../trafficserver/iocore/eventsystem/I_Lock.h:555
No locals.
#2 0x00787888 in write_to_net_io (nh=0x2b44f3a70e60,
vc=0x2aac5002bf10, thread=0x2b44f3a6d010)
at ../../../../trafficserver/iocore/net/UnixNetVConnection.cc:439
s = 0x2aac5002c098
mutex = 0x2b44f40035d0
lock = {m = {m_ptr = 0x0}, lock_acquired = 16}
ntodo = 47575248100432
buf = @0x2b9de60
towrite = 47575145566224
signalled = 10
needs = 2147483647
total_written = 3807
r = 44090535680
#3 0x0078781e in write_to_net (nh=0x2b44f3a70e60,
vc=0x2aac5002bf10, thread=0x2b44f3a6d010)
at ../../../../trafficserver/iocore/net/UnixNetVConnection.cc:430
mutex = 0x2b44f40035d0
#4 0x0077f443 in NetHandler::mainNetEvent (this=0x2b44f3a70e60,
event=5, e=0x2cb5860)
at ../../../../trafficserver/iocore/net/UnixNet.cc:526
epd = 0x2aac5c02dd70
poll_timeout = 0
pd = 0x2b45a010
vc = 0x2aac5002bf10
__func__ = "mainNetEvent"
#5 0x00515354 in Continuation::handleEvent (this=0x2b44f3a70e60,
event=5, data=0x2cb5860)
at
/home/bcall/dev/yahoo/build/_build/ats_build/../../trafficserver/iocore/eventsystem/I_Continuation.h:153
No locals.
#6 0x007a8bc3 in EThread::process_event (this=0x2b44f3a6d010,
e=0x2cb5860, calling_code=5)
at ../../../../trafficserver/iocore/eventsystem/UnixEThread.cc:143
c_temp = 0x2b44f3a70e60
lock = {m = {m_ptr = 0x2b44f4001f50}, lock_acquired = true}
#7 0x007a90c4 in EThread::execute (this=0x2b44f3a6d010)
at ../../../../trafficserver/iocore/eventsystem/UnixEThread.cc:270
done_one = false
e = 0x2cb5860
NegativeQueue = {<DLL<Event, Event::Link_link>> = {head = 0x0},
tail = 0x0}
next_time = 1486425567363334599
#8 0x007a8279 in spawn_thread_internal (a=0x2ba5fd0)
at ../../../../trafficserver/iocore/eventsystem/Thread.cc:84
p = 0x2ba5fd0
#9 0x2b44f0c14aa1 in start_thread () from /lib64/libpthread.so.0
No symbol table info available.
#10 0x2b44f0960aad in clone () from /lib64/libc.so.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1412: Assertion in HttpSM::tunnel_handler_post
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/issues/1412 The event is VC_EVENT_INACTIVITY_TIMEOUT (value 105) when it asserts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1403: idempotent requests should be retryable irrespect...
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/issues/1403 This is the PR for this issue: #1404 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1401: Segfault in write_to_net_io with 7.1.x
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/issues/1401 What does the vc look like? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1391: Allow configurable body factory response m...
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/1391 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1391: Allow configurable body factory response max size
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1391 Still needs a clang-format. I will merge it and clang-format it once it is committed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1398: Configure option to disable CURL
GitHub user bryancall opened a pull request: https://github.com/apache/trafficserver/pull/1398 Configure option to disable CURL You can merge this pull request into a Git repository by running: $ git pull https://github.com/bryancall/trafficserver no_curl Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1398.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1398 commit 9865edc02b86a549c7d5a1b8f66426bd1fbb2d50 Author: Bryan Call <bc...@apache.org> Date: 2017-01-31T00:23:02Z Configure option to disable CURL --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1391: Allow configurable body factory response max size
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1391 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1248: TS-5070 Add configuration variables to set file p...
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1248 Please squash commits before merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1391: Allow configurable body factory response max size
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1391 Please run clang-format on the code. It is not passing CI. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1391: Allow configurable body factory response max size
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1391 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1391: Allow configurable body factory response max size
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1391 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #210: TS-3607: Integrate ats_pagespeed into the automake...
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/210 Please reopen or create another pull request if you want to resolve this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #210: TS-3607: Integrate ats_pagespeed into the a...
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/210 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #761: TS-4332: proxy.config.net.connections_throt...
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/761 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #761: TS-4332: proxy.config.net.connections_throttle sho...
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/761 Please reopen or create a new pull request if you still want to resolve this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1275: TS-5105: Do vc->con.setRemote(target) before sock...
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1275 Please make sure pull requests are reviewed before merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1380: Fixed issue where somaxconn was being set ...
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/1380 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1283: CID 1367526: CID 1367525 : money_trace/money_trac...
Github user bryancall closed the issue at: https://github.com/apache/trafficserver/issues/1283 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1279: CID 1367531: Uninitialized members (UNINIT_CTOR):...
Github user bryancall closed the issue at: https://github.com/apache/trafficserver/issues/1279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1279: CID 1367531: Uninitialized members (UNINIT_CTOR):...
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/issues/1279 This was closed in PR #1279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1380: Fixed issue where somaxconn was being set ...
GitHub user bryancall opened a pull request: https://github.com/apache/trafficserver/pull/1380 Fixed issue where somaxconn was being set to 0 on OSX and preventing ATS to work You can merge this pull request into a Git repository by running: $ git pull https://github.com/bryancall/trafficserver osx_reboot Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1380.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1380 commit 0d4b4692a1f2fc0f566d03d09343763442ff498b Author: Bryan Call <bc...@apache.org> Date: 2017-01-26T01:20:44Z Fixed issue where somaxconn was being set to 0 on OSX and preventing ATS to work --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1373: #1279 - CID 1367531: Uninitialized members...
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/1373 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
