[jira] [Work logged] (TS-4909) Throttling based on resident memory usage

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4909?focusedWorklogId=30722=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30722
 ]

ASF GitHub Bot logged work on TS-4909:
--

Author: ASF GitHub Bot
Created on: 15/Oct/16 23:42
Start Date: 15/Oct/16 23:42
Worklog Time Spent: 10m 
  Work Description: Github user bryancall closed the pull request at:

https://github.com/apache/trafficserver/pull/1063


Issue Time Tracking
---

Worklog Id: (was: 30722)
Time Spent: 2h 20m  (was: 2h 10m)

> Throttling based on resident memory usage
> -
>
> Key: TS-4909
> URL: https://issues.apache.org/jira/browse/TS-4909
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core
>Reporter: Bryan Call
> Fix For: 7.1.0
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Add a feature to stop accepting connections if the resident memory is over a 
> certain limit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4909) Throttling based on resident memory usage

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4909?focusedWorklogId=30689=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30689
 ]

ASF GitHub Bot logged work on TS-4909:
--

Author: ASF GitHub Bot
Created on: 14/Oct/16 21:27
Start Date: 14/Oct/16 21:27
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1063#discussion_r83504741
  
--- Diff: proxy/Main.cc ---
@@ -346,6 +346,54 @@ class DiagsLogContinuation : public Continuation
   }
 };
 
+class MemoryLimit : public Continuation
+{
+public:
+  MemoryLimit() : Continuation(new_ProxyMutex()), _memory_limit(0) { 
SET_HANDLER(::periodic); }
+  ~MemoryLimit() { mutex = NULL; }
+  int
+  periodic(int event, Event *e)
+  {
+if (event == EVENT_IMMEDIATE) {
+  // rescheduled from periodic to immediate event
+  // this is the indication to terminate
+  delete this;
+  return EVENT_DONE;
+}
+if (_memory_limit == 0) {
+  // first time it has been run
+  _memory_limit = 
REC_ConfigReadInteger("proxy.config.memory.max_usage");
--- End diff --

Ok that sounds reasonable.


Issue Time Tracking
---

Worklog Id: (was: 30689)
Time Spent: 2h 10m  (was: 2h)

> Throttling based on resident memory usage
> -
>
> Key: TS-4909
> URL: https://issues.apache.org/jira/browse/TS-4909
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core
>Reporter: Bryan Call
> Fix For: 7.1.0
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Add a feature to stop accepting connections if the resident memory is over a 
> certain limit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4909) Throttling based on resident memory usage

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4909?focusedWorklogId=30688=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30688
 ]

ASF GitHub Bot logged work on TS-4909:
--

Author: ASF GitHub Bot
Created on: 14/Oct/16 21:26
Start Date: 14/Oct/16 21:26
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1063#discussion_r83504537
  
--- Diff: iocore/net/UnixNetAccept.cc ---
@@ -280,6 +234,14 @@ NetAccept::do_blocking_accept(EThread *t)
   return -1;
 }
 
+// Throttle accepts
+if (!backdoor && (check_net_throttle(ACCEPT, now) || 
net_memory_throttle)) {
+  Debug("net_accept", "Too many connections or too much memory used, 
throttling");
+  check_throttle_warning();
+  con.close();
--- End diff --

Ok, sounds good.


Issue Time Tracking
---

Worklog Id: (was: 30688)
Time Spent: 2h  (was: 1h 50m)

> Throttling based on resident memory usage
> -
>
> Key: TS-4909
> URL: https://issues.apache.org/jira/browse/TS-4909
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core
>Reporter: Bryan Call
> Fix For: 7.1.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> Add a feature to stop accepting connections if the resident memory is over a 
> certain limit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4909) Throttling based on resident memory usage

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4909?focusedWorklogId=30687=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30687
 ]

ASF GitHub Bot logged work on TS-4909:
--

Author: ASF GitHub Bot
Created on: 14/Oct/16 21:20
Start Date: 14/Oct/16 21:20
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1063
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/911/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 30687)
Time Spent: 1h 50m  (was: 1h 40m)

> Throttling based on resident memory usage
> -
>
> Key: TS-4909
> URL: https://issues.apache.org/jira/browse/TS-4909
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core
>Reporter: Bryan Call
> Fix For: 7.1.0
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Add a feature to stop accepting connections if the resident memory is over a 
> certain limit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4909) Throttling based on resident memory usage

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4909?focusedWorklogId=30686=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30686
 ]

ASF GitHub Bot logged work on TS-4909:
--

Author: ASF GitHub Bot
Created on: 14/Oct/16 21:16
Start Date: 14/Oct/16 21:16
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1063
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1019/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 30686)
Time Spent: 1h 40m  (was: 1.5h)

> Throttling based on resident memory usage
> -
>
> Key: TS-4909
> URL: https://issues.apache.org/jira/browse/TS-4909
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core
>Reporter: Bryan Call
> Fix For: 7.1.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Add a feature to stop accepting connections if the resident memory is over a 
> certain limit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4909) Throttling based on resident memory usage

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4909?focusedWorklogId=30685=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30685
 ]

ASF GitHub Bot logged work on TS-4909:
--

Author: ASF GitHub Bot
Created on: 14/Oct/16 21:15
Start Date: 14/Oct/16 21:15
Worklog Time Spent: 10m 
  Work Description: Github user bryancall commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1063#discussion_r83502802
  
--- Diff: iocore/net/UnixNetAccept.cc ---
@@ -280,6 +234,14 @@ NetAccept::do_blocking_accept(EThread *t)
   return -1;
 }
 
+// Throttle accepts
+if (!backdoor && (check_net_throttle(ACCEPT, now) || 
net_memory_throttle)) {
+  Debug("net_accept", "Too many connections or too much memory used, 
throttling");
+  check_throttle_warning();
+  con.close();
--- End diff --

check_throttle_warning logs an error message.  There currently isn't a stat 
for throttled incoming connections.  I can file a bug for it since I believe it 
will need to be added in a couple places.


Issue Time Tracking
---

Worklog Id: (was: 30685)
Time Spent: 1.5h  (was: 1h 20m)

> Throttling based on resident memory usage
> -
>
> Key: TS-4909
> URL: https://issues.apache.org/jira/browse/TS-4909
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core
>Reporter: Bryan Call
> Fix For: 7.1.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Add a feature to stop accepting connections if the resident memory is over a 
> certain limit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4909) Throttling based on resident memory usage

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4909?focusedWorklogId=30683=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30683
 ]

ASF GitHub Bot logged work on TS-4909:
--

Author: ASF GitHub Bot
Created on: 14/Oct/16 21:13
Start Date: 14/Oct/16 21:13
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1063
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1020/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 30683)
Time Spent: 1h 10m  (was: 1h)

> Throttling based on resident memory usage
> -
>
> Key: TS-4909
> URL: https://issues.apache.org/jira/browse/TS-4909
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core
>Reporter: Bryan Call
> Fix For: 7.1.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Add a feature to stop accepting connections if the resident memory is over a 
> certain limit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4909) Throttling based on resident memory usage

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4909?focusedWorklogId=30684=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30684
 ]

ASF GitHub Bot logged work on TS-4909:
--

Author: ASF GitHub Bot
Created on: 14/Oct/16 21:13
Start Date: 14/Oct/16 21:13
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1063
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/912/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 30684)
Time Spent: 1h 20m  (was: 1h 10m)

> Throttling based on resident memory usage
> -
>
> Key: TS-4909
> URL: https://issues.apache.org/jira/browse/TS-4909
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core
>Reporter: Bryan Call
> Fix For: 7.1.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Add a feature to stop accepting connections if the resident memory is over a 
> certain limit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4909) Throttling based on resident memory usage

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4909?focusedWorklogId=30682=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30682
 ]

ASF GitHub Bot logged work on TS-4909:
--

Author: ASF GitHub Bot
Created on: 14/Oct/16 21:03
Start Date: 14/Oct/16 21:03
Worklog Time Spent: 10m 
  Work Description: Github user bryancall commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1063#discussion_r83501005
  
--- Diff: proxy/Main.cc ---
@@ -346,6 +346,54 @@ class DiagsLogContinuation : public Continuation
   }
 };
 
+class MemoryLimit : public Continuation
+{
+public:
+  MemoryLimit() : Continuation(new_ProxyMutex()), _memory_limit(0) { 
SET_HANDLER(::periodic); }
+  ~MemoryLimit() { mutex = NULL; }
+  int
+  periodic(int event, Event *e)
+  {
+if (event == EVENT_IMMEDIATE) {
+  // rescheduled from periodic to immediate event
+  // this is the indication to terminate
+  delete this;
+  return EVENT_DONE;
+}
+if (_memory_limit == 0) {
+  // first time it has been run
+  _memory_limit = 
REC_ConfigReadInteger("proxy.config.memory.max_usage");
+}
+if (_memory_limit > 0) {
+  if (getrusage(RUSAGE_SELF, &_usage) == 0) {
+Debug("server", "memory usage - ru_maxrss: %ld memory limit: %" 
PRId64, _usage.ru_maxrss, _memory_limit);
+if (_usage.ru_maxrss > _memory_limit) {
--- End diff --

Fixed this. Did a divide by 1024 for the setting.


Issue Time Tracking
---

Worklog Id: (was: 30682)
Time Spent: 1h  (was: 50m)

> Throttling based on resident memory usage
> -
>
> Key: TS-4909
> URL: https://issues.apache.org/jira/browse/TS-4909
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core
>Reporter: Bryan Call
> Fix For: 7.1.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Add a feature to stop accepting connections if the resident memory is over a 
> certain limit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4909) Throttling based on resident memory usage

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4909?focusedWorklogId=30678=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30678
 ]

ASF GitHub Bot logged work on TS-4909:
--

Author: ASF GitHub Bot
Created on: 14/Oct/16 20:45
Start Date: 14/Oct/16 20:45
Worklog Time Spent: 10m 
  Work Description: Github user bryancall commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1063#discussion_r83498036
  
--- Diff: proxy/Main.cc ---
@@ -346,6 +346,54 @@ class DiagsLogContinuation : public Continuation
   }
 };
 
+class MemoryLimit : public Continuation
+{
+public:
+  MemoryLimit() : Continuation(new_ProxyMutex()), _memory_limit(0) { 
SET_HANDLER(::periodic); }
+  ~MemoryLimit() { mutex = NULL; }
+  int
+  periodic(int event, Event *e)
+  {
+if (event == EVENT_IMMEDIATE) {
+  // rescheduled from periodic to immediate event
+  // this is the indication to terminate
+  delete this;
+  return EVENT_DONE;
+}
+if (_memory_limit == 0) {
+  // first time it has been run
+  _memory_limit = 
REC_ConfigReadInteger("proxy.config.memory.max_usage");
--- End diff --

I don't have an event scheduled if it is not configured.  I thought it 
would be nice to not have an event scheduled every 1 second if someone doesn't 
have it configured.


Issue Time Tracking
---

Worklog Id: (was: 30678)
Time Spent: 50m  (was: 40m)

> Throttling based on resident memory usage
> -
>
> Key: TS-4909
> URL: https://issues.apache.org/jira/browse/TS-4909
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core
>Reporter: Bryan Call
> Fix For: 7.1.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Add a feature to stop accepting connections if the resident memory is over a 
> certain limit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4909) Throttling based on resident memory usage

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4909?focusedWorklogId=30201=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30201
 ]

ASF GitHub Bot logged work on TS-4909:
--

Author: ASF GitHub Bot
Created on: 05/Oct/16 20:00
Start Date: 05/Oct/16 20:00
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1063#discussion_r82057266
  
--- Diff: proxy/Main.cc ---
@@ -346,6 +346,54 @@ class DiagsLogContinuation : public Continuation
   }
 };
 
+class MemoryLimit : public Continuation
+{
+public:
+  MemoryLimit() : Continuation(new_ProxyMutex()), _memory_limit(0) { 
SET_HANDLER(::periodic); }
+  ~MemoryLimit() { mutex = NULL; }
+  int
+  periodic(int event, Event *e)
+  {
+if (event == EVENT_IMMEDIATE) {
+  // rescheduled from periodic to immediate event
+  // this is the indication to terminate
+  delete this;
+  return EVENT_DONE;
+}
+if (_memory_limit == 0) {
+  // first time it has been run
+  _memory_limit = 
REC_ConfigReadInteger("proxy.config.memory.max_usage");
+}
+if (_memory_limit > 0) {
+  if (getrusage(RUSAGE_SELF, &_usage) == 0) {
+Debug("server", "memory usage - ru_maxrss: %ld memory limit: %" 
PRId64, _usage.ru_maxrss, _memory_limit);
+if (_usage.ru_maxrss > _memory_limit) {
--- End diff --

What units are we working with here? ``ru_maxrss`` is in KB, but one would 
think that ``proxy.config.memory.max_usage`` is in bytes? 
``proxy.config.memory.max_usage`` as bytes makes sense because then you can do 
``proxy.config.memory.max_usage=100GB``.


Issue Time Tracking
---

Worklog Id: (was: 30201)
Time Spent: 40m  (was: 0.5h)

> Throttling based on resident memory usage
> -
>
> Key: TS-4909
> URL: https://issues.apache.org/jira/browse/TS-4909
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core
>Reporter: Bryan Call
> Fix For: 7.1.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Add a feature to stop accepting connections if the resident memory is over a 
> certain limit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4909) Throttling based on resident memory usage

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4909?focusedWorklogId=30200=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30200
 ]

ASF GitHub Bot logged work on TS-4909:
--

Author: ASF GitHub Bot
Created on: 05/Oct/16 20:00
Start Date: 05/Oct/16 20:00
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1063#discussion_r82056447
  
--- Diff: proxy/Main.cc ---
@@ -346,6 +346,54 @@ class DiagsLogContinuation : public Continuation
   }
 };
 
+class MemoryLimit : public Continuation
+{
+public:
+  MemoryLimit() : Continuation(new_ProxyMutex()), _memory_limit(0) { 
SET_HANDLER(::periodic); }
+  ~MemoryLimit() { mutex = NULL; }
+  int
+  periodic(int event, Event *e)
+  {
+if (event == EVENT_IMMEDIATE) {
+  // rescheduled from periodic to immediate event
+  // this is the indication to terminate
+  delete this;
+  return EVENT_DONE;
+}
+if (_memory_limit == 0) {
+  // first time it has been run
+  _memory_limit = 
REC_ConfigReadInteger("proxy.config.memory.max_usage");
+}
+if (_memory_limit > 0) {
+  if (getrusage(RUSAGE_SELF, &_usage) == 0) {
+Debug("server", "memory usage - ru_maxrss: %ld memory limit: %" 
PRId64, _usage.ru_maxrss, _memory_limit);
+if (_usage.ru_maxrss > _memory_limit) {
+  if (net_memory_throttle == false) {
+net_memory_throttle = true;
+Debug("server", "memory usage exceeded limit - ru_maxrss: %ld 
memory limit: %" PRId64, _usage.ru_maxrss, _memory_limit);
+  }
+} else {
+  if (net_memory_throttle == true) {
+net_memory_throttle = false;
+Debug("server", "memory usage under limit - ru_maxrss: %ld 
memory limit: %" PRId64, _usage.ru_maxrss, _memory_limit);
+  }
+}
+  }
+} else {
+  // this feature has not be enabled
+  Debug("server", "limiting connections baxed on memory usage has been 
disabled");
--- End diff --

s/baxed/based/


Issue Time Tracking
---

Worklog Id: (was: 30200)
Time Spent: 40m  (was: 0.5h)

> Throttling based on resident memory usage
> -
>
> Key: TS-4909
> URL: https://issues.apache.org/jira/browse/TS-4909
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core
>Reporter: Bryan Call
> Fix For: 7.1.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Add a feature to stop accepting connections if the resident memory is over a 
> certain limit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4909) Throttling based on resident memory usage

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4909?focusedWorklogId=30199=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30199
 ]

ASF GitHub Bot logged work on TS-4909:
--

Author: ASF GitHub Bot
Created on: 05/Oct/16 20:00
Start Date: 05/Oct/16 20:00
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1063#discussion_r82057095
  
--- Diff: proxy/Main.cc ---
@@ -346,6 +346,54 @@ class DiagsLogContinuation : public Continuation
   }
 };
 
+class MemoryLimit : public Continuation
+{
+public:
+  MemoryLimit() : Continuation(new_ProxyMutex()), _memory_limit(0) { 
SET_HANDLER(::periodic); }
+  ~MemoryLimit() { mutex = NULL; }
+  int
+  periodic(int event, Event *e)
+  {
+if (event == EVENT_IMMEDIATE) {
+  // rescheduled from periodic to immediate event
+  // this is the indication to terminate
+  delete this;
+  return EVENT_DONE;
+}
+if (_memory_limit == 0) {
+  // first time it has been run
+  _memory_limit = 
REC_ConfigReadInteger("proxy.config.memory.max_usage");
--- End diff --

Can you re-read this on each check so that it is a dynamic configuration?


Issue Time Tracking
---

Worklog Id: (was: 30199)
Time Spent: 40m  (was: 0.5h)

> Throttling based on resident memory usage
> -
>
> Key: TS-4909
> URL: https://issues.apache.org/jira/browse/TS-4909
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core
>Reporter: Bryan Call
> Fix For: 7.1.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Add a feature to stop accepting connections if the resident memory is over a 
> certain limit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4909) Throttling based on resident memory usage

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4909?focusedWorklogId=30202=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30202
 ]

ASF GitHub Bot logged work on TS-4909:
--

Author: ASF GitHub Bot
Created on: 05/Oct/16 20:00
Start Date: 05/Oct/16 20:00
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1063#discussion_r82056583
  
--- Diff: iocore/net/UnixNetAccept.cc ---
@@ -280,6 +234,14 @@ NetAccept::do_blocking_accept(EThread *t)
   return -1;
 }
 
+// Throttle accepts
+if (!backdoor && (check_net_throttle(ACCEPT, now) || 
net_memory_throttle)) {
+  Debug("net_accept", "Too many connections or too much memory used, 
throttling");
+  check_throttle_warning();
+  con.close();
--- End diff --

Add a metric for this case?


Issue Time Tracking
---

Worklog Id: (was: 30202)
Time Spent: 40m  (was: 0.5h)

> Throttling based on resident memory usage
> -
>
> Key: TS-4909
> URL: https://issues.apache.org/jira/browse/TS-4909
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core
>Reporter: Bryan Call
> Fix For: 7.1.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Add a feature to stop accepting connections if the resident memory is over a 
> certain limit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4909) Throttling based on resident memory usage

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4909?focusedWorklogId=29957=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29957
 ]

ASF GitHub Bot logged work on TS-4909:
--

Author: ASF GitHub Bot
Created on: 29/Sep/16 04:39
Start Date: 29/Sep/16 04:39
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1063
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/795/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 29957)
Time Spent: 0.5h  (was: 20m)

> Throttling based on resident memory usage
> -
>
> Key: TS-4909
> URL: https://issues.apache.org/jira/browse/TS-4909
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core
>Reporter: Bryan Call
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Add a feature to stop accepting connections if the resident memory is over a 
> certain limit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4909) Throttling based on resident memory usage

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4909?focusedWorklogId=29956=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29956
 ]

ASF GitHub Bot logged work on TS-4909:
--

Author: ASF GitHub Bot
Created on: 29/Sep/16 04:38
Start Date: 29/Sep/16 04:38
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1063
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/900/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 29956)
Time Spent: 20m  (was: 10m)

> Throttling based on resident memory usage
> -
>
> Key: TS-4909
> URL: https://issues.apache.org/jira/browse/TS-4909
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core
>Reporter: Bryan Call
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Add a feature to stop accepting connections if the resident memory is over a 
> certain limit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4909) Throttling based on resident memory usage

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4909?focusedWorklogId=29955=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29955
 ]

ASF GitHub Bot logged work on TS-4909:
--

Author: ASF GitHub Bot
Created on: 29/Sep/16 04:23
Start Date: 29/Sep/16 04:23
Worklog Time Spent: 10m 
  Work Description: GitHub user bryancall opened a pull request:

https://github.com/apache/trafficserver/pull/1063

TS-4909: Throttling based on resident memory usage



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bryancall/trafficserver TS-4909

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1063.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1063


commit 66c79b32efcd2eac8da8c631f89d20681617e751
Author: Bryan Call 
Date:   2016-09-29T04:17:43Z

TS-4909: Throttling based on resident memory




Issue Time Tracking
---

Worklog Id: (was: 29955)
Time Spent: 10m
Remaining Estimate: 0h

> Throttling based on resident memory usage
> -
>
> Key: TS-4909
> URL: https://issues.apache.org/jira/browse/TS-4909
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core
>Reporter: Bryan Call
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Add a feature to stop accepting connections if the resident memory is over a 
> certain limit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)