[jira] [Work logged] (TS-4955) Remove the global mutex from the plugin session acceptor

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4955?focusedWorklogId=30562=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30562
 ]

ASF GitHub Bot logged work on TS-4955:
--

Author: ASF GitHub Bot
Created on: 13/Oct/16 03:45
Start Date: 13/Oct/16 03:45
Worklog Time Spent: 10m 
  Work Description: Github user jpeach closed the pull request at:

https://github.com/apache/trafficserver/pull/1096


Issue Time Tracking
---

Worklog Id: (was: 30562)
Time Spent: 1h 10m  (was: 1h)

> Remove the global mutex from the plugin session acceptor
> 
>
> Key: TS-4955
> URL: https://issues.apache.org/jira/browse/TS-4955
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core, Performance
>Reporter: James Peach
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> {{plugin_http_accept}} has a global mutex which gets contended by protocol 
> plugins. We don't require locking on {{HttpSessionAccept}} objects and the 
> normal server port accept objects are not locked.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4955) Remove the global mutex from the plugin session acceptor

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4955?focusedWorklogId=30541=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30541
 ]

ASF GitHub Bot logged work on TS-4955:
--

Author: ASF GitHub Bot
Created on: 12/Oct/16 22:05
Start Date: 12/Oct/16 22:05
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1096
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/970/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 30541)
Time Spent: 1h  (was: 50m)

> Remove the global mutex from the plugin session acceptor
> 
>
> Key: TS-4955
> URL: https://issues.apache.org/jira/browse/TS-4955
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core, Performance
>Reporter: James Peach
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> {{plugin_http_accept}} has a global mutex which gets contended by protocol 
> plugins. We don't require locking on {{HttpSessionAccept}} objects and the 
> normal server port accept objects are not locked.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4955) Remove the global mutex from the plugin session acceptor

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4955?focusedWorklogId=30511=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30511
 ]

ASF GitHub Bot logged work on TS-4955:
--

Author: ASF GitHub Bot
Created on: 12/Oct/16 19:11
Start Date: 12/Oct/16 19:11
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1096
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/980/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 30511)
Time Spent: 50m  (was: 40m)

> Remove the global mutex from the plugin session acceptor
> 
>
> Key: TS-4955
> URL: https://issues.apache.org/jira/browse/TS-4955
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core, Performance
>Reporter: James Peach
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> {{plugin_http_accept}} has a global mutex which gets contended by protocol 
> plugins. We don't require locking on {{HttpSessionAccept}} objects and the 
> normal server port accept objects are not locked.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4955) Remove the global mutex from the plugin session acceptor

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4955?focusedWorklogId=30510=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30510
 ]

ASF GitHub Bot logged work on TS-4955:
--

Author: ASF GitHub Bot
Created on: 12/Oct/16 19:09
Start Date: 12/Oct/16 19:09
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1096
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/872/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 30510)
Time Spent: 40m  (was: 0.5h)

> Remove the global mutex from the plugin session acceptor
> 
>
> Key: TS-4955
> URL: https://issues.apache.org/jira/browse/TS-4955
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core, Performance
>Reporter: James Peach
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> {{plugin_http_accept}} has a global mutex which gets contended by protocol 
> plugins. We don't require locking on {{HttpSessionAccept}} objects and the 
> normal server port accept objects are not locked.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4955) Remove the global mutex from the plugin session acceptor

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4955?focusedWorklogId=30500=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30500
 ]

ASF GitHub Bot logged work on TS-4955:
--

Author: ASF GitHub Bot
Created on: 12/Oct/16 16:23
Start Date: 12/Oct/16 16:23
Worklog Time Spent: 10m 
  Work Description: Github user bryancall commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1096#discussion_r83042781
  
--- Diff: proxy/InkAPI.cc ---
@@ -6663,8 +6661,7 @@ TSHttpTxnServerIntercept(TSCont contp, TSHttpTxn txnp)
   sdk_assert(sdk_sanity_check_mutex(i->mutex) == TS_SUCCESS);
 
   http_sm->plugin_tunnel_type = HTTP_PLUGIN_AS_SERVER;
-  http_sm->plugin_tunnel  = PluginVCCore::alloc();
-  http_sm->plugin_tunnel->set_accept_cont(i);
--- End diff --

"i" - Should be a better variable name.


Issue Time Tracking
---

Worklog Id: (was: 30500)
Time Spent: 0.5h  (was: 20m)

> Remove the global mutex from the plugin session acceptor
> 
>
> Key: TS-4955
> URL: https://issues.apache.org/jira/browse/TS-4955
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core, Performance
>Reporter: James Peach
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> {{plugin_http_accept}} has a global mutex which gets contended by protocol 
> plugins. We don't require locking on {{HttpSessionAccept}} objects and the 
> normal server port accept objects are not locked.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4955) Remove the global mutex from the plugin session acceptor.

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4955?focusedWorklogId=30434=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30434
 ]

ASF GitHub Bot logged work on TS-4955:
--

Author: ASF GitHub Bot
Created on: 11/Oct/16 21:09
Start Date: 11/Oct/16 21:09
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1096
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/862/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 30434)
Time Spent: 20m  (was: 10m)

> Remove the global mutex from the plugin session acceptor.
> -
>
> Key: TS-4955
> URL: https://issues.apache.org/jira/browse/TS-4955
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core, Performance
>Reporter: James Peach
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> {{plugin_http_accept}} has a global mutex which gets contended by protocol 
> plugins. We don't require locking on {{HttpSessionAccept}} objects and the 
> normal server port accept objects are not locked.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4955) Remove the global mutex from the plugin session acceptor.

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4955?focusedWorklogId=30433=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30433
 ]

ASF GitHub Bot logged work on TS-4955:
--

Author: ASF GitHub Bot
Created on: 11/Oct/16 20:52
Start Date: 11/Oct/16 20:52
Worklog Time Spent: 10m 
  Work Description: GitHub user jpeach opened a pull request:

https://github.com/apache/trafficserver/pull/1096

TS-4955: Remove the global mutex from the plugin session acceptor.

``plugin_http_accept`` has a global mutex which can be contended by 
protocol plugins. We don't require locking on ``HttpSessionAccept`` objects and 
the normal server port accept objects are not locked.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jpeach/trafficserver fix/4955

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1096.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1096


commit 733c6113790fd5eb26492e1df3a14447118c6e40
Author: James Peach 
Date:   2016-10-11T19:07:59Z

TS-4955: Assign the Plugin VC acceptor at allocation time.

Since we always require a continuation to receive the accept event,
just require it at allocation time, rather than requiring the caller to
remember to call an additional function.

commit c5906cae914787c4c6acf14f590a736b1eff9984
Author: James Peach 
Date:   2016-10-11T20:44:42Z

TS-4955: Allow Plugin VC accept continuation to be unlocked.

We never need to hold the continuation lock when delivering
NET_EVENT_ACCEPT, so allow a NULL continuation mutex in PluginVC to
prevent lock contention on the plugin_http_accept object. We still hold
the lock if it is present since in the intercept cases, the continuation
can come from plugins that may be expecting us to lock.




Issue Time Tracking
---

Worklog Id: (was: 30433)
Time Spent: 10m
Remaining Estimate: 0h

> Remove the global mutex from the plugin session acceptor.
> -
>
> Key: TS-4955
> URL: https://issues.apache.org/jira/browse/TS-4955
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core, Performance
>Reporter: James Peach
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> {{plugin_http_accept}} has a global mutex which gets contended by protocol 
> plugins. We don't require locking on {{HttpSessionAccept}} objects and the 
> normal server port accept objects are not locked.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)