[GitHub] trafficserver issue #1083: TS-4938: Avoid crashes due to NULL vc dereference...

2016-10-10 Thread shinrich
Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1083
  
I've been running with this fix in production all day.  No crashes on this 
issue.  The push this morning addressed @bryancall  and @jpeach comments.  The 
most recent comment was just a squash.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1083: TS-4938: Avoid crashes due to NULL vc dereference...

2016-10-10 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1083
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/845/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1083: TS-4938: Avoid crashes due to NULL vc dereference...

2016-10-10 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1083
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/953/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1083: TS-4938: Avoid crashes due to NULL vc dereference...

2016-10-10 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1083
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/844/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1083: TS-4938: Avoid crashes due to NULL vc dereference...

2016-10-10 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1083
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/952/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1083: TS-4938: Avoid crashes due to NULL vc dereference...

2016-10-10 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1083
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/951/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1083: TS-4938: Avoid crashes due to NULL vc dereference...

2016-10-10 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1083
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/843/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1083: TS-4938: Avoid crashes due to NULL vc dereference...

2016-10-10 Thread shinrich
Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1083
  
Probably don't need the server checks.  I'll back those out.  I've only 
seen ua_session->get_netvc() indirection crashes.  Probably overgeneralized for 
the server side.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1083: TS-4938: Avoid crashes due to NULL vc dereference...

2016-10-07 Thread bryancall
Github user bryancall commented on the issue:

https://github.com/apache/trafficserver/pull/1083
  
Why do we have to guard against the server_session server_vc being NULL 
now?  What change occurred to require this or was it always possible?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1083: TS-4938: Avoid crashes due to NULL vc dereference...

2016-10-07 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1083
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/839/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1083: TS-4938: Avoid crashes due to NULL vc dereference...

2016-10-07 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1083
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/947/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1083: TS-4938: Avoid crashes due to NULL vc dereference...

2016-10-06 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1083
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/835/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1083: TS-4938: Avoid crashes due to NULL vc dereference...

2016-10-06 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1083
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/943/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---