[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal

Github user ngara commented on the issue: https://github.com/apache/trafficserver/pull/1152 Maybe this should be an ink_abort instead of ink_release_assert? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1152 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1114/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal

Github user ngara commented on the issue: https://github.com/apache/trafficserver/pull/1152 I took a close look at this and I didn't make the change that caused clang-format to fail here --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal

Github user ngara commented on the issue: https://github.com/apache/trafficserver/pull/1152 OK, figured it out. removing a variable made the equals signs want to line up differently on a line i didnt modify. Fixed! --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1152 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/1008/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1152 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal

Github user ngara commented on the issue: https://github.com/apache/trafficserver/pull/1152 I put the plugin hook in and got it working. Thanks for the suggestion. Nathan > On Oct 26, 2016, at 9:01 PM, Leif Hedstrom wrote: > >

[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1152 @ngara I think this is failing because of clang-format. I recommend you copy the pre-commit githook into your .git/hooks tree. --- If your project is set up for it, you can reply to this

[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1152 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD// for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1152 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/1004/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1152 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,