Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1197
We get complaints about huge PRs and now we get complaints about small ones
:-(. I think for a change like this starting small is the best approach
especially given how contentious
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1197
Please reformat the PR and commit subject to the convention:
```
TS-1257: Replace TCL hash table with unordered_map.
```
---
If your project is set up for it, you can reply to
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1197
Set the tags to the right please :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user persiaAziz commented on the issue:
https://github.com/apache/trafficserver/pull/1197
TCL hash is being used in numerous places including RecCore, InkAPI,
URLRewrite etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1197
Pretty sure I see other places where TCL hash is used, no? So this would
just make things worse, we'd get both TCL hash and STL hashes :-/.
---
If your project is set up for it, you can reply
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1197
Is this the only place where we use TCL hash now? If so, it seems we could
shoe horn something else here other than STL?
---
If your project is set up for it, you can reply to this email and
Github user persiaAziz commented on the issue:
https://github.com/apache/trafficserver/pull/1197
Please review @SolidWallOfCode
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1197
Boom!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user persiaAziz commented on the issue:
https://github.com/apache/trafficserver/pull/1197
Please review @SolidWallOfCode
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1197
Because then we don't need to like or require TCL.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1197
Why are we replacing the TCL hash with an STL unordered map? I don't see a
benefit of switching from TCL hash, unless we are going to use lib/ts/Map.
---
If your project is set up for
11 matches
Mail list logo
