[GitHub] trafficserver issue #1565: Fix Assertion failure in the regex_revalidate plu...

2017-03-15 Thread jrushford 
Github user jrushford commented on the issue:

https://github.com/apache/trafficserver/pull/1565
  
@amc - thanks, I just saw @jpeach comment.

@zwoop - Yes this change fixes the issue.  We ran into the problem running 
6.2.x in production.  The  PR that mad a mutex a requirement was from this 
Jira:  
https://issues.apache.org/jira/browse/TS-4387?jql=text%20~%20%22TSContSchedule%22
regex_revalidate may have been overlooked when they updated plugins using 
TSContSchedule()



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1565: Fix Assertion failure in the regex_revalidate plu...

2017-03-14 Thread zwoop 
Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1565
  
Merged to 7.1.0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1565: Fix Assertion failure in the regex_revalidate plu...

2017-03-14 Thread SolidWallOfCode 
Github user SolidWallOfCode commented on the issue:

https://github.com/apache/trafficserver/pull/1565
  
@jpeach I'll take care of updating the docs in a direct commit, it's not 
worth a PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1565: Fix Assertion failure in the regex_revalidate plu...

2017-03-14 Thread jrushford 
Github user jrushford commented on the issue:

https://github.com/apache/trafficserver/pull/1565
  
@zwoop there was a change, https://issues.apache.org/jira/browse/TS-4387, 
made that requires a mutex when using TSContSchedule().  With the PR, all 
plugins using TSContSchedule were updated to supply a mutex on the continuation 
scheduled by TSContSchedule().   Sdding the Mutex() did solve the assertion 
failures in 6..2 that we saw whenever the regex_revalidate config file was 
changed.


Thanks
--
John J. Rushford











From: Leif Hedstrom 
Reply-To: apache/trafficserver 
Date: Tuesday, March 14, 2017 at 3:36 PM
To: apache/trafficserver 
Cc: John Rushford , Review requested 

Subject: Re: [apache/trafficserver] Fix Assertion failure in the 
regex_revalidate plugin. (#1565)


@zwoop commented on this pull request.



In 
plugins/regex_revalidate/regex_revalidate.c:

> @@ -362,7 +362,7 @@ config_handler(TSCont cont, TSEvent event ATS_UNUSED, 
void *edata ATS_UNUSED)

 iptr = __sync_val_compare_and_swap(&(pstate->invalidate_list), 
pstate->invalidate_list, i);



 if (iptr) {

-  free_cont = TSContCreate(free_handler, NULL);

+  free_cont = TSContCreate(free_handler, TSMutexCreate());

I'm ok with this (assuming this solves the problem, it's not immediately 
clear as to why it needs the mutex). However, this approach of a schedule 
"delete" seems bad, we should change this (later) to use ref-counted data 
instead. That would eliminate the entire free_cont, and is a better / more 
reliable pattern.

—
You are receiving this because your review was requested.
Reply to this email directly, view it on 
GitHub,
 or mute the 
thread.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1565: Fix Assertion failure in the regex_revalidate plu...

2017-03-10 Thread jpeach 
Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/1565
  
Consider updating the API documentation?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1565: Fix Assertion failure in the regex_revalidate plu...

2017-03-10 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1565
  
clang-analyzer build *successful*! 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/287/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1565: Fix Assertion failure in the regex_revalidate plu...

2017-03-10 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1565
  
Intel CC build *successful*! 
https://ci.trafficserver.apache.org/job/icc-github/155/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1565: Fix Assertion failure in the regex_revalidate plu...

2017-03-10 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1565
  
Linux build *successful*! 
https://ci.trafficserver.apache.org/job/linux-github/1620/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1565: Fix Assertion failure in the regex_revalidate plu...

2017-03-10 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1565
  
FreeBSD11 build *successful*! 
https://ci.trafficserver.apache.org/job/freebsd-github/1725/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1565: Fix Assertion failure in the regex_revalidate plu...

2017-03-10 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1565
  
AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/29/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1565: Fix Assertion failure in the regex_revalidate plu...

2017-03-10 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1565
  
RAT check *successful*! 
https://ci.trafficserver.apache.org/job/RAT-github/43/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1565: Fix Assertion failure in the regex_revalidate plu...

2017-03-10 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1565
  
clang format *successful*! 
https://ci.trafficserver.apache.org/job/clang-format-github/30/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---