[GitHub] trafficserver issue #753: TS-4705: Proposal: NetVC Context
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/753 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/844/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #753: TS-4705: Proposal: NetVC Context
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/753 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/739/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #753: TS-4705: Proposal: NetVC Context
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/753 bugfix: In do_blocking_accept(), we should check the con.fd == NO_FD while we get return from check_emergency_throttle(). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #753: TS-4705: Proposal: NetVC Context
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/753 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/830/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #753: TS-4705: Proposal: NetVC Context
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/753 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/726/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #753: TS-4705: Proposal: NetVC Context
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/753 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/777/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #753: TS-4705: Proposal: NetVC Context
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/753 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/673/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #753: TS-4705: Proposal: NetVC Context
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/753 Depend on @jpeach's suggestion: - the return type of set_context is void now. - add ink_assert inside set_context() Also: - set NET_VCONNECTION_UNSET to 0 in the enum definition. - add comments for set_context() and get_context(). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #753: TS-4705: Proposal: NetVC Context
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/753 rebase after TS-4779 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #753: TS-4705: Proposal: NetVC Context
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/753 Looks good to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #753: TS-4705: Proposal: NetVC Context
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/753 @bryancall update the enums. ``` NET_VCONNECTION_UNSET, NET_VCONNECTION_IN, // Client <--> ATS, Client-Side NET_VCONNECTION_OUT, // ATS <--> Server, Server-Side ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #753: TS-4705: Proposal: NetVC Context
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/753 @oknet AFAIK, it's same. Please set type of JIRA 'improvement'. Currently all code changes are tracked by JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #753: TS-4705: Proposal: NetVC Context
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/753 @masaori335 JIRA issue created. BTW what is the proposal review progress ? Is it same as the bug report progress ? create JIRA issue then create PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
