[GitHub] trafficserver issue #995: TS-4731: Changes return codes for IsInternal APIs

2016-09-13 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/995 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/789/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #995: TS-4731: Changes return codes for IsInternal APIs

2016-09-13 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/995 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/685/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #995: TS-4731: Changes return codes for IsInternal APIs

2016-09-12 Thread bryancall
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/995 👍 - Looks good, but needs an update --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver issue #995: TS-4731: Changes return codes for IsInternal APIs

2016-09-09 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/995 Rebase! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver issue #995: TS-4731: Changes return codes for IsInternal APIs

2016-09-09 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/995 👍 Consider a heads-up email to dev@ since this change is likely to break 3rd party plugins. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #995: TS-4731: Changes return codes for IsInternal APIs

2016-09-08 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/995 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/649/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #995: TS-4731: Changes return codes for IsInternal APIs

2016-09-08 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/995 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/753/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #995: TS-4731: Changes return codes for IsInternal APIs

2016-09-08 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/995 Whomever is reviewing: Please make sure I got all the conditionals right, with the correct boolean logic. --- If your project is set up for it, you can reply to this email and have your reply