[GitHub] trafficserver pull request #1114: TS-4976: Remove useless casts from plugins...
Github user SolidWallOfCode closed the pull request at: https://github.com/apache/trafficserver/pull/1114 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1114: TS-4976: Remove useless casts from plugins...
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1114#discussion_r83854785
--- Diff: example/intercept/intercept.cc ---
@@ -538,9 +538,9 @@ TSPluginInit(int /* argc */, const char * /* argv */ [])
{
TSPluginRegistrationInfo info;
- info.plugin_name = (char *)PLUGIN;
- info.vendor_name = (char *)"MyCompany";
- info.support_email = (char *)"ts-api-supp...@mycompany.com";
+ info.plugin_name = PLUGIN;
+ info.vendor_name = "MyCompany";
+ info.support_email = "ts-api-supp...@mycompany.com";
--- End diff --
I fixed `example/add-header` and `example/append-transform` this way. See
if that looks reasonable. For `.cc` files I would replace `static` with the
anonymous namespace.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1114: TS-4976: Remove useless casts from plugins...
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1114#discussion_r83743000
--- Diff: plugins/experimental/ats_pagespeed/gzip/misc.cc ---
@@ -157,7 +157,7 @@ register_plugin()
const char *
load_dictionary(const char *preload_file)
{
- char *dict = (char *)malloc(80);
+ char *dict = malloc(80);
--- End diff --
That's outside the scope of this fix :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1114: TS-4976: Remove useless casts from plugins...
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1114#discussion_r83742164 --- Diff: plugins/experimental/mysql_remap/mysql_remap.cc --- @@ -232,7 +232,7 @@ TSPluginInit(int argc, const char *argv[]) return; } - data->query = (char *)TSmalloc(QSIZE * sizeof(char)); // TODO: malloc smarter sizes + data->query = TSmalloc(QSIZE * sizeof(char)); // TODO: malloc smarter sizes --- End diff -- Ah, that's not being compiled for me due to lack of mySQL packages. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
