[GitHub] trafficserver pull request #1608: FTP Support

2017-04-03 Thread clearswift
Github user clearswift commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1608#discussion_r109416571 --- Diff: proxy/http/HttpConfig.cc --- @@ -1129,6 +1129,8 @@ HttpConfig::startup() // Local Manager

[GitHub] trafficserver pull request #1608: FTP Support

2017-03-29 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1608#discussion_r108767725 --- Diff: proxy/http/HttpConfig.cc --- @@ -1129,6 +1129,8 @@ HttpConfig::startup() // Local Manager

[GitHub] trafficserver pull request #1608: FTP Support

2017-03-28 Thread dragon512
Github user dragon512 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1608#discussion_r108465171 --- Diff: ci/tsqa/tests/test_forward_proxy.py --- @@ -0,0 +1,123 @@ +''' --- End diff -- for the test engine what I have at the

[GitHub] trafficserver pull request #1608: FTP Support

2017-03-28 Thread clearswift
Github user clearswift commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1608#discussion_r108464212 --- Diff: ci/tsqa/tests/test_forward_proxy.py --- @@ -0,0 +1,123 @@ +''' --- End diff -- Is there documentation for the new AU

[GitHub] trafficserver pull request #1608: FTP Support

2017-03-28 Thread clearswift
Github user clearswift commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1608#discussion_r108463999 --- Diff: proxy/http/HttpConfig.h --- @@ -824,6 +824,8 @@ struct HttpConfigParams : public ConfigInfo { MgmtInt

[GitHub] trafficserver pull request #1608: FTP Support

2017-03-28 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1608#discussion_r108463799 --- Diff: ci/tsqa/tests/test_forward_proxy.py --- @@ -0,0 +1,123 @@ +''' --- End diff -- If at all possible, can you convert this to

[GitHub] trafficserver pull request #1608: FTP Support

2017-03-28 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1608#discussion_r108462625 --- Diff: proxy/http/HttpConfig.cc --- @@ -1129,6 +1129,8 @@ HttpConfig::startup() // Local Manager

[GitHub] trafficserver pull request #1608: FTP Support

2017-03-28 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1608#discussion_r108462430 --- Diff: proxy/http/HttpConfig.h --- @@ -824,6 +824,8 @@ struct HttpConfigParams : public ConfigInfo { MgmtInt