[GitHub] trafficserver pull request #851: TS-4548: Convert custom log config file to ...

[jpeach]

Github user jpeach closed the pull request at:

https://github.com/apache/trafficserver/pull/851


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #851: TS-4548: Convert custom log config file to ...

[jpeach]

Github user jpeach commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/851#discussion_r74668539
  
--- Diff: proxy/logging/LogConfig.cc ---
@@ -493,14 +494,21 @@ void
 LogConfig::setup_log_objects()
 {
   Debug("log", "creating objects...");
+  RecBool enable_lua = false;
+
+  RecGetRecordBool("proxy.config.log.config.enable_lua", _lua);
--- End diff --

Would prefer to do that as a separate Jira.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #851: TS-4548: Convert custom log config file to ...

[zwoop]

Github user zwoop commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/851#discussion_r74513800
  
--- Diff: proxy/logging/LogConfig.cc ---
@@ -493,14 +494,21 @@ void
 LogConfig::setup_log_objects()
 {
   Debug("log", "creating objects...");
+  RecBool enable_lua = false;
+
+  RecGetRecordBool("proxy.config.log.config.enable_lua", _lua);
--- End diff --

I think you should nuke this config, and just make the new config default.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #851: TS-4548: Convert custom log config file to ...

[jpeach]

GitHub user jpeach opened a pull request:

https://github.com/apache/trafficserver/pull/851

TS-4548: Convert custom log config file to Lua

Initial implementation of ``logging.config`` which is a Lua configuration 
file for custom logs.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jpeach/trafficserver lua/logging

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/851.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #851


commit 0611f3e5cc2d9bdb70796fa3a8d09f5d61a3ea84
Author: James Peach 
Date:   2016-08-02T02:17:34Z

TS-4548: Add lua_getfield helper.

commit 65fdb20c378cbcbdebb9dee98e1565a637608cd4
Author: James Peach 
Date:   2016-07-29T05:22:11Z

TS-4548: Convert logs_xml.config to Lua.

- Add Lua bindings for LogFormat, LogObject and LogFilter objects.
- Add the proxy.config.log.config.enable_lua setting to enable use of 
logging.config.
- Add a default logging.config configuration file.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---