[jira] [Commented] (TS-2334) --with-tcmalloc does not test whether the found library actually exists
[
https://issues.apache.org/jira/browse/TS-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14582541#comment-14582541
]
Phil Sorber commented on TS-2334:
-
[~esproul], Can you include this fix as well with TS-1153?
--with-tcmalloc does not test whether the found library actually exists
-
Key: TS-2334
URL: https://issues.apache.org/jira/browse/TS-2334
Project: Traffic Server
Issue Type: Bug
Components: Build
Affects Versions: 4.1.2, 4.2.0
Reporter: Igor Galić
Assignee: Eric Sproul
Fix For: sometime
Our {{TS_CHECK_TCMALLOC}} does not work.
I found this when compiling --with-tcmalloc on Ubuntu, where the {{tcmalloc}}
library is called {{tcmalloc_minimal}}. (And its corresponding -dev package,
will, intuitively be named {{libgoogle-perftools-dev}}. )
But none of this actually matters. I don't need to have any tcmalloc
libraries installed for this to fail horribly: {{-ltcmalloc}} will be added
to the build simply because I specified {{--with-tcmalloc}} this causes
pretty much everything in the configure run to break, or at least run with
defaults. (e.g.: glibc2 is not recognized to have a reentrant
{{gethostbyname()}}, see TS-2331)
proposal: ACTUALLY check if {{tcmalloc}} can be found, abort {{configure}} if
it can't.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-2334) --with-tcmalloc does not test whether the found library actually exists
[
https://issues.apache.org/jira/browse/TS-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817474#comment-13817474
]
Leif Hedstrom commented on TS-2334:
---
I'm not saying we shouldn't make the checks better, but the configure option
supports what you need. E.g.
{code}
--with-tcmalloc-lib=tcmalloc_minimal
{code}
--with-tcmalloc does not test whether the found library actually exists
-
Key: TS-2334
URL: https://issues.apache.org/jira/browse/TS-2334
Project: Traffic Server
Issue Type: Bug
Components: Build
Affects Versions: 4.1.0, 4.2.0
Reporter: Igor Galić
Our {{TS_CHECK_TCMALLOC}} does not work.
I found this when compiling --with-tcmalloc on Ubuntu, where the {{tcmalloc}}
library is called {{tcmalloc_minimal}}. (And its corresponding -dev package,
will, intuitively be named {{libgoogle-perftools-dev}}. )
But none of this actually matters. I don't need to have any tcmalloc
libraries installed for this to fail horribly: {{-ltcmalloc}} will be added
to the build simply because I specified {{--with-tcmalloc}} this causes
pretty much everything in the configure run to break, or at least run with
defaults. (e.g.: glibc2 is not recognized to have a reentrant
{{gethostbyname()}}, see TS-2331)
proposal: ACTUALLY check if {{tcmalloc}} can be found, abort {{configure}} if
it can't.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
Re: [jira] [Commented] (TS-2334) --with-tcmalloc does not test whether the found library actually exists
- Original Message -
[
https://issues.apache.org/jira/browse/TS-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817474#comment-13817474
]
Leif Hedstrom commented on TS-2334:
---
I'm not saying we shouldn't make the checks better, but the configure option
supports what you need. E.g.
{code}
--with-tcmalloc-lib=tcmalloc_minimal
{code}
yes it does. But even then it still doesn't work.
Test it yourself, please. Remove tcmalloc, configure --with-tcmalloc
--with-tcmalloc-lib=tcmalloc_lolwhut and
by not failing here and aborting, and instead happily continuing our journey
through configure we get stuff like this:
{code}
ink_inet.cc:59:23: error: no matching function for call to 'gethostbyname_r'
struct hostent *r = gethostbyname_r(hostname, data-ent, data-buf,
^~~
/usr/include/netdb.h:179:12: note: candidate function not viable: requires 6
arguments, but 5 were provided
extern int gethostbyname_r (const char *__restrict __name,
^
ink_inet.cc:83:23: error: no matching function for call to 'gethostbyaddr_r'
struct hostent *r = gethostbyaddr_r((char *) ip, len, type, data-ent,
^~~
{code}
-- i
--with-tcmalloc does not test whether the found library actually exists
-
Key: TS-2334
URL: https://issues.apache.org/jira/browse/TS-2334
Project: Traffic Server
Issue Type: Bug
Components: Build
Affects Versions: 4.1.0, 4.2.0
Reporter: Igor Galić
Our {{TS_CHECK_TCMALLOC}} does not work.
I found this when compiling --with-tcmalloc on Ubuntu, where the
{{tcmalloc}} library is called {{tcmalloc_minimal}}. (And its
corresponding -dev package, will, intuitively be named
{{libgoogle-perftools-dev}}. )
But none of this actually matters. I don't need to have any tcmalloc
libraries installed for this to fail horribly: {{-ltcmalloc}} will be
added to the build simply because I specified {{--with-tcmalloc}} this
causes pretty much everything in the configure run to break, or at least
run with defaults. (e.g.: glibc2 is not recognized to have a reentrant
{{gethostbyname()}}, see TS-2331)
proposal: ACTUALLY check if {{tcmalloc}} can be found, abort {{configure}}
if it can't.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
--
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.ga...@brainsware.org
URL: http://brainsware.org/
GPG: 8716 7A9F 989B ABD5 100F 4008 F266 55D6 2998 1641
[jira] [Commented] (TS-2334) --with-tcmalloc does not test whether the found library actually exists
[
https://issues.apache.org/jira/browse/TS-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817578#comment-13817578
]
Igor Galić commented on TS-2334:
yes it does. But even then it still doesn't work.
Test it yourself, please. Remove tcmalloc, configure --with-tcmalloc
--with-tcmalloc-lib=tcmalloc_lolwhut and
by not failing here and aborting, and instead happily continuing our journey
through configure we get stuff like this:
{code}
ink_inet.cc:59:23: error: no matching function for call to 'gethostbyname_r'
struct hostent *r = gethostbyname_r(hostname, data-ent, data-buf,
^~~
/usr/include/netdb.h:179:12: note: candidate function not viable: requires 6
arguments, but 5 were provided
extern int gethostbyname_r (const char *__restrict __name,
^
ink_inet.cc:83:23: error: no matching function for call to 'gethostbyaddr_r'
struct hostent *r = gethostbyaddr_r((char *) ip, len, type, data-ent,
^~~
{code}
--with-tcmalloc does not test whether the found library actually exists
-
Key: TS-2334
URL: https://issues.apache.org/jira/browse/TS-2334
Project: Traffic Server
Issue Type: Bug
Components: Build
Affects Versions: 4.1.0, 4.2.0
Reporter: Igor Galić
Our {{TS_CHECK_TCMALLOC}} does not work.
I found this when compiling --with-tcmalloc on Ubuntu, where the {{tcmalloc}}
library is called {{tcmalloc_minimal}}. (And its corresponding -dev package,
will, intuitively be named {{libgoogle-perftools-dev}}. )
But none of this actually matters. I don't need to have any tcmalloc
libraries installed for this to fail horribly: {{-ltcmalloc}} will be added
to the build simply because I specified {{--with-tcmalloc}} this causes
pretty much everything in the configure run to break, or at least run with
defaults. (e.g.: glibc2 is not recognized to have a reentrant
{{gethostbyname()}}, see TS-2331)
proposal: ACTUALLY check if {{tcmalloc}} can be found, abort {{configure}} if
it can't.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
