[
https://issues.apache.org/jira/browse/TS-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917907#comment-13917907
]
Leif Hedstrom commented on TS-2595:
---
The latest changes looks good, thanks!
DNS lookup
[
https://issues.apache.org/jira/browse/TS-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918103#comment-13918103
]
ASF subversion and git services commented on TS-2595:
-
Commit
[
https://issues.apache.org/jira/browse/TS-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918106#comment-13918106
]
ASF subversion and git services commented on TS-2595:
-
Commit
[
https://issues.apache.org/jira/browse/TS-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918105#comment-13918105
]
ASF subversion and git services commented on TS-2595:
-
Commit
[
https://issues.apache.org/jira/browse/TS-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918104#comment-13918104
]
ASF subversion and git services commented on TS-2595:
-
Commit
[
https://issues.apache.org/jira/browse/TS-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918158#comment-13918158
]
ASF GitHub Bot commented on TS-2595:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/TS-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917335#comment-13917335
]
Thach Tran commented on TS-2595:
Pull request updated with latest suggestion
[
https://issues.apache.org/jira/browse/TS-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917143#comment-13917143
]
Thach Tran commented on TS-2595:
I agree that we could simplify by not caring about trailing
[
https://issues.apache.org/jira/browse/TS-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917162#comment-13917162
]
Leif Hedstrom commented on TS-2595:
---
Oh, that's an excellent point! I definitely agree, if
[
https://issues.apache.org/jira/browse/TS-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915639#comment-13915639
]
Thach Tran commented on TS-2595:
I'm not sure what I did wrong but my github's pull request
[
https://issues.apache.org/jira/browse/TS-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915940#comment-13915940
]
Leif Hedstrom commented on TS-2595:
---
Looks good. I'd like to make the following change, it
[
https://issues.apache.org/jira/browse/TS-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914368#comment-13914368
]
Thach Tran commented on TS-2595:
I'm working on a fix for this and will submit a pull request
[
https://issues.apache.org/jira/browse/TS-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914938#comment-13914938
]
Leif Hedstrom commented on TS-2595:
---
Yes, sounds broken to me. Please submit a patch :).
13 matches
Mail list logo