[jira] [Commented] (TS-3152) We offer up H2-14 on current master, even when it's not working / supported
[
https://issues.apache.org/jira/browse/TS-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182834#comment-14182834
]
Leif Hedstrom commented on TS-3152:
---
isn't that what the proto tag is for?
We offer up H2-14 on current master, even when it's not working / supported
---
Key: TS-3152
URL: https://issues.apache.org/jira/browse/TS-3152
Project: Traffic Server
Issue Type: Bug
Components: HTTP/2
Reporter: Leif Hedstrom
Assignee: Alan M. Carroll
Fix For: 5.2.0
Attachments: TS-3152.diff, TS-3152.diff
E.g.
{code}
[root@ats ~]# /usr/local/bin/nghttp -v https://www.ogre.com
[ 0.112][NPN] server offers:
* spdy/3.1
* spdy/3
* h2-14
* http/1.1
* http/1.0
The negotiated protocol: h2-14
...
[ 0.156] send SETTINGS frame length=0, flags=0x01, stream_id=0
; ACK
(niv=0)
[ERROR] Network error
Some requests were not processed. total=1, processed=0
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-3152) We offer up H2-14 on current master, even when it's not working / supported
[
https://issues.apache.org/jira/browse/TS-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182888#comment-14182888
]
James Peach commented on TS-3152:
-
Well we should only enable a protocol by default when it is considered ready.
H2 is built-in so you always have it at compile time. SPDY has external
dependencies so in most cases you won't have it.
We offer up H2-14 on current master, even when it's not working / supported
---
Key: TS-3152
URL: https://issues.apache.org/jira/browse/TS-3152
Project: Traffic Server
Issue Type: Bug
Components: HTTP/2
Reporter: Leif Hedstrom
Assignee: Alan M. Carroll
Fix For: 5.2.0
Attachments: TS-3152.diff, TS-3152.diff
E.g.
{code}
[root@ats ~]# /usr/local/bin/nghttp -v https://www.ogre.com
[ 0.112][NPN] server offers:
* spdy/3.1
* spdy/3
* h2-14
* http/1.1
* http/1.0
The negotiated protocol: h2-14
...
[ 0.156] send SETTINGS frame length=0, flags=0x01, stream_id=0
; ACK
(niv=0)
[ERROR] Network error
Some requests were not processed. total=1, processed=0
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-3152) We offer up H2-14 on current master, even when it's not working / supported
[
https://issues.apache.org/jira/browse/TS-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183054#comment-14183054
]
Leif Hedstrom commented on TS-3152:
---
Agreed. With SPDY it's easy since it's explicit but with H2 I wouldn't expect
it to announce it unless it's stable. I'm guessing we won't have a build option
for H2 so my comments were more related to how things are today.
We offer up H2-14 on current master, even when it's not working / supported
---
Key: TS-3152
URL: https://issues.apache.org/jira/browse/TS-3152
Project: Traffic Server
Issue Type: Bug
Components: HTTP/2
Reporter: Leif Hedstrom
Assignee: Alan M. Carroll
Fix For: 5.2.0
Attachments: TS-3152.diff, TS-3152.diff
E.g.
{code}
[root@ats ~]# /usr/local/bin/nghttp -v https://www.ogre.com
[ 0.112][NPN] server offers:
* spdy/3.1
* spdy/3
* h2-14
* http/1.1
* http/1.0
The negotiated protocol: h2-14
...
[ 0.156] send SETTINGS frame length=0, flags=0x01, stream_id=0
; ACK
(niv=0)
[ERROR] Network error
Some requests were not processed. total=1, processed=0
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-3152) We offer up H2-14 on current master, even when it's not working / supported
[
https://issues.apache.org/jira/browse/TS-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183719#comment-14183719
]
ASF subversion and git services commented on TS-3152:
-
Commit ef45a39f8b04a143a507bd2a997adc9a0c16d7d9 in trafficserver's branch
refs/heads/master from [~jpe...@apache.org]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=ef45a39 ]
TS-3152: stop offerring HTTP/2 over TLS by default
We should only enable a protocol by default when it is considered
ready. HTTP/2 is built-in so you always have it at compile time.
SPDY has external dependencies so in most cases you won't have it.
We offer up H2-14 on current master, even when it's not working / supported
---
Key: TS-3152
URL: https://issues.apache.org/jira/browse/TS-3152
Project: Traffic Server
Issue Type: Bug
Components: HTTP/2
Reporter: Leif Hedstrom
Assignee: Alan M. Carroll
Fix For: 5.2.0
Attachments: TS-3152.diff
E.g.
{code}
[root@ats ~]# /usr/local/bin/nghttp -v https://www.ogre.com
[ 0.112][NPN] server offers:
* spdy/3.1
* spdy/3
* h2-14
* http/1.1
* http/1.0
The negotiated protocol: h2-14
...
[ 0.156] send SETTINGS frame length=0, flags=0x01, stream_id=0
; ACK
(niv=0)
[ERROR] Network error
Some requests were not processed. total=1, processed=0
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-3152) We offer up H2-14 on current master, even when it's not working / supported
[
https://issues.apache.org/jira/browse/TS-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182298#comment-14182298
]
bettydramit commented on TS-3152:
-
with ts-3152.diff
Test with nghttp
nghttp -v https://aaa.verycdn.cn/a.html
[ 0.080][NPN] server offers:
* http/1.1
* http/1.0
[ERROR] HTTP/2 protocol was not selected. (nghttp2 expects h2-14)
[ERROR] Could not connect to the host
Some requests were not processed. total=1, processed=0
We offer up H2-14 on current master, even when it's not working / supported
---
Key: TS-3152
URL: https://issues.apache.org/jira/browse/TS-3152
Project: Traffic Server
Issue Type: Bug
Components: HTTP/2
Reporter: Leif Hedstrom
Assignee: Alan M. Carroll
Fix For: 5.2.0
Attachments: TS-3152.diff
E.g.
{code}
[root@ats ~]# /usr/local/bin/nghttp -v https://www.ogre.com
[ 0.112][NPN] server offers:
* spdy/3.1
* spdy/3
* h2-14
* http/1.1
* http/1.0
The negotiated protocol: h2-14
...
[ 0.156] send SETTINGS frame length=0, flags=0x01, stream_id=0
; ACK
(niv=0)
[ERROR] Network error
Some requests were not processed. total=1, processed=0
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-3152) We offer up H2-14 on current master, even when it's not working / supported
[
https://issues.apache.org/jira/browse/TS-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182352#comment-14182352
]
James Peach commented on TS-3152:
-
-1 on the compile-time HTTP/2 patch. This should just default to off and only
be enabled when it is explicitly specified on a port.
We offer up H2-14 on current master, even when it's not working / supported
---
Key: TS-3152
URL: https://issues.apache.org/jira/browse/TS-3152
Project: Traffic Server
Issue Type: Bug
Components: HTTP/2
Reporter: Leif Hedstrom
Assignee: Alan M. Carroll
Fix For: 5.2.0
Attachments: TS-3152.diff
E.g.
{code}
[root@ats ~]# /usr/local/bin/nghttp -v https://www.ogre.com
[ 0.112][NPN] server offers:
* spdy/3.1
* spdy/3
* h2-14
* http/1.1
* http/1.0
The negotiated protocol: h2-14
...
[ 0.156] send SETTINGS frame length=0, flags=0x01, stream_id=0
; ACK
(niv=0)
[ERROR] Network error
Some requests were not processed. total=1, processed=0
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-3152) We offer up H2-14 on current master, even when it's not working / supported
[
https://issues.apache.org/jira/browse/TS-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182366#comment-14182366
]
Leif Hedstrom commented on TS-3152:
---
Hmmm, I guess I don't understand the issue here. The docs say, and I agree with
that, that if I just specify ssl, it'll use all supported protocols. What I
had expected to happen is this:
1) If I compile with SPDY enabled, it would then offer SPDY, unless I tell it
not to.
2) If I compile it with H2 enabled, it would then offer H2, unless I tell it
not to.
Having to manually enable these things both at compile time and then again at
config time seems annoying at best, and probably even confusing. I'd venture a
guess that if you compile with e.g. SPDY support, you want that to be on by
default.
We offer up H2-14 on current master, even when it's not working / supported
---
Key: TS-3152
URL: https://issues.apache.org/jira/browse/TS-3152
Project: Traffic Server
Issue Type: Bug
Components: HTTP/2
Reporter: Leif Hedstrom
Assignee: Alan M. Carroll
Fix For: 5.2.0
Attachments: TS-3152.diff
E.g.
{code}
[root@ats ~]# /usr/local/bin/nghttp -v https://www.ogre.com
[ 0.112][NPN] server offers:
* spdy/3.1
* spdy/3
* h2-14
* http/1.1
* http/1.0
The negotiated protocol: h2-14
...
[ 0.156] send SETTINGS frame length=0, flags=0x01, stream_id=0
; ACK
(niv=0)
[ERROR] Network error
Some requests were not processed. total=1, processed=0
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-3152) We offer up H2-14 on current master, even when it's not working / supported
[
https://issues.apache.org/jira/browse/TS-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14180477#comment-14180477
]
Leif Hedstrom commented on TS-3152:
---
Also, reading the docs, server_ports implies that if you specify ssl, it will
by default offer up all supported protocols for NPN/ALPN. But H2-14 ought to
not be one of those :).
We offer up H2-14 on current master, even when it's not working / supported
---
Key: TS-3152
URL: https://issues.apache.org/jira/browse/TS-3152
Project: Traffic Server
Issue Type: Bug
Components: HTTP/2
Reporter: Leif Hedstrom
E.g.
{code}
[root@ats ~]# /usr/local/bin/nghttp -v https://www.ogre.com
[ 0.112][NPN] server offers:
* spdy/3.1
* spdy/3
* h2-14
* http/1.1
* http/1.0
The negotiated protocol: h2-14
...
[ 0.156] send SETTINGS frame length=0, flags=0x01, stream_id=0
; ACK
(niv=0)
[ERROR] Network error
Some requests were not processed. total=1, processed=0
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-3152) We offer up H2-14 on current master, even when it's not working / supported
[
https://issues.apache.org/jira/browse/TS-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14180678#comment-14180678
]
Alan M. Carroll commented on TS-3152:
-
It's even worse. We offer SPDY even if SPDY wasn't configured and compiled.
That should fixed.
We offer up H2-14 on current master, even when it's not working / supported
---
Key: TS-3152
URL: https://issues.apache.org/jira/browse/TS-3152
Project: Traffic Server
Issue Type: Bug
Components: HTTP/2
Reporter: Leif Hedstrom
Fix For: 5.2.0
E.g.
{code}
[root@ats ~]# /usr/local/bin/nghttp -v https://www.ogre.com
[ 0.112][NPN] server offers:
* spdy/3.1
* spdy/3
* h2-14
* http/1.1
* http/1.0
The negotiated protocol: h2-14
...
[ 0.156] send SETTINGS frame length=0, flags=0x01, stream_id=0
; ACK
(niv=0)
[ERROR] Network error
Some requests were not processed. total=1, processed=0
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
