[jira] [Commented] (TS-3272) TS_SSL_SNI_HOOK continuously called
[ https://issues.apache.org/jira/browse/TS-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280269#comment-14280269 ] Lev Stipakov commented on TS-3272: -- Yep, works fine now. TS_SSL_SNI_HOOK continuously called Key: TS-3272 URL: https://issues.apache.org/jira/browse/TS-3272 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Lev Stipakov Assignee: Susan Hinrichs Fix For: 5.3.0 Attachments: SSLNetVConnection.patch, plugin.cc, ts-3272-2.diff, ts-3272-3.diff, ts-3272-4.diff, ts-3272-5.diff, ts-3272-master.diff, ts-3272.diff I have created a simple plugin with TS_SSL_SNI_HOOK handler. Handler starts thread. Thread function has small sleep and after that calls TSVConnTunnel. The problem is that during sleep duration TS_SSL_SNI_HOOK handler gets continuously called. I would expect that TS_SSL_SNI_HOOK handler should be called just once. See plugin code in attach. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3272) TS_SSL_SNI_HOOK continuously called
[ https://issues.apache.org/jira/browse/TS-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281128#comment-14281128 ] ASF subversion and git services commented on TS-3272: - Commit c1d845910b33e3a82d840ac9085627dd0bcdbc41 in trafficserver's branch refs/heads/master from shinrich [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=c1d8459 ] TS-3272: SNI callback called too often TS_SSL_SNI_HOOK continuously called Key: TS-3272 URL: https://issues.apache.org/jira/browse/TS-3272 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Lev Stipakov Assignee: Susan Hinrichs Fix For: 5.3.0 Attachments: SSLNetVConnection.patch, plugin.cc, ts-3272-2.diff, ts-3272-3.diff, ts-3272-4.diff, ts-3272-5.diff, ts-3272-master.diff, ts-3272.diff I have created a simple plugin with TS_SSL_SNI_HOOK handler. Handler starts thread. Thread function has small sleep and after that calls TSVConnTunnel. The problem is that during sleep duration TS_SSL_SNI_HOOK handler gets continuously called. I would expect that TS_SSL_SNI_HOOK handler should be called just once. See plugin code in attach. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3272) TS_SSL_SNI_HOOK continuously called
[ https://issues.apache.org/jira/browse/TS-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14277011#comment-14277011 ] Lev Stipakov commented on TS-3272: -- Just noticed that if thread function calls only TSVConnReenable (and not TSVConnTunnel), TS_SSL_SNI_HOOK gets called again. It starts / pushes task to a thread, which calls TSVConnReenable and we're in a loop. It does not happen if TSVConnReenable is called directly from TS_SSL_SNI_HOOK. TS_SSL_SNI_HOOK continuously called Key: TS-3272 URL: https://issues.apache.org/jira/browse/TS-3272 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Lev Stipakov Assignee: Susan Hinrichs Fix For: 5.3.0 Attachments: SSLNetVConnection.patch, plugin.cc, ts-3272-2.diff, ts-3272-3.diff, ts-3272-4.diff, ts-3272-master.diff, ts-3272.diff I have created a simple plugin with TS_SSL_SNI_HOOK handler. Handler starts thread. Thread function has small sleep and after that calls TSVConnTunnel. The problem is that during sleep duration TS_SSL_SNI_HOOK handler gets continuously called. I would expect that TS_SSL_SNI_HOOK handler should be called just once. See plugin code in attach. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3272) TS_SSL_SNI_HOOK continuously called
[ https://issues.apache.org/jira/browse/TS-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271766#comment-14271766 ] ASF subversion and git services commented on TS-3272: - Commit 5862f45ba323095ede6ba4300e8415f0c2b6 in trafficserver's branch refs/heads/master from shinrich [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=5862f45 ] TS-3272: Another fix for the preaccept callback. TS_SSL_SNI_HOOK continuously called Key: TS-3272 URL: https://issues.apache.org/jira/browse/TS-3272 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Lev Stipakov Assignee: Susan Hinrichs Fix For: 5.3.0 Attachments: SSLNetVConnection.patch, plugin.cc, ts-3272-2.diff, ts-3272-3.diff, ts-3272-4.diff, ts-3272-master.diff, ts-3272.diff I have created a simple plugin with TS_SSL_SNI_HOOK handler. Handler starts thread. Thread function has small sleep and after that calls TSVConnTunnel. The problem is that during sleep duration TS_SSL_SNI_HOOK handler gets continuously called. I would expect that TS_SSL_SNI_HOOK handler should be called just once. See plugin code in attach. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3272) TS_SSL_SNI_HOOK continuously called
[ https://issues.apache.org/jira/browse/TS-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269722#comment-14269722 ] Lev Stipakov commented on TS-3272: -- In patch v2 sslServerHandShakeEvent() function returns EVENT_CONT instead of SSL_WAIT_FOR_HOOK, so we got original problem again. TS_SSL_SNI_HOOK continuously called Key: TS-3272 URL: https://issues.apache.org/jira/browse/TS-3272 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Lev Stipakov Assignee: Susan Hinrichs Fix For: 5.3.0 Attachments: SSLNetVConnection.patch, plugin.cc, ts-3272-2.diff, ts-3272.diff I have created a simple plugin with TS_SSL_SNI_HOOK handler. Handler starts thread. Thread function has small sleep and after that calls TSVConnTunnel. The problem is that during sleep duration TS_SSL_SNI_HOOK handler gets continuously called. I would expect that TS_SSL_SNI_HOOK handler should be called just once. See plugin code in attach. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3272) TS_SSL_SNI_HOOK continuously called
[ https://issues.apache.org/jira/browse/TS-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269876#comment-14269876 ] Susan Hinrichs commented on TS-3272: Sorry! I noticed that omission while getting ready to commit. Fixing up now. TS_SSL_SNI_HOOK continuously called Key: TS-3272 URL: https://issues.apache.org/jira/browse/TS-3272 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Lev Stipakov Assignee: Susan Hinrichs Fix For: 5.3.0 Attachments: SSLNetVConnection.patch, plugin.cc, ts-3272-2.diff, ts-3272.diff I have created a simple plugin with TS_SSL_SNI_HOOK handler. Handler starts thread. Thread function has small sleep and after that calls TSVConnTunnel. The problem is that during sleep duration TS_SSL_SNI_HOOK handler gets continuously called. I would expect that TS_SSL_SNI_HOOK handler should be called just once. See plugin code in attach. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3272) TS_SSL_SNI_HOOK continuously called
[ https://issues.apache.org/jira/browse/TS-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269925#comment-14269925 ] ASF subversion and git services commented on TS-3272: - Commit aaf5d6bfaebe978c23f75f7fbde441ba83454acf in trafficserver's branch refs/heads/master from [~shinrich] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=aaf5d6b ] TS-3272: TS_SSL_SNI_HOOK continuously called. TS_SSL_SNI_HOOK continuously called Key: TS-3272 URL: https://issues.apache.org/jira/browse/TS-3272 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Lev Stipakov Assignee: Susan Hinrichs Fix For: 5.3.0 Attachments: SSLNetVConnection.patch, plugin.cc, ts-3272-2.diff, ts-3272-3.diff, ts-3272.diff I have created a simple plugin with TS_SSL_SNI_HOOK handler. Handler starts thread. Thread function has small sleep and after that calls TSVConnTunnel. The problem is that during sleep duration TS_SSL_SNI_HOOK handler gets continuously called. I would expect that TS_SSL_SNI_HOOK handler should be called just once. See plugin code in attach. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3272) TS_SSL_SNI_HOOK continuously called
[ https://issues.apache.org/jira/browse/TS-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14265343#comment-14265343 ] Lev Stipakov commented on TS-3272: -- I have noticed that in SSLNetVConnection::net_read_io() readSignalDone is called twice: https://github.com/apache/trafficserver/blob/master/iocore/net/SSLNetVConnection.cc#L444 https://github.com/apache/trafficserver/blob/master/iocore/net/SSLNetVConnection.cc#L466 I wonder if this is correct. TS_SSL_SNI_HOOK continuously called Key: TS-3272 URL: https://issues.apache.org/jira/browse/TS-3272 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Lev Stipakov Assignee: Susan Hinrichs Fix For: 5.3.0 Attachments: SSLNetVConnection.patch, plugin.cc, ts-3272.diff I have created a simple plugin with TS_SSL_SNI_HOOK handler. Handler starts thread. Thread function has small sleep and after that calls TSVConnTunnel. The problem is that during sleep duration TS_SSL_SNI_HOOK handler gets continuously called. I would expect that TS_SSL_SNI_HOOK handler should be called just once. See plugin code in attach. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
