[jira] [Updated] (ZOOKEEPER-4804) Use daemon threads for Netty client

[Zili Chen (Jira)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-4804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zili Chen updated ZOOKEEPER-4804:
-
Fix Version/s: 3.10.0

> Use daemon threads for Netty client
> ---
>
> Key: ZOOKEEPER-4804
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4804
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.8.3
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.10.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> When the Netty client is used, the Java process hangs on System.exit if there 
> is an open Zookeeper connection.
> This is caused by the non-daemon threads created by Netty.
> Exiting without closing the connection is not a good practice, but this hang 
> does not happen with the NIO client, and I think ZK should behave the same 
> regardless of the client implementation used.
> The Netty ThreadFactory implementation is configurable, it shouldn't be too 
> hard make sure that daemon threads are created.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (ZOOKEEPER-4276) Serving only with secureClientPort fails

[Zili Chen (Jira)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-4276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zili Chen resolved ZOOKEEPER-4276.
--
Fix Version/s: 3.10.0
 Assignee: Abhilash Kishore
   Resolution: Fixed

master via bc1fc6d36435d3fad7b31642b647dc7680d7866e.

> Serving only with secureClientPort fails
> 
>
> Key: ZOOKEEPER-4276
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4276
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.7.0, 3.5.8, 3.6.2, 3.8.0
>Reporter: Kei Kori
>Assignee: Abhilash Kishore
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.10.0
>
>  Time Spent: 3h
>  Remaining Estimate: 0h
>
> clientPort in zoo.cfg is forcefully complemented from client address by 
> QuorumPeerConfig#setupClientPort even though secureClientPort is set and 
> matches with client address' port.
> Because of this behavior, in case rolling update with replacing clientPort to 
> secureClientPort in the same port number following [Upgrading existing 
> non-TLS cluster with no 
> downtime|https://zookeeper.apache.org/doc/r3.7.0/zookeeperAdmin.html#Upgrading+existing+nonTLS+cluster]
>  conflicts and gets errors below.
> {code}
> 2021-03-29 23:21:58,638 - INFO  [main:NettyServerCnxnFactory@590] - binding 
> to port /0.0.0.0:2281
> 2021-03-29 23:21:58,748 - INFO  [main:NettyServerCnxnFactory@595] - bound to 
> port 2281
> 2021-03-29 23:21:58,749 - INFO  [main:NettyServerCnxnFactory@590] - binding 
> to port 0.0.0.0/0.0.0.0:2281
> 2021-03-29 23:21:58,753 - ERROR [main:QuorumPeerMain@101] - Unexpected 
> exception, exiting abnormally
> java.net.BindException: Address already in use
> {code}
> QuorumPeerConfig#setupClientPort should complement only when both clientPort 
> and secureClientPort are empty, and allow serving zookeeper server only with 
> secure client port.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)