[jira] [Commented] (ZOOKEEPER-4804) Use daemon threads for Netty client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-4804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829215#comment-17829215 ] Istvan Toth commented on ZOOKEEPER-4804: I think this is important enopugh to be backported to all active branches. FYI [~andor] > Use daemon threads for Netty client > --- > > Key: ZOOKEEPER-4804 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4804 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.8.3 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Labels: pull-request-available > Fix For: 3.10.0 > > Time Spent: 50m > Remaining Estimate: 0h > > When the Netty client is used, the Java process hangs on System.exit if there > is an open Zookeeper connection. > This is caused by the non-daemon threads created by Netty. > Exiting without closing the connection is not a good practice, but this hang > does not happen with the NIO client, and I think ZK should behave the same > regardless of the client implementation used. > The Netty ThreadFactory implementation is configurable, it shouldn't be too > hard make sure that daemon threads are created. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ZOOKEEPER-4804) Use daemon threads for Netty client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-4804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819679#comment-17819679 ] Istvan Toth commented on ZOOKEEPER-4804: I have uploaded a PR with the fix [~eolivelli]. > Use daemon threads for Netty client > --- > > Key: ZOOKEEPER-4804 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4804 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.8.3 >Reporter: Istvan Toth >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > When the Netty client is used, the Java process hangs on System.exit if there > is an open Zookeeper connection. > This is caused by the non-daemon threads created by Netty. > Exiting without closing the connection is not a good practice, but this hang > does not happen with the NIO client, and I think ZK should behave the same > regardless of the client implementation used. > The Netty ThreadFactory implementation is configurable, it shouldn't be too > hard make sure that daemon threads are created. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ZOOKEEPER-4804) Use daemon threads for Netty client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-4804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815593#comment-17815593 ] Istvan Toth commented on ZOOKEEPER-4804: I don't have the time right now. Maybe in a few weeks, but if anyone feels like doing this, don't wait for me. > Use daemon threads for Netty client > --- > > Key: ZOOKEEPER-4804 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4804 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.8.3 >Reporter: Istvan Toth >Priority: Major > > When the Netty client is used, the Java process hangs on System.exit if there > is an open Zookeeper connection. > This is caused by the non-daemon threads created by Netty. > Exiting without closing the connection is not a good practice, but this hang > does not happen with the NIO client, and I think ZK should behave the same > regardless of the client implementation used. > The Netty ThreadFactory implementation is configurable, it shouldn't be too > hard make sure that daemon threads are created. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ZOOKEEPER-4804) Use daemon threads for Netty client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-4804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815569#comment-17815569 ] Enrico Olivelli commented on ZOOKEEPER-4804: would you like to send a PR ? > Use daemon threads for Netty client > --- > > Key: ZOOKEEPER-4804 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4804 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.8.3 >Reporter: Istvan Toth >Priority: Major > > When the Netty client is used, the Java process hangs on System.exit if there > is an open Zookeeper connection. > This is caused by the non-daemon threads created by Netty. > Exiting without closing the connection is not a good practice, but this hang > does not happen with the NIO client, and I think ZK should behave the same > regardless of the client implementation used. > The Netty ThreadFactory implementation is configurable, it shouldn't be too > hard make sure that daemon threads are created. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ZOOKEEPER-4804) Use daemon threads for Netty client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-4804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815563#comment-17815563 ] Istvan Toth commented on ZOOKEEPER-4804: FYI [~andor]. > Use daemon threads for Netty client > --- > > Key: ZOOKEEPER-4804 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4804 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.8.3 >Reporter: Istvan Toth >Priority: Major > > When the Netty client is used, the Java process hangs on System.exit if there > is an open Zookeeper connection. > This is caused by the non-daemon threads created by Netty. > Exiting without closing the connection is not a good practice, but this hang > does not happen with the NIO client, and I think ZK should behave the same > regardless of the client implementation used. > The Netty ThreadFactory implementation is configurable, it shouldn't be too > hard make sure that daemon threads are created. -- This message was sent by Atlassian Jira (v8.20.10#820010)
