[jira] [Commented] (ZOOKEEPER-4829) Support DatadirCleanup in minutes

2024-04-24 Thread Purshotam Shah (Jira)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840507#comment-17840507
 ] 

Purshotam Shah commented on ZOOKEEPER-4829:
---

I'll be contributing a patch.

Indeed, the problem was resolved by switching to a larger disk. The system 
generated many snapshots, and with the deletion interval set at one hour, the 
disk filled up quickly.

However, we only needed a few snapshots. In this case, the larger disk was not 
necessary.

> Support DatadirCleanup in minutes
> -
>
> Key: ZOOKEEPER-4829
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4829
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Purshotam Shah
>Priority: Major
>
> On the cloud, space can be limited. Currently, the DatadirCleanup only 
> supports hours; we should also support cleanup intervals in minutes.
>  
> {code:java}
> 2024-02-20 20:55:28,862 - WARN  
> [QuorumPeer[myid=5](plain=disabled)(secure=[0:0:0:0:0:0:0:0]:50512):o.a.z.s.q.Follower@131]
>  - Exception when following the leader
> java.io.IOException: No space left on device
>     at java.base/java.io.FileOutputStream.writeBytes(Native Method)
>     at java.base/java.io.FileOutputStream.write(FileOutputStream.java:354)
>     at 
> org.apache.zookeeper.common.AtomicFileOutputStream.write(AtomicFileOutputStream.java:72)
>     at java.base/sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:233)
>     at 
> java.base/sun.nio.cs.StreamEncoder.implFlushBuffer(StreamEncoder.java:312)
>     at java.base/sun.nio.cs.StreamEncoder.implFlush(StreamEncoder.java:316)
>     at java.base/sun.nio.cs.StreamEncoder.flush(StreamEncoder.java:153)
>     at java.base/java.io.OutputStreamWriter.flush(OutputStreamWriter.java:251)
>     at java.base/java.io.BufferedWriter.flush(BufferedWriter.java:257)
>     at 
> org.apache.zookeeper.common.AtomicFileWritingIdiom.(AtomicFileWritingIdiom.java:72)
>     at 
> org.apache.zookeeper.common.AtomicFileWritingIdiom.(AtomicFileWritingIdiom.java:54)
>     at 
> org.apache.zookeeper.server.quorum.QuorumPeer.writeLongToFile(QuorumPeer.java:2229)
>     at 
> org.apache.zookeeper.server.quorum.QuorumPeer.setAcceptedEpoch(QuorumPeer.java:2258)
>     at 
> org.apache.zookeeper.server.quorum.Learner.registerWithLeader(Learner.java:511)
>     at 
> org.apache.zookeeper.server.quorum.Follower.followLeader(Follower.java:91)
>     at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:1551)
> 2024-02-20 20:55:28,863 - INFO  
> [QuorumPeer[myid=5](plain=disabled)(secure=[0:0:0:0:0:0:0:0]:50512):o.a.z.s.q.Follower@145]{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ZOOKEEPER-4829) Support DatadirCleanup in minutes

2024-04-23 Thread Enrico Olivelli (Jira)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840275#comment-17840275
 ] 

Enrico Olivelli commented on ZOOKEEPER-4829:


Would you like to contribute a patch?

 

 

Side comment: this is a pretty unusual request, I have seeing many 
installations of ZK in the cloud on k8s and I have heard about such problem.

Did you consider using a bigger disk? Running maintenance top often may impact 
latency.

> Support DatadirCleanup in minutes
> -
>
> Key: ZOOKEEPER-4829
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4829
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Purshotam Shah
>Priority: Major
>
> On the cloud, space can be limited. Currently, the DatadirCleanup only 
> supports hours; we should also support cleanup intervals in minutes.
>  
> {code:java}
> 2024-02-20 20:55:28,862 - WARN  
> [QuorumPeer[myid=5](plain=disabled)(secure=[0:0:0:0:0:0:0:0]:50512):o.a.z.s.q.Follower@131]
>  - Exception when following the leader
> java.io.IOException: No space left on device
>     at java.base/java.io.FileOutputStream.writeBytes(Native Method)
>     at java.base/java.io.FileOutputStream.write(FileOutputStream.java:354)
>     at 
> org.apache.zookeeper.common.AtomicFileOutputStream.write(AtomicFileOutputStream.java:72)
>     at java.base/sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:233)
>     at 
> java.base/sun.nio.cs.StreamEncoder.implFlushBuffer(StreamEncoder.java:312)
>     at java.base/sun.nio.cs.StreamEncoder.implFlush(StreamEncoder.java:316)
>     at java.base/sun.nio.cs.StreamEncoder.flush(StreamEncoder.java:153)
>     at java.base/java.io.OutputStreamWriter.flush(OutputStreamWriter.java:251)
>     at java.base/java.io.BufferedWriter.flush(BufferedWriter.java:257)
>     at 
> org.apache.zookeeper.common.AtomicFileWritingIdiom.(AtomicFileWritingIdiom.java:72)
>     at 
> org.apache.zookeeper.common.AtomicFileWritingIdiom.(AtomicFileWritingIdiom.java:54)
>     at 
> org.apache.zookeeper.server.quorum.QuorumPeer.writeLongToFile(QuorumPeer.java:2229)
>     at 
> org.apache.zookeeper.server.quorum.QuorumPeer.setAcceptedEpoch(QuorumPeer.java:2258)
>     at 
> org.apache.zookeeper.server.quorum.Learner.registerWithLeader(Learner.java:511)
>     at 
> org.apache.zookeeper.server.quorum.Follower.followLeader(Follower.java:91)
>     at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:1551)
> 2024-02-20 20:55:28,863 - INFO  
> [QuorumPeer[myid=5](plain=disabled)(secure=[0:0:0:0:0:0:0:0]:50512):o.a.z.s.q.Follower@145]{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)