[
https://issues.apache.org/jira/browse/IMPALA-12469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771216#comment-17771216
]
ASF subversion and git services commented on IMPALA-12469:
----------------------------------------------------------
Commit 80af98645baf095765c87cd2287cf49fec86fa4a in impala's branch
refs/heads/master from Peter Rozsa
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=80af98645 ]
IMPALA-12469: Allow short if statements on a single line in clang-format
This change allows short if statements and blocks to be put on a single
line, clang-format will keep these constructions as-is.
Change-Id: I65d04f00187648fafab89c82cb01ffd9ea17c4bb
Reviewed-on: http://gerrit.cloudera.org:8080/20513
Reviewed-by: Daniel Becker <daniel.bec...@cloudera.com>
Reviewed-by: Tamas Mate <tma...@apache.org>
Tested-by: Tamas Mate <tma...@apache.org>
> Allow short if statements on a single line in clang-format
> ----------------------------------------------------------
>
> Key: IMPALA-12469
> URL: https://issues.apache.org/jira/browse/IMPALA-12469
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: Impala 4.2.0
> Reporter: Peter Rozsa
> Assignee: Peter Rozsa
> Priority: Trivial
> Fix For: Impala 4.3.0
>
>
> Impala's Java codebase uses a lot of oneliner if statements like:
> {code:java}
> if (ifExists_) { sb.append("IF EXISTS "); } {code}
> The .clang-format file does not reflect this, the following rules are missing:
> {code:java}
> AllowShortIfStatementsOnASingleLine: true
> AllowShortBlocksOnASingleLine: true {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
