[
https://issues.apache.org/jira/browse/IMPALA-12762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812512#comment-17812512
]
ASF subversion and git services commented on IMPALA-12762:
----------------------------------------------------------
Commit 18a77cd3bcafa7d650177ad8b6ad1db8cf21a21d in impala's branch
refs/heads/master from zhangyifan27
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=18a77cd3b ]
IMPALA-12762: Fix cmake error in package building
This patch adds extra processing of option 'BUILD_WITH_NO_TESTS' in
be/src/exec/json/CMakeLists.txt, so test targets will not be generated
by the CMake when building Impala with -package and -notests.
Testing:
- Run './buildall.sh -noclean -notests -package' with no error
Change-Id: Ice0cbb0671d915f997fa74217521a82be164ae57
Reviewed-on: http://gerrit.cloudera.org:8080/20965
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> Build package from scratch failed by cmake error
> ------------------------------------------------
>
> Key: IMPALA-12762
> URL: https://issues.apache.org/jira/browse/IMPALA-12762
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: Impala 4.3.0
> Reporter: Quanlong Huang
> Assignee: YifanZhang
> Priority: Major
>
> Saw the following error when building the RPM package from scratch:
> {noformat}
> CMake Error at be/CMakeLists.txt:774 (ADD_DEPENDENCIES):
> Cannot add target-level dependencies to non-existent target
> "unified-be-test".
> The add_dependencies works for top-level logical targets created by the
> add_executable, add_library, or add_custom_target commands. If you want to
> add file-level dependencies see the DEPENDS option of the add_custom_target
> and add_custom_command commands.
> Call Stack (most recent call first):
> be/CMakeLists.txt:795 (ADD_UNIFIED_BE_TEST)
> be/src/exec/json/CMakeLists.txt:36 (ADD_UNIFIED_BE_LSAN_TEST) {noformat}
> The command is
> {code:java}
> ./buildall.sh -noclean -notests -package{code}
> or
> {code:java}
> ./buildall.sh -noclean -notests -release -package{code}
> However, if I build the binaries (including tests) with -package, it succeeds.
> {code:java}
> ./buildall.sh -noclean -skiptests -release -package{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
