[ 
https://issues.apache.org/jira/browse/IMPALA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821808#comment-17821808
 ] 

ASF subversion and git services commented on IMPALA-12847:
----------------------------------------------------------

Commit e4fa1b8c8f4f2935d1c630628e39aefbbfd2a3c3 in impala's branch 
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=e4fa1b8c8 ]

IMPALA-12847: Expose computeScanRangeLocations and computeStats

After IMPALA-12631, HdfsScanNode.computeScanRangeLocations() need check
if countStarSlot_ is null or not to schedule footer range only.
HdfsScanNode.computeScanRangeLocations() is called along with
HdfsScanNode.init() call.

An external frontend that has its own count star slot analysis and
initialization will need to recompute scan range assignment and stats
after HdfsScanNode.init(). Therefore, computeScanRangeLocations() and
computeStats() should be made idempotent after init() and exposed to
subclasses.

This patch decouple countStarSlot_ initialization from
computeScanRangeLocations() and raise access level of
computeScanRangeLocations() from private to protected.

Testing:
- Pass core tests.

Change-Id: Ia621309c67455bb599f71bec9efc1f67fc085022
Reviewed-on: http://gerrit.cloudera.org:8080/21077
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>


> Make computeScanRangeLocations and computeStats idempotent in 
> HdfsScanNode.java
> -------------------------------------------------------------------------------
>
>                 Key: IMPALA-12847
>                 URL: https://issues.apache.org/jira/browse/IMPALA-12847
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Frontend
>            Reporter: Riza Suminto
>            Assignee: Riza Suminto
>            Priority: Major
>
> After IMPALA-12631, HdfsScanNode.computeScanRangeLocations() need check if 
> countStarSlot_ is null or not to schedule footer range only. 
> HdfsScanNode.computeScanRangeLocations() is called along with 
> HdfsScanNode.init() call.
> An external frontend that has its own count star slot analysis and 
> initialization will need to recompute scan range assignment and stats after 
> HdfsScanNode.init(). Therefore, computeScanRangeLocations() and 
> computeStats() should be made idempotent after init() and exposed to 
> subclasses.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to