[ https://issues.apache.org/jira/browse/IMPALA-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Armstrong resolved IMPALA-5933. ----------------------------------- Resolution: Fixed Assignee: Zoltán Borók-Nagy Fix Version/s: Impala 3.0 Should return "No partitions selected for incremental stats update" now. See test in testdata/workloads/functional-query/queries/QueryTest/compute-stats-incremental.test commit 2ee914d5b365c8230645fdd0604a67eff1edbeb2 Author: Zoltan Borok-Nagy <borokna...@cloudera.com> Date: Thu Apr 5 14:54:27 2018 +0200 IMPALA-5903: Inconsistent specification of result set and result set metadata Before this commit it was quite random which DDL oprations returned a result set and which didn't. With this commit, every DDL operations return a summary of its execution. They declare their result set schema in Frontend.java, and provide the summary in CalatogOpExecutor.java. Updated the tests according to the new behavior. Change-Id: Ic542fb8e49e850052416ac663ee329ee3974e3b9 Reviewed-on: http://gerrit.cloudera.org:8080/9090 Reviewed-by: Alex Behm <alex.b...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> > Compute incremental stats should always return a result set > ----------------------------------------------------------- > > Key: IMPALA-5933 > URL: https://issues.apache.org/jira/browse/IMPALA-5933 > Project: IMPALA > Issue Type: Bug > Components: Backend, Frontend > Affects Versions: Impala 2.6.0, Impala 2.7.0, Impala 2.8.0, Impala 2.9.0, > Impala 2.10.0 > Reporter: Alexander Behm > Assignee: Zoltán Borók-Nagy > Priority: Major > Fix For: Impala 3.0 > > > Compute incremental stats should always return a result set that states which > stats were computed/modified. Today, we have a shortcut in the code for > compute incremental stats that does not return a result set when no new stats > are computed because all partitions already have incremental stats. > The fact that the same command sometimes returns a result set and sometimes > not depending on the state of a table is strange, and can confuse clients > like JDBC/ODBC that might reasonably expect a result set for that statement. > The issue can be reproduced by running compute incremental stats twice in a > row on the same table. The second run does not return a result set. > The culprit is in client-request-state.cc ClientRequestState::WaitInternal(): > {code} > ... > if (catalog_op_type() == TCatalogOpType::DDL && > ddl_type() == TDdlType::COMPUTE_STATS && child_queries.size() > 0) { > RETURN_IF_ERROR(UpdateTableAndColumnStats(child_queries)); > } > ... > {code} > For a no-op incremental stats the number of child queries is 0, so we never > set a result set or the result set metadata. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org