[jira] [Commented] (IMPALA-7468) Port CancelQueryFInstances() to KRPC
[ https://issues.apache.org/jira/browse/IMPALA-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740604#comment-16740604 ] Andrew Sherman commented on IMPALA-7468: [~arodoni_cloudera] no doc impact. > Port CancelQueryFInstances() to KRPC > > > Key: IMPALA-7468 > URL: https://issues.apache.org/jira/browse/IMPALA-7468 > Project: IMPALA > Issue Type: Sub-task > Components: Distributed Exec >Affects Versions: Impala 3.1.0 >Reporter: Michael Ho >Assignee: Andrew Sherman >Priority: Major > Labels: ramp-up > Fix For: Impala 3.2.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-7468) Port CancelQueryFInstances() to KRPC
[ https://issues.apache.org/jira/browse/IMPALA-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739955#comment-16739955 ] Alex Rodoni commented on IMPALA-7468: - [~asherman] Any doc impact? > Port CancelQueryFInstances() to KRPC > > > Key: IMPALA-7468 > URL: https://issues.apache.org/jira/browse/IMPALA-7468 > Project: IMPALA > Issue Type: Sub-task > Components: Distributed Exec >Affects Versions: Impala 3.1.0 >Reporter: Michael Ho >Assignee: Andrew Sherman >Priority: Major > Labels: ramp-up > Fix For: Impala 3.2.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-7468) Port CancelQueryFInstances() to KRPC
[ https://issues.apache.org/jira/browse/IMPALA-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736563#comment-16736563 ] ASF subversion and git services commented on IMPALA-7468: - Commit e4cff7d0d60e60ddf6c77b48ca0da7b878672c1a in impala's branch refs/heads/master from Andrew Sherman [ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=e4cff7d ] IMPALA-7468: Port CancelQueryFInstances() to KRPC. When the Coordinator needs to cancel a query (for example because a user has hit Control-C), it does this by sending a CancelQueryFInstances message to each fragment instance. This change switches this code to use KRPC. Add new protobuf definitions for the messages, and remove the old thrift definitions. Move the server-side implementation of Cancel() from ImpalaInternalService to ControlService. Rework the scheduler so that the FInstanceExecParams always contains the KRPC address of the fragment executors, this address can then be used if a query is to be cancelled. For now keep the KRPC calls to CancelQueryFInstances() as synchronous. While moving the client-side code, remove the fault injection code that was inserted with FAULT_INJECTION_SEND_RPC_EXCEPTION and FAULT_INJECTION_RECV_RPC_EXCEPTION (triggered by running impalad with --fault_injection_rpc_exception_type=1) as this tickles code in client-cache.h which is now not used. TESTING: Ran all end-to-end tests. No new tests as test_cancellation.py provides good coverage. Checked in debugger that DebugAction style fault injection (triggered from test_cancellation.py) was working correctly. Change-Id: I625030c3f1068061aa029e6e242f016cadd84969 Reviewed-on: http://gerrit.cloudera.org:8080/12142 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins > Port CancelQueryFInstances() to KRPC > > > Key: IMPALA-7468 > URL: https://issues.apache.org/jira/browse/IMPALA-7468 > Project: IMPALA > Issue Type: Sub-task > Components: Distributed Exec >Affects Versions: Impala 3.1.0 >Reporter: Michael Ho >Assignee: Andrew Sherman >Priority: Major > Labels: ramp-up > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-7468) Port CancelQueryFInstances() to KRPC
[ https://issues.apache.org/jira/browse/IMPALA-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709252#comment-16709252 ] Thomas Tauber-Marshall commented on IMPALA-7468: Example of a similar patch: https://gerrit.cloudera.org/#/c/10855/ > Port CancelQueryFInstances() to KRPC > > > Key: IMPALA-7468 > URL: https://issues.apache.org/jira/browse/IMPALA-7468 > Project: IMPALA > Issue Type: Sub-task > Components: Distributed Exec >Affects Versions: Impala 3.1.0 >Reporter: Michael Ho >Assignee: Andrew Sherman >Priority: Major > Labels: ramp-up > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org
