[ 
https://issues.apache.org/jira/browse/IMPALA-12684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842167#comment-17842167
 ] 

ASF subversion and git services commented on IMPALA-12684:
----------------------------------------------------------

Commit 56f35ad40a7ded4a700222eef8dc99cf7ea44625 in impala's branch 
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=56f35ad40 ]

IMPALA-12684: Enable IMPALA_COMPRESSED_DEBUG_INFO by default

IMPALA_COMPRESSED_DEBUG_INFO was introduced in IMPALA-11511
and reduces Impala binary sizes by >50%. Debug tools like
gdb and our minidump processing scripts handle compressed
debug information properly. There are slightly higher link
times and additional overhead when doing debugging.

Overall, the reduction in binary sizes seems worth it given
the modest overhead. Compressing the debug information also
avoids concerns that adding debug information to toolchain
components would increase binary sizes.

This changes the default for IMPALA_COMPRESSED_DEBUG_INFO to
true.

Testing:
 - Ran pstack on a Centos 7 machine running tests with
   IMPALA_COMPRESSED_DEBUG_INFO=true and verified that
   the symbols work properly
 - Forced the production of minidumps for a job using
   IMPALA_COMPRESSED_DEBUG_INFO=true and verified it is
   processed properly.
 - Used this locally for development for several months

Change-Id: I31640f1453d351b11644bb46af3d2158b22af5b3
Reviewed-on: http://gerrit.cloudera.org:8080/20871
Reviewed-by: Quanlong Huang <huangquanl...@gmail.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>


> Use IMPALA_COMPRESSED_DEBUG_INFO=true by default
> ------------------------------------------------
>
>                 Key: IMPALA-12684
>                 URL: https://issues.apache.org/jira/browse/IMPALA-12684
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>    Affects Versions: Impala 4.4.0
>            Reporter: Joe McDonnell
>            Priority: Major
>
> A large part of the Impala binary's size is debug information. The 
> IMPALA_COMPRESSED_DEBUG_INFO environment variable was introduced in 
> IMPALA-11511 and reduces the binary size by >50%. For developer environments, 
> this is can dramatically reduce disk space usage, especially when building 
> the backend tests. The downside is slower linking and slower processing of 
> the debuginfo (attaching with GDB, dumping symbols for minidumps).
> The disk space difference is very large, and this can help enable us to 
> expand debug information for the toolchain. We should switch the default 
> value to true.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to