[jira] [Commented] (IMPALA-2746) Backend tests should pass with leak sanitizer enabled
[ https://issues.apache.org/jira/browse/IMPALA-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516492#comment-16516492 ] Tim Armstrong commented on IMPALA-2746: --- IMPALA-2746: part 1: enable LSAN for many backend tests This turns on leak sanitizer for backend tests that required relatively small modifications to pass. We suppress a few leaks, mainly related to the embedded JVM. Testing: Ran core tests under ASAN. Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4 Reviewed-on: http://gerrit.cloudera.org:8080/10668 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins > Backend tests should pass with leak sanitizer enabled > - > > Key: IMPALA-2746 > URL: https://issues.apache.org/jira/browse/IMPALA-2746 > Project: IMPALA > Issue Type: Bug > Components: Backend >Affects Versions: Impala 2.3.0 >Reporter: Martin Grund >Priority: Minor > Labels: resource-management, test-infra > > Currently, when running the backend tests with ASAN, the build will fail if > memory leak detection is enabled. We should investigate where leaks occur and > fix them to make sure we can benefit from the leak detection as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-2746) Backend tests should pass with leak sanitizer enabled
[ https://issues.apache.org/jira/browse/IMPALA-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511331#comment-16511331 ] ASF subversion and git services commented on IMPALA-2746: - Commit 7c5eb933b810c476505c9f5a044b749ed630da86 in impala's branch refs/heads/2.x from [~tarmstr...@cloudera.com] [ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=7c5eb93 ] IMPALA-7145: fix leak of OpenSSL context when spilling Add a RAII wrapper for the OpenSSL context that automatically frees on all exit paths from the function. Add a backend test wrapper that enables LeakSanitizer for an individual test. This is a step towards IMPALA-2746. Fix version check bug in asan.h. Testing: Enable LeakSanitizer for openssl-util-test. This reliably found the bug. Ran core tests under ASAN. Change-Id: I98760ed8f31b18b489a156f945c29c95c9bf3184 Reviewed-on: http://gerrit.cloudera.org:8080/10666 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins > Backend tests should pass with leak sanitizer enabled > - > > Key: IMPALA-2746 > URL: https://issues.apache.org/jira/browse/IMPALA-2746 > Project: IMPALA > Issue Type: Bug > Components: Backend >Affects Versions: Impala 2.3.0 >Reporter: Martin Grund >Priority: Minor > Labels: resource-management, test-infra > > Currently, when running the backend tests with ASAN, the build will fail if > memory leak detection is enabled. We should investigate where leaks occur and > fix them to make sure we can benefit from the leak detection as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-2746) Backend tests should pass with leak sanitizer enabled
[ https://issues.apache.org/jira/browse/IMPALA-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510333#comment-16510333 ] ASF subversion and git services commented on IMPALA-2746: - Commit 501dc6abfb360575613eb2210c0c87f3e37235ce in impala's branch refs/heads/master from [~tarmstr...@cloudera.com] [ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=501dc6a ] IMPALA-7145: fix leak of OpenSSL context when spilling Add a RAII wrapper for the OpenSSL context that automatically frees on all exit paths from the function. Add a backend test wrapper that enables LeakSanitizer for an individual test. This is a step towards IMPALA-2746. Fix version check bug in asan.h. Testing: Enable LeakSanitizer for openssl-util-test. This reliably found the bug. Ran core tests under ASAN. Change-Id: I98760ed8f31b18b489a156f945c29c95c9bf3184 Reviewed-on: http://gerrit.cloudera.org:8080/10666 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins > Backend tests should pass with leak sanitizer enabled > - > > Key: IMPALA-2746 > URL: https://issues.apache.org/jira/browse/IMPALA-2746 > Project: IMPALA > Issue Type: Bug > Components: Backend >Affects Versions: Impala 2.3.0 >Reporter: Martin Grund >Priority: Minor > Labels: resource-management, test-infra > > Currently, when running the backend tests with ASAN, the build will fail if > memory leak detection is enabled. We should investigate where leaks occur and > fix them to make sure we can benefit from the leak detection as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org
