[ https://issues.apache.org/jira/browse/IMPALA-7902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731961#comment-16731961 ]
ASF subversion and git services commented on IMPALA-7902: --------------------------------------------------------- Commit 27577dd652554dda5a03016e2d1e3ab66fe6b1f5 in impala's branch refs/heads/master from Paul Rogers [ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=27577dd ] IMPALA-7902: NumericLiteral fixes, refactoring The work to clean up the rewriter logic must start with a stable AST, which must start with sprucing up some issues with the leaf nodes. This CR tackles the NumericLiteral used to hold numbers. IMPALA-7896: Literals should not need explicit analyze step Partial fix: removes the need to analyze a numeric literal: analyze() is a no-op. This eliminates the need to do a "fake" analysis with a null analyzer: numeric literals are now created analyzed. This is useful because the catalog module creates numeric literals outside of a query (and outside of an analyzer.) A literal is immutable except for type. Modified the constructor to set the type and cost, then mark the node as analyzed. A later call to analyze() has nothing to do. Code that created and dummy-analyzed numeric literals changed to use static create() methods resulting in simpler literal creation, and eliminates the special "analyzer == null" checks in analyze(). IMPALA-7886: NumericLiteral constructor fails to round values to Decimal type IMPALA-7887: NumericLiteral fails to detect numeric overflow IMPALA-7888: Incorrect NumericLiteral overflow checks for FLOAT, DOUBLE IMPALA-7891: Analyzer does not detect numeric overflow in CAST IMPALA-7894: Parser does not catch double overflow These are all caused by the somewhat cluttered state of the numeric range check code after years of incremental changes. This patch centralizes all checks into a series of constants and methods for uniformity. All values are set in the constructor which now checks that the value is legal for the type. Cast operations verify that the cast is valid. Multiple semi-parallel versions of the same logic is replaced by calls to a single implementation. The numeric checks now follow the SQL standard which says that implementations should fail if a cast would trucate the most significant digits, but round when truncating the least significant. IMPALA-7865: Repeated type widening of arithmetic expressions Partial fix. Replaces the "is explicit cast" flag in the numeric literal with the explicit type. This allows reseting an implicit type back to the explciit type if an arithmetic expression is analyzed multiple times. A later patch will feed this type information into the type inference mechanism to complete the fix. Finally, adds a set of new exceptions that begin to unify error reporting. These handle casts (SqlCastException), value validation (InvalidValueException) and unsupported features (UnsupportedFeatureException.) These all derive from AnalysisException for backward compatibility. Tests use the new exceptions to check for expected errors rather than parsing text strings (which tend to change.) Testing: * Added unit tests just for numeric literals. Refactored code to simplify the tests. * Added a test case for the obscure case in Decimal V1 of an implicit cast overflow. * The depth-check tests needed one extra level of nesting to trigger failure. * Ran all FE tests. Change-Id: I484600747b2871d3a6fe9153751973af9a8534f2 Reviewed-on: http://gerrit.cloudera.org:8080/12001 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> > Revise NumericLiteral to avoid analysis, fix multiple issues > ------------------------------------------------------------ > > Key: IMPALA-7902 > URL: https://issues.apache.org/jira/browse/IMPALA-7902 > Project: IMPALA > Issue Type: Improvement > Components: Frontend > Affects Versions: Impala 3.0 > Reporter: Paul Rogers > Assignee: Paul Rogers > Priority: Minor > > The {{NumericLiteral}} class is a leaf node in the Impala FE AST. In order to > address a number of pending issues, we must adjust this class to improve its > semantics and fix a number of bugs. > See the linked JIRA tickets for the issues that this roll-up ticket addresses. > The issues are combined because they are tightly related; makes more sense to > offer them as a single patch than as a series of disjoint patches. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org